Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException

2025-02-17 Thread Nicole Xu
On Wed, 8 Jan 2025 09:04:47 GMT, Nicole Xu wrote: > Suite MaskedLogicOpts.maskedLogicOperationsLong512() failed on both x86 and > AArch64 with the following error: > > > java.lang.IndexOutOfBoundsException: Index 252 out of bounds for length 249 > > > The variable `long256_arr_idx` is misuse

Re: RFR: 8342103: C2 compiler support for Float16 type and associated scalar operations [v18]

2025-02-17 Thread Julian Waters
On Tue, 11 Feb 2025 06:32:56 GMT, Jatin Bhateja wrote: >> Hi All, >> >> This patch adds C2 compiler support for various Float16 operations added by >> [PR#22128](https://github.com/openjdk/jdk/pull/22128) >> >> Following is the summary of changes included with this patch:- >> >> 1. Detection

Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v2]

2025-02-17 Thread Jason Mehrens
On Mon, 17 Feb 2025 13:52:33 GMT, David Beaumont wrote: >>>I've looked through a lot of github logging properties files and see no >>>evidence that the pattern of use... >> >> Closed source GOTS/COTS products that require troubleshooting require using >> all of the logging API features when ot

Withdrawn: 8310996: Add JFR event for connect operations

2025-02-17 Thread duke
On Wed, 16 Oct 2024 01:19:15 GMT, Tim Prinzing wrote: > Adds a JFR event for socket connect operations. > > Existing tests TestSocketEvents and TestSocketChannelEvents modified to also > check for connect events. This pull request has been closed without being integrated. - PR: h

Withdrawn: 8342869: Errors related to unused code on Windows after 8339120 in awt

2025-02-17 Thread duke
On Wed, 23 Oct 2024 05:07:37 GMT, Julian Waters wrote: > After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unuse

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v12]

2025-02-17 Thread Galder Zamarreño
On Mon, 17 Feb 2025 17:02:47 GMT, Galder Zamarreño wrote: > This test is like a reduction test and no vectorization appears to be kicking > in any of the percentages (I've not enabled vectorization SW rejections to > check). Ah, that's probably because of profitable vectorization checks.

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v12]

2025-02-17 Thread Galder Zamarreño
On Fri, 7 Feb 2025 12:39:24 GMT, Galder Zamarreño wrote: >> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in >> order to help improve vectorization performance. >> >> Currently vectorization does not kick in for loops containing either of >> these calls because of t

Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException

2025-02-17 Thread Jatin Bhateja
On Thu, 13 Feb 2025 07:52:30 GMT, Nicole Xu wrote: >> Oh, the OCA-verify is still stuck. I'm sorry about that 🙈 >> I pinged my manager @TobiHartmann , he will reach out to see what's the >> issue. > > Hi @eme64, do you see any risks here? Would you please help to review the > patch? Thanks. >

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Galder Zamarreño
On Mon, 17 Feb 2025 15:02:32 GMT, Roland Westrelin wrote: >> @rwestrel @galderz >> >>> It seems overall, we likely win more than we loose with this intrinsic, so >>> I would integrate this change as it is and file a bug to keep track of >>> remaining issues. >> >> I'm a little scared to just

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-17 Thread Matthias Baesken
On Thu, 12 Dec 2024 01:11:33 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Integrated: 8347123: Add missing @serial tags to other modules

2025-02-17 Thread Hannes Wallnöfer
On Wed, 8 Jan 2025 20:13:50 GMT, Hannes Wallnöfer wrote: > Please review a doc-only change to mostly add missing `@serial` javadoc tags. > This is a sub-task of [JDK-8286931] to allow us to re-enable the javadoc > `-serialwarn` option in the JDK doc build, which has been disabled since JDK > 1

Re: RFR: 8342486: Implement JEP draft: Structured Concurrency (Fifth Preview) [v5]

2025-02-17 Thread Alan Bateman
> Changes for [JEP draft: Structured Concurrency (Fifth > Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical > roadmap yet. The proposal is to re-preview the API with some changes, > specifically: > > - A > [StructuredTaskScope](https://download.java.net/java/early_acc

Re: RFR: 8347123: Add missing @serial tags to other modules [v2]

2025-02-17 Thread Alan Bateman
On Fri, 24 Jan 2025 10:58:24 GMT, Hannes Wallnöfer wrote: >> Please review a doc-only change to mostly add missing `@serial` javadoc >> tags. This is a sub-task of [JDK-8286931] to allow us to re-enable the >> javadoc `-serialwarn` option in the JDK doc build, which has been disabled >> since

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Roland Westrelin
On Mon, 17 Feb 2025 10:36:52 GMT, Emanuel Peter wrote: > I think we should be able to see the same issue here, actually. Yes. Here a > quick benchmark below: I observe the same: Warmup 7513bTestIntMax::test1 (27 bytes) Run Time: 360 550 158 Warmup 1862 15bTestInt

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v11]

2025-02-17 Thread Severin Gehwolf
On Thu, 12 Dec 2024 01:11:33 GMT, Sergey Chernyshev wrote: >> Cgroup V1 subsustem fails to initialize mounted controllers properly in >> certain cases, that may lead to controllers left undetected/inactive. We >> observed the behavior in CloudFoundry deployments, it affects also host >> syste

Withdrawn: 8342486: Implement JEP draft: Structured Concurrency (Fifth Preview)

2025-02-17 Thread duke
On Wed, 6 Nov 2024 15:47:55 GMT, Alan Bateman wrote: > Changes for [JEP draft: Structured Concurrency (Fifth > Preview)](https://openjdk.org/jeps/8340343). The JEP isn't on the technical > roadmap yet. The proposal is to re-preview the API with some changes, > specifically: > > - A > [Struct

Re: RFR: 8349206: j.u.l.Handler classes create deadlock risk via synchronized publish() method [v2]

2025-02-17 Thread David Beaumont
On Fri, 14 Feb 2025 19:51:19 GMT, Jason Mehrens wrote: >> The reason I'm pushing back a little here is that the idea of making a >> "secret handshake" method between StreamHandler and FileHandler isn't a >> solution for anyone who made their own handler (e.g. an >> "EncryptedLogFileHandler" th

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources

2025-02-17 Thread Eirik Bjørsnøs
On Sun, 16 Feb 2025 12:45:04 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to improve >> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, >> `InflaterInputStream` and `InflaterOutputStream` classes? >> >> As noted in https:/

Re: RFR: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases

2025-02-17 Thread Jaikiran Pai
On Mon, 17 Feb 2025 10:49:25 GMT, Alan Bateman wrote: > Looks fine although I assume we've never had any reports of an exception here. Right - given the nature of this tool, I doubt it would ever be an issue in practice. Thank you for the review. I'll go ahead and integrate this now.

Integrated: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases

2025-02-17 Thread Jaikiran Pai
On Fri, 14 Feb 2025 07:41:26 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to properly close the > `Inflater` instance used in > `jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This > addresses https://bugs.openjdk.org/browse/JDK-834

Re: RFR: 8066583: DeflaterInput/OutputStream and InflaterInput/OutputStream should explain responsibility for freeing resources [v2]

2025-02-17 Thread Alan Bateman
On Sun, 16 Feb 2025 12:48:54 GMT, Jaikiran Pai wrote: >> Can I please get a review of this doc-only change which proposes to improve >> the API documentation of `DeflaterInputStream`, `DeflaterOutputStream`, >> `InflaterInputStream` and `InflaterOutputStream` classes? >> >> As noted in https:/

Re: RFR: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases

2025-02-17 Thread Alan Bateman
On Fri, 14 Feb 2025 07:41:26 GMT, Jaikiran Pai wrote: > Can I please get a review of this change which proposes to properly close the > `Inflater` instance used in > `jdk.internal.jimage.decompressor.ZipDecompressor.decompress()` method? This > addresses https://bugs.openjdk.org/browse/JDK-834

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Roland Westrelin
On Mon, 17 Feb 2025 10:36:52 GMT, Emanuel Peter wrote: > I suppose we could write an optimization that can hoist out loop independent > if-diamonds out of a loop. If the condition and all phi inputs are loop > invariant, you could just cut the diamond out of the loop, and paste it > before the

Re: RFR: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException

2025-02-17 Thread Emanuel Peter
On Thu, 13 Feb 2025 07:52:30 GMT, Nicole Xu wrote: >> Oh, the OCA-verify is still stuck. I'm sorry about that 🙈 >> I pinged my manager @TobiHartmann , he will reach out to see what's the >> issue. > > Hi @eme64, do you see any risks here? Would you please help to review the > patch? Thanks. @

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Emanuel Peter
On Mon, 17 Feb 2025 08:44:46 GMT, Roland Westrelin wrote: >>> I suppose extracting the branch probability from the MethodData and >>> attaching it to the Min/Max nodes is not impossible. >> >> That is basically what `PhaseIdealLoop::conditional_move` already does, >> right? It detects the diam

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Roland Westrelin
On Mon, 17 Feb 2025 08:37:56 GMT, Emanuel Peter wrote: > > I suppose extracting the branch probability from the MethodData and > > attaching it to the Min/Max nodes is not impossible. > > That is basically what `PhaseIdealLoop::conditional_move` already does, > right? It detects the diamond an

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v11]

2025-02-17 Thread Emanuel Peter
On Fri, 14 Feb 2025 16:52:17 GMT, Roland Westrelin wrote: > I suppose extracting the branch probability from the MethodData and attaching > it to the Min/Max nodes is not impossible. That is basically what `PhaseIdealLoop::conditional_move` already does, right? It detects the diamond and conve

Re: RFR: 8350151: Support requires property to filer tests incompatible with --enable-preview

2025-02-17 Thread Alan Bateman
On Sat, 15 Feb 2025 19:43:39 GMT, Leonid Mesnik wrote: > It might be useful to be able to run testing with --enable-preview for > feature development. The tests incompatible with this mode must be filtered > out. > > I chose name 'java.enablePreview' , because it is more java property than vm