Re: RFR: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs) [v12]

2025-02-15 Thread Archie Cobbs
> Please review this patch which removes unnecessary `@SuppressWarnings` > annotations. Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 22 commits: - Merge branch 'master' into SuppressWarningsCleanup-core-libs to fix

RFR: 8350151: Support requires property to filer tests incompatible with --enable-preview

2025-02-15 Thread Leonid Mesnik
It might be useful to be able to run testing with --enable-preview for feature development. The tests incompatible with this mode must be filtered out. I chose name 'java.enablePreview' , because it is more java property than vm or jdk. And 'enablePreview' to be similar with jtreg tag. Tested

Re: RFR: 8347946: Add API note that caller should validate/trust signers to the getCertificates and getCodeSigners methods of JarEntry and JarURLConnection

2025-02-15 Thread Jaikiran Pai
On Thu, 13 Feb 2025 16:27:03 GMT, Sean Mullan wrote: > This change adds an API note to these methods recommending that the caller > should perform further validation steps on the code signers that signed the > JAR file, such as validating the code signer's certificate chain, and > determining

Re: JDK-8072840: Presizing for Stream Collectors

2025-02-15 Thread Remi Forax
> From: "Viktor Klang" > To: "Paul Sandoz" , "Fabian Meumertzheim" > > Cc: "core-libs-dev" > Sent: Thursday, February 13, 2025 11:30:59 PM > Subject: Re: JDK-8072840: Presizing for Stream Collectors > Indeed. I hope I didn't sound discouraging about the possibility to propagate > the stream siz

Integrated: 8350098: jpackage test lib erroneously will run methods without @Test annotation as tests

2025-02-15 Thread Alexey Semenyuk
On Fri, 14 Feb 2025 14:30:25 GMT, Alexey Semenyuk wrote: > Don't consider functions without `jdk.jpackage.test.Annotations.Test` > annotation as tests. > > Additionally, enhance the functionality of > `jdk.jpackage.test.Annotations.ParameterSupplier` annotation: make an empty > string the def

Re: JDK-8072840: Presizing for Stream Collectors

2025-02-15 Thread Fabian Meumertzheim
Thanks for your feedback and for making me aware of the complications around Gatherers. I will also put more thought into how this could work for Gatherers. On Thu, Feb 13, 2025, 23:31 Viktor Klang wrote: > Indeed. I hope I didn't sound discouraging about the possibility to > propagate the stre