On Thu, 19 Dec 2024 18:14:39 GMT, Severin Gehwolf wrote:
> Please review this fairly simple change to improve how the
> `JimageDiffGenerator` works. The original implementation is pretty naive and
> read all bytes into memory and then compared them. This improved version only
> reads bytes on
On Sun, 29 Dec 2024 14:51:06 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which improves the
> `test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
> when the JVM logs any warning when launching an application through `java
> -jar ...`?
On Sun, 29 Dec 2024 14:51:06 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which improves the
> `test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
> when the JVM logs any warning when launching an application through `java
> -jar ...`?
On Sun, 29 Dec 2024 14:51:06 GMT, Jaikiran Pai wrote:
> Can I please get a review of this test-only change which improves the
> `test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
> when the JVM logs any warning when launching an application through `java
> -jar ...`?
Can I please get a review of this test-only change which improves the
`test/jdk/java/util/zip/EntryCount64k.java` test code to allow for it to pass
when the JVM logs any warning when launching an application through `java -jar
...`?
The proposed change merely relaxes a check to allow for additi
On Fri, 20 Dec 2024 06:38:54 GMT, Jaikiran Pai wrote:
> Can I please get a review for this change which proposes to fix the issue
> noted in https://bugs.openjdk.org/browse/JDK-8302293?
>
> As noted in the issue, when creating a temporary file during the "jar
> --create" operation, if the orig
On Fri, 20 Dec 2024 14:15:14 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to fix the issue
>> noted in https://bugs.openjdk.org/browse/JDK-8302293?
>>
>> As noted in the issue, when creating a temporary file during the "jar
>> --create" operation, if the
