On Mon, 23 Dec 2024 22:16:01 GMT, Phil Race wrote:
>> I was also wondering how this was tested.
>
> FYI, the way to test this is ..
> cd test/jdk
> jtreg sanity/client/SwingSet/src/TableDemoTest.java
>
> I tried converting all ^M to \n in this file another repo and comparing with
> your patch b
On Mon, 23 Dec 2024 19:13:09 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
On Mon, 23 Dec 2024 17:11:14 GMT, Justin Lu wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch up
On Mon, 23 Dec 2024 14:00:54 GMT, Erik Joelsson wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touc
On Mon, 23 Dec 2024 18:57:39 GMT, Kim Barrett wrote:
>> Qizheng Xing has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
>> - Do not touch files in test.
>> - Do not touch
> This patch fixes unmatched brackets in some source files.
Qizheng Xing has updated the pull request incrementally with three additional
commits since the last revision:
- Update `hotspot-unit-tests.md` and HTML (using Pandoc 2.19.2).
- Do not touch files in test.
- Do not touch upstream dat
Hi all,
This pull request contains a backport of commit
[cf28fd4c](https://github.com/openjdk/jdk/commit/cf28fd4cbc6507eb69fcfeb33622316eb5b6b0c5)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Evgeny Nikitin on 20 Dec 2024 and
was r
On Mon, 23 Dec 2024 20:29:09 GMT, Phil Race wrote:
>> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
>> line 2:
>>
>>> 1:
>>> 2: http://www.fatdog.com/oscar-results";
>>
>> Does this change affect the behavior of the associated test(s)?
>
> I was a
On Mon, 23 Dec 2024 19:30:56 GMT, Kim Barrett wrote:
>> This patch fixes unmatched brackets in some source files.
>
> test/jdk/sanity/client/lib/SwingSet3/src/com/sun/swingset3/demos/table/resources/oscars.xml
> line 2:
>
>> 1:
>> 2: http://www.fatdog.com/oscar-results";
>
> Does this change
On Mon, 23 Dec 2024 19:42:34 GMT, Kim Barrett wrote:
> > That makes it harder to review and to manage the review, because it is
> > large and affects a wide range of areas, so may need many reviewers.
>
> And many of the appropriate reviewers might be unavailable for a while, since
> it's righ
On Sat, 2 Nov 2024 11:02:13 GMT, Jaikiran Pai wrote:
>> Deoptimization with escape analysis can fail when trying to rematerialize
>> objects as described in JDK-8227309. In this test this can happen in Xcomp
>> mode in the framework of the test resulting in a test failure. Making the
>> numb
On Mon, 23 Dec 2024 19:33:36 GMT, Kim Barrett wrote:
> That makes it harder to review and to manage the review, because it is large
> and affects a wide range of areas, so may need many reviewers.
And many of the appropriate reviewers might be unavailable for a while, since
it's right before C
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
I strongly suggest avoiding omnibus changes like this when possible (which it
is here). Just because it's all about one "kind" of change doesn't make it a
cohesive change. This is to
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
make/data/cldr/common/main/kn.xml line 1085:
> 1083: ಇಸ್ಲಾಮಿಕ್
> ಕ್ಯಾಲೆಂಡರ್
> 1084: type="islamic-civil">ಇಸ್ಲಾಮಿಕ್-ಸಿವಿಲ್ ಕ್ಯಾಲೆಂಡರ
Hi Davide,
For rpm and deb packages jpackage will build the list of required
packages from the dependencies of shared libraries in the app's runtime
image.
This dependency resolution is specific to a host where jpackage is
executed. The dependencies may not be available in other Linux distro
On Mon, 23 Dec 2024 09:45:00 GMT, Qizheng Xing wrote:
> This patch fixes unmatched brackets in some source files.
I can really only review the doc files and the Makefile.
doc/hotspot-unit-tests.md line 175:
> 173: there is no need to have them in error messages. Asserts print only
> 174: compa
Hi all,
This pull request contains a backport of commit
[054c644e](https://github.com/openjdk/jdk/commit/054c644ea6ea38e54abc81e231977106d04bb69e)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Nizar Benalla on 20 Dec 2024 and
was re
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
> To resolve java/io/File/GetXSpace.java failure, I fix libGetXSpace.c to use
> Cygwin’s `df` to get the size for comparison if the test target drive is a
> CD-ROM drive.
>
> As described in JDK-8343342, GetDiskSpaceInformationW can't get information
> about the size of the CD-ROM drive.
> Ge
On Mon, 23 Dec 2024 08:18:40 GMT, Thomas Stuefe wrote:
>> src/java.desktop/share/native/common/awt/debug/debug_trace.h line 66:
>>
>>> 64: /* each file includes this flag indicating module trace status */
>>> 65: #ifdef __cplusplus
>>> 66: [[maybe_unused]]
>>
>> I don't really know what to do a
This patch fixes unmatched brackets in some source files.
-
Commit messages:
- Fix unmatched brackets in source files.
Changes: https://git.openjdk.org/jdk/pull/22861/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22861&range=00
Issue: https://bugs.openjdk.org/browse/JDK
On Wed, 23 Oct 2024 05:08:47 GMT, Julian Waters wrote:
>> After 8339120, gcc began catching many different instances of unused code in
>> the Windows specific codebase. Some of these seem to be bugs. I've taken the
>> effort to mark out all the relevant globals and locals that trigger the
>> u
22 matches
Mail list logo
