Withdrawn: 8339704: Refactor StringConcatHelper simpleConcat

2024-12-01 Thread duke
On Tue, 27 Aug 2024 10:09:09 GMT, Shaojin Wen wrote: > The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat m

Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v4]

2024-12-01 Thread Jaikiran Pai
On Wed, 27 Nov 2024 07:18:43 GMT, Alan Bateman wrote: >> Hello Alan, >> >>> If it goes ahead as reviewed, then we'll to do some outreach and be >>> prepared to back out this change in the event that breakage is reported >>> before GA. >> >> I agree that if the `final close()` causes issues,

Re: RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v12]

2024-12-01 Thread Jaikiran Pai
> Can I please get a review of this enhancement which proposes to enhance > `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`? > > The actual work for this was done a few years back when we discussed the > proposed approaches and then I raised a RFR. At that time I could

Re: RFR: 8345279: Mistake in javadoc of javax.sql.rowset.BaseRowSet#setBigDecimal

2024-12-01 Thread Joe Darcy
On Mon, 2 Dec 2024 04:19:08 GMT, Jaikiran Pai wrote: > Can I please get a review of this trivial typo fix in the javadoc of > `javax.sql.rowset.BaseRowSet#setBigDecimal()` method? > > As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc > incorrectly mentions `java.lang.BigDeci

RFR: 8345279: Mistake in javadoc of javax.sql.rowset.BaseRowSet#setBigDecimal

2024-12-01 Thread Jaikiran Pai
Can I please get a review of this trivial typo fix in the javadoc of `javax.sql.rowset.BaseRowSet#setBigDecimal()` method? As noted in https://bugs.openjdk.org/browse/JDK-8345279, the javadoc incorrectly mentions `java.lang.BigDecimal` instead of `java.math.BigDecimal`. As part of this change,

Re: RFR: 8315487: Security Providers Filter [v13]

2024-12-01 Thread Xue-Lei Andrew Fan
On Fri, 29 Nov 2024 14:28:27 GMT, Martin Balao wrote: >> In addition to the goals, scope, motivation, specification and requirement >> notes in [JDK-8315487](https://bugs.openjdk.org/browse/JDK-8315487), we >> would like to describe the most relevant decisions taken during the >> implementatio

Re: RFR: 8337199: Add jcmd Thread.vthread_scheduler and Thread.vthread_pollers diagnostic commands [v3]

2024-12-01 Thread David Holmes
On Fri, 29 Nov 2024 11:12:22 GMT, Alan Bateman wrote: >> Adds `jcmd Thread.vthread_scheduler` to print the virtual thread >> scheduler and `jcmd Thread.vthread_pollers` to print the I/O pollers >> that support virtual threads doing blocking network I/O operations. >> >> This is a subset of t

RE: Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-12-01 Thread Markus Karg
As Thanksgiving is over, and as work towards 24-RDP1 should mostly be done, I think it is a good time to resume our now. To kick-off, below I am repeating my last response to Chen. Kindly asking everybody to chime in, so we can find a feasible and beneficial conclusion in this area. -Markus

Re: RFR: 8343191: Cgroup v1 subsystem fails to set subsystem path [v3]

2024-12-01 Thread Sergey Chernyshev
On Fri, 29 Nov 2024 17:19:34 GMT, Severin Gehwolf wrote: > In the cloudflare case we'd end up with a subsystem path of > `/sys/fs/cgroup/cpu,cpuacct/system.slice/garden.service/garden/bad/2f57368b-0eda-4e52-64d8-af5c`. > Since the cgroup_path != _root we trigger path adjustment increasing the