On Sun, 24 Nov 2024 23:15:02 GMT, Erik Gahlin wrote:
> Perhaps this should be made more explicit with a failed field. Alternatively,
> there could be two events: one for success and one for failure. What is the
> typical duration of a failed event? If it is above 10-20 ms, two events might
> n
On Fri, 22 Nov 2024 22:13:00 GMT, Roger Riggs wrote:
> Updates to the java.xml module following the SecurityManager removal.
> Refactor to remove doPrivilege calls
> Refactor to eliminate dead code assuming getSecurityManager() == null
> Refactor to drop use of AccessControlContext
> Remove (mos
On Tue, 17 Sep 2024 14:12:58 GMT, Per Minborg wrote:
> This PR prevents sequence layout with padding to be used with the Linker.
This pull request has now been integrated.
Changeset: 68ba7ee5
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/68ba7ee5c8f152a268b1e95d52417783
On Fri, 22 Nov 2024 23:44:11 GMT, Brian Burkhalter wrote:
> Make the memory used by internal temporary direct buffers not count towards
> the upper limit on direct buffer memory.
Could we add some tests also?
-
PR Comment: https://git.openjdk.org/jdk/pull/22339#issuecomment-249708
> ClassPrinter prints `null` values as `String` "null" or as
> `String.valueOf(ConstantDescs.BSM_NULL_CONSTANT)`, based on context.
>
> This patch unifies handling of `null` values.
> They are now exclusively represented as `ConstantDescs.BSM_NULL_CONSTANT`.
> In Json and Yaml format is `null` va
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Sun, 24 Nov 2024 03:26:18 GMT, Quan Anh Mai wrote:
>> Hi,
>>
>> This patch sharpens the return types of various internal methods. This helps
>> the compiler to have better information when the corresponding methods are
>> not inlined.
>>
>> Please take a look and leave your reviews, thanks
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
On Mon, 25 Nov 2024 06:17:23 GMT, SendaoYan wrote:
> Hi all,
> File `src/java.base/share/native/libjli/java.c` compile `error: control
> reaches end of non-void function [-Werror=return-type]` with gcc options
> `-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this
> file
Hi all,
File `src/java.base/share/native/libjli/java.c` compile `error: control reaches
end of non-void function [-Werror=return-type]` with gcc options
`-fsanitize=address -O0`. The function `int JavaMain(void* _args)` in this file
missed last return statement, The original last macro statemen
On Mon, 25 Nov 2024 01:07:43 GMT, Hao Sun wrote:
> > Hi @shqking , thanks for your review. I am currently working on adding the
> > aarch64 port for these operations. It's being done here -
> > [jatin-bhateja#6](https://github.com/jatin-bhateja/jdk/pull/6). Do you
> > think it's ok to keep the
On Thu, 21 Nov 2024 23:11:40 GMT, Calvin Cheung wrote:
>> I think the concern may be that we want to avoid license headers.
>>
>> However, we should still use text blocks instead of these string arrays for
>> such inlined source files.
>
> I've changed the code to use text blocks.
We have two
On Fri, 22 Nov 2024 17:25:54 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
On Fri, 22 Nov 2024 17:25:54 GMT, Calvin Cheung wrote:
>> Currently, when retrieving a ClassFileStream during runtime, we call into
>> the zip library to retrieve the stream based only on a class name. This
>> doesn't work well if the class is in a multi-release jar under a versioned
>> direct
Can I please get a review of this change that proposes to address the issue
noted in https://bugs.openjdk.org/browse/JDK-8344908?
With this change, the URLClassPath will no longer propagate the
`IllegalArgumentException` throwing when constructing a resource loader. The
URL which caused the iss
> Can I please get a review of this change that proposes to address the issue
> noted in https://bugs.openjdk.org/browse/JDK-8344908?
>
> With this change, the URLClassPath will no longer propagate the
> `IllegalArgumentException` throwing when constructing a resource loader. The
> URL which ca
On Thu, 21 Nov 2024 02:41:47 GMT, Hao Sun wrote:
>> Hi All,
>>
>> This patch adds C2 compiler support for various Float16 operations added by
>> [PR#22128](https://github.com/openjdk/jdk/pull/22128)
>>
>> Following is the summary of changes included with this patch:-
>>
>> 1. Detection of var
On Sat, 23 Nov 2024 08:02:42 GMT, Alan Bateman wrote:
>> Tim Prinzing has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added more tests for socket connect events.
>>
>> - SocketAdapter connect
>> - SocketAdapter connect with except
Hi Markus,
Thanks for drafting the release note and improvments.
Slight update "add in get a" -> "added to get a".
Regards, Roger
p.s. An Oracle Tech writer also reviews and may do minor cleanup to
each release note to give a consistent use of terms and format.
On 11/24/24 11:12 AM, Marku
> Complete the SM cleanup in java.util.concurrent that was deferred during
> other FJP updates
Doug Lea has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request contains
Updates to the java.xml module following the SecurityManager removal.
Refactor to remove doPrivilege calls
Refactor to eliminate dead code assuming getSecurityManager() == null
Refactor to drop use of AccessControlContext
Remove (most) references to SecurityException
Remove error messages that ref
Thank you so much for your kind reviews, Alan and Chen! :-)
I have slighly extended Alan's draft to let people better understand the
differences, hence to be able to actively chose between StringReader and
Reader.of(CharSequence):
"The static factory method `java.io.Reader.of(CharSequence)` has
On Sun, 24 Nov 2024 12:55:18 GMT, Attila Szegedi wrote:
> Thanks for making the changes! I'm approving it as-is, I have a small nit
> with an `@apiNote` but it's no big deal.
What is this nit? We added the API note to SecureLookupSupplier as part of the
JEP 486, follow-on work could deprecate
On Sat, 23 Nov 2024 15:08:38 GMT, Markus KARG wrote:
> I have drafted a release note for
> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566) in
> [JDK-8344910](https://bugs.openjdk.org/browse/JDK-8344910). Kindly asking for
> reviews! :-)
Thanks for creating this. I've edited it so t
On Sat, 23 Nov 2024 12:08:24 GMT, Alan Bateman wrote:
>> Complete the SM cleanup in java.util.concurrent that was deferred during
>> other FJP updates
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinWorkerThread.java
> line 83:
>
>> 81: if (handler != null)
>> 82:
On Mon, 18 Nov 2024 16:13:27 GMT, Roger Riggs wrote:
>> Refactor to remove use of SecurityManager
>
> Roger Riggs has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Apply review comments:
> Retain public static constants for permission names
27 matches
Mail list logo
