Re: JDK-8019345 & 8294241: Deprecate URL public constructors

2024-11-09 Thread Alan Bateman
On 10/11/2024 07:05, Peter Firmstone wrote: So we have an RFC3986 compliant URI implementation, that's not compatible with Java's RFC2396 URI and now we use deprecated URL public constructors... But I guess they're only deprecated, not going to be removed, we can't change our code to use RFC2

Re: RFR: 8341137: Optimize long vector multiplication using x86 VPMUL[U]DQ instruction [v2]

2024-11-09 Thread Jatin Bhateja
On Fri, 8 Nov 2024 23:18:18 GMT, Sandhya Viswanathan wrote: >> src/hotspot/share/opto/vectornode.cpp line 2132: >> >>> 2130: // Directly forward masked inputs if >>> 2131: if (n->Opcode() == Op_AndV) { >>> 2132: return n->in(1)->Opcode() == Op_Replicate ? n->in(2) : n->in(1); >> >> Th

Re: JDK-8019345 & 8294241: Deprecate URL public constructors

2024-11-09 Thread Peter Firmstone
Our code addresses compatibility: /** Fixes windows file URI string by converting back slashes to forward * slashes and inserting a forward slash before the drive letter if it is * missing.  No normalisation or modification of case is performed. * @param uri String representation

JDK-8019345 & 8294241: Deprecate URL public constructors

2024-11-09 Thread Peter Firmstone
So we have an RFC3986 compliant URI implementation, that's not compatible with Java's RFC2396 URI and now we use deprecated URL public constructors... But I guess they're only deprecated, not going to be removed, we can't change our code to use RFC2396 URI without unintended consequences...  

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider

2024-11-09 Thread jyxzwd
On Sat, 9 Nov 2024 18:12:34 GMT, Alan Bateman wrote: >> I was wondering, in JDK 17 or JDK 21, isn't classes in jrt-fs.jar already >> included under the java.base module? This would mean that the classes in >> jrt-fs.jar are actually already loaded by the bootstrapClassLoader, so a >> custom cl

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v20]

2024-11-09 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8325203: System.exit(0) kills the launched 3rd party application

2024-11-09 Thread Davide Perini
On Thu, 8 Feb 2024 21:03:26 GMT, Alexey Semenyuk wrote: >> Tested with the use case from the CR. >> >> The idea of the fix is to prevent grandchildren processes from being >> automatically attached to the job killing all processes attached to it when >> the job object is destroyed. >> >> File

Re: RFR: 8331977: Crash: SIGSEGV in dlerror()

2024-11-09 Thread Thomas Stuefe
On Tue, 4 Jun 2024 13:02:18 GMT, Alexey Semenyuk wrote: >> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app >> launcher instead of raw Executor. This makes MainClassTest test run app >> launchers with retries. This change addresses the primary issue. >> >> Fix inconsi

Re: RFR: 8331977: Crash: SIGSEGV in dlerror()

2024-11-09 Thread Alexey Semenyuk
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote: > Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app > launcher instead of raw Executor. This makes MainClassTest test run app > launchers with retries. This change addresses the primary issue. > > Fix inconsisten

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v19]

2024-11-09 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider

2024-11-09 Thread Alan Bateman
On Sat, 9 Nov 2024 13:06:30 GMT, jyxzwd wrote: >> src/java.base/share/classes/jdk/internal/jimage/ImageReaderFactory.java line >> 51: >> >>> 49: private static final String JAVA_HOME = >>> System.getProperty("java.home"); >>> 50: private static final Path BOOT_MODULES_JIMAGE = >>> 51:

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider

2024-11-09 Thread jyxzwd
On Sat, 9 Nov 2024 08:57:17 GMT, Alan Bateman wrote: >> Use the built-in file system provider rather than the custom file system >> provider. >> Add "public static FileSystemProvider create" method in >> DefaultFileSystemProvider which is from java8API to be compatible against >> runtime. > >

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v33]

2024-11-09 Thread Thomas Stuefe
On Fri, 8 Nov 2024 11:31:40 GMT, Magnus Ihse Bursie wrote: >> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>>

Integrated: 8343793: Test java/foreign/TestMemorySession.java is timing out

2024-11-09 Thread Quan Anh Mai
On Fri, 8 Nov 2024 11:56:08 GMT, Quan Anh Mai wrote: > Hi, > > This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`. > The lock-step spin lock is implemented as with `lock` being an > `AtomicInteger`: > > // Keep the 2 threads operating on the same scope > int k =

Integrated: 8343819: Link Float.NaN and Double.NaN to equivalence discussion in Double

2024-11-09 Thread Eirik Bjørsnøs
On Fri, 8 Nov 2024 10:10:28 GMT, Eirik Bjørsnøs wrote: > Please review this doc-only enhancement which links the word _equivalent_ in > `Float.NaN` and `Double.NaN` constant field descriptions to the > floating-point equivalence discussion in `Double`. > >> It is equivalent to the value retu

Re: RFR: 8331467: ImageReaderFactory can cause a ClassNotFoundException if the default FileSystemProvider is not the system-default provider

2024-11-09 Thread Alan Bateman
On Sat, 9 Nov 2024 02:18:22 GMT, jyxzwd wrote: > Use the built-in file system provider rather than the custom file system > provider. > Add "public static FileSystemProvider create" method in > DefaultFileSystemProvider which is from java8API to be compatible against > runtime. src/java.base/

Re: RFR: 8343793: Test java/foreign/TestMemorySession.java is timing out [v2]

2024-11-09 Thread Quan Anh Mai
On Fri, 8 Nov 2024 16:59:48 GMT, Quan Anh Mai wrote: >> Hi, >> >> This patch fixes the deadlock in `TestMemorySession#testAcquireCloseRace`. >> The lock-step spin lock is implemented as with `lock` being an >> `AtomicInteger`: >> >> // Keep the 2 threads operating on the same scope >>