Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v28]

2024-11-03 Thread Axel Boldt-Christmas
On Fri, 1 Nov 2024 19:37:14 GMT, Patricio Chilano Mateo wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the changes

Integrated: 8343436: Regression in StackMapGenerator after JDK-8339205

2024-11-03 Thread Adam Sotona
On Fri, 1 Nov 2024 15:03:51 GMT, Adam Sotona wrote: > JDK-8339205 introduced multiple regressions in StackMapGenerator and added a > lot of new untested code. > > This patch reverts StackMapGenerator to the state before JDK-8339205 and adds > one regression test. > > Please review. > > Thank

Re: RFR: 8342868: Errors related to unused code on Windows after 8339120 in core libs [v2]

2024-11-03 Thread Julian Waters
On Thu, 31 Oct 2024 05:43:11 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v4]

2024-11-03 Thread Julian Waters
On Thu, 31 Oct 2024 07:18:35 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v28]

2024-11-03 Thread Alan Bateman
On Mon, 4 Nov 2024 02:12:40 GMT, David Holmes wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Use lazySubmitRunContinuation when blocking > > src/hotspot/share/classfile/javaClasses.cpp line 2107: > >> 2

Re: RFR: 8343500: Optimize ArrayClassDescImpl computeDescriptor

2024-11-03 Thread Chen Liang
On Sat, 2 Nov 2024 22:50:29 GMT, Shaojin Wen wrote: > A small improvement to ArrayClassDescImpl#computeDescriptor that avoids > intermediate object allocation in the common rank 1 scenario. Nice simplification. constant tests pass. - Marked as reviewed by liach (Reviewer). PR Re

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v7]

2024-11-03 Thread Ioi Lam
> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & > Linking](https://openjdk.org/jeps/483). > > > Note: this is a combined PR of the following individual PRs > - https://github.com/openjdk/jdk/pull/20516 > - https://github.com/openjdk/jdk/pull/20517 > - https://github.co

Re: RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v6]

2024-11-03 Thread Ioi Lam
On Fri, 1 Nov 2024 03:54:24 GMT, Dan Heidinga wrote: >> Ioi Lam has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixed whitespace; fixed minimal build > > src/hotspot/share/cds/aotClassInitializer.cpp line 348: > >> 346: } >> 347:

Re: RFR: 8336267: Method and Constructor signature parsing can be shared on the root object [v5]

2024-11-03 Thread Mandy Chung
On Wed, 30 Oct 2024 16:42:18 GMT, Chen Liang wrote: >> A straightforward optimization, to share the signature parsing of method, >> constructor, and field between the root and the copied objects, like how >> method handle accessors are shared. > > Chen Liang has updated the pull request increme

Re: RFR: 8339783: Implement JEP 479: Remove the Windows 32-bit x86 Port [v17]

2024-11-03 Thread David Holmes
On Fri, 1 Nov 2024 16:04:55 GMT, Magnus Ihse Bursie wrote: >> This is the implementation of [JEP 479: _Remove the Windows 32-bit x86 >> Port_](https://openjdk.org/jeps/479). >> >> This is the summary of JEP 479: >>> Remove the source code and build support for the Windows 32-bit x86 port. >>>

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v28]

2024-11-03 Thread David Holmes
On Fri, 1 Nov 2024 19:37:14 GMT, Patricio Chilano Mateo wrote: >> This is the implementation of JEP 491: Synchronize Virtual Threads without >> Pinning. See [JEP 491](https://bugs.openjdk.org/browse/JDK-8337395) for >> further details. >> >> In order to make the code review easier the changes

RFR: 8343500: Optimize ArrayClassDescImpl computeDescriptor

2024-11-03 Thread Shaojin Wen
A small improvement to ArrayClassDescImpl#computeDescriptor that avoids intermediate object allocation in the common rank 1 scenario. - Commit messages: - optimize computeDescriptor Changes: https://git.openjdk.org/jdk/pull/21860/files Webrev: https://webrevs.openjdk.org/?repo=jd

Re: RFR: 8339480: Build static-jdk image with a statically linked launcher [v9]

2024-11-03 Thread Jiangli Zhou
On Fri, 1 Nov 2024 16:25:59 GMT, Magnus Ihse Bursie wrote: >> As a prerequisite for Hermetic Java, we need a statically linked `java` >> launcher. It should behave like the normal, dynamically linked `java` >> launcher, except that all JDK native libraries should be statically, not >> dynamica

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v16]

2024-11-03 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-11-03 Thread Alan Bateman
On Sun, 3 Nov 2024 11:25:13 GMT, Daniel Fuchs wrote: >> src/java.base/share/classes/java/lang/System.java line 1364: >> >>> 1362: * >>> 1363: * It is the responsibility of the provider of >>> 1364: * the concrete {@code LoggerFinder} implementation to ensure that >> >> This is s

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-11-03 Thread Daniel Fuchs
On Sat, 2 Nov 2024 22:25:06 GMT, ExE Boss wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 200 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Modify three RMI tests

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-03 Thread Jaikiran Pai
On Wed, 30 Oct 2024 12:25:34 GMT, Jan Lahoda wrote: >> src/java.base/share/classes/java/io/Console.java line 184: >> >>> 182: */ >>> 183: @PreviewFeature(feature = PreviewFeature.Feature.IMPLICIT_CLASSES) >>> 184: public Console println() { >> >> Hello Jan, with the introduction of

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v3]

2024-11-03 Thread Jaikiran Pai
On Tue, 29 Oct 2024 08:13:22 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-11-03 Thread Alan Bateman
On Sat, 2 Nov 2024 22:18:09 GMT, ExE Boss wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 200 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Modify three RMI tests