Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v3]

2024-10-26 Thread Julian Waters
> After 8339120, gcc began catching many different instances of unused code in > the Windows specific codebase. Some of these seem to be bugs. I've taken the > effort to mark out all the relevant globals and locals that trigger the > unused warnings and addressed all of them by commenting out th

Re: RFR: 8341273: JVMTI is not properly hiding some continuation related methods [v13]

2024-10-26 Thread Serguei Spitsyn
> This fixes a problem in the VTMS (Virtual Thread Mount State) transition > frames hiding mechanism. > Please, see a fix description in the first comment. > > Testing: > - Verified with new test `vthread/CheckHiddenFrames` > - Mach5 tiers 1-6 are passed Serguei Spitsyn has updated the pull re

Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-10-26 Thread Markus Karg
Dear Sirs, apparently my opening of PR and CSR in DRAFT state gave the impression that these documents are published to request reviews. This is NOT the case! Both documents are still and fully intentionally in DRAFT state. I published them solely for the purpose of a public storage of my w

AW: Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-10-26 Thread Markus Karg
>Is it a follow up change/PR for various places which would benefit from using >the new method? Yes, there will be a subsequent PR for various places other than Reader.of(CharSequence). -Markus

Re: RFR: 8321413: IllegalArgumentException: Code length outside the allowed range while creating a jlink image [v6]

2024-10-26 Thread Henry Jen
> This PR split out large array/set construction into separate factory methods > to avoid oversized method trying to construct several of those. > > In order to do that, we will need to generate those help methods on demand in > the class builder. Here we have two approach, one is for dedup set,

Re: RFR: 8341260: Add Float16 to jdk.incubator.vector [v9]

2024-10-26 Thread Joe Darcy
> Port of Float16 from java.lang in the lworld+fp16 branch to > jdk.incubabor.vector. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 14 addi

Re: Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-10-26 Thread Brett Okken
+1 to option A. Option C is too limiting on uses for the target. It could be added as a default which calls through to option A, if there is meaningful demand. Is it a follow up change/PR for various places which would benefit from using the new method? On Fri, Oct 25, 2024 at 1:34 PM Markus Kar

Integrated: 8342083: Make a few fields in FileSystemPreferences final

2024-10-26 Thread Andrey Turbanov
On Mon, 23 Sep 2024 09:13:58 GMT, Andrey Turbanov wrote: > 8342083: Make a few fields in FileSystemPreferences final This pull request has now been integrated. Changeset: 0e3fc93d Author:Andrey Turbanov URL: https://git.openjdk.org/jdk/commit/0e3fc93dfb14378a848571a6b83282c0c73e690f

AW: Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-10-26 Thread Markus Karg
Chen, thank you for chiming in! :-) Answering in PR draft's discussion thread, where you asked the same question meanwhile, to not duplicate discussions. https://github.com/openjdk/jdk/pull/21730 -Markus Von: Chen Liang [mailto:liangchenb...@gmail.com] Gesendet: Samstag, 2

Re: Request for Comments: Adding bulk-read method "CharSequence.getChars(int srcBegin, int srcEnd, char[] dst, int dstBegin)"

2024-10-26 Thread Chen Liang
Hi Markus, Should we drop the srcBigin/srcEnd parameters, as they can be replaced by a subSequence(srcBegin, srcEnd) call? On Fri, Oct 25, 2024, 12:34 PM Markus Karg wrote: > I hereby request for comments on the proposal to generalize the existing > method "String.getChars()"'s signature to beco

Re: RFR: 8341566: Add Reader.of(CharSequence) [v11]

2024-10-26 Thread Markus KARG
On Tue, 15 Oct 2024 10:43:54 GMT, Markus KARG wrote: >> That had been discussed here: >> https://github.com/openjdk/jdk/pull/21371#pullrequestreview-2350588453 > > Stay tuned. I have already forwarded a subsequent RFE and PR to cover this > topic. 🤩 I just filed the PR to implement `CharSequen

Re: RFR: 8341566: Add Reader.of(CharSequence) [v3]

2024-10-26 Thread Markus KARG
On Tue, 8 Oct 2024 09:06:42 GMT, Markus KARG wrote: >> I believe this batch operation would be a useful addition, but it is best >> reserved for another RFE. > > Agree to Chen. As I already wrote in [the > RFE](https://bugs.openjdk.org/browse/JDK-8341566): >>As this option is not essentially ne

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v9]

2024-10-26 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Integrated: 8342865: Use type parameter for Class::getPrimitiveClass

2024-10-26 Thread Chen Liang
On Wed, 23 Oct 2024 03:06:39 GMT, Chen Liang wrote: > Discovered this small cleanup while looking at wrapper class code. This pull request has now been integrated. Changeset: 40e07a7e Author:Chen Liang URL: https://git.openjdk.org/jdk/commit/40e07a7ea31d04722cda3e6d2fc988df50a7cdca

Re: RFR: 8342642: Class loading failure due to archived map issue in ModuleLoaderMap.Mapper

2024-10-26 Thread Chen Liang
On Fri, 25 Oct 2024 21:25:54 GMT, Jiangli Zhou wrote: > Moved from > https://github.com/openjdk/jdk/pull/21672/commits/ade90fb51d1e3652910a3b46775522b730306e16: > > Please review the fix that uses String type for the mapped value in > ModuleLoaderMap.Mapper map (Map). Please see details in >

Integrated: 8343102: Remove `--compress` from jlink command lines from jpackage tests

2024-10-26 Thread Alexey Semenyuk
On Fri, 25 Oct 2024 21:35:37 GMT, Alexey Semenyuk wrote: > Remove `--compress` from jlink command lines in jpackage tests This pull request has now been integrated. Changeset: 9e451aa3 Author:Alexey Semenyuk URL: https://git.openjdk.org/jdk/commit/9e451aa36586badc7be58804ae6f12e6b67

Re: RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v8]

2024-10-26 Thread Doug Lea
> This addresses tendencies in previous update to increase fencing, scanning, > and signalling that can increase contention, and slow down performance > especially on ARM platforms. It also uses more ARM-friendly constructions to > reduce overhead (leading to several changes that all of the same

Re: RFR: 8342936: Enhance java.io.IO with parameter-less println() and readln() [v2]

2024-10-26 Thread Jaikiran Pai
On Fri, 25 Oct 2024 06:56:30 GMT, Jan Lahoda wrote: >> This PR is simply adding parameter-less `java.io.IO.{println(),readln()}`, >> with the (hopefully) obvious semantics, plus the corresponding wiring to >> make those work. This may become part of JEP 495: >> https://openjdk.org/jeps/495 > >

Re: RFR: 8342682: Errors related to unused code on Windows after 8339120 in dt_shmem jdwp security and jpackage [v2]

2024-10-26 Thread Julian Waters
On Thu, 24 Oct 2024 14:22:28 GMT, Julian Waters wrote: >> After 8339120, gcc began catching many different instances of unused code in >> the Windows specific codebase. Some of these seem to be bugs. I've taken the >> effort to mark out all the relevant globals and locals that trigger the >> u

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v12]

2024-10-26 Thread Richard Reingruber
On Sat, 26 Oct 2024 01:54:26 GMT, Dean Long wrote: >> Patricio Chilano Mateo has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Restore use of atPointA in test StopThreadTest.java >> - remove interruptible check from conditional in Objec

Re: RFR: 8338383: Implement JEP 491: Synchronize Virtual Threads without Pinning [v9]

2024-10-26 Thread Patricio Chilano Mateo
On Fri, 25 Oct 2024 21:28:22 GMT, Patricio Chilano Mateo wrote: >> If it's always the current thread, then it should be called 'current' imo. > > I see that in lightweightSynchronizer.cpp we already use the name > `locking_thread` (although > `LightweightSynchronizer::inflate_into_object_heade