On Tue, 15 Oct 2024 06:43:47 GMT, SendaoYan wrote:
>> The change looks OK to me. Please wait for Jorn @JornVernee to take a look,
>> before integrating.
>
>> The change looks OK to me. Please wait for Jorn @JornVernee to take a look,
>> before integrating.
>
> Okey.
> @sendaoYan I forgot to a
On Tue, 15 Oct 2024 06:34:44 GMT, Jaikiran Pai wrote:
> The change looks OK to me. Please wait for Jorn @JornVernee to take a look,
> before integrating.
Okey.
-
PR Comment: https://git.openjdk.org/jdk/pull/21512#issuecomment-2413025856
On Tue, 15 Oct 2024 01:25:56 GMT, SendaoYan wrote:
> Hi all,
> Test `java/foreign/TestUpcallStress.java` intermittent timeout with -Xcomp,
> and this test use a very precise race, thus `-Xcomp` probably will never
> trigger the problematic use-case. So this test not suitable for -Xcomp mode.I
On Wed, 9 Oct 2024 11:24:43 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base
On Mon, 14 Oct 2024 23:30:06 GMT, Brian Burkhalter wrote:
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
Overall the approach
> This is the 7th and final PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> This PR implements the AOT-linking of invokedynamic callsites:
> - We only link lambda expressions (`LambdaMetafactory::metafactory`) and
> string concat (`Stri
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
On Tue, 15 Oct 2024 05:16:58 GMT, Ioi Lam wrote:
>> This is the 6th PR for [JEP 483: Ahead-of-Time Class Loading &
>> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>>
>> The implementation of java.lang.invoke uses SoftReferences so that unused
>> MethodHandles, LambdaForms, etc, can b
On Mon, 14 Oct 2024 23:30:06 GMT, Brian Burkhalter wrote:
> Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
> to native code and use these in `ChannelInputStream` to work around cases
> where a wrapped `FileChannelImpl` is not really seekable.
src/java.base/window
> This is the 6th PR for [JEP 483: Ahead-of-Time Class Loading &
> Linking](https://bugs.openjdk.org/browse/JDK-8315737).
>
> The implementation of java.lang.invoke uses SoftReferences so that unused
> MethodHandles, LambdaForms, etc, can be garbage collected.
>
> However, if we want to store j
On Mon, 14 Oct 2024 20:57:45 GMT, Claes Redestad wrote:
>> If we trust that versioned entries are rare, this should not matter much
>> either way. But I pushed a commit which uses HashSet and Arrays::sort on
>> freezing instead. WDYT?
>>
>> Given that most versioned entries will only have a si
On Mon, 30 Sep 2024 09:19:21 GMT, Per Minborg wrote:
> This PR suggests fixing a problem on big-endian platforms.
Ran tier1 and got no regression for s390x. LGTM
-
Marked as reviewed by amitkumar (Committer).
PR Review: https://git.openjdk.org/jdk/pull/21258#pullrequestreview-2368
Hi all,
Test `java/foreign/TestUpcallStress.java` intermittent timeout with -Xcomp, and
this test use a very precise race, thus `-Xcomp` probably will never trigger
the problematic use-case. So this test not suitable for -Xcomp mode.I add
`@requires vm.compMode != "Xcomp"` to exclude from Xcomp
On Sun, 6 Oct 2024 09:15:58 GMT, SendaoYan wrote:
> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
> mode.
Okey, I will create a new PR to the test from the problem list and use
`@requires` instead. Thanks for the correction.
-
PR Comment: https://git.
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
Add `isOther` and `available` methods to `FileChannelImpl` and the interfaces
to native code and use these in `ChannelInputStream` to work around cases where
a wrapped `FileChannelImpl` is not really seekable.
-
Commit messages:
- 8233451: (fs) Files.newInputStream() cannot be used
On Mon, 14 Oct 2024 23:07:28 GMT, Erik Joelsson wrote:
> I'm taking this fix for a spin over night in the environment where I noticed
> the problem.
I'll hold off integrating until that is over.
-
PR Comment: https://git.openjdk.org/jdk/pull/21503#issuecomment-2412512411
On Mon, 14 Oct 2024 18:02:44 GMT, Brian Burkhalter wrote:
>> Change property `test.src` to `test.dir`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8341997: Replace test.dir property with CWD
I'm taking this fix for
On Mon, 14 Oct 2024 17:55:49 GMT, Brian Burkhalter wrote:
> The property `test.dir` has been used as a convention but I've no problem
> with changing it to the CWD.
I wasn't aware, but if it's convention, I'm ok with it.
-
PR Comment: https://git.openjdk.org/jdk/pull/21503#issueco
On Mon, 14 Oct 2024 18:02:44 GMT, Brian Burkhalter wrote:
>> Change property `test.src` to `test.dir`.
>
> Brian Burkhalter has updated the pull request incrementally with one
> additional commit since the last revision:
>
> 8341997: Replace test.dir property with CWD
Marked as reviewed by e
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
> repeated squares trick.
fabioromano1 has updated the pull request incrementally with one additional
commit since the last revision:
Apply suggestions from code review
-
Changes:
- all: https://git.openj
This addresses tendencies in previous update to increase fencing, scanning, and
signalling that can increase contention, and slow down performance especially
on ARM platforms. It also uses more ARM-friendly constructions to reduce
overhead (leading to several changes that all of the same form),
On Mon, 14 Oct 2024 19:52:50 GMT, Eirik Bjørsnøs wrote:
>> src/java.base/share/classes/java/util/zip/ZipFile.java line 1831:
>>
>>> 1829: metaVersions = new HashMap<>();
>>> 1830: for (var entry : metaVersionsMap.entrySet()) {
>>> 1831: // Conv
On Wed, 9 Oct 2024 11:24:43 GMT, Maurizio Cimadamore
wrote:
>> This PR moves the section on restricted methods from the the javadoc of
>> `java.lang.foreign` package into a standalone static [javadoc
>> page](https://cr.openjdk.org/~mcimadamore/jdk/restricted_javadoc_section/docs/api/java.base
On Mon, 14 Oct 2024 19:27:00 GMT, Eirik Bjørsnøs wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert 'inc should be faster than add on most CPUs'
>
> src/java.base/share/classes/java/io/Reader.java line 214:
>
>
8342083: Make a few fields in FileSystemPreferences final
-
Commit messages:
- [PATCH] Make a few fields in FileSystemPreferences final
Changes: https://git.openjdk.org/jdk/pull/21131/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21131&range=00
Issue: https://bugs.openj
On Mon, 14 Oct 2024 18:17:15 GMT, Chen Liang wrote:
>> Eirik Bjørsnøs has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Use Arrays.sort instead of TreeSet
>
> src/java.base/share/classes/java/util/zip/ZipFile.java line 1831:
>
>> 1829:
On Wed, 9 Oct 2024 08:44:34 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
>
> Please review this PR which speeds up `JarFile::getEntry` lookup
> significantly for multi-release JAR files.
>
> The changes in this PR are motivated by the following insights:
>
> * `META-INF/versions/` is sparsely populated.
> * Most entries are not versioned
> * The number of unique versio
On Mon, 14 Oct 2024 14:23:22 GMT, Alan Bateman wrote:
>> Jan Lahoda has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 15 commits:
>>
>> - Merge branch 'master' into JDK-8335989
>> - Reflecting review feedback.
>> - Cleanup.
>> -
On Sat, 12 Oct 2024 07:47:56 GMT, Markus KARG wrote:
>> This Pull Requests proposes an implementation for
>> [JDK-8341566](https://bugs.openjdk.org/browse/JDK-8341566): Adding the new
>> method `public static Reader Reader.of(CharSequence)` will return an
>> anonymous, non-synchronized impleme
Hi Viktor,
thanks for your clarifications.
I agree that from a performance point of view, there isn't all that much to be
gained. I thought more about parallelizing distinctBy and windowSliding,
Perhaps one can squeeze out a modest gain, but I am not excited by the
potential.
AFAIK, the "gre
On Sun, 13 Oct 2024 03:52:01 GMT, Justin Lu wrote:
>> Please review this PR which improves the safety of equality checking for
>> DecimalFormatSymbols. As certain setters did not throw NPE, this allowed for
>> NPE in the equality method. This PR now updates the setters to throw NPE.
>>
>> In a
On Mon, 14 Oct 2024 11:01:21 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `JarFile::getEntry` lookup
> significantly for multi-release JAR files.
>
> The changes in this PR are motivated by the following insights:
>
> * `META-INF/versions/` is sparsely populated.
> * Most
On Mon, 30 Sep 2024 09:19:21 GMT, Per Minborg wrote:
> This PR suggests fixing a problem on big-endian platforms.
This version uses little endian accesses on big endian machines. This may
defeat the purpose of
[JDK-8339531](https://bugs.openjdk.org/browse/JDK-8339531) for those platforms.
Acc
> Change property `test.src` to `test.dir`.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8341997: Replace test.dir property with CWD
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21503/files
- new: https:
On Mon, 14 Oct 2024 17:37:01 GMT, Brian Burkhalter wrote:
> Change property `test.src` to `test.dir`.
The property `test.dir` has been used as a convention but I've no problem with
changing it to the CWD.
-
PR Comment: https://git.openjdk.org/jdk/pull/21503#issuecomment-2411903557
On Mon, 14 Oct 2024 17:37:01 GMT, Brian Burkhalter wrote:
> Change property `test.src` to `test.dir`.
I can't find any reference to `test.dir` in the jtreg documentation. I would
expect to see it here https://openjdk.org/jtreg/tag-spec.html#testvars. My
understanding is that you should just us
On Mon, 14 Oct 2024 15:04:54 GMT, Jasmine Karthikeyan
wrote:
> For the record I think in this PR we could simply match the IR patterns in
> the ad file, since (from my understanding) the patterns we are matching could
> be supported there. We should do platform-specific lowering in a separate
Change property `test.src` to `test.dir`.
-
Commit messages:
- 8341997: Tests create files in src tree instead of scratch dir
Changes: https://git.openjdk.org/jdk/pull/21503/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=21503&range=00
Issue: https://bugs.openjdk.org/bro
On Mon, 30 Sep 2024 09:57:11 GMT, Amit Kumar wrote:
>> This PR suggests fixing a problem on big-endian platforms.
>
> @minborg , I am still getting error on s390x (big endian):
>
> STDOUT:
> test TestMismatch.random(): failure [197ms]
> java.lang.AssertionError: expected [1] but found [0]
>
On Fri, 11 Oct 2024 05:39:20 GMT, Chen Liang wrote:
> Patch a tableswitch instruction's low value to be greater than a high value,
> previously, javap will not print any previous instruction and report
> problematic address/bci to be 0. This is because the iteration of bound
> models require f
On Thu, 10 Oct 2024 19:13:01 GMT, Chen Liang wrote:
> Please review this patch that adds a test by @nizarbenalla to perform null
> checks across the ClassFile API. This is an updated version of #20556 that
> minimizes impact on our implementation code.
>
> Notes:
> 1. There's one change in `Me
On Fri, 11 Oct 2024 16:21:30 GMT, Chen Liang wrote:
>> Please review this patch that adds a test by @nizarbenalla to perform null
>> checks across the ClassFile API. This is an updated version of #20556 that
>> minimizes impact on our implementation code.
>>
>> Notes:
>> 1. There's one change
Right, the issue has been solved.
The library ended up on the classpath, because the module descriptor could not
be read (Classfile API will solve this in the future).
Plexus-java is the library responsible for this.
The latest version op plexus-java supports Java 23, and based on the
docum
On Mon, 30 Sep 2024 09:19:21 GMT, Per Minborg wrote:
> This PR suggests fixing a problem on big-endian platforms.
@minborg , I am still getting error on s390x (big endian):
STDOUT:
test TestMismatch.random(): failure [197ms]
java.lang.AssertionError: expected [1] but found [0]
at org.t
This PR suggests fixing a problem on big-endian platforms.
-
Commit messages:
- Remove debug info
- Add debug logs
- Use another way for BE
- Merge branch 'master' into mismatch-big-endian
- Always use little endian in get operations
Changes: https://git.openjdk.org/jdk/pull/212
Hi,
I cannot confirm this. Apache Lucene (just released today in version
10.0.0, but also previous veersion 9.12.0) can open indexes just fine,
both with preview enabled or not. I modified the start script of the
"Luke" GUI to use classpath mode and add the "--enable-preview" flag.
All varian
Hello Robert,
This certainly looks like a behavioural change that would need
investigation. So yes, a reproducer will be helpful.
-Jaikiran
On 13/10/24 5:23 pm, Robert Scholte wrote:
Hi,
It seems there’s a change in the ServiceLoader, and it looks like
regression to me.
I’ve created a s
Christian Stein mentioned that this is something to due with Surefire
not supporting JDK 23 class files, is that right?
-Alan
On 13/10/2024 12:53, Robert Scholte wrote:
Hi,
It seems there’s a change in the ServiceLoader, and it looks like
regression to me.
I’ve created a small project t
Hi Mark,
Try running app launcher with JPACKAGE_DEBUG env variable set to "true":
$ env JPACKAGE_DEBUG=true /app/bin/example
It will produce debug output in the console that might give a clue what
went wrong.
- Alexey
On 10/5/2024 10:15 AM, Mark Raynsford wrote:
Hello!
I've been working
On Mon, 7 Oct 2024 14:53:48 GMT, SendaoYan wrote:
>> A trivial fix to ProblemList `java/foreign/TestUpcallStress.java` in Xcomp
>> mode.
>
> Thanks for the review.
Hello @sendaoYan, I noticed this PR today. For tests that we want to exclude
from Xcomp testing, the convention has been to use a
Hi,
It seems there's a change in the ServiceLoader, and it looks like regression
to me.
I've created a small project to reproduce it (I can provide it if wanted and
confirmed this is indeed a bug).
What it basically does is just:
ServiceLoader.load(Car.class).findFirst().orElseThrow();
On Mon, 14 Oct 2024 15:30:16 GMT, Raffaello Giulietti
wrote:
>> Maybe something like "too few powers of five left to remove with respect to
>> the number of removable zeros in the initial value of intVal", I can't think
>> of anything better for now...
>
> OK, let me give it a try, maybe tomor
On Mon, 14 Oct 2024 04:13:46 GMT, Johny Jose wrote:
>> Timezone data 2024b changes
>
> Johny Jose has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review changes
LGTM
-
Marked as reviewed by naoto (Reviewer).
PR Review: https
> The fourth preview of scoped values.
Andrew Haley has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains seven additional commits since
the last revision:
On Sun, 13 Oct 2024 11:18:01 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> As per the discussion on panama-dev mailing list[1], patch adds the support
>> for following new two vector permutation APIs.
>>
>>
>> Declaration:-
>> Vector.selectFrom(Vector v1, Vector v2)
>>
>>
>> Semantics:-
>>
On Mon, 14 Oct 2024 15:25:44 GMT, fabioromano1 wrote:
>> It's hard for me to think of something more explicit than the mathematical
>> definitions already present in the comments...
>
> Maybe something like "too few powers of five left to remove with respect to
> the maximum number of removable
On Mon, 14 Oct 2024 15:16:49 GMT, fabioromano1 wrote:
>> src/java.base/share/classes/java/math/BigDecimal.java line 5280:
>>
>>> 5278: BigInteger[] qr; // quotient-remainder pair
>>> 5279: // Remove 5^(2^i) from the factors of intVal, until
>>> 5^remainingZeros < 5^(2^i)
>>> 528
On Mon, 14 Oct 2024 15:06:42 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Added mathematical comments for maxPowsOf5
>
> src/java.base/share/classes/java/math/BigDecimal.java line 5280:
On Sun, 13 Oct 2024 22:45:25 GMT, fabioromano1 wrote:
>> An optimized algorithm for `BigDecimal.stripTrailingZeros()` that uses
>> repeated squares trick.
>
> fabioromano1 has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Added mathematical
On Wed, 9 Oct 2024 09:59:11 GMT, Jatin Bhateja wrote:
>> This patch optimizes LongVector multiplication by inferring VPMULUDQ
>> instruction for following IR pallets.
>>
>>
>>MulL ( And SRC1, 0x) ( And SRC2, 0x)
>>MulL (URShift SRC1 , 32) (URShift S
On Mon, 14 Oct 2024 13:40:50 GMT, Andrew Haley wrote:
>> The fourth preview of scoped values.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Scoped values
> - Scoped values
Tier1 and Tier2 done. I had one tier2 failure
On Mon, 14 Oct 2024 11:01:21 GMT, Eirik Bjørsnøs wrote:
> Please review this PR which speeds up `JarFile::getEntry` lookup
> significantly for multi-release JAR files.
>
> The changes in this PR are motivated by the following insights:
>
> * `META-INF/versions/` is sparsely populated.
> * Most
Please review this PR which speeds up `JarFile::getEntry` lookup significantly
for multi-release JAR files.
The changes in this PR are motivated by the following insights:
* `META-INF/versions/` is sparsely populated.
* Most entries are not versioned
* The number of unique versions for each vers
On Mon, 14 Oct 2024 12:46:29 GMT, Jan Lahoda wrote:
>> This is a current patch for module imports declarations, second preview. At
>> least the JEP number and preview revision will need to be updated in
>> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
>> ready to
On Mon, 14 Oct 2024 12:12:58 GMT, Jatin Bhateja wrote:
>>> I am having a similar idea that is to group those transformations together
>>> into a `Phase` called `PhaseLowering`
>>
>> I think such a phase could be quite useful in general. Recently I was trying
>> to implement the BMI1 instructio
On Mon, 14 Oct 2024 13:40:50 GMT, Andrew Haley wrote:
>> The fourth preview of scoped values.
>
> Andrew Haley has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Scoped values
> - Scoped values
The changes in update 90a344a3 looks okay, ju
On Sat, 12 Oct 2024 11:33:33 GMT, Markus KARG wrote:
>> test/jdk/java/io/Reader/Of.java line 92:
>>
>>> 90:
>>> 91: @Test(dataProvider = "readers")
>>> 92: public void testReadBII(Reader reader) throws IOException {
>>
>> What does `BII` in some of these test method names represent?
>
> The fourth preview of scoped values.
Andrew Haley has updated the pull request incrementally with two additional
commits since the last revision:
- Scoped values
- Scoped values
-
Changes:
- all: https://git.openjdk.org/jdk/pull/21456/files
- new: https://git.openjdk.org/jd
On Mon, 14 Oct 2024 12:45:36 GMT, Per Minborg wrote:
>> This PR prevents sequence layout with padding to be used with the Linker.
>
> Per Minborg has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in
> This is a current patch for module imports declarations, second preview. At
> least the JEP number and preview revision will need to be updated in
> `jdk.internal.javac.PreviewFeature.Feature`, but otherwise I believe this is
> ready to receive feedback.
>
> The main changes are:
> - `require
> This PR prevents sequence layout with padding to be used with the Linker.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 13 additional co
On Fri, 11 Oct 2024 17:12:49 GMT, Jasmine Karthikeyan
wrote:
> > I am having a similar idea that is to group those transformations together
> > into a `Phase` called `PhaseLowering`
>
> I think such a phase could be quite useful in general. Recently I was trying
> to implement the BMI1 instru
On Fri, 11 Oct 2024 18:05:58 GMT, Kim Barrett wrote:
>> Matthias Baesken has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> comm
On Wed, 9 Oct 2024 07:50:20 GMT, Matthias Baesken wrote:
>> There is some old awt/2d coding where warnings occur when running with ubsan
>> enabled binaries.
>> However at most of these locations the coding should work (at least on our
>> supported platform set) so the warnings can be disabled
On Wed, 9 Oct 2024 08:44:34 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
>
79 matches
Mail list logo
