Re: RFR: 8341141: Optimize DirectCodeBuilder [v10]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8341141: Optimize DirectCodeBuilder [v9]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long) [v3]

2024-09-29 Thread Per Minborg
On Fri, 27 Sep 2024 17:42:25 GMT, Andrew Haley wrote: > > The only situation where this PR is a regression compared to current code > > is when the one of the branch side is always taken. > > Bear in mind that's quite common. It's not very unusual to clip a range with > something equivalent to

Re: RFR: 8341141: Optimize DirectCodeBuilder [v8]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8341141: Optimize DirectCodeBuilder [v7]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8341141: Optimize DirectCodeBuilder [v6]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8338017: Add AOT command-line flag aliases [v6]

2024-09-29 Thread Ioi Lam
> This is the 1st PR for [JEP 483: Ahead-of-Time Class Loading & > Linking](https://bugs.openjdk.org/browse/JDK-8315737). > > Add the following command-line options as specified in JEP 483: > > > - `-XX:AOTMode=off/record/create/auto/on` > - `-XX:AOTConfiguration=.aotconfig` > - `-XX:AOTCache=.

Re: RFR: 8341064: Define anchor point and index term for "wrapper classes" [v4]

2024-09-29 Thread Chen Liang
On Mon, 30 Sep 2024 02:10:09 GMT, Joe Darcy wrote: >> The is the initial version of a PR to defined an anchor point and index term >> of "wrapper classes." > > Joe Darcy has updated the pull request incrementally with one additional > commit since the last revision: > > Respond to review fee

Re: RFR: 8341100: Add index entries for terms used in java.lang.Class [v2]

2024-09-29 Thread Joe Darcy
> Small update to java.lang.Class docs. > > I didn't add an index item for "hidden classes" since the indexing mechanism > picks up the section titles. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. --

Re: RFR: 8341064: Define anchor point and index term for "wrapper classes" [v3]

2024-09-29 Thread Joe Darcy
On Sun, 29 Sep 2024 18:08:10 GMT, Jonathan Gibbons wrote: >> Agree; I have recommedned consolidating id property into h2 without an extra >> a tag. > > `` is a semantic tag to indicate the defining instance of a term. It may > be used by search engines, to improve their results. When `` is us

Re: RFR: 8341064: Define anchor point and index term for "wrapper classes" [v4]

2024-09-29 Thread Joe Darcy
> The is the initial version of a PR to defined an anchor point and index term > of "wrapper classes." Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org

Re: RFR: 8341141: Optimize DirectCodeBuilder [v5]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe

2024-09-29 Thread David Holmes
On Sun, 29 Sep 2024 22:39:28 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/invoke/MethodHandle.java line 1882: >> >>> 1880: assert (newForm.customized == null || >>> newForm.customized == this); >>> 1881: newForm.prepare(); // as in Meth

Re: RFR: 8341141: Optimize DirectCodeBuilder [v4]

2024-09-29 Thread Chen Liang
On Sun, 29 Sep 2024 13:35:14 GMT, Shaojin Wen wrote: >> Some DirectCodeBuilder related optimizations to improve startup and running >> performance: >> 1. Merge calls, merge writeU1 and writeU2 into writeU3 >> 2. Merge calls, merge writeU1 and writeIndex operations >> 3. Directly use writeU1 inst

Re: RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe

2024-09-29 Thread Chen Liang
On Sun, 29 Sep 2024 22:22:30 GMT, David Holmes wrote: >> When investigating an intermittent NPE with an Oracle internal test on >> AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by >> `MethodHandles::jump_to_lambda_form` when trying to load the >> `MemberName::method

Re: RFR: 8340812: LambdaForm customization via MethodHandle::updateForm is not thread safe

2024-09-29 Thread David Holmes
On Tue, 24 Sep 2024 14:18:58 GMT, Tobias Hartmann wrote: > When investigating an intermittent NPE with an Oracle internal test on > AArch64, I noticed that the NPE is actually a SIGSEGV in the code emitted by > `MethodHandles::jump_to_lambda_form` when trying to load the > `MemberName::method`

Re: RFR: 8340801: Disable ubsan checks in some awt/2d coding

2024-09-29 Thread David Holmes
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote: > There is some old awt/2d coding where warnings occur when running with ubsan > enabled binaries. > However at most of these locations the coding should work (at least on our > supported platform set) so the warnings can be disabled at

Re: RFR: 8340572: ConcurrentModificationException when sorting ArrayList sublists

2024-09-29 Thread David Holmes
On Sun, 29 Sep 2024 17:44:30 GMT, Attila Szegedi wrote: > Fixes a regression with #17818 where `ArrayList.subList(…).sort()` started > incrementing `ArrayList.modCount` resulting in some cases throwing a > `ConcurrentModificationException` where none was thrown before. > > This change keeps th

Re: RFR: 8341141: Optimize DirectCodeBuilder [v4]

2024-09-29 Thread Claes Redestad
On Sun, 29 Sep 2024 13:35:14 GMT, Shaojin Wen wrote: >> Some DirectCodeBuilder related optimizations to improve startup and running >> performance: >> 1. Merge calls, merge writeU1 and writeU2 into writeU3 >> 2. Merge calls, merge writeU1 and writeIndex operations >> 3. Directly use writeU1 inst

Re: RFR: 8341064: Define anchor point and index term for "wrapper classes" [v3]

2024-09-29 Thread Jonathan Gibbons
On Sat, 28 Sep 2024 21:45:09 GMT, Chen Liang wrote: >> src/java.base/share/classes/java/lang/package-info.java line 34: >> >>> 32: * Frequently it is necessary to represent a value of primitive >>> 33: * type as if it were an object. The >>> 34: * {@index "wrapper classes"} {@link Boolean}, {

RFR: 8340572: ConcurrentModificationException when sorting ArrayList sublists

2024-09-29 Thread Attila Szegedi
Fixes a regression with #17818 where `ArrayList.subList(…).sort()` started incrementing `ArrayList.modCount` resulting in some cases throwing a `ConcurrentModificationException` where none was thrown before. This change keeps the optimization from #17818 but restores the behavior where only sor

Re: RFR: 8341141: Optimize DirectCodeBuilder [v4]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: Proposal for new public class: java.io.CharSequenceReader

2024-09-29 Thread Rob Spoor
On 28/09/2024 18:15, Markus Karg wrote: - Applications could use Apache Commons IO's CharSequenceReader. As it is an open-source third-party dependency, some authors might not be allowed to use it, or may not want to carry this additional burden just for the sake of this single performance improv

Re: RFR: 8341141: Optimize DirectCodeBuilder [v3]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8341141: Optimize DirectCodeBuilder [v2]

2024-09-29 Thread Shaojin Wen
> Some DirectCodeBuilder related optimizations to improve startup and running > performance: > 1. Merge calls, merge writeU1 and writeU2 into writeU3 > 2. Merge calls, merge writeU1 and writeIndex operations > 3. Directly use writeU1 instead of writeBytecode > 4. Rewrite the implementation of load

Re: RFR: 8340229: Improve opening sentence of FileInputStream constructor specification

2024-09-29 Thread Alan Bateman
On Fri, 27 Sep 2024 16:06:51 GMT, Brian Burkhalter wrote: > Improve the first sentences of the three `FileInputStream` constructors, in > particular removing the term "connection." src/java.base/share/classes/java/io/FileInputStream.java line 166: > 164: /** > 165: * Creates a {@code