On Fri, 27 Sep 2024 16:06:51 GMT, Brian Burkhalter wrote:
> Improve the first sentences of the three `FileInputStream` constructors, in
> particular removing the term "connection."
Do you think, as part of this PR, we should also revisit some of the javadoc in
the `java.io.FileOutputStream` cl
> The is the initial version of a PR to defined an anchor point and index term
> of "wrapper classes."
Joe Darcy has updated the pull request with a new target base due to a merge or
a rebase. The incremental webrev excludes the unrelated changes brought in by
the merge/rebase. The pull request
On Fri, 27 Sep 2024 09:18:11 GMT, Pavel Rappo wrote:
>> The is the initial version of a PR to defined an anchor point and index term
>> of "wrapper classes."
>
> src/java.base/share/classes/java/lang/package-info.java line 36:
>
>> 34: * The {@index "wrapper classes"} {@link Boolean},
>> 35:
On Fri, 19 Jul 2024 15:52:14 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS
> archive;
> during run time, full module graph will not be used.
>
> With this patch, the full module graph will be included in the CDS archive
>
> Prior to this patch, if `--module-path` is specified in the command line:
> during CDS dump time, full module graph will not be included in the CDS
> archive;
> during run time, full module graph will not be used.
>
> With this patch, the full module graph will be included in the CDS archive
>
On Thu, 26 Sep 2024 23:46:04 GMT, Joe Darcy wrote:
> The is the initial version of a PR to defined an anchor point and index term
> of "wrapper classes."
src/java.base/share/classes/java/lang/package-info.java line 36:
> 34: * The {@index "wrapper classes"} {@link Boolean},
> 35: * {@link Ch
On Thu, 26 Sep 2024 17:24:18 GMT, Justin Lu wrote:
>> Please review this PR which removes usages of Applet within the corelibs
>> tests.
>>
>> Most changes are removed comments/updated var names. The JBS issue lists
>> more files than the ones included in this pull request, please see the
>>
On Mon, 23 Sep 2024 05:57:09 GMT, Calvin Cheung wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleReferences.java line
>> 105:
>>
>>> 103: public byte[] generate(String algorithm) {
>>> 104: return ModuleHashes.computeHash(supplier, algorithm);
>>> 105:
On Fri, 27 Sep 2024 14:15:04 GMT, Galder Zamarreño wrote:
> The only situation where this PR is a regression compared to current code is
> when the one of the branch side is always taken.
Bear in mind that's quite common. It's not very unusual to clip a range with
something equivalent to `x =
> This implementation of MutableBigInteger.leftShift(int) optimizes the current
> version, avoiding unnecessary copy of the MutableBigInteger's value content
> and performing the primitive shifting only in the original portion of the
> value array rather than in the value yet extended with trail
On Fri, 30 Aug 2024 18:12:38 GMT, David M. Lloyd wrote:
>> Please review this small documentation change to ConstantPoolBuilder to fix
>> a typo and clarify the usage of the `constantValueEntry` method.
>
> David M. Lloyd has updated the pull request incrementally with one additional
> commit s
On Fri, 19 Jul 2024 15:52:14 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Fri, 27 Sep 2024 17:44:38 GMT, Vladimir Kozlov wrote:
> Is ZGC affected by this? I see only G1 and Shenandoah changes.
Good question.
ZGC expands the GC barriers late. This is why the IR test configuration that
tests ZGC shows the same result as with other collectors: no additional fluff
i
> This implementation of MutableBigInteger.leftShift(int) optimizes the current
> version, avoiding unnecessary copy of the MutableBigInteger's value content
> and performing the primitive shifting only in the original portion of the
> value array rather than in the value yet extended with trail
On Tue, 10 Sep 2024 16:37:11 GMT, sbgoog wrote:
> FIleSystemPreferences.lockFile() catches an InterruptedException and just
> returns false, forgetting to re-interrupt the current thread. This leaves the
> caller with no way to observe that the thread was interrupted. This change
> restores th
> Please review this PR which removes usages of Applet within the corelibs
> tests.
>
> Most changes are removed comments/updated var names. The JBS issue lists more
> files than the ones included in this pull request, please see the comment on
> the JBS issue for the reason why they were not i
> This PR split out large array/set construction into separate factory methods
> to avoid oversized method trying to construct several of those.
>
> In order to do that, we will need to generate those help methods on demand in
> the class builder. Here we have two approach, one is for dedup set,
On Fri, 19 Jul 2024 15:52:14 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Fri, 27 Sep 2024 11:11:20 GMT, Alan Bateman wrote:
> Do you remember why resetArchivedStates resets the resource cache? I would
> expected it to be cleared for all class loaders.
>
I think it is because `resourceCache` is a `SoftReference` and it will fail the
check in `JavaClasses::is_sup
Improve the first sentences of the three `FileInputStream` constructors, in
particular removing the term "connection."
-
Commit messages:
- 8340229: Improve opening sentence of FileInputStream constructor
specification
Changes: https://git.openjdk.org/jdk/pull/21223/files
Webrev
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Thu, 26 Sep 2024 08:16:50 GMT, Adam Sotona wrote:
>> Class-File API is leaving preview.
>> This is a removal of all `@PreviewFeature` annotations from Class-File API.
>> It also bumps all `@since` tags and removes
>> `jdk.internal.javac.PreviewFeature.Feature.CLASSFILE_API`.
>>
>> Please rev
On Wed, 25 Sep 2024 16:22:55 GMT, Eirik Bjørsnøs wrote:
>> Please review this cleanup PR which makes `ZipFile.Source.initCEN` not
>> include the 22-byte trailing`END` header when reading the `CEN` section of
>> the ZIP file.
>>
>> The reading of the END header was probably brought over from na
On Fri, 27 Sep 2024 14:38:56 GMT, sbgoog wrote:
> This PR needs another reviewer. Is there someone that can have a look at it?
@djelinski ? @jaikiran ?
-
PR Comment: https://git.openjdk.org/jdk/pull/20938#issuecomment-2379585126
On Thu, 12 Sep 2024 20:49:49 GMT, fabioromano1 wrote:
>> This implementation of MutableBigInteger.leftShift(int) optimizes the
>> current version, avoiding unnecessary copy of the MutableBigInteger's value
>> content and performing the primitive shifting only in the original portion
>> of the
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
On Tue, 3 Sep 2024 16:50:26 GMT, fabioromano1 wrote:
>>> > It would be nice to see some benchmarks where it gives performance
>>> > benefits.
>>>
>>> @kuksenko Try to run the benchmark of the `BigInteger`'s square root, maybe
>>> there the benefits are more visible...
>>
>> "maybe"
>> So,
On Tue, 10 Sep 2024 16:37:11 GMT, sbgoog wrote:
> FIleSystemPreferences.lockFile() catches an InterruptedException and just
> returns false, forgetting to re-interrupt the current thread. This leaves the
> caller with no way to observe that the thread was interrupted. This change
> restores th
On Fri, 27 Sep 2024 14:21:57 GMT, Galder Zamarreño wrote:
>> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
>> order to help improve vectorization performance.
>>
>> Currently vectorization does not kick in for loops containing either of
>> these calls because of
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
> order to help improve vectorization performance.
>
> Currently vectorization does not kick in for loops containing either of these
> calls because of the following error:
>
>
> VLoop::check_preconditions: failed:
> This patch intrinsifies `Math.max(long, long)` and `Math.min(long, long)` in
> order to help improve vectorization performance.
>
> Currently vectorization does not kick in for loops containing either of these
> calls because of the following error:
>
>
> VLoop::check_preconditions: failed:
On Wed, 17 Jul 2024 22:48:04 GMT, Jasmine Karthikeyan
wrote:
>>> The C2 changes look nice! I just added one comment here about style. It
>>> would also be good to add some IR tests checking that the intrinsic is
>>> creating `MaxL`/`MinL` nodes before macro expansion, and a microbenchmark
>>>
On Tue, 3 Sep 2024 16:50:26 GMT, fabioromano1 wrote:
>>> > It would be nice to see some benchmarks where it gives performance
>>> > benefits.
>>>
>>> @kuksenko Try to run the benchmark of the `BigInteger`'s square root, maybe
>>> there the benefits are more visible...
>>
>> "maybe"
>> So,
On Fri, 19 Jul 2024 15:52:14 GMT, Aleksey Shipilev wrote:
>> [JDK-8240696](https://bugs.openjdk.org/browse/JDK-8240696) added the native
>> method for `Reference.clear`. The original patch skipped intrinsification of
>> this method, because we thought `Reference.clear` is not on a performance
On Tue, 24 Sep 2024 21:17:35 GMT, Calvin Cheung wrote:
>> src/java.base/share/classes/jdk/internal/module/ModuleBootstrap.java line
>> 481:
>>
>>> 479: cf,
>>> 480: clf,
>>> 481: mainModule);
>>
>> This was correctly aligned before, n
On Thu, 26 Sep 2024 00:49:20 GMT, Calvin Cheung wrote:
>> Prior to this patch, if `--module-path` is specified in the command line:
>> during CDS dump time, full module graph will not be included in the CDS
>> archive;
>> during run time, full module graph will not be used.
>>
>> With this patc
On Wed, 25 Sep 2024 12:17:59 GMT, Matthias Baesken wrote:
> There is some old awt/2d coding where warnings occur when running with ubsan
> enabled binaries.
> However at most of these locations the coding should work (at least on our
> supported platform set) so the warnings can be disabled at
On Fri, 27 Sep 2024 06:46:24 GMT, Matthias Baesken wrote:
> And it was reviewed by erikj and ihse, I think those are members of the
> OpenJDK build group
Erik and Magnus are indeed part of the build team. Erik is the Skara tool lead
but does build work as well, while Magnus is pretty much the
39 matches
Mail list logo
