Re: RFR: 8339644: Improve parsing of Day/Month in tzdata rules [v3]

2024-09-08 Thread Sean Coffey
On Fri, 6 Sep 2024 21:49:30 GMT, Naoto Sato wrote: >> Fixing TZDB build tool to accommodate full month/day names. Recently >> released tzdb2024b included (inadvertently) full month name "April", which >> is allowed by the spec (zic.8), but never used. This will cause build >> failure of the JD

Re: RFR: 8338890: Add monitoring/management interface for the virtual thread scheduler [v4]

2024-09-08 Thread Alan Bateman
> This PR proposes to add a JDK-specific monitoring and management interface > for the virtual thread scheduler. The interface is named > [VirtualThreadSchedulerMXBean](https://download.java.net/java/early_access/loom/docs/api/jdk.management/jdk/management/VirtualThreadSchedulerMXBean.html) > an

Integrated: 8339710: Avoid initializing AccessFlag related classes in write-only cases

2024-09-08 Thread Claes Redestad
On Sun, 8 Sep 2024 13:17:24 GMT, Claes Redestad wrote: > This PR reduces number of classes loaded on a minimal lambda bootstrapping > test by 4 by avoiding the need to pull in some AccessFlag classes. This pull request has now been integrated. Changeset: b45fe174 Author:Claes Redestad URL

Re: RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases [v2]

2024-09-08 Thread Claes Redestad
On Sun, 8 Sep 2024 16:48:36 GMT, Claes Redestad wrote: >> This PR reduces number of classes loaded on a minimal lambda bootstrapping >> test by 4 by avoiding the need to pull in some AccessFlag classes. > > Claes Redestad has updated the pull request incrementally with one additional > commit s

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v5]

2024-09-08 Thread Shaojin Wen
> The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat methods can also be exposed through JLA for use by other

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v4]

2024-09-08 Thread Shaojin Wen
> The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat methods can also be exposed through JLA for use by other

Re: RFR: 8307513: C2: intrinsify Math.max(long,long) and Math.min(long,long)

2024-09-08 Thread Galder Zamarreño
On Tue, 3 Sep 2024 07:37:33 GMT, Francesco Nigro wrote: >> Working on it > > @galderz in the benchmark did you collected the mispredicts/branches? @franz1981 No I hadn't done so until now, but I will be tracking those more closely. Context: I have been running some reduction JMH benchmarks an

Re: RFR: 8339687: Rearrange reachabilityFence()s in jdk.test.lib.util.ForceGC

2024-09-08 Thread David Holmes
On Sat, 7 Sep 2024 00:39:16 GMT, Stuart Marks wrote: >> From the bug description: >> ForceGC would be improved by moving the Reference.reachabilityFence() calls >> for 'obj' and 'ref'. >> >> Reference.reachabilityFence(obj) is currently placed after 'obj' has been >> set to null, so effectivel

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v3]

2024-09-08 Thread Shaojin Wen
> The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat methods can also be exposed through JLA for use by other

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v11]

2024-09-08 Thread Shaojin Wen
> This is a follow-up to PR #20273, which improves performance when the number > of parameters exceeds 20. > > When the number of parameters is large, the possibility of reuse will be > lower, so we can use the static concat method and write the length and coder > directly into the bytecode to

Re: RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases [v2]

2024-09-08 Thread Chen Liang
On Sun, 8 Sep 2024 16:48:36 GMT, Claes Redestad wrote: >> This PR reduces number of classes loaded on a minimal lambda bootstrapping >> test by 4 by avoiding the need to pull in some AccessFlag classes. > > Claes Redestad has updated the pull request incrementally with one additional > commit s

Re: RFR: 8338930: StringConcatFactory hardCoded string concatenation strategy [v10]

2024-09-08 Thread Claes Redestad
On Sun, 8 Sep 2024 05:01:53 GMT, Shaojin Wen wrote: >> This is a follow-up to PR #20273, which improves performance when the number >> of parameters exceeds 20. >> >> When the number of parameters is large, the possibility of reuse will be >> lower, so we can use the static concat method and w

Re: RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases

2024-09-08 Thread Claes Redestad
On Sun, 8 Sep 2024 13:17:24 GMT, Claes Redestad wrote: > This PR reduces number of classes loaded on a minimal lambda bootstrapping > test by 4 by avoiding the need to pull in some AccessFlag classes. Added `DirectMethodBuilder::withFlags` too, for consistency. - PR Comment: https

Re: RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases [v2]

2024-09-08 Thread Claes Redestad
> This PR reduces number of classes loaded on a minimal lambda bootstrapping > test by 4 by avoiding the need to pull in some AccessFlag classes. Claes Redestad has updated the pull request incrementally with one additional commit since the last revision: Add DMB.withFlags for consistency --

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v2]

2024-09-08 Thread Claes Redestad
On Sun, 8 Sep 2024 14:44:16 GMT, Shaojin Wen wrote: >> src/java.base/share/classes/java/lang/StringConcatHelper.java line 731: >> >>> 729: @ForceInline >>> 730: static String concat(String prefix, float value, String suffix) { >>> 731: if (prefix == null) prefix = "null"; >> >>

Re: [External] : Re: Stream Gatherers (JEP 473) feedback

2024-09-08 Thread Viktor Klang
>The non-reusability is intentional here, being a drop-in replacement for >`Stream::concat`. Gatherers are designed to be reusable, Streams not. So having a Gatherer which isn't reusable would be a bit of a non-starter I'm afraid. Or perhaps I misunderstood? Personally, when I want to concat m

RFR: 8339711: ZipFile.Source.initCEN needlessly reads END header

2024-09-08 Thread Eirik Bjørsnøs
Please review this cleanup PR which makes `ZipFile.Source.initCEN` not include the 22-byte trailing`END` header when reading the `CEN` section of the ZIP file. The reading of the END header was probably brought over from native code with the transition to Java in JDK 9. In the current JDK, the

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v2]

2024-09-08 Thread Shaojin Wen
On Sun, 8 Sep 2024 13:31:53 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update >> src/java.base/share/classes/java/lang/invoke/StringConcatFactory.java >> >> Co-authored-by: Claes Redes

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat [v2]

2024-09-08 Thread Shaojin Wen
> The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat methods can also be exposed through JLA for use by other

Re: [External] : Re: [POTENTIAL BUG] Potential FIFO violation in BlockingQueue under high contention and suggestion for fair mode in ArrayBlockingQueue and LinkedBlockingQueue

2024-09-08 Thread Archie Cobbs
Hi Kim, Thanks for the details. So to summarize: - Kim is saying that "Interpretation B" is how it actually works. - Viktor is saying that "Interpretation A" is how it actually works. Do I have that right? -Archie P.S. Viktor: my apologies for misspelling your name before On Sat, Sep

Re: RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases

2024-09-08 Thread Chen Liang
On Sun, 8 Sep 2024 13:17:24 GMT, Claes Redestad wrote: > This PR reduces number of classes loaded on a minimal lambda bootstrapping > test by 4 by avoiding the need to pull in some AccessFlag classes. Do you think we need a parallel declaration in `DirectMethodBuilder`? Though that one won't b

Re: RFR: 8339704: Refactor StringConcatHelper simpleConcat

2024-09-08 Thread Claes Redestad
On Tue, 27 Aug 2024 10:09:09 GMT, Shaojin Wen wrote: > The string concatenation of the java.base module is implemented using > StringBuilder. By providing a series of concat methods in StringConcatHelper, > it is used in the java.lang package to replace string concatenation. > > These concat m

RFR: 8339710: Avoid initializing AccessFlag related classes in write-only cases

2024-09-08 Thread Claes Redestad
This PR reduces number of classes loaded on a minimal lambda bootstrapping test by 4 by avoiding the need to pull in some AccessFlag classes. - Commit messages: - Add withFlag(int) to DFB for consistency - Avoid loading AccessFlag by providing overrides Changes: https://git.openjd

RFR: 8339704: Refactor StringConcatHelper simpleConcat

2024-09-08 Thread Shaojin Wen
The string concatenation of the java.base module is implemented using StringBuilder. By providing a series of concat methods in StringConcatHelper, it is used in the java.lang package to replace string concatenation. These concat methods can also be exposed through JLA for use by other packages,