Re: RFR: 8336274: MutableBigInteger.leftShift(int) optimization [v3]

2024-08-31 Thread fabioromano1
> This implementation of MutableBigInteger.leftShift(int) optimizes the current > version, avoiding unnecessary copy of the MutableBigInteger's value content > and performing the primitive shifting only in the original portion of the > value array rather than in the value yet extended with trail

Re: RFR: 8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc) [v2]

2024-08-31 Thread Chen Liang
On Sat, 31 Aug 2024 10:16:57 GMT, ExE Boss wrote: >> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line >> 679: >> >>> 677: getEventConfiguration(blockCodeBuilder); >>> 678: // stack: [EW] [EW] [EC] >>> 679: blockCodeBuilder.loadConstant(eventTypeI

Re: RFR: 8338768: Introduce runtime lookup to check for static builds [v2]

2024-08-31 Thread David Holmes
On Fri, 30 Aug 2024 10:51:30 GMT, Magnus Ihse Bursie wrote: >> I understand the cost overhead experienced by any individual Java run may be >> lost in the noise, but it still impacts every single Java run just to save >> some time/resources for the handful of builders of statically linked VMs.

Re: RFR: 8304846: Provide a shared utility to dump generated classes defined via Lookup API [v8]

2024-08-31 Thread ExE Boss
On Mon, 3 Apr 2023 22:32:44 GMT, Mandy Chung wrote: >> This implements a shared utility to dump generated classes defined as >> normal/hidden classes via `Lookup` API. This replaces the implementation >> in `LambdaMetaFactory` and method handle implementation that dumps the >> hidden class b

Re: RFR: 8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc) [v2]

2024-08-31 Thread ExE Boss
On Sat, 31 Aug 2024 09:42:41 GMT, Erik Gahlin wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Move bipush and sipush fix from Opcode cleanup to this patch > > src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumen

Re: RFR: 8339214: Remove misleading CodeBuilder.loadConstant(Opcode, ConstantDesc) [v2]

2024-08-31 Thread Erik Gahlin
On Thu, 29 Aug 2024 21:46:52 GMT, Chen Liang wrote: >> `CodeBuilder::loadConstant(Opcode, ConstantDesc)` is error-prone and >> confusing. Users should almost always use `loadConstant(ConstantDesc)` for >> optimized instructions, or use specific factories `iconst_0` etc. or >> `bipush` with arg

Re: RFR: 8337279: Optimize format instant [v7]

2024-08-31 Thread Stephen Colebourne
On Tue, 27 Aug 2024 23:49:50 GMT, Shaojin Wen wrote: >> By removing the redundant code logic in >> DateTimeFormatterBuilder$InstantPrinterParser#formatTo, the codeSize can be >> reduced and the performance can be improved. > > Shaojin Wen has updated the pull request with a new target base due