AW: RFR: 8338930: StringConcatFactory static string concatenation strategy

2024-08-24 Thread Markus Karg
Could it be the case that you posted twice the exact same performance numbers? I do not see any actual difference in your numbers. -Markus -Ursprüngliche Nachricht- Von: core-libs-dev [mailto:core-libs-dev-r...@openjdk.org] Im Auftrag von Shaojin Wen Gesendet: Sonntag, 25. August 2024 0

Re: RFR: 8338930: StringConcatFactory static string concatenation strategy

2024-08-24 Thread ExE Boss
On Thu, 22 Aug 2024 11:50:02 GMT, Shaojin Wen wrote: > This is a follow-up to PR #20273, which improves performance when the number > of parameters exceeds 20. > > When the number of parameters is large, the possibility of reuse will be > lower, so we can use the static concat method and write

Re: RFR: 8338930: StringConcatFactory static string concatenation strategy

2024-08-24 Thread Shaojin Wen
On Thu, 22 Aug 2024 11:50:02 GMT, Shaojin Wen wrote: > This is a follow-up to PR #20273, which improves performance when the number > of parameters exceeds 20. > > When the number of parameters is large, the possibility of reuse will be > lower, so we can use the static concat method and write

RFR: 8338930: StringConcatFactory static string concatenation strategy

2024-08-24 Thread Shaojin Wen
This is a follow-up to PR #20273, which improves performance when the number of parameters exceeds 20. When the number of parameters is large, the possibility of reuse will be lower, so we can use the static concat method and write the length and coder directly into the bytecode to solve the pe

Re: RFR: 8338906: Avoid passing EnumDescs and extra classes to type switch methods that don't use them [v2]

2024-08-24 Thread Chen Liang
On Sat, 24 Aug 2024 21:16:34 GMT, Claes Redestad wrote: >> This PR refactors SwitchBootstraps so that extra EnumDescs and classes are >> only passed into bootstraps when needed. Benchmarking shows that in many >> cases these are not needed, and avoiding passing them (via binding in the >> list

Re: RFR: 8338906: Avoid passing EnumDescs and extra classes to type switch methods that don't use them [v2]

2024-08-24 Thread Claes Redestad
> This PR refactors SwitchBootstraps so that extra EnumDescs and classes are > only passed into bootstraps when needed. Benchmarking shows that in many > cases these are not needed, and avoiding passing them (via binding in the > lists via `MethodHandle::insertArguments`) avoids some auxiliary M

Re: RFR: 8336843: Deprecate java.util.zip.ZipError for removal

2024-08-24 Thread Chen Liang
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote: > Please review this PR which suggests to deprecate the unused class > `java.util.zip.ZipError` for removal. > > The class has been unsed by OpenJDK since the ZIP API was rewritten from > native to Java in JDK 9. > > I opted to not expl

Re: RFR: 8336843: Deprecate java.util.zip.ZipError for removal

2024-08-24 Thread Lance Andersen
On Sat, 24 Aug 2024 10:16:55 GMT, Eirik Bjørsnøs wrote: >> On a corpus search, found >> org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/AddJarFileToIndex.java >> references ZipError (16 usages) >> >> sbt/internal/inc/zip/ZipCentralDir.java referenced ZipError(was based

Re: RFR: 8336843: Deprecate java.util.zip.ZipError for removal

2024-08-24 Thread Chen Liang
On Sat, 24 Aug 2024 10:16:55 GMT, Eirik Bjørsnøs wrote: >> On a corpus search, found >> org.eclipse.jdt.core/search/org/eclipse/jdt/internal/core/search/indexing/AddJarFileToIndex.java >> references ZipError (16 usages) >> >> sbt/internal/inc/zip/ZipCentralDir.java referenced ZipError(was based

Re: RFR: 8336843: Deprecate java.util.zip.ZipError for removal

2024-08-24 Thread Chen Liang
On Tue, 20 Aug 2024 10:24:25 GMT, Eirik Bjørsnøs wrote: > Please review this PR which suggests to deprecate the unused class > `java.util.zip.ZipError` for removal. > > The class has been unsed by OpenJDK since the ZIP API was rewritten from > native to Java in JDK 9. > > I opted to not expl

Re: RFR: 8334714: Class-File API leaves preview [v2]

2024-08-24 Thread Chen Liang
On Sat, 24 Aug 2024 05:03:33 GMT, xxDark wrote: > If Hotspot now parses these files incorrectly, it might be worth to just > throw `UnsupportedClassVersionError` for oak class files? This would be an important decision; I would wait till Monday when more engineers are back to discuss about the

RFR: 8338931: ZipEntry.flags could be made internal to ZipOutputStream

2024-08-24 Thread Eirik Bjørsnøs
Please review this refactoring PR which moves the `ZipEntry.flags` field to `ZipOutputStream.XEntry`. Moving this field will save four bytes from the `ZipEntry` object size and also saves an unneccessary read in `ZipFile.getZipEntry`. Testing: This PR is a refactoring of existing code and does

Re: RFR: 8338906: Avoid passing EnumDescs and extra classes to type switch methods that don't use them

2024-08-24 Thread ExE Boss
On Fri, 23 Aug 2024 12:34:17 GMT, Claes Redestad wrote: > This PR refactors SwitchBootstraps so that extra EnumDescs and classes are > only passed into bootstraps when needed. Benchmarking shows that in many > cases these are not needed, and avoiding passing them (via binding in the > lists vi

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace [v2]

2024-08-24 Thread Thomas Stuefe
On Fri, 23 Aug 2024 20:46:39 GMT, Coleen Phillimore wrote: >> This change stores InstanceKlass for interface and abstract classes in the >> non-class metaspace, since class metaspace will have limits on number of >> classes that can be represented when Lilliput changes go in. Classes that >>

Re: RFR: 8338526: Don't store abstract and interface Klasses in class metaspace

2024-08-24 Thread Thomas Stuefe
On Fri, 23 Aug 2024 19:26:46 GMT, Coleen Phillimore wrote: > Yes, is_in_klass_space was just to direct where to deallocate the metaspace > pointer. In your patch isn't the contains metaspace call still very slow? Or > I suppose for class space, it's not because it's a fixed space. But it's not

Re: RFR: 8336843: Deprecate java.util.zip.ZipError for removal

2024-08-24 Thread Eirik Bjørsnøs
On Fri, 23 Aug 2024 19:13:23 GMT, Lance Andersen wrote: > So would be good to also alert those projects if possible I guess the deprecation warning itself is the "official" channel for communicating this type of information. But I agree it doesn't hurt to alert at least some of the larger proj