Re: RFR: 8336856: Optimize String Concat [v39]

2024-08-08 Thread Shaojin Wen
On Thu, 8 Aug 2024 11:43:07 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision:

Re: RFR: 8333793: Improve BootstrapMethodInvoker for ConstantBootstraps and ProxyGenerator [v3]

2024-08-08 Thread Chen Liang
On Mon, 10 Jun 2024 10:09:38 GMT, Claes Redestad wrote: >> This PR refactors type matching in BootstrapMethodInvoker and adds a few >> types, seeking to improve bootstrap overheads of some ConstantBootstraps and >> in particular the ProxyGenerator condys generated for e.g. annotation >> proxie

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-08 Thread Jasmine Karthikeyan
On Thu, 8 Aug 2024 17:20:06 GMT, Jatin Bhateja wrote: >> Hi All, >> >> As per the discussion on panama-dev mailing list[1], patch adds the support >> following new vector operators. >> >> >> . SATURATING_UADD : Saturating unsigned addition. >> . SATURATING_ADD: Saturating sig

Re: RFR: 8336856: Optimize String Concat [v39]

2024-08-08 Thread Shaojin Wen
On Thu, 8 Aug 2024 11:43:07 GMT, Shaojin Wen wrote: >> This PR implements the same algorithm as the current generateMHInlineCopy >> based on bytecode to improve startup performance. > > Shaojin Wen has updated the pull request incrementally with one additional > commit since the last revision:

RFR: 8338017: Add AOT command-line flag aliases

2024-08-08 Thread Ioi Lam
This is the first PR for [JEP 483: Ahead-of-Time Class Loading & Linking](https://bugs.openjdk.org/browse/JDK-8315737). Add the following command-line options as specified in JEP 483: - `-XX:AOTMode=off/record/create/auto/on` - `-XX:AOTConfiguration=.aotconfig` - `-XX:AOTCache=.aot` These opti

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 16:48:24 GMT, Brian Burkhalter wrote: >> Possibly - if you made isIPv6Supported() in InetAddress.c return false, you >> might be able to see the issue in the same test that you observed failing >> without your change. >> >> InetAddress has a static block that will load the

Re: RFR: 8338021: Support saturating vector operators in VectorAPI [v2]

2024-08-08 Thread Jatin Bhateja
> Hi All, > > As per the discussion on panama-dev mailing list[1], patch adds the support > following new vector operators. > > > . SATURATING_UADD : Saturating unsigned addition. > . SATURATING_ADD: Saturating signed addition. > . SATURATING_USUB : Saturating unsigned

RFR: 8338023: Support two vector selectFrom API

2024-08-08 Thread Jatin Bhateja
Hi All, As per the discussion on panama-dev mailing list[1], patch adds the support for following new two vector permutation APIs. Declaration:- Vector.selectFrom(Vector v1, Vector v2) Semantics:- Using index values stored in the lanes of "this" vector, assemble the values stored in

RFR: 8338021: Support saturating vector operators in VectorAPI

2024-08-08 Thread Jatin Bhateja
Hi All, As per the discussion on panama-dev mailing list[1], patch adds the support following new vector operators. . SATURATING_UADD : Saturating unsigned addition. . SATURATING_ADD: Saturating signed addition. . SATURATING_USUB : Saturating unsigned subtraction.

Integrated: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Roger Riggs
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 16:39:33 GMT, Daniel Fuchs wrote: >> I'll have to investigate. > > Possibly - if you made isIPv6Supported() in InetAddress.c return false, you > might be able to see the issue in the same test that you observed failing > without your change. > > InetAddress has a static blo

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Daniel Fuchs
On Thu, 8 Aug 2024 16:21:30 GMT, Brian Burkhalter wrote: >> I don't know - you added that code to Inet6AddressImpl - so presumably a >> test was failing without that code? >> Which test was that? It wasn't obvious to me that adding code to load the >> "net" library would be required here. > > I

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Daniel Fuchs
On Thu, 8 Aug 2024 16:09:55 GMT, Brian Burkhalter wrote: >> It may be because we have no IPv4 only machine in the CI? It seems strange >> that IPv6 is treated differently than IPv4 in that respect. > > How would you suggest testing this? I don't know - you added that code to Inet6AddressImpl -

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 14:31:09 GMT, Brian Burkhalter wrote: >> And pthread? > > I will check. `pthread` is still needed: open/src/java.base/unix/native/libjava/nio/ch/NativeThread.c:83: error: undefined reference to 'pthread_kill' - PR Review Comment: https://git.openjdk.org/jdk/pul

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 16:18:28 GMT, Daniel Fuchs wrote: >> How would you suggest testing this? > > I don't know - you added that code to Inet6AddressImpl - so presumably a test > was failing without that code? > Which test was that? It wasn't obvious to me that adding code to load the > "net" libr

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 15:16:14 GMT, Daniel Fuchs wrote: >> I have not seen any failures in CI testing. Is there a specific test that >> would reveal whether this is a problem? > > It may be because we have no IPv4 only machine in the CI? It seems strange > that IPv6 is treated differently than IPv

Integrated: 8338015: Fix "Java Java" typo in package info file of java.lang.classfile

2024-08-08 Thread Joe Darcy
On Thu, 8 Aug 2024 02:04:17 GMT, Joe Darcy wrote: > Easy fix of an accidentally repeated "Java". This pull request has now been integrated. Changeset: 78773b17 Author:Joe Darcy URL: https://git.openjdk.org/jdk/commit/78773b1769922611318243b6680d59518ed4e015 Stats: 2 lines in 1 f

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Daniel Fuchs
On Thu, 8 Aug 2024 14:32:25 GMT, Brian Burkhalter wrote: >> src/java.base/share/classes/java/net/Inet6AddressImpl.java line 154: >> >>> 152: static { >>> 153: jdk.internal.loader.BootLoader.loadLibrary("net"); >>> 154: } >> >> I am curious about this change - wouldn't it be need

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 12:18:04 GMT, Magnus Ihse Bursie wrote: >> The Windows libs are also still required for `TransmitFile` and >> `WSAGetLastError`: >> >> - ```mswsock.lib: FileDispatcherImpl.obj : error LNK2019: unresolved >> external symbol TransmitFile``` >> - ```ws2_32.lib: FileDispatcherIm

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Brian Burkhalter
On Thu, 8 Aug 2024 09:11:31 GMT, Daniel Fuchs wrote: >> Brian Burkhalter has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional >> comm

Re: RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Roger Riggs
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Daniel Fuchs
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8328821: Map.of() derived view collection mutators should throw UnsupportedOperationException [v7]

2024-08-08 Thread Chen Liang
On Tue, 9 Jul 2024 23:17:47 GMT, Liam Miller-Cushon wrote: >> This change overrides mutator methods in the implementation returned by >> `Map.of().entrySet()` to throw `UnsupportedOperationException`. > > Liam Miller-Cushon has updated the pull request incrementally with one > additional commit

Withdrawn: 8326227: Rounding error that may distort computeNextGaussian results

2024-08-08 Thread duke
On Mon, 5 Feb 2024 04:25:16 GMT, Chris Hennick wrote: > This provides a slightly more accurate bounding limit for > `computeNextExponentialSoftCapped` when calling it from > `computeNextGaussian`. This could cause the `while > (computeNextExponentialSoftCapped(rng, limit) < limit)` check in >

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Magnus Ihse Bursie
On Wed, 7 Aug 2024 18:13:25 GMT, Brian Burkhalter wrote: >> `CoreServices` is still necessary ([Uniform Type >> Identifier](https://developer.apple.com/documentation/uniformtypeidentifiers)s). > > The Windows libs are also still required for `TransmitFile` and > `WSAGetLastError`: > > - ```msw

Re: RFR: 8336856: Optimize String Concat [v39]

2024-08-08 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: fix comments - Changes: - all: https://git

Re: RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Jaikiran Pai
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Aleksey Shipilev
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException

2024-08-08 Thread Aleksey Shipilev
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote: > The original test fails intermittently, the reproducer failed consistently. > With the fix, the failure was not observed in the test or reproducer. > > In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, > avoid removing

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v4]

2024-08-08 Thread Daniel Fuchs
On Wed, 7 Aug 2024 15:59:14 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request wit

Re: RFR: 8336856: Optimize String Concat [v38]

2024-08-08 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: fix comments - Changes: - all: https://git