On Wed, 7 Aug 2024 08:33:06 GMT, Doug Simon wrote:
> Problem list until [JDK-8336926](https://bugs.openjdk.org/browse/JDK-8336926)
> is fixed to reduce the noise in testing.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/20488
On Wed, 7 Aug 2024 08:33:06 GMT, Doug Simon wrote:
> Problem list until [JDK-8336926](https://bugs.openjdk.org/browse/JDK-8336926)
> is fixed to reduce the noise in testing.
Great, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/20488#issuecomment-2275017545
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Wed, 7 Aug 2024 08:33:06 GMT, Doug Simon wrote:
> Problem list until [JDK-8336926](https://bugs.openjdk.org/browse/JDK-8336926)
> is fixed to reduce the noise in testing.
Hello @dougxc, there's now a PR open to fix JDK-8336926
https://github.com/openjdk/jdk/pull/20499.
-
PR Co
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Wed, 7 Aug 2024 21:44:09 GMT, Chen Liang wrote:
>> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
>> equivalent to Stack's `peek()` method since both of them don't throw when a
>> collection is empty. This is not the case with the current `getFirst()`
>> method.
On Thu, 8 Aug 2024 02:04:17 GMT, Joe Darcy wrote:
> Easy fix of an accidentally repeated "Java".
Marked as reviewed by liach (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20505#pullrequestreview-2226743125
On Thu, 8 Aug 2024 02:04:17 GMT, Joe Darcy wrote:
> Easy fix of an accidentally repeated "Java".
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20505#pullrequestreview-2226737958
On Thu, 8 Aug 2024 02:04:17 GMT, Joe Darcy wrote:
> Easy fix of an accidentally repeated "Java".
LGTM
-
Marked as reviewed by jiefu (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20505#pullrequestreview-2226726552
Easy fix of an accidentally repeated "Java".
-
Commit messages:
- JDK-8338015: Fix "Java Java" typo in package info file of java.lang.classfile
Changes: https://git.openjdk.org/jdk/pull/20505/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20505&range=00
Issue: https://bu
On Fri, 24 May 2024 15:32:09 GMT, Liam Miller-Cushon wrote:
> This change fixes a bug preventing javac from emitting
> 'compiler.warn.sun.proprietary' diagnostics if `--system` is set to a
> non-default value. The diagnostics are currently emitted for values of
> `--release`, and for the defau
On Fri, 26 Jul 2024 21:06:31 GMT, Turkhan wrote:
> This PR fixes `java.util.Deque`'s specification to name `peekFirst()` as an
> equivalent to Stack's `peek()` method since both of them don't throw when a
> collection is empty. This is not the case with the current `getFirst()`
> method.
>
>
On Wed, 7 Aug 2024 19:26:59 GMT, Roger Riggs wrote:
> The original test fails intermittently, the reproducer failed consistently.
> With the fix, the failure was not observed in the test or reproducer.
>
> In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods,
> avoid removing
The original test fails intermittently, the reproducer failed consistently.
With the fix, the failure was not observed in the test or reproducer.
In jdk.internal.util.ReferencedKeyMap.entrySet() and toString() methods, avoid
removing stale references that would modify the keyset while it is being
On Wed, 7 Aug 2024 16:03:33 GMT, Brian Burkhalter wrote:
>> I will check. Thanks for noticing it.
>
> `CoreServices` is still necessary ([Uniform Type
> Identifier](https://developer.apple.com/documentation/uniformtypeidentifiers)s).
The Windows libs are also still required for `TransmitFile` a
On Fri, 26 Jul 2024 13:09:19 GMT, Andrey Turbanov wrote:
> There is implicit null check in line before.
>
> https://github.com/openjdk/jdk/blob/431d4f7e18369466eedd00926a5162a1461d0b25/src/java.base/share/classes/java/io/ObjectOutputStream.java#L1267-L1277
>
> 'cl' can't be null after that.
lg
On Wed, 7 Aug 2024 16:00:26 GMT, Brian Burkhalter wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>>
>>> 69: -framework Foundation \
>>> 70: -framework SystemConfiguration, \
>>> 71: LIBS_windows := advapi32.lib mswsock.lib ole32.lib shell32.lib
>>> version.l
On Wed, 7 Aug 2024 15:56:06 GMT, Magnus Ihse Bursie wrote:
>> Brian Burkhalter has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>
On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote:
> Fixing a regression caused by the removal of the legacy locale data. Legacy
> locale data happened to have resource bundle for "he" language (new ISO code)
> with the launguage name for "iw" (old ISO code). CLDR does not have it, thus
> the
On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote:
> Fixing a regression caused by the removal of the legacy locale data. Legacy
> locale data happened to have resource bundle for "he" language (new ISO code)
> with the launguage name for "iw" (old ISO code). CLDR does not have it, thus
> the
On Wed, 7 Aug 2024 15:56:06 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request wit
On Mon, 5 Aug 2024 15:37:46 GMT, Brian Burkhalter wrote:
>> make/modules/java.base/lib/CoreLibraries.gmk line 57:
>>
>>> 55: OPTIMIZATION := HIGH, \
>>> 56: EXTRA_HEADER_DIRS := \
>>> 57: libnio/ch, \
>>
>> This will introduce a source code dependency from libjava to libnio. It
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental
On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
> This implementation of MutableBigInteger.leftShift(int) optimizes the current
> version, avoiding unnecessary copy of the MutableBigInteger's value content
> and performing the primitive shifting only in the original portion of the
> value array rather than in the value yet extended with trail
On Fri, 19 Jul 2024 09:52:50 GMT, Andrey Turbanov wrote:
> A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could
> be removed:
> 1. plusWeeks(long)
> 2. minusYears(long)
> 3. minusMonths(long)
> 4. minusWeeks(long)
> 5. minusDays(long)
>
> Tested `test/jdk/java/time` on L
All input/feedback is welcome! 🙂
Cheers,
√
Viktor Klang
Software Architect, Java Platform Group
Oracle
From: David Alayachew
Sent: Tuesday, 6 August 2024 23:21
To: Viktor Klang
Cc: core-libs-dev ; Remi Forax
Subject: Re: [External] : Gatherers -- windowBy
Tha
On Fri, 19 Jul 2024 09:52:50 GMT, Andrey Turbanov wrote:
> A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could
> be removed:
> 1. plusWeeks(long)
> 2. minusYears(long)
> 3. minusMonths(long)
> 4. minusWeeks(long)
> 5. minusDays(long)
>
> Tested `test/jdk/java/time` on L
Problem list until [JDK-8336926](https://bugs.openjdk.org/browse/JDK-8336926)
is fixed to reduce the noise in testing.
-
Commit messages:
- Problem list jdk/internal/util/ReferencedKeyTest.java
Changes: https://git.openjdk.org/jdk/pull/20488/files
Webrev: https://webrevs.openjdk.
32 matches
Mail list logo
