On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote:
> Fixing a regression caused by the removal of the legacy locale data. Legacy
> locale data happened to have resource bundle for "he" language (new ISO code)
> with the launguage name for "iw" (old ISO code). CLDR does not have it, thus
> the
On Thu, 25 Jul 2024 08:59:17 GMT, Andrey Turbanov wrote:
> 3 fields in java.text.MergeCollation could be made 'static':
> 1. BITARRAYMASK
> 2. BYTEPOWER
> 3. BYTEMASK
Looks OK to me.
-
Marked as reviewed by jpai (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/20323#pullreq
On Fri, 26 Jul 2024 13:09:19 GMT, Andrey Turbanov wrote:
> There is implicit null check in line before.
>
> https://github.com/openjdk/jdk/blob/431d4f7e18369466eedd00926a5162a1461d0b25/src/java.base/share/classes/java/io/ObjectOutputStream.java#L1267-L1277
>
> 'cl' can't be null after that.
Th
On Fri, 2 Aug 2024 18:40:07 GMT, Naoto Sato wrote:
>> Fixing the Java launcher's command line argument parsing issue on Windows.
>> The Java launcher on Windows has been using `GetCommandLineA()` to obtain
>> arguments, which by default does "best-fit" mapping when the arguments are
>> convert
Fixing a regression caused by the removal of the legacy locale data. Legacy
locale data happened to have resource bundle for "he" language (new ISO code)
with the launguage name for "iw" (old ISO code). CLDR does not have it, thus
the name fell back to English.
-
Commit messages:
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
typo
-
Changes:
- all: https://git.openjdk
There is implicit null check in line before.
https://github.com/openjdk/jdk/blob/431d4f7e18369466eedd00926a5162a1461d0b25/src/java.base/share/classes/java/io/ObjectOutputStream.java#L1267-L1277
'cl' can't be null after that.
-
Commit messages:
- [PATCH] Remove redundant null check
3 fields in java.text.MergeCollation could be made 'static':
1. BITARRAYMASK
2. BYTEPOWER
3. BYTEMASK
-
Commit messages:
- [PATCH] Make a few fields in MergeCollation static
Changes: https://git.openjdk.org/jdk/pull/20323/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2032
A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could be
removed:
1. plusWeeks(long)
2. minusYears(long)
3. minusMonths(long)
4. minusWeeks(long)
5. minusDays(long)
Tested `test/jdk/java/time` on Linux x64 release
-
Commit messages:
- [PATCH] Remove unused me
Similar to PR #20321, this improves performance by providing a method that
passes in a StringBuilder to avoid unnecessary object allocation.
-
Commit messages:
- copyright
- use var
- Update src/java.base/share/classes/java/time/ZonedDateTime.java
- refactor datetime to string
C
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote:
> Similar to PR #20321, this improves performance by providing a method that
> passes in a StringBuilder to avoid unnecessary object allocation.
src/java.base/share/classes/java/time/ZonedDateTime.java line :
> 2220: if (offset !
On Mon, 5 Aug 2024 15:19:33 GMT, Magnus Ihse Bursie wrote:
> This will introduce a source code dependency from libjava to libnio. It might
> be the correct thing to do, but I just want to highlight this.
I'll look into improving it.
> make/modules/java.base/lib/CoreLibraries.gmk line 71:
>
>>
On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter wrote:
>> This proposed change would move the native objects required for NIO file
>> interaction from the libnio native library to the libjava native library on
>> Linux, macOS, and Windows.
>
> Brian Burkhalter has updated the pull request in
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote:
> This trivial PR proposes to add a missing parenthesis in
> `java.util.Date::toString`.
This pull request has now been integrated.
Changeset: 219e1eb1
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/219e1eb13a688532705
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote:
> This trivial PR proposes to add a missing parenthesis in
> `java.util.Date::toString`.
Marked as reviewed by rgiulietti (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/20439#pullrequestreview-2219235940
Hi David,
Thank you for the write-up—sharing your experience with us.
I'm happy you've had much success with `windowBy`, and we're going to have to
wait and see what other feedback on Gatherers and potential unmet needs in the
roster of baked-in Gatherers.
Gatherers is scheduled to have a seco
> This PR implements the same algorithm as the current generateMHInlineCopy
> based on bytecode to improve startup performance.
Shaojin Wen has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 93 commits:
- Merge remote-tracking branch '
On Tue, 30 Jul 2024 09:24:12 GMT, Viktor Klang wrote:
> Removes some of the old wording around the algorithmic complexity of
> ConcurrentSkipListSet::size() while still retaining the warning around the
> accuracy of the returned result.
This pull request has now been integrated.
Changeset: d3
On Mon, 5 Aug 2024 10:23:27 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java
>> line 192:
>>
>>> 190: * returns {@code Integer.MAX_VALUE}.
>>> 191: *
>>> 192: * It is possible for the size to change during execution of
>>> t
On Mon, 5 Aug 2024 09:52:54 GMT, Viktor Klang wrote:
>> Viktor Klang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Adding paragraph to ConcurrentSkipListSet::set
>
> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSe
On Mon, 5 Aug 2024 09:57:04 GMT, Viktor Klang wrote:
>> Removes some of the old wording around the algorithmic complexity of
>> ConcurrentSkipListSet::size() while still retaining the warning around the
>> accuracy of the returned result.
>
> Viktor Klang has updated the pull request incrementa
On Mon, 5 Aug 2024 09:53:48 GMT, Viktor Klang wrote:
>> Removes some of the old wording around the algorithmic complexity of
>> ConcurrentSkipListSet::size() while still retaining the warning around the
>> accuracy of the returned result.
>
> Viktor Klang has updated the pull request incrementa
> Removes some of the old wording around the algorithmic complexity of
> ConcurrentSkipListSet::size() while still retaining the warning around the
> accuracy of the returned result.
Viktor Klang has updated the pull request incrementally with one additional
commit since the last revision:
A
23 matches
Mail list logo