Re: RFR: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true

2024-08-05 Thread Iris Clark
On Tue, 6 Aug 2024 00:50:48 GMT, Naoto Sato wrote: > Fixing a regression caused by the removal of the legacy locale data. Legacy > locale data happened to have resource bundle for "he" language (new ISO code) > with the launguage name for "iw" (old ISO code). CLDR does not have it, thus > the

Re: RFR: 8337839: Make a few fields in MergeCollation static

2024-08-05 Thread Jaikiran Pai
On Thu, 25 Jul 2024 08:59:17 GMT, Andrey Turbanov wrote: > 3 fields in java.text.MergeCollation could be made 'static': > 1. BITARRAYMASK > 2. BYTEPOWER > 3. BYTEMASK Looks OK to me. - Marked as reviewed by jpai (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/20323#pullreq

Re: RFR: 8337840: Remove redundant null check in ObjectOutputStream.writeProxyDesc

2024-08-05 Thread Jaikiran Pai
On Fri, 26 Jul 2024 13:09:19 GMT, Andrey Turbanov wrote: > There is implicit null check in line before. > > https://github.com/openjdk/jdk/blob/431d4f7e18369466eedd00926a5162a1461d0b25/src/java.base/share/classes/java/io/ObjectOutputStream.java#L1267-L1277 > > 'cl' can't be null after that. Th

Re: RFR: 8337506: Disable "best-fit" mapping on Windows command line [v2]

2024-08-05 Thread Alan Bateman
On Fri, 2 Aug 2024 18:40:07 GMT, Naoto Sato wrote: >> Fixing the Java launcher's command line argument parsing issue on Windows. >> The Java launcher on Windows has been using `GetCommandLineA()` to obtain >> arguments, which by default does "best-fit" mapping when the arguments are >> convert

RFR: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true

2024-08-05 Thread Naoto Sato
Fixing a regression caused by the removal of the legacy locale data. Legacy locale data happened to have resource bundle for "he" language (new ISO code) with the launguage name for "iw" (old ISO code). CLDR does not have it, thus the name fell back to English. - Commit messages:

Re: RFR: 8336856: Optimize String Concat [v31]

2024-08-05 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision: typo - Changes: - all: https://git.openjdk

RFR: 8337840: Remove redundant null check in ObjectOutputStream.writeProxyDesc

2024-08-05 Thread Andrey Turbanov
There is implicit null check in line before. https://github.com/openjdk/jdk/blob/431d4f7e18369466eedd00926a5162a1461d0b25/src/java.base/share/classes/java/io/ObjectOutputStream.java#L1267-L1277 'cl' can't be null after that. - Commit messages: - [PATCH] Remove redundant null check

RFR: 8337839: Make a few fields in MergeCollation static

2024-08-05 Thread Andrey Turbanov
3 fields in java.text.MergeCollation could be made 'static': 1. BITARRAYMASK 2. BYTEPOWER 3. BYTEMASK - Commit messages: - [PATCH] Make a few fields in MergeCollation static Changes: https://git.openjdk.org/jdk/pull/20323/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=2032

RFR: 8337838: Remove unused methods from ChronoLocalDateImpl

2024-08-05 Thread Andrey Turbanov
A few methods in `java.time.chrono.ChronoLocalDateImpl` are unused and could be removed: 1. plusWeeks(long) 2. minusYears(long) 3. minusMonths(long) 4. minusWeeks(long) 5. minusDays(long) Tested `test/jdk/java/time` on Linux x64 release - Commit messages: - [PATCH] Remove unused me

RFR: 8337832: Optimize datetime toString

2024-08-05 Thread Shaojin Wen
Similar to PR #20321, this improves performance by providing a method that passes in a StringBuilder to avoid unnecessary object allocation. - Commit messages: - copyright - use var - Update src/java.base/share/classes/java/time/ZonedDateTime.java - refactor datetime to string C

Re: RFR: 8337832: Optimize datetime toString

2024-08-05 Thread Chen Liang
On Sat, 27 Jul 2024 13:45:11 GMT, Shaojin Wen wrote: > Similar to PR #20321, this improves performance by providing a method that > passes in a StringBuilder to avoid unnecessary object allocation. src/java.base/share/classes/java/time/ZonedDateTime.java line : > 2220: if (offset !

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-05 Thread Brian Burkhalter
On Mon, 5 Aug 2024 15:19:33 GMT, Magnus Ihse Bursie wrote: > This will introduce a source code dependency from libjava to libnio. It might > be the correct thing to do, but I just want to highlight this. I'll look into improving it. > make/modules/java.base/lib/CoreLibraries.gmk line 71: > >>

Re: RFR: 8337143: (fc, fs) Move filesystem-related native objects from libnio to libjava [v2]

2024-08-05 Thread Magnus Ihse Bursie
On Fri, 26 Jul 2024 19:40:24 GMT, Brian Burkhalter wrote: >> This proposed change would move the native objects required for NIO file >> interaction from the libnio native library to the libjava native library on >> Linux, macOS, and Windows. > > Brian Burkhalter has updated the pull request in

Integrated: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis

2024-08-05 Thread Per Minborg
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote: > This trivial PR proposes to add a missing parenthesis in > `java.util.Date::toString`. This pull request has now been integrated. Changeset: 219e1eb1 Author:Per Minborg URL: https://git.openjdk.org/jdk/commit/219e1eb13a688532705

Re: RFR: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis

2024-08-05 Thread Raffaello Giulietti
On Fri, 2 Aug 2024 07:20:39 GMT, Per Minborg wrote: > This trivial PR proposes to add a missing parenthesis in > `java.util.Date::toString`. Marked as reviewed by rgiulietti (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/20439#pullrequestreview-2219235940

Re: [External] : Gatherers -- windowBy

2024-08-05 Thread Viktor Klang
Hi David, Thank you for the write-up—sharing your experience with us. I'm happy you've had much success with `windowBy`, and we're going to have to wait and see what other feedback on Gatherers and potential unmet needs in the roster of baked-in Gatherers. Gatherers is scheduled to have a seco

Re: RFR: 8336856: Optimize String Concat [v30]

2024-08-05 Thread Shaojin Wen
> This PR implements the same algorithm as the current generateMHInlineCopy > based on bytecode to improve startup performance. Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 93 commits: - Merge remote-tracking branch '

Integrated: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity

2024-08-05 Thread Viktor Klang
On Tue, 30 Jul 2024 09:24:12 GMT, Viktor Klang wrote: > Removes some of the old wording around the algorithmic complexity of > ConcurrentSkipListSet::size() while still retaining the warning around the > accuracy of the returned result. This pull request has now been integrated. Changeset: d3

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

2024-08-05 Thread Viktor Klang
On Mon, 5 Aug 2024 10:23:27 GMT, Jaikiran Pai wrote: >> src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSet.java >> line 192: >> >>> 190: * returns {@code Integer.MAX_VALUE}. >>> 191: * >>> 192: * It is possible for the size to change during execution of >>> t

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

2024-08-05 Thread Jaikiran Pai
On Mon, 5 Aug 2024 09:52:54 GMT, Viktor Klang wrote: >> Viktor Klang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Adding paragraph to ConcurrentSkipListSet::set > > src/java.base/share/classes/java/util/concurrent/ConcurrentSkipListSe

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

2024-08-05 Thread Jaikiran Pai
On Mon, 5 Aug 2024 09:57:04 GMT, Viktor Klang wrote: >> Removes some of the old wording around the algorithmic complexity of >> ConcurrentSkipListSet::size() while still retaining the warning around the >> accuracy of the returned result. > > Viktor Klang has updated the pull request incrementa

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

2024-08-05 Thread Viktor Klang
On Mon, 5 Aug 2024 09:53:48 GMT, Viktor Klang wrote: >> Removes some of the old wording around the algorithmic complexity of >> ConcurrentSkipListSet::size() while still retaining the warning around the >> accuracy of the returned result. > > Viktor Klang has updated the pull request incrementa

Re: RFR: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity [v2]

2024-08-05 Thread Viktor Klang
> Removes some of the old wording around the algorithmic complexity of > ConcurrentSkipListSet::size() while still retaining the warning around the > accuracy of the returned result. Viktor Klang has updated the pull request incrementally with one additional commit since the last revision: A