On Fri, 2 Aug 2024 06:31:05 GMT, fabioromano1 wrote:
> Mmh, benchmarks show a slight slowdown with the iterative variant (except for
> the XS case). I tried several times, this one is the most favorable run:
>
> ```
> BenchmarkMode Cnt Score Error Units
> BigI
On Thu, 1 Aug 2024 21:38:47 GMT, Raffaello Giulietti
wrote:
> Mmh, benchmarks show a slight slowdown with the iterative variant (except for
> the XS case). I tried several times, this one is the most favorable run:
>
> ```
> BenchmarkMode Cnt Score Error Unit
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
On Fri, 2 Aug 2024 00:59:06 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the len
On Fri, 2 Aug 2024 01:04:08 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix performance regression caused by args.erase()
>
> I think erasing arguments is needed for correctness - are you sur
On Fri, 2 Aug 2024 00:59:06 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the len
On Fri, 2 Aug 2024 00:59:06 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the len
On Fri, 2 Aug 2024 00:59:06 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the len
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
1. Add notes and docs about the difference between resolved constants and
constant pool descriptors for annotation constants (e.g. `char` vs
`IntegerEntry`)
2. Improved value specification to specify their tags.
3. Improved value factories to return their specific types instead of
`OfConstant`
4
On Fri, 2 Aug 2024 00:21:28 GMT, Brian Burkhalter wrote:
> Add some verbiage indicating that an `IOException` will be thrown if a file
> with a name generated from the supplied prefix and suffix according to the
> described algorithm cannot be generated by the underlying system, whether
> that
Add some verbiage indicating that an `IOException` will be thrown if a file
with a name generated from the supplied prefix and suffix according to the
described algorithm cannot be generated by the underlying system, whether that
be due to the presence of one of more characters not supported by
On Thu, 1 Aug 2024 20:02:54 GMT, Chen Liang wrote:
>> `TypeAnnotation` is not an annotation, as it should not be used in places
>> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
>> annotation at a given location instead of to be an annotation.
>>
>> Depends on #20205.
>
> `TypeAnnotation` is not an annotation, as it should not be used in places
> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
> annotation at a given location instead of to be an annotation.
>
> Depends on #20205.
Chen Liang has updated the pull request with a new target
On Wed, 31 Jul 2024 22:27:53 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the le
On Sun, 14 Jul 2024 22:30:43 GMT, Chen Liang wrote:
> Remove `AnnotationConstantValueEntry` and `AnnotationValue.OfConstant`.
>
> This is a relic of the old model from
> https://github.com/openjdk/jdk-sandbox/commit/bb7e29474ecfcfbd1eb01d237593eb80d062944f.
> In addition, this is bug-prone: th
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Wed, 24 Jul 2024 13:00:47 GMT, Chen Liang wrote:
>> `TypeAnnotation` is not an annotation, as it should not be used in places
>> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
>> annotation at a given location instead of to be an annotation.
>>
>> Depends on #20205.
> `TypeAnnotation` is not an annotation, as it should not be used in places
> like `AnnotationValue.ofAnnotation`. Thus it's remodeled to contain an
> annotation at a given location instead of to be an annotation.
>
> Depends on #20205.
Chen Liang has updated the pull request with a new target
On Thu, 1 Aug 2024 19:10:51 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Last small changes
>
> I guess the overhead is negligible when compared to the arithmetic operation
> (shifts,
On Thu, 1 Aug 2024 04:11:24 GMT, Prasadrao Koppula wrote:
> Using SharedSecrets, I attempted to expose FileInputStream::path information.
> After implementing the fix, I validated the startup performance tests.
> Observed no consistent pattern of performance drops or gains, can disregard
> the
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
On Thu, 1 Aug 2024 10:22:10 GMT, Raffaello Giulietti
wrote:
>> fabioromano1 has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Last small changes
>
> I have no further comments, but I'll wait for a couple of days more before
> approving,
Fixing the Java launcher's command line argument parsing issue on Windows. The
Java launcher on Windows has been using `GetCommandLineA()` to obtain
arguments, which by default does "best-fit" mapping when the arguments are
converted to ANSI code page encoding. By disabling this "best-fit" mappi
Hi all,
This PR addresses [8337667](https://bugs.openjdk.org/browse/JDK-8337667) .
The `Compiler.perfmap` test case is failing on mac and windows as it is only
enabled in linux. I am removing this test case and noting that this use case is
already tested in
[test/hotspot/jtreg/serviceability
On Wed, 31 Jul 2024 21:54:15 GMT, fitzsim wrote:
>> 8334048: -Xbootclasspath can not read some ZIP64 zip files
>
> fitzsim has updated the pull request incrementally with one additional commit
> since the last revision:
>
> BootClassPathZipFileTest: Switch to createClassBytes, createZip stati
On Tue, 16 Jul 2024 08:59:20 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Sat, 13 Jul 2024 05:34:00 GMT, Julian Waters wrote:
>> snprintf has been available for all officially and unofficially supported
>> compilers for Windows, Visual Studio since version 2015 and gcc since, well,
>> forever. snprintf is conforming to C99 since the start when compiling using
>>
On Wed, 3 Jul 2024 19:43:05 GMT, Hannes Greule wrote:
> Similar to how `MethodHandle#invoke(Exact)` methods are already handled, this
> change adds special casing for `VarHandle.{access-mode}` methods.
>
> The exception message is less exact, but I think that's acceptable.
This pull request ha
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote:
>> Similar to how `MethodHandle#invoke(Exact)` methods are already handled,
>> this change adds special casing for `VarHandle.{access-mode}` methods.
>>
>> The exception message is less exact, but I think that's acceptable.
>
> Hannes Greule
On Wed, 31 Jul 2024 13:40:31 GMT, Jorn Vernee wrote:
> This test spawns 2 forked processes, which then try to trigger a code cache
> OOM in FFM hotspot code. Even without `-Xcomp`, the test is already pretty
> slow, which increases dramatically with `-Xcomp`, since startup Java code has
> to b
On Fri, 5 Jul 2024 14:23:50 GMT, Jorn Vernee wrote:
>> Hannes Greule has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address comments
>
> I think this needs a CSR, to document the change in behavior. (See e.g.
> https://bugs.openjdk.org
On Tue, 30 Jul 2024 09:24:12 GMT, Viktor Klang wrote:
> Removes some of the old wording around the algorithmic complexity of
> ConcurrentSkipListSet::size() while still retaining the warning around the
> accuracy of the returned result.
@AlanBateman Would you want to be Reviewer? :)
-
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote:
>> Similar to how `MethodHandle#invoke(Exact)` methods are already handled,
>> this change adds special casing for `VarHandle.{access-mode}` methods.
>>
>> The exception message is less exact, but I think that's acceptable.
>
> Hannes Greule
On Thu, 4 Jul 2024 06:22:31 GMT, Hannes Greule wrote:
>> Similar to how `MethodHandle#invoke(Exact)` methods are already handled,
>> this change adds special casing for `VarHandle.{access-mode}` methods.
>>
>> The exception message is less exact, but I think that's acceptable.
>
> Hannes Greule
On Thu, 1 Aug 2024 10:16:59 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
> I have implemented the Zimmermann's square root algorithm, available in works
> [here](https://inria.hal.science/inria-00072854/en/) and
> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>
> The algorithm is proved to be asymptotically faster than the New
On Wed, 31 Jul 2024 18:52:12 GMT, fabioromano1 wrote:
>> I have implemented the Zimmermann's square root algorithm, available in
>> works [here](https://inria.hal.science/inria-00072854/en/) and
>> [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root).
>>
>> The
40 matches
Mail list logo
