On Fri, 26 Jul 2024 06:29:05 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
On Fri, 26 Jul 2024 04:30:16 GMT, Jaikiran Pai wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 1. Just catch the IOException here when getting the FileStore and skip the
>> test instead of checking for specific excep
> Hi all,
> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails on
> rpm build mock environment. The `df -h` command return fail `df: cannot read
> table of mounted file systems: No such file or directory` on the rpm build
> mock environment also. I think it's a environmen
On Thu, 25 Jul 2024 13:56:34 GMT, Andrew Haley wrote:
>> Thanks, now I see that `Class::isInstance(Object)` is backed by
>> `Runtime1::is_instance_of()` which uses `oopDesc::is_a()` to do the job.
>>
>> If it turns out to be performance critical, the intrinsic implementation
>> should be rewri
On Thu, 25 Jul 2024 00:24:59 GMT, Brian Burkhalter wrote:
> Add some verbiage stating that two buffered readers or input streams should
> not be used to read from the same reader or input stream, respectively.
I went through the linked JBS issue to understand why we are adding this. The
use ca
On Thu, 25 Jul 2024 00:24:59 GMT, Brian Burkhalter wrote:
> Add some verbiage stating that two buffered readers or input streams should
> not be used to read from the same reader or input stream, respectively.
src/java.base/share/classes/java/io/BufferedInputStream.java line 56:
> 54: * to re
On Thu, 25 Jul 2024 09:50:10 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
On Thu, 25 Jul 2024 09:50:10 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
8337245: Fix wrong comment of StringConcatHelper
-
Commit messages:
- fix typo
Changes: https://git.openjdk.org/jdk/pull/20344/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=20344&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8337245
Stats: 3 lines in 1 file chan
On Thu, 25 Jul 2024 16:05:49 GMT, Andrew Haley wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSpot
On Thu, 25 Jul 2024 23:28:44 GMT, Chen Liang wrote:
> You should add `@since` tags on all these new API additions.
Thanks for the reminder. Updated.
-
PR Comment: https://git.openjdk.org/jdk/pull/20337#issuecomment-2251577718
> Please review this PR which adds public StringBuilder overloads to the
> formatting methods of java.text.Format and implementing subclasses.
>
> While Format, NumberFormat, and DateFormat are abstract, these new methods
> are not added as abstract to prevent compatibility concerns. Instead the
On Thu, 25 Jul 2024 10:15:20 GMT, Claes Redestad wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add benchmark
>
> test/micro/org/openjdk/bench/java/lang/StringConcatGenerate.java line 47:
>
>> 45: @Measurement(ite
On Thu, 25 Jul 2024 16:05:49 GMT, Andrew Haley wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSpot
On Thu, 25 Jul 2024 22:18:03 GMT, Justin Lu wrote:
> Please review this PR which adds public StringBuilder overloads to the
> formatting methods of java.text.Format and implementing subclasses.
>
> While Format, NumberFormat, and DateFormat are abstract, these new methods
> are not added as ab
Removes 6 `AccessFlags` factories that do not take class-file versions as its
arguments.
`AccessFlags` is a wrapper around a bit mask to support modifier streaming in
ClassFile API. It additionally supports advanced validation based on location.
However, as class file versions evolve, we may al
On Thu, 25 Jul 2024 23:05:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit sinc
On Thu, 25 Jul 2024 22:51:09 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with one additional
commit sinc
As discussed in offline meeting, the max stack and locals information are part
of the code attribute and not meaningful for buffered code elements.
Computation would be costly and these see no real usage during transformations.
Thus, the proposed solution is to move these APIs to be CodeAttribut
On Thu, 25 Jul 2024 21:45:21 GMT, Roger Riggs wrote:
>> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
>> against using `SharedSecrets`.
>>
>> The cleanup in `JavaLangReflectAccess` is:
>> - Converted `newConstructor` taking parameters to taking another constructor
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
> against using `SharedSecrets`.
>
> The cleanup in `JavaLangReflectAccess` is:
> - Converted `newConstructor` taking parameters to taking another constructor
> and a new accessor. The old existing API essentially does
Please review this PR which adds public StringBuilder overloads to the
formatting methods of java.text.Format and implementing subclasses.
While Format, NumberFormat, and DateFormat are abstract, these new methods are
not added as abstract to prevent compatibility concerns. Instead they are adde
On Thu, 25 Jul 2024 21:52:03 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Shaojin Wen has updated th
On Thu, 25 Jul 2024 21:38:04 GMT, Roger Riggs wrote:
>> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
>> against using `SharedSecrets`.
>
> src/java.base/share/classes/jdk/internal/access/JavaLangReflectAccess.java
> line 53:
>
>> 51: //
>> 52:
>> 53: //
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote:
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
> against using `SharedSecrets`.
src/java.base/share/classes/java/lang/reflect/Constructor.java line 168:
> 166: }
> 167:
> 168: /** Creates a new root con
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Shaojin Wen has updated the pull request incrementally with two additional
commits sin
On Tue, 23 Jul 2024 04:10:38 GMT, Chen Liang wrote:
> Removed redundant APIs in `JavaLangReflectAccess` and added general warning
> against using `SharedSecrets`.
The description should include a summary of the changes and the rationale.
The Jira description is a bit better and could also be mo
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote:
>> Integer.stringSize and Long.stringSize are used not only in java.lang, but
>> also in other places. We put stringSize in DecimalDigits to reduce duplicate
>> code and the use of JLA.
>
> Shaojin Wen has updated the pull request incremental
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
src/java.base/share/classes/java
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
LGTM
src/java.base/share/classe
On Thu, 25 Jul 2024 08:40:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Thu, 25 Jul 2024 10:58:42 GMT, Jorn Vernee wrote:
> We are seeing some failures of this test in our CI, particularly on Windows
> machines, which are known to starve out certain threads.
>
> To make sure the compiler threads get a chance to work, I've added `-Xbatch`
> to the flags with whi
On Thu, 25 Jul 2024 10:58:42 GMT, Jorn Vernee wrote:
> We are seeing some failures of this test in our CI, particularly on Windows
> machines, which are known to starve out certain threads.
>
> To make sure the compiler threads get a chance to work, I've added `-Xbatch`
> to the flags with whi
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote:
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Perhaps `/native/libjava/nio/ch` and
`/native/libjava
On Thu, 25 Jul 2024 16:05:49 GMT, Andrew Haley wrote:
>> This patch expands the use of a hash table for secondary superclasses
>> to the interpreter, C1, and runtime. It also adds a C2 implementation
>> of hashed lookup in cases where the superclass isn't known at compile
>> time.
>>
>> HotSpot
> This patch expands the use of a hash table for secondary superclasses
> to the interpreter, C1, and runtime. It also adds a C2 implementation
> of hashed lookup in cases where the superclass isn't known at compile
> time.
>
> HotSpot shared runtime
> --
>
> Building hashed s
On Thu, 25 Jul 2024 14:52:11 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the le
On Thu, 25 Jul 2024 08:40:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
> This patch expands the use of a hash table for secondary superclasses
> to the interpreter, C1, and runtime. It also adds a C2 implementation
> of hashed lookup in cases where the superclass isn't known at compile
> time.
>
> HotSpot shared runtime
> --
>
> Building hashed s
On Thu, 25 Jul 2024 06:19:46 GMT, Shaojin Wen wrote:
>> The current LocalDateTime.toString implementation concatenates the toString
>> results of date and time, which can be passed to StringBuilder to reduce
>> additional object allocation and improve performance.
>
> Below are the performance
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote:
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
Yes, I was wondering about changing the organization o
Can I please get a review of this test-only backport of the fix that we did in
master branch a few weeks back?
This isn't a clean backport, there were trivial merge issues in the
`NativeMethodPrefixApp` test class, which I have resolved manually. The merged
content matches with what we have in
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
@wenshao
Your change (at versio
On Thu, 25 Jul 2024 14:48:29 GMT, Roger Riggs wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused Integer.stringSize & Long.stringSize
>
> What is the performance difference between the long and int versio
On Thu, 25 Jul 2024 14:48:29 GMT, Roger Riggs wrote:
>> Shaojin Wen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> remove unused Integer.stringSize & Long.stringSize
>
> What is the performance difference between the long and int versio
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote:
>> Integer.stringSize and Long.stringSize are used not only in java.lang, but
>> also in other places. We put stringSize in DecimalDigits to reduce duplicate
>> code and the use of JLA.
>
> Shaojin Wen has updated the pull request incremental
On Thu, 25 Jul 2024 14:29:05 GMT, Shaojin Wen wrote:
>> Integer.stringSize and Long.stringSize are used not only in java.lang, but
>> also in other places. We put stringSize in DecimalDigits to reduce duplicate
>> code and the use of JLA.
>
> Shaojin Wen has updated the pull request incremental
> Integer.stringSize and Long.stringSize are used not only in java.lang, but
> also in other places. We put stringSize in DecimalDigits to reduce duplicate
> code and the use of JLA.
Shaojin Wen has updated the pull request incrementally with one additional
commit since the last revision:
re
On Wed, 24 Jul 2024 19:09:06 GMT, Vladimir Ivanov wrote:
>>> > Also also, Klass::is_subtype_of() is used for C1 runtime.
>>>
>>> Can you elaborate, please?
>>
>> Sorry, that was rather vague. In C1-compiled code, the Java method
>> `Class::isInstance(Object)`calls `Klass::is_subtype_of()`.
>>
On Thu, 25 Jul 2024 13:23:37 GMT, Alan Bateman wrote:
> Is this because you only run tier1 or do you mean this is the only test that
> fails?
We only run tier1 on rpmbuild mock enviroment.
-
PR Comment: https://git.openjdk.org/jdk/pull/19905#issuecomment-2250369276
On Thu, 25 Jul 2024 12:54:16 GMT, SendaoYan wrote:
> > Okay, but doesn't mean that lots of other tests will fail too, esp. tests
> > in jdk_nio test group.
>
> Currently we observer only this test fails of tier1.
Is this because you only run tier1 or do you mean this is the only test that
fai
On Thu, 25 Jul 2024 12:48:20 GMT, Alan Bateman wrote:
> Okay, but doesn't mean that lots of other tests will fail too, esp. tests in
> jdk_nio test group.
Currently we observer only this test fails of tier1.
-
PR Comment: https://git.openjdk.org/jdk/pull/19905#issuecomment-2250252
On Thu, 25 Jul 2024 10:58:42 GMT, Jorn Vernee wrote:
> We are seeing some failures of this test in our CI, particularly on Windows
> machines, which are known to starve out certain threads.
>
> To make sure the compiler threads get a chance to work, I've added `-Xbatch`
> to the flags with whi
On Thu, 25 Jul 2024 12:39:35 GMT, SendaoYan wrote:
> The rpmbuild mock enviroment is like a sandbox, which created by `chroot`
> shell command, in the rpmbuild mock enviroment, `df -h` report `cannot read
> table of mounted file systems`, and java Files.getFileStore also throw
> `IOException`.
On Thu, 25 Jul 2024 09:50:10 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
On Thu, 25 Jul 2024 10:23:29 GMT, Alan Bateman wrote:
> Would it possible to provide a summary on how Mock works and how we end up
> with the current directory in a location that doesn't have a mount point?
The rpmbuild mock enviroment is like a sandbox, which created by `chroot` shell
command
On Thu, 25 Jul 2024 05:30:34 GMT, Shaojin Wen wrote:
> Integer.stringSize and Long.stringSize are used not only in java.lang, but
> also in other places. We put stringSize in DecimalDigits to reduce duplicate
> code and the use of JLA.
src/java.base/share/classes/jdk/internal/access/JavaLangAc
Hi Turkhan, this mail belongs to core-libs-dev list. I have forwarded your mail
to the right list.
Indeed, we should claim that peek() is equivalent to peekFirst(); the
information in stack section should be a typo, as peek() being the same as
peekFirst() is claimed by the deque section and the
On Thu, 25 Jul 2024 10:58:42 GMT, Jorn Vernee wrote:
> We are seeing some failures of this test in our CI, particularly on Windows
> machines, which are known to starve out certain threads.
>
> To make sure the compiler threads get a chance to work, I've added `-Xbatch`
> to the flags with whi
We are seeing some failures of this test in our CI, particularly on Windows
machines, which are known to starve out certain threads.
To make sure the compiler threads get a chance to work, I've added `-Xbatch` to
the flags with which the test runs (this was missed in the original PR). I've
also
On Thu, 25 Jul 2024 05:30:34 GMT, Shaojin Wen wrote:
> Integer.stringSize and Long.stringSize are used not only in java.lang, but
> also in other places. We put stringSize in DecimalDigits to reduce duplicate
> code and the use of JLA.
src/java.base/share/classes/java/lang/Integer.java line 47
On Thu, 25 Jul 2024 09:50:10 GMT, SendaoYan wrote:
>> Hi all,
>> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails
>> on rpm build mock environment. The `df -h` command return fail `df: cannot
>> read table of mounted file systems: No such file or directory` on the rpm
On Thu, 25 Jul 2024 08:58:14 GMT, Shaojin Wen wrote:
>> The current implementation of StringConcat is to mix the coder and length
>> into a long. This operation will have some overhead for int/long/boolean
>> types. We can separate the calculation of the coder from the calculation of
>> the le
On Wed, 24 Jul 2024 19:11:42 GMT, Brian Burkhalter wrote:
> This proposed change would move the native objects required for NIO file
> interaction from the libnio native library to the libjava native library on
> Linux, macOS, and Windows.
I think this will require thinking about how to organi
On Thu, 25 Jul 2024 04:53:33 GMT, Jaikiran Pai wrote:
>> SendaoYan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add a word throw
>
> test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java line 216:
>
>> 214: } catch (I
On Thu, 25 Jul 2024 05:06:17 GMT, Shaojin Wen wrote:
> The current LocalDateTime.toString implementation concatenates the toString
> results of date and time, which can be passed to StringBuilder to reduce
> additional object allocation and improve performance.
Simple and straightforward impro
> Hi all,
> Test `test/jdk/java/lang/invoke/lambda/LogGeneratedClassesTest.java` fails on
> rpm build mock environment. The `df -h` command return fail `df: cannot read
> table of mounted file systems: No such file or directory` on the rpm build
> mock environment also. I think it's a environmen
On Wed, 24 Jul 2024 16:00:10 GMT, Shaojin Wen wrote:
>> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We
>> need a JMH Benchmark to evaluate the performance of various batch operations
>> and the effect of MergeStore.
>
> Shaojin Wen has updated the pull request with
On Sun, 16 Jun 2024 07:17:16 GMT, Shaojin Wen wrote:
> [8318446](https://github.com/openjdk/jdk/pull/16245) brings MergeStore. We
> need a JMH Benchmark to evaluate the performance of various batch operations
> and the effect of MergeStore.
This pull request has now been integrated.
Changese
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
On Wed, 24 Jul 2024 21:59:52 GMT, Shaojin Wen wrote:
>> Shaojin Wen has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 16 additional
>> commits sin
> The current implementation of StringConcat is to mix the coder and length
> into a long. This operation will have some overhead for int/long/boolean
> types. We can separate the calculation of the coder from the calculation of
> the length, which can improve the performance in the scenario of
> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
> fixed the issue and changes are tested.
Vanitha B P has updated the pull request incrementally with one additional
commit since the last revision:
Addressed the review comments
-
Changes:
- all: ht
76 matches
Mail list logo
