RFR: 8336860: x86: Change integer src operand for CMoveL of 0 and 1 to long

2024-07-21 Thread Jasmine Karthikeyan
Hi all, This patch fixes `cmovL_imm_01*` instructions matching against an integer immediate 1 instead of a long immediate 1. I noticed while looking at the backend implementation of CMove that the rules specify `immI_1` instead of `immL1`, which means that the instructions can't be matched and i

Re: want to try out small idea; where is the implementing class for Stream interface?

2024-07-21 Thread Bernd Eckenfels
I think StreamSupport has most of the glue code used by the collections, and ReferencePipeline must of the stream implementations, for example the reduce here makes use of the ReduceOps operation class! https://github.com/openjdk/jdk/blob/4da99158754c25c5d0650f2d042aad3e94a9b0c5/src/java.base/sh

Integrated: 8333396: Use StringBuilder internally for java.text.Format.* formatting

2024-07-21 Thread lingjun-cg
On Mon, 3 Jun 2024 04:18:20 GMT, lingjun-cg wrote: > ### Performance regression of DecimalFormat.format > From the output of perf, we can see the hottest regions contain atomic > instructions. But when run with JDK 11, there is no such problem. The reason > is the removed biased locking. > T

Re: RFR: 8333396: Use StringBuilder internally for java.text.Format.* formatting [v21]

2024-07-21 Thread duke
On Mon, 15 Jul 2024 02:30:54 GMT, lingjun-cg wrote: >> ### Performance regression of DecimalFormat.format >> From the output of perf, we can see the hottest regions contain atomic >> instructions. But when run with JDK 11, there is no such problem. The >> reason is the removed biased locking.

Re: want to try out small idea; where is the implementing class for Stream interface?

2024-07-21 Thread Chen Liang
Please refer to the "Intellij Idea" section on the ide doc: https://github.com/openjdk/jdk/blob/master/doc/ide.md#intellij-idea In short, in `jdk`, you need to run the `bin/idea.sh` with cygwin after you've done `make images` once. Then the root `jdk` directory will be recognized by idea as an idea

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-21 Thread Chen Liang
On Sun, 21 Jul 2024 21:15:03 GMT, Nizar Benalla wrote: >> Can I get a review for this change that fixes some broken links in javadoc >> comments? The new docs are hosted >> [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). >> >> It's mostly fixing some relative li

Re: [jdk23] RFR: 8325280: Update troff manpages in JDK 23 before RC

2024-07-21 Thread David Holmes
On Fri, 19 Jul 2024 08:26:51 GMT, Alan Bateman wrote: >> Before RC we need to update the man pages in the repo from their Markdown >> sources. All pages at a minimum have 23-ea replaced with 23, and publication >> year set to 2024 if needed. >> >> This also picks up the unpublished changes to

[jdk23] Integrated: 8325280: Update troff manpages in JDK 23 before RC

2024-07-21 Thread David Holmes
On Fri, 19 Jul 2024 05:47:15 GMT, David Holmes wrote: > Before RC we need to update the man pages in the repo from their Markdown > sources. All pages at a minimum have 23-ea replaced with 23, and publication > year set to 2024 if needed. > > This also picks up the unpublished changes to java.

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v4]

2024-07-21 Thread Nizar Benalla
On Sat, 20 Jul 2024 15:10:10 GMT, Alan Bateman wrote: >> Nizar Benalla has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Update src/java.base/share/classes/java/lang/foreign/MemorySegment.java >> >> forgot this one >> >> Co-autho

Re: RFR: 8336039: Doccheck: HTML warnings, broken links and missing files in java.base documentation [v5]

2024-07-21 Thread Nizar Benalla
> Can I get a review for this change that fixes some broken links in javadoc > comments? The new docs are hosted > [here](https://cr.openjdk.org/~nbenalla/GeneratedDocs/8336039-warnings-links/). > > It's mostly fixing some relative links. > If using `{@docroot}` isn't ideal I can change it. > >

Re: want to try out small idea; where is the implementing class for Stream interface?

2024-07-21 Thread Anil
Chen, Thanks for your reply. Yes, I am using IntelliJ Community Edition (on Windows 11, Cygwin64). I did not set up the project - I just opened the package in IJ C:\Users\Anil\OpenJDK\jdk\src\java.base\share\classes\java\util\stream Is there something different I should be doing? thanks, Anil On

Re: RFR: 8316882: Do not close ZipFileSystem on interrupt

2024-07-21 Thread Technici4n
On Sun, 21 Jul 2024 13:29:36 GMT, Technici4n wrote: > Hi, > > Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the > `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for > example. > > There has been some discussion on nio-dev about more broadl

Re: RFR: 8316882: Do not close ZipFileSystem on interrupt

2024-07-21 Thread Alan Bateman
On Sun, 21 Jul 2024 13:29:36 GMT, Technici4n wrote: > Hi, > > Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the > `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for > example. > > There has been some discussion on nio-dev about more broadl

RFR: 8316882: Do not close ZipFileSystem on interrupt

2024-07-21 Thread Technici4n
Hi, Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882, following the `FileChannelImpl#setUninterruptible` pattern used in `Files.readAllBytes` for example. There has been some discussion on nio-dev about more broadly rethinking the interrupt handling for `FileChannels`, for example

Re: RFR: 8336856: Optimize String Concat

2024-07-21 Thread Claes Redestad
On Sun, 21 Jul 2024 12:25:36 GMT, Shaojin Wen wrote: > The current implementation of StringConcat is to mix the coder and length > into a long. This operation will have some overhead for int/long/boolean > types. We can separate the calculation of the coder from the calculation of > the length

Re: RFR: 8336856: Optimize String Concat

2024-07-21 Thread Shaojin Wen
On Sun, 21 Jul 2024 12:25:36 GMT, Shaojin Wen wrote: > The current implementation of StringConcat is to mix the coder and length > into a long. This operation will have some overhead for int/long/boolean > types. We can separate the calculation of the coder from the calculation of > the length

RFR: 8336856: Optimize String Concat

2024-07-21 Thread Shaojin Wen
The current implementation of StringConcat is to mix the coder and length into a long. This operation will have some overhead for int/long/boolean types. We can separate the calculation of the coder from the calculation of the length, which can improve the performance in the scenario of concat i

Re: RFR: 8336844: ZipConstants64 defines duplicate constants EXTID_ZIP64 and ZIP64_EXTID [v2]

2024-07-21 Thread Lance Andersen
On Sat, 20 Jul 2024 02:18:11 GMT, Liam Miller-Cushon wrote: >> This change deduplicates constants in ZipConstants64 for the Zip64 Extended >> Information Extra Field Header ID (see APPNOTE.TXT 4.5.3). >> >> I think there are arguments for consolidating on either `EXTID_ZIP64` or >> `ZIP64_EXTI

Withdrawn: 8327858: Improve spliterator and forEach for single-element immutable collections

2024-07-21 Thread duke
On Wed, 20 Sep 2023 04:52:31 GMT, Chen Liang wrote: > Please review this patch that: > 1. Implemented `forEach` to optimize for 1 or 2 element collections. > 2. Implemented `spliterator` to optimize for a single element. > > The default implementations for multiple-element immutable collections