[jdk23] Integrated: 8334708: FFM: two javadoc problems

2024-06-23 Thread Hannes Greule
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: [jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-23 Thread Hannes Greule
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

RFR: 8334810: Redo: Un-ProblemList LocaleProvidersRun and CalendarDataRegression

2024-06-23 Thread Yude Lin
[JDK-8318107](https://bugs.openjdk.org/browse/JDK-8318107) Un-ProblemListed LocaleProvidersRun and CalendarDataRegression, and [JDK-8288899](https://bugs.openjdk.org/browse/JDK-8288899) added them back. I'm guessing it's a mistake in resolving merge conflict. - Commit messages: -

Re: RFR: 8334397: RISC-V: verify perf of ReverseBytesS/US

2024-06-23 Thread Fei Yang
On Fri, 21 Jun 2024 14:24:26 GMT, Hamlin Li wrote: > Hi, > Can you help to review this patch? > Thanks! > > This is similar with previous JDK-8334396. > Added some tests. > > ### Test > >   | Tests | Scores | Errors | Unit > -- | -- | -- | -- | -- > Intrinsic, +zbb, +rvv | Characters.reverseBy

Re: [jdk23] RFR: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-23 Thread SendaoYan
On Sat, 22 Jun 2024 08:07:54 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v9]

2024-06-23 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New

[jdk23] Integrated: 8334441: Mark tests in jdk_security_infra group as manual

2024-06-23 Thread SendaoYan
On Sat, 22 Jun 2024 08:07:54 GMT, SendaoYan wrote: > Hi all, > > This pull request contains a backport of commit > [8e1d2b09](https://github.com/openjdk/jdk/commit/8e1d2b091c9a311d98a0b886a803fb18d4405d8a) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit being

Re: RFR: 8334394: Race condition in Class::protectionDomain [v2]

2024-06-23 Thread Chen Liang
On Mon, 17 Jun 2024 15:24:27 GMT, Weijun Wang wrote: >> Make sure `pd` is always the same object when `getProtectionDomain0` is null. > > Weijun Wang has updated the pull request incrementally with one additional > commit since the last revision: > > explain why the test is related to the fix

[jdk23] RFR: 8333358: java/io/IO/IO.java test fails intermittently

2024-06-23 Thread SendaoYan
Hi all, This pull request contains a backport of commit [1b1dba80](https://github.com/openjdk/jdk/commit/1b1dba8082969244effa86ac03c6053b3b0ddc43) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. The commit being backported was authored by Pavel Rappo on 20 Jun 2024 and was revi

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 06:19:17 GMT, Daniel Jeliński wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused import > > Thanks for contributing to the OpenJDK! > What tests did you run for this change? How did

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v8]

2024-06-23 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v7]

2024-06-23 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New

Re: [jdk23] RFR: 8334708: FFM: two javadoc problems

2024-06-23 Thread Jaikiran Pai
On Sun, 23 Jun 2024 06:32:50 GMT, Hannes Greule wrote: > Hi all, > > This pull request contains a backport of commit > [72ca7baf](https://github.com/openjdk/jdk/commit/72ca7bafcd49a98c1fe09da72e4e47683f052e9d) > from the [openjdk/jdk](https://git.openjdk.org/jdk) repository. > > The commit be

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v6]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 10:52:13 GMT, Daniel Jeliński wrote: >> @djelinski I'm referring to the tests of square root for BigIntegers. > > ah, so before your changes, the arguments were always normalized, and now > they are not? @djelinski Now I found the issue and resolved it normalizing the Zimmer

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v6]

2024-06-23 Thread fabioromano1
> I have implemented the Zimmermann's square root algorithm, available in works > [here](https://inria.hal.science/inria-00072854/en/) and > [here](https://www.researchgate.net/publication/220532560_A_proof_of_GMP_square_root). > > The algorithm is proved to be asymptotically faster than the New

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread Daniel Jeliński
On Sun, 23 Jun 2024 10:33:08 GMT, fabioromano1 wrote: >> Which program are you referring to? >> >> It is the responsibility of the caller of `subtract` to ensure that the >> arguments are normalized. This may or may not require calling `normalize`, >> depending on whether the argument is norma

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 10:23:15 GMT, Daniel Jeliński wrote: >>> Most likely. If you check the code you'll notice that most methods that >>> change the `MutableBigInteger` value (like `subtract`) call `normalize` >>> after performing the operation, so the values should be normalized most of >>> th

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread Daniel Jeliński
On Sun, 23 Jun 2024 09:53:48 GMT, fabioromano1 wrote: >>> why the documentation does not specify that the method assumes the >>> arguments are normalized? >> >> Well, the best answer I can offer is "because no one documented it yet". >> `MutableBigInteger` is an internal class, so most people

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v12]

2024-06-23 Thread Shaojin Wen
On Thu, 20 Jun 2024 09:54:37 GMT, Claes Redestad wrote: >> Shaojin Wen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Utf16 case remove `append first utf16 char` > > src/java.base/share/classes/java/lang/StringLatin1.java line 832: > >

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 09:48:59 GMT, Daniel Jeliński wrote: > Most likely. If you check the code you'll notice that most methods that > change the `MutableBigInteger` value (like `subtract`) call `normalize` after > performing the operation, so the values should be normalized most of the time. @d

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread Daniel Jeliński
On Sun, 23 Jun 2024 08:55:17 GMT, fabioromano1 wrote: > why the documentation does not specify that the method assumes the arguments > are normalized? Well, the best answer I can offer is "because no one documented it yet". `MutableBigInteger` is an internal class, so most people never see its

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 06:19:17 GMT, Daniel Jeliński wrote: >> fabioromano1 has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused import > > Thanks for contributing to the OpenJDK! > What tests did you run for this change? How did

Re: RFR: 8334755: Asymptotically faster implementation of square root algorithm [v5]

2024-06-23 Thread fabioromano1
On Sun, 23 Jun 2024 05:57:56 GMT, Daniel Jeliński wrote: >> src/java.base/share/classes/java/math/MutableBigInteger.java line 293: >> >>> 291: */ >>> 292: private int compareShifted(MutableBigInteger b, int ints) { >>> 293: this.normalize(); >> >> See >> [JDK-8334483](http://b

Re: RFR: 8333893: Optimization for StringBuilder append boolean & null [v13]

2024-06-23 Thread Shaojin Wen
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into > primitive arrays by combining values ​​into larger stores. > > This PR rewrites the code of appendNull and append(boolean) methods so that > these two methods can be optimized by C2. Shaojin Wen has updated the pul