On Wed, 12 Jun 2024 16:54:54 GMT, Severin Gehwolf wrote:
> Could you please help review it? Thanks!
Yes, on my list.
-
PR Comment: https://git.openjdk.org/jdk/pull/14787#issuecomment-2167341692
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Tue, 11 Jun 2024 08:17:02 GMT, Albert Mingkun Yang wrote:
> Obsolete OldSize and related code. An internal variable `OldSize` is kept to
> capture the capacity of old-gen size.
Al seems reasonable.
Thanks.
src/hotspot/share/runtime/arguments.cpp line 543:
> 541: { "UseNeon",
On Thu, 13 Jun 2024 17:53:45 GMT, Justin Lu wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/CompactNumberFormat.java l
On Thu, 13 Jun 2024 19:40:49 GMT, Chen Liang wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/StringBuilderBufferProxy.
On Thu, 13 Jun 2024 19:40:48 GMT, Naoto Sato wrote:
> I second Justin's suggestion here. The change should benefit every
> implementation in the JDK, not only NumberFormat. Also, I might suggest
> renaming the new class, as it is kind of long/redundant. How about using
> something as simple as
> ### Performance regression of DecimalFormat.format
> From the output of perf, we can see the hottest regions contain atomic
> instructions. But when run with JDK 11, there is no such problem. The reason
> is the removed biased locking.
> The DecimalFormat uses StringBuffer everywhere, and St
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to remove the
>> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
>> JBS issue, in
> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
> primitive arrays by combining values into larger stores.
>
> This PR rewrites the code of appendNull and append(boolean) methods so that
> these two methods can be optimized by C2.
Shaojin Wen has updated the pul
On Thu, 30 May 2024 02:28:56 GMT, Leonid Mesnik wrote:
> The message is generated if cores (or any other tools) section doesn't exist
> or is empty. However, there is no any tool for cores processing now defined.
> So ERROR message is generating, confusing users.
> The fix is to don't print err
Currently, javap crashes for class files that have set non-zero values for
undefined access flag bits, as `java.lang.reflect.AccessFlag.maskToAccessFlag`
and `java.lang.classfile.AccessFlags.flags` fail. In contrast, the JVMS, though
asking for these bits to be set to 0, requires VM to proceed a
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
On Thu, 13 Jun 2024 21:38:48 GMT, Damon Nguyen wrote:
> Hi all,
>
> This pull request contains a backport of commit
> [c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a)
> from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
>
> The commit bei
Hi all,
This pull request contains a backport of commit
[c4702ca8](https://github.com/openjdk/jdk/commit/c4702ca8c026e2d265aca0126fd3fb7bc5bb392a)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by Damon Nguyen on 13 Jun 2024 and was
rev
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translati
On Thu, 6 Jun 2024 18:16:14 GMT, Raffaello Giulietti
wrote:
> A documentation-only change to match the original intent and the implemented
> behavior.
This pull request has now been integrated.
Changeset: bb7ef030
Author:Raffaello Giulietti
URL:
https://git.openjdk.org/jdk/commit/
On Tue, 11 Jun 2024 19:01:45 GMT, Weijun Wang wrote:
>> Thanks I'll go through the above comments and update - some of the changes I
>> see are unnecessary and from when I was trying migrating to callAs, and
>> doPrivileged, and yes they can be simpler.
>>
>> On the allowSecurityMananger check
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Wed, 12 Jun 2024 14:08:43 GMT, Ferenc Rakoczi wrote:
>> This PR removes some unnecessary conversions between byte arrays and long
>> arrays during SHA3 digest computations.
>
> Ferenc Rakoczi has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 13 Jun 2024 16:47:43 GMT, Viktor Klang wrote:
> Making sure that the Javadoc is correct for Gatherer
This pull request has now been integrated.
Changeset: 5230786a
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/5230786a0d2185d8db3f7a3843f3ae33f94f7215
Stats:
On Wed, 5 Jun 2024 03:59:24 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Wed, 5 Jun 2024 03:59:24 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Thu, 13 Jun 2024 16:47:43 GMT, Viktor Klang wrote:
> Making sure that the Javadoc is correct for Gatherer
Marked as reviewed by iris (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19704#pullrequestreview-2116350395
On Thu, 13 Jun 2024 16:51:30 GMT, Justin Lu wrote:
>> lingjun-cg has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 896: Performance regression of DecimalFormat.format
>
> src/java.base/share/classes/java/text/StringBuilderBufferProxy.j
On Wed, 5 Jun 2024 03:59:24 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
Making sure that the Javadoc is correct for Gatherer
-
Commit messages:
- Backport cff048c7354dd947a3946d262f4752a55b7e2a43
Changes: https://git.openjdk.org/jdk/pull/19704/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19704&range=00
Issue: https://bugs.openjdk.org/brows
On Wed, 12 Jun 2024 21:58:25 GMT, Justin Lu wrote:
>> Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8333920)
>> which corrects a bug where NumberFormat cannot successfully parse values in
>> integer only mode, when the format expects a suffix.
>>
>> For example,
>>
>> //
On Thu, 13 Jun 2024 16:02:38 GMT, Chen Liang wrote:
> My suggestion is that our comment should say why we have this check here even
> though there's already an identical check in end().
I now see what you mean. I'll update this appropriately tomorrow.
-
PR Review Comment: https://
Created jtreg test case for
[JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
The JpackageTest created tests that the child process started from the app
launched by jpackage launcher is not automatically terminated when the the
launcher is terminated.
-
Commit mess
> On Jun 13, 2024, at 8:20 AM, fo...@univ-mlv.fr wrote:
>
>
>
> From: "Viktor Klang"
> To: "Remi Forax" , "core-libs-dev"
>
> Sent: Thursday, June 13, 2024 12:52:03 PM
> Subject: Re: [External] : Gatherer and primitive specialization
> Hi Rémi,
>
> Given that Collector has not been special
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to remove the
>> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
>> JBS issue, in
On Wed, 12 Jun 2024 20:58:28 GMT, Viktor Klang wrote:
> Erronous Javadoc reference addressed. This should be backported to 23.
This pull request has now been integrated.
Changeset: cff048c7
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit/cff048c7354dd947a3946d262f4752a55
> From: "Viktor Klang"
> To: "Remi Forax" , "core-libs-dev"
>
> Sent: Thursday, June 13, 2024 12:52:03 PM
> Subject: Re: [External] : Gatherer and primitive specialization
> Hi Rémi,
> Given that Collector has not been specialized since it was introduced, we
> opted
> to not specialize Gathere
On Thu, 13 Jun 2024 14:09:16 GMT, Jaikiran Pai wrote:
>> src/java.base/share/classes/java/util/zip/Deflater.java line 904:
>>
>>> 902: public void close() {
>>> 903: synchronized (zsRef) {
>>> 904: // check if already closed
>>
>> Should we comment `// in case subclasses
On Thu, 6 Jun 2024 13:28:55 GMT, Jaikiran Pai wrote:
>> Can I please get a review for this change which proposes to remove the
>> `CHECK_EXCEPTION_NULL_FAIL` macro from the `java` launcher code?
>>
>> This addresses https://bugs.openjdk.org/browse/JDK-8333714. As noted in that
>> JBS issue, in
On Thu, Jun 13, 2024 at 9:01 AM Alan Bateman
wrote:
> On 13/06/2024 14:22, David Lloyd wrote:
>
> :
>
> I've updated with a few commits today which solve (I think) the access
> control issue, moves constant descriptors to constants in a holder class,
> moves the bootstrap to `ConstantBootstraps`,
On Wed, 12 Jun 2024 21:07:25 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> convert the tests to junit
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 904:
>
>> 902: public vo
> Please review this patch that fixes a critical issue that breaks some Proxy
> usages.
>
> Since the problematic patch from before cannot be backed out, this patch aims
> to emulate the old behavior before. A diff between before the problematic
> patch and this patch is available at
> https:/
On Thu, 13 Jun 2024 13:59:09 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 676:
>>
>>> 674: * @param method The method for which to create a
>>> proxy
>>> 675: */
>>> 676: private ProxyMethod(Method method, St
On Thu, 13 Jun 2024 08:27:47 GMT, Claes Redestad wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> More rename and code style cleanup
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 676:
>
>
On Thu, Jun 13, 2024 at 8:39 AM Alan Bateman
wrote:
> On 12/06/2024 15:23, David Lloyd wrote:
>
>
> :
> .
>
> I have a *very* rough prototype up [1]. It adds two new accessor methods
> to `ReflectionFactory`: `defaultReadObjectForSerialization` and
> `defaultWriteObjectForSerialization`. It was e
On 13/06/2024 14:22, David Lloyd wrote:
:
I've updated with a few commits today which solve (I think) the access
control issue, moves constant descriptors to constants in a holder
class, moves the bootstrap to `ConstantBootstraps`, just says "no" to
caching, and cleans up a few other minor is
On 12/06/2024 15:23, David Lloyd wrote:
:
.
I have a *very* rough prototype up [1]. It adds two new accessor
methods to `ReflectionFactory`: `defaultReadObjectForSerialization`
and `defaultWriteObjectForSerialization`. It was easier than expected,
due largely to the classfile API, which is r
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Wed, Jun 12, 2024 at 9:23 AM David Lloyd wrote:
>
>
> On Tue, Jun 11, 2024 at 1:08 PM David Lloyd
> wrote:
>
>>
>>
>> On Tue, Jun 11, 2024 at 12:57 PM Alan Bateman
>> wrote:
>>
>>>
>>>
>>> On 11/06/2024 18:19, David Lloyd wrote:
>>>
>>> :
>>>
>>> I thought that might be where Alan was headed
On Thu, 13 Jun 2024 09:47:25 GMT, Christoph Langer wrote:
> It seems the error is gone meanwhile. So we can reenable the test.
This pull request has now been integrated.
Changeset: f5213671
Author:Christoph Langer
URL:
https://git.openjdk.org/jdk/commit/f5213671f7b636b32bb93c78e4369
On Thu, 13 Jun 2024 09:47:25 GMT, Christoph Langer wrote:
> It seems the error is gone meanwhile. So we can reenable the test.
Trivial fix of test listing, so
-
PR Comment: https://git.openjdk.org/jdk/pull/19691#issuecomment-2165639694
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Wed, 12 Jun 2024 16:41:36 GMT, Daniel Fuchs wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>Undo test policy updates
>
> src/java.management.rmi/share/classes/javax/management/remote/rmi/RMIConnectionImpl.java
>
On Thu, 13 Jun 2024 09:47:25 GMT, Christoph Langer wrote:
> It seems the error is gone meanwhile. So we can reenable the test.
Okay. Any idea what fixed the test?
-
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19691#pullrequestreview-2115358
On Wed, 12 Jun 2024 20:42:27 GMT, Sean Mullan wrote:
>> Kevin Walls has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>>Undo test policy updates
>
> src/java.management/share/classes/com/sun/jmx/remote/security/MBeanServerFileAccessControll
> Please review this fix for an intermittent test failure.
>
> On some configurations, the default `expect` timeout of 10 seconds is
> insufficient. It is increased to 20; it's hard to imagine a configuration for
> which that new value would still be insufficient, but we'll see.
>
> Aside from
On Thu, 13 Jun 2024 02:06:42 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Thu, 13 Jun 2024 10:48:15 GMT, Viktor Klang wrote:
>> Erronous Javadoc reference addressed. This should be backported to 23.
>
> Viktor Klang has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Tweaking the copyright year to reflect initia
On Thu, 13 Jun 2024 01:31:46 GMT, Jaikiran Pai wrote:
>> Viktor Klang has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Tweaking the copyright year to reflect initial year AND current
>> - Updating copyright year
>
> Hello Viktor, the c
> Erronous Javadoc reference addressed. This should be backported to 23.
Viktor Klang has updated the pull request incrementally with two additional
commits since the last revision:
- Tweaking the copyright year to reflect initial year AND current
- Updating copyright year
-
Chan
Hi Rémi,
Given that Collector has not been specialized since it was introduced, we opted
to not specialize Gatherer eagerly as Valhalla Value Classes may also move the
needle a bit regarding the need for specialization in general.
It was also not clear how far to take such specialization―since
> JMX uses APIs related to the Security Mananger which are deprecated. Use of
> AccessControlContext will be removed when Security Manager is removed.
>
> Until then, updates are needed to not require setting
> -Djava.security.manager=allow to use JMX authentication.
Kevin Walls has updated t
On Thu, 13 Jun 2024 09:47:25 GMT, Christoph Langer wrote:
> It seems the error is gone meanwhile. So we can reenable the test.
Maybe [this
one](https://github.com/openjdk/jdk/commit/4d9042043ecade75d50c25574a445e6b8ef43618)?
But just guessing...
-
PR Comment: https://git.openjdk.
On Thu, 13 Jun 2024 06:47:07 GMT, Jaikiran Pai wrote:
> in the past on systems that Matthias has run into similar issues, it was
> observed that those systems run with a very high `-concurrency` value (which
> implies too many test processes running at the same time) which could cause
> slowne
It seems the error is gone meanwhile. So we can reenable the test.
-
Commit messages:
- JDK-8211847
Changes: https://git.openjdk.org/jdk/pull/19691/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19691&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8211847
Stats: 1
On Thu, 13 Jun 2024 02:06:42 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
On Thu, 6 Jun 2024 11:41:05 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - reverted static initialization of ConstantPoolBuilder and CP entries
>> - fixed naming conventions
>
> src/java.base/sha
On Wed, 12 Jun 2024 22:00:45 GMT, Chen Liang wrote:
>> Please review this patch that fixes a critical issue that breaks some Proxy
>> usages.
>>
>> Since the problematic patch from before cannot be backed out, this patch
>> aims to emulate the old behavior before. A diff between before the
>>
Hello,
the Gatherer API do not provide primitive specialization while intermediate
methods like map(), flatMap() or mapMulti() do.
Unlike collectors where it is okay to not be specialized because most
collectors mutate a collection that is not specialized too,
gatherers can process/transform val
On Thu, 13 Jun 2024 08:05:15 GMT, Alan Bateman wrote:
>> Looking briefly at this, I think we should be able to provide this as a
>> feature of jtreg's support of `junit` test itself. I've created
>> https://bugs.openjdk.org/browse/CODETOOLS-7903751 to investigate this
>> support in jtreg.
>
>
On Thu, 13 Jun 2024 06:59:39 GMT, Jaikiran Pai wrote:
>> test/jdk/java/io/IO/IO.java line 192:
>>
>>> 190: // adapted from
>>> https://junit.org/junit5/docs/current/user-guide/#extensions-lifecycle-callbacks-timing-extension
>>> 191:
>>> 192: public static class TimingExtension impleme
On Wed, 12 Jun 2024 15:58:59 GMT, Shaojin Wen wrote:
>>> @eme64 It seems like MergeStore didn't happen, is there something I did
>>> wrong?
>>
>> Yes ;)
>>
>> @wenshao The issue is that the pattern matching is quite **limited**.
>> `putCharsAt(byte[] value, int i, char c1, char c2, char c3, ch
On Wed, 12 Jun 2024 21:08:35 GMT, Chen Liang wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> convert the tests to junit
>
> test/jdk/java/util/zip/DeflaterClose.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2019,
> Can I please get a review of this enhancement which proposes to enhance
> `java.util.zip.Deflater/Inflater` classes to now implement `AutoCloseable`?
>
> The actual work for this was done a few years back when we discussed the
> proposed approaches and then I raised a RFR. At that time I could
On Thu, 13 Jun 2024 06:29:36 GMT, Alan Bateman wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Disable timeout in expect scripts
>
> test/jdk/java/io/IO/IO.java line 192:
>
>> 190: // adapted from
>> https://j
72 matches
Mail list logo
