Re: RFR: 8333854: IllegalAccessError with proxies after JDK-8332457 [v2]

2024-06-09 Thread Chen Liang
> Please review this patch that fixes a critical issue that breaks some Proxy > usages. > > CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible > package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such types can appear > in method descriptors in the same class. The

Re: RFR: 8310843: Reimplement ByteArray and ByteArrayLittleEndian with Unsafe [v2]

2024-06-09 Thread Glavo
> Things have changed since https://github.com/openjdk/jdk/pull/14636 was > closed, so let me reopen it. > > https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE > caused a startup regression. In order to not have any more revert patches, it > makes sense to optimize BAL

Re: RFR: 8310843: Reimplement ByteArray and ByteArrayLittleEndian with Unsafe

2024-06-09 Thread Chen Liang
On Mon, 10 Jun 2024 02:12:11 GMT, Glavo wrote: > Things have changed since https://github.com/openjdk/jdk/pull/14636 was > closed, so let me reopen it. > > https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE > caused a startup regression. In order to not have any more

RFR: 8330205: Initial troff manpage generation for JDK 24

2024-06-09 Thread David Holmes
Sets the version to 24/24-ea and the copyright year to 2025. Content changes related to the start of release (e.g. for removed options in java.1) are handled separately. This initial generation also picks up the unpublished changes from: - JDK-8330807: Update Manpage for obsoletion of Scavenge

RFR: 8310843: Reimplement ByteArray and ByteArrayLittleEndian with Unsafe

2024-06-09 Thread Glavo
Things have changed since https://github.com/openjdk/jdk/pull/14636 was closed, so let me reopen it. https://github.com/openjdk/jdk/pull/15386 confirmed that `VarHandle` in BALE caused a startup regression. In order to not have any more revert patches, it makes sense to optimize BALE. The opti

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v6]

2024-06-09 Thread Glavo
On Sun, 9 Jun 2024 22:45:26 GMT, Shaojin Wen wrote: >> After PR #16245, C2 optimizes stores into primitive arrays by combining >> values ​​into larger stores. In the UUID.toString method, >> ByteArrayLittleEndian can be removed, making the code more elegant and >> faster. > > Shaojin Wen has u

RFR: 8333854: IllegalAccessError with proxies after JDK-8332457

2024-06-09 Thread Chen Liang
Please review this patch that fixes a critical issue that breaks some Proxy usages. CONSTANT_Class and CONSTANT_MethodType must fail resolution for inaccessible package-private types per JVMS 5.4.3.1 and 5.4.3.5, yet such types can appear in method descriptors in the same class. The proposed wa

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v6]

2024-06-09 Thread Chen Liang
On Sun, 9 Jun 2024 22:45:26 GMT, Shaojin Wen wrote: >> After PR #16245, C2 optimizes stores into primitive arrays by combining >> values ​​into larger stores. In the UUID.toString method, >> ByteArrayLittleEndian can be removed, making the code more elegant and >> faster. > > Shaojin Wen has u

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v6]

2024-06-09 Thread Shaojin Wen
> After PR #16245, C2 optimizes stores into primitive arrays by combining > values ​​into larger stores. In the UUID.toString method, > ByteArrayLittleEndian can be removed, making the code more elegant and faster. Shaojin Wen has updated the pull request incrementally with one additional commi

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v5]

2024-06-09 Thread Claes Redestad
On Sun, 9 Jun 2024 07:22:39 GMT, Shaojin Wen wrote: >> After PR #16245, C2 optimizes stores into primitive arrays by combining >> values ​​into larger stores. In the UUID.toString method, >> ByteArrayLittleEndian can be removed, making the code more elegant and >> faster. > > Shaojin Wen has u

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v5]

2024-06-09 Thread Shaojin Wen
> After PR #16245, C2 optimizes stores into primitive arrays by combining > values ​​into larger stores. In the UUID.toString method, > ByteArrayLittleEndian can be removed, making the code more elegant and faster. Shaojin Wen has updated the pull request incrementally with two additional commi

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v4]

2024-06-09 Thread Shaojin Wen
> After PR #16245, C2 optimizes stores into primitive arrays by combining > values ​​into larger stores. In the UUID.toString method, > ByteArrayLittleEndian can be removed, making the code more elegant and faster. Shaojin Wen has updated the pull request incrementally with one additional commi

Re: RFR: 8333833: UUID toString removes the use of ByteArrayLittleEndian [v3]

2024-06-09 Thread Chen Liang
On Sat, 8 Jun 2024 23:30:38 GMT, Shaojin Wen wrote: >> After PR #16245, C2 optimizes stores into primitive arrays by combining >> values ​​into larger stores. In the UUID.toString method, >> ByteArrayLittleEndian can be removed, making the code more elegant and >> faster. > > Shaojin Wen has u