On Tue, 30 Apr 2024 23:58:49 GMT, Alexey Semenyuk wrote:
> Rerun pandoc on updated source man page file
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19028#pullrequestreview-2032839569
Rerun pandoc on updated source man page file
-
Commit messages:
- 8331222: Malformed text in the jpackage doc page
Changes: https://git.openjdk.org/jdk/pull/19028/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19028&range=00
Issue: https://bugs.openjdk.org/browse/JDK-833
On Tue, 30 Apr 2024 18:18:30 GMT, Paul Sandoz wrote:
>> Class files with specifically corrupted tableswitch or lookupswitch
>> instructions in the bytecode cause OutOfMemoryError while parsing with
>> Class-File API.
>> This patch performs additional checks to avoid OOME and adds relevant tests
On Sun, 21 Apr 2024 04:37:45 GMT, Srinivas Vamsi Parasa
wrote:
>> Hello Vamsi (@vamsi-parasa),
>>
>> Could you please run the new benchmarking?
>> To save time and don't patch JDK several times, I've created
>> JavaBenchmarkHarness
>> class which is under package java.util and compares several
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Tue, 30 Apr 2024 15:31:02 GMT, Adam Sotona wrote:
> Class files with specifically corrupted tableswitch or lookupswitch
> instructions in the bytecode cause OutOfMemoryError while parsing with
> Class-File API.
> This patch performs additional checks to avoid OOME and adds relevant tests.
>
On Fri, 26 Apr 2024 17:47:46 GMT, Justin Lu wrote:
> Correct a misleading example in the DateFormat parse documentation.
>
> Common usage is to use a factory instance. The original example provided
> assumes a pattern provided by a COMPAT factory instance.
>
> The pattern itself should be exp
On Mon, 29 Apr 2024 21:53:02 GMT, Tim Prinzing wrote:
> Should I set the default to be fairly high (like maybe 1600ms)? I think to be
> useful people will have to set the threshold to something that fits their
> needs anyway.
I wonder about the usefulness of this event if the default threshold
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote:
> Currently the JFR event FileForceEvent is generated by instrumenting the
> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
> mirror events with static methods.
>
> Added the event at jdk.internal.event.FileForc
Class files with specifically corrupted tableswitch or lookupswitch
instructions in the bytecode cause OutOfMemoryError while parsing with
Class-File API.
This patch performs additional checks to avoid OOME and adds relevant tests.
Please review.
Thank you,
Adam
-
Commit messages:
On Mon, 29 Apr 2024 16:42:05 GMT, Viktor Klang wrote:
> This PR finalizes JEP 473 by modifying the PreviewFeature JEP number and
> status for Stream Gatherers.
This pull request has now been integrated.
Changeset: 2cc8eccb
Author:Viktor Klang
URL:
https://git.openjdk.org/jdk/commit
> Consider code like:
>
> public class ConsoleTest {
> public static void main(String... args) {
> System.console().printf("Hello!");
> }
> }
>
>
> When run as:
>
> $ java ConsoleTest.java >/dev/null
>
>
> it prints `Hello!` to stderr, instead of to stdout (where it would be
On Tue, 30 Apr 2024 14:01:37 GMT, Jan Lahoda wrote:
> I.e. not trying to be too smart about output, and simply using stdout as
> other programs do seems consistent, and most useful - the output can then be
> used in pipes, etc.
Totally reasonable. But the ssh example is telling - suppose for e
Please review this trivial method rename. While this issue was originally
spotted in [another PR], it makes sense to address it separately. Test results
are pending; not that I expect failures, but still.
[another PR]: https://github.com/openjdk/jdk/pull/14831#issuecomment-1655477396
--
On Mon, 29 Apr 2024 20:21:23 GMT, Archie Cobbs wrote:
> > Of course the question is if it should write to stderr or /dev/tty like
> > mechanism..
>
> I was wondering the same thing. My understanding of the definition of
> "console" is a bidirectional byte channel with a keyboard & screen on th
> Hi,
> During performance optimization work on Class-File API as JDK lambda
> generator we found some static initialization killers.
> One of them is `java.lang.classfile.Attributes` with tens of static fields
> initialized with individual attribute mappers, and common set of all mappers,
> and
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contai
On Tue, 30 Apr 2024 12:38:02 GMT, Viktor Klang wrote:
> @pavelrappo Wdyt?
I like it, but maybe native speakers who also write clearly could double check
that change from _which_ to _that_? In no particular order: @DougLea,
@AlanBateman, @stuart-marks.
-
PR Comment: https://git.op
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contai
On Sat, 27 Apr 2024 11:52:18 GMT, Viktor Klang wrote:
>> This is an attempt to be more clear about recommendations on Lock usage.
>
> Viktor Klang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/java/ut
On Tue, 30 Apr 2024 12:23:36 GMT, Adam Sotona wrote:
>> Hi,
>> During performance optimization work on Class-File API as JDK lambda
>> generator we found some static initialization killers.
>> One of them is `java.lang.classfile.Attributes` with tens of static fields
>> initialized with individ
On Tue, 30 Apr 2024 12:13:59 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/BoundAttribute.java
>> line 996:
>>
>>> 994: public static AttributeMapper standardAttribute(Utf8Entry name)
>>> {
>>> 995: // critical bootstrap path, so no lambdas nor
On Tue, 30 Apr 2024 07:01:16 GMT, Jan Kratochvil
wrote:
> * Will the patch be accepted only for memory or it has to support also CPU?
It should be fine for memory only for a start, but we should allow for
on-boarding of other controllers as well.
> * Should I code it on top of OpenJDK trunk o
On Tue, 30 Apr 2024 12:05:46 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added bug number
>
> src/java.base/share/classes/jdk/internal/classfile/impl/BoundAttribute.java
> line 996:
>
>> 994:
> Hi,
> During performance optimization work on Class-File API as JDK lambda
> generator we found some static initialization killers.
> One of them is `java.lang.classfile.Attributes` with tens of static fields
> initialized with individual attribute mappers, and common set of all mappers,
> and
On Tue, 30 Apr 2024 12:09:05 GMT, Chen Liang wrote:
> Also the `final` modifier addition should be included in the CSR, as it
> changes the access modifiers even if it has no real impact.
The class already had only private constructor, so there was no way to extend
it.
-
PR Comme
On 2024-04-25 20:30, Philip Race wrote:
On 4/24/24 4:24 AM, Magnus Ihse Bursie wrote:
That is a good question. libiconv is used only on macOS and AIX, for
a few libraries, as you say. I just tried removing -liconv from the
macOS dependencies and recompiled, just to see what would happen.
Th
On Mon, 29 Apr 2024 18:48:53 GMT, Adam Sotona wrote:
> Hi,
> During performance optimization work on Class-File API as JDK lambda
> generator we found some static initialization killers.
> One of them is `java.lang.classfile.Attributes` with tens of static fields
> initialized with individual a
On Mon, 29 Apr 2024 18:48:53 GMT, Adam Sotona wrote:
> Hi,
> During performance optimization work on Class-File API as JDK lambda
> generator we found some static initialization killers.
> One of them is `java.lang.classfile.Attributes` with tens of static fields
> initialized with individual a
Hi,
During performance optimization work on Class-File API as JDK lambda generator
we found some static initialization killers.
One of them is `java.lang.classfile.Attributes` with tens of static fields
initialized with individual attribute mappers, and common set of all mappers,
and static map
On Mon, 29 Apr 2024 23:04:38 GMT, Chen Liang wrote:
> Nice changes! Remarks
>
> 1. The `INSTANCE` fields should be declared `final`, still safe for lazy
> initialization.
> 2. Not from this patch, but the `AttributeStability stability()` overrides
> can be moved to `AbstractAttributeMapper`, s
> Move all random generators mandated in package `java.util.random` and
> currently implemented in module `jdk.random` to module `java.base`, and
> remove module `jdk.random`.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
T
Can I please get a review of these test-only changes which proposes to remove
the `test/jdk/sun/tools/jcmd/JcmdOutputEncodingTest.java` and
`test/jdk/sun/tools/jstack/BasicJStackTest.java` tests from
`ProblemList-Virtual.txt`?
When jtreg was enhanced to allow running the tests from within a vir
On Mon, 29 Apr 2024 16:42:05 GMT, Viktor Klang wrote:
> This PR finalizes JEP 473 by modifying the PreviewFeature JEP number and
> status for Stream Gatherers.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/19003#pullrequestreview-2030820148
This PR finalizes JEP 473 by modifying the PreviewFeature JEP number and status
for Stream Gatherers.
-
Commit messages:
- Updating PreviewFeature.STREAM_GATHERERS to 473 - Second Preview
Changes: https://git.openjdk.org/jdk/pull/19003/files
Webrev: https://webrevs.openjdk.org/?r
On Mon, 29 Apr 2024 16:42:05 GMT, Viktor Klang wrote:
> This PR finalizes JEP 473 by modifying the PreviewFeature JEP number and
> status for Stream Gatherers.
@AlanBateman Let me know if I should create a new JBS issue for this change, or
if it is fine to target the JEP JBS issue. 🤔
On Mon, 29 Apr 2024 16:42:05 GMT, Viktor Klang wrote:
> This PR finalizes JEP 473 by modifying the PreviewFeature JEP number and
> status for Stream Gatherers.
LGTM
-
Marked as reviewed by pminborg (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19003#pullrequestreview-20
On Mon, 29 Apr 2024 16:42:59 GMT, Viktor Klang wrote:
> @AlanBateman Let me know if I should create a new JBS issue for this change,
> or if it is fine to target the JEP JBS issue. 🤔
The bot has spotted this already (see "Integration Blocker" in the updated
description). You'll need to create
> By correctly sizing an intermediate `byte[]` and making use of the internal
> `newStringNoRepl()` method, one allocation per conversion can be avoided when
> the runtime uses compact strings.
Raffaello Giulietti has updated the pull request with a new target base due to
a merge or a rebase. T
On Mon, 29 Apr 2024 15:57:02 GMT, Alan Bateman wrote:
> This looks like it's adding code to search LD_LIBRARY_PATH on Linux/macOS
> too, did you mean to do that?
Hi Alan, this first commit of the PR is just a question if Linux/macOS want to
participate in this 3rd method. For them it's just a
On Mon, 29 Apr 2024 08:11:06 GMT, Claes Redestad wrote:
> I'm looking at ways at reducing/eliminating startup overheads the classfile
> API in preparation of #17108, and have pushed a series of enhancements to
> that effect already. This PR is a collection of minor improvements which add
> up
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contai
42 matches
Mail list logo
