Hello Íñigo,
https://bugs.openjdk.org/browse/JDK-8313674 is already assigned to
someone else. Have you checked with them if it's OK to work on this one?
-Jaikiran
On 25/04/24 9:59 am, Iñigo Mediavilla wrote:
Hello,
For my first contribution to OpenJDK, I've started looking into
JDK-8313674
Thank Alan.
I will redirect my email to the other mailing list and include the person
who has been assigned to that ticket to see if we can collaborate or he
already has a fix.
Íñigo
El jue, 25 abr 2024, 7:32, Alan Bateman escribió:
> On 25/04/2024 05:29, Iñigo Mediavilla wrote:
>
> Hello,
>
On 25/04/2024 05:29, Iñigo Mediavilla wrote:
Hello,
For my first contribution to OpenJDK, I've started looking into
JDK-8313674, an issue that falls into core-libs. According to the
OpenJDK Developers’ Guide I'd need a sponsor to help me through the
contribution process, would anyone be avail
Hello,
For my first contribution to OpenJDK, I've started looking into
JDK-8313674, an issue that falls into core-libs. According to the OpenJDK
Developers’ Guide I'd need a sponsor to help me through the contribution
process, would anyone be available to help me ?
Thanks in advance
Íñigo Mediav
On Sun, 10 Mar 2024 14:40:09 GMT, Jan Kratochvil
wrote:
>> The testcase requires root permissions.
>>
>> Designed by Severin Gehwolf, implemented by Jan Kratochvil.
>
> Jan Kratochvil has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contai
On Wed, 24 Apr 2024 21:52:11 GMT, Paul Sandoz wrote:
> Rather than duplicating some checks I wonder if it is possible to add a
> private method `entryByIndex(int index, int expectedTag)` that the existing
> `entryByIndex` defers to. If the `expectedTag` is non-negative then it checks
> `tag` a
Claes,
> IIUC this optimization leans on 4 long divs being slower than 1 long div + 4
> int divs
Exactly. I think there is also some benefit from unrolling the 4 int
digit pair operations.
> which might not be true on all platforms, nor stay true in the future
Agreed, but I am not sure how to
> Add two sample configuration files:
>
> jaxp-strict.properties: used to set strict configuration, stricter than
> jaxp.properties in previous versions such as JDK 22
>
> jaxp-compat.properties: used to regain compatibility from any more
> restricted configuration than previous versions su
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> - `Refer
On Tue, 23 Apr 2024 12:59:18 GMT, Adam Sotona wrote:
> ClassFile API `StackMapGenerator` attaches print or hex dump of the method to
> an error message.
> However there is no such attachment when the stack maps generation is turned
> off.
>
> This patch moves class print/dump to `impl.Util::d
On Tue, 23 Apr 2024 11:56:41 GMT, Adam Sotona wrote:
> This patch adds missing `@throws` javadoc annotations to
> `java.lang.classfile.BufWriter`.
>
> Please review.
>
> Thank you,
> Adam
This looks good, but for completeness it will need a CSR.
-
PR Review: https://git.openjdk.
On Tue, 23 Apr 2024 07:39:47 GMT, Adam Sotona wrote:
> ClassFile API dives into the nested constant pool entries without type
> restrictions, while parsing a class file. Validation of the entry is
> performed post-parsing. Specifically corrupted constant pool entry may cause
> infinite loop du
On Wed, 24 Apr 2024 19:53:41 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
On Wed, 24 Apr 2024 08:54:53 GMT, Jin Kwon wrote:
>> Fix typos within the `DatabaseMetaData.java`.
>
> Jin Kwon has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8330686: Fix typos in the DatabaseMetaData javadoc
>
> Reviewed-by: jpai
M
On Wed, 24 Apr 2024 15:00:34 GMT, Vicente Romero wrote:
>> Vicente Romero has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> adding comment to jcod file
>
> test
> Will this fix be backported to JDK 21? @vicente-romero-oracle
not sure rig
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
Hi,
IIUC this optimization leans on 4 long divs being slower than 1 long div + 4
int divs, which might not be true on all platforms, nor stay true in the
future. Long values will in practice likely be biased towards lower values, so
it’s important that any optimization to .. longer values doesn
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue linked above,
> [LauncherHelper#getMainType](https://github.com/open
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue linked above,
> [LauncherHelper#getMainType](https://github.com/open
> This patch suggests a workaround to an issue with huge SCF MH expression
> trees taking excessive JIT compilation resources by reviving (part of) the
> simple bytecode-generating strategy that was originally available as an
> all-or-nothing strategy choice.
>
> Instead of reintroducing a bin
On Wed, 24 Apr 2024 10:08:42 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
Is there interest in optimizing StringLatin1.getChars(long, int, byte[])
for large (larger than int) long values[1]?
We can change this to work with 8 digits at a time, which reduces the
amount of 64 bit arithmetic required.
if (i <= -1_000_000_000) {
long q = i / 100_000_000;
charPos -= 8;
wri
On Tue, 23 Apr 2024 09:32:40 GMT, Jin Kwon wrote:
>> Fix typos within the `DatabaseMetaData.java`.
>
> Jin Kwon has updated the pull request incrementally with one additional
> commit since the last revision:
>
> [JDK-8330686] Update copyright year
Marked as reviewed by lancea (Reviewer).
-
Proposing new overloaded methods in `java.io.Console` class that explicitly
take a `Locale` argument. Existing methods rely on the default locale, so the
users won't be able to format their prompts/outputs in a certain locale
explicitly.
-
Commit messages:
- Not using System.err
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Tue, 9 Apr 2024 02:01:36 GMT, Anthony Scarpino wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> remove use of jdk.crypto.ec
>
> src/java.base/share/classes/sun/security/ec/ECOperations.java line 308:
>
>>
On Tue, 23 Apr 2024 19:55:57 GMT, Anthony Scarpino
wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Comments from Jatin and Tony
>
> src/java.base/share/classes/sun/security/ec/ECOperations.java line 204:
>
On Tue, 16 Apr 2024 02:26:57 GMT, Jatin Bhateja wrote:
>> Per-above, this is a switch statement (`UNLIKELY`) fallback. I can still add
>> alignment and loop rotation, but being a fallback figured its more important
>> to keep it small&readable...
>
> It's all part of intrinsic, no harm in polis
> Performance. Before:
>
> Benchmark(algorithm) (dataSize) (keyLength)
> (provider) Mode Cnt ScoreError Units
> SignatureBench.ECDSA.signSHA256withECDSA1024 256
> thrpt3 6443.934 ± 6.491 ops/s
> SignatureBench.ECDSA.
On Wed, 24 Apr 2024 14:49:55 GMT, Sonia Zaldana Calles
wrote:
>> Hi folks,
>>
>> This PR aims to fix
>> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>>
>> I think the regression got introduced in
>> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>>
>> In the i
On Wed, 24 Apr 2024 15:45:58 GMT, Brian Burkhalter wrote:
>> Prevent blocking due to a carrier thread not being released when
>> `ByteArrayOutputStream.writeTo` is invoked from a virtual thread.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebas
On Wed, 24 Apr 2024 10:08:42 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
On Wed, 24 Apr 2024 16:11:35 GMT, Jaikiran Pai wrote:
> With inputs from Lance, I've updated the text and the summary of the release
> note as per the guidelines. You can now mark it as "Resolved", "Delivered".
Done - thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/17113#is
> Reflection is not retrieving generic type information for mandated
> parameters. This is a known issue which has been explicitly stated in the API
> of some reflection methods. Fix for
> [JDK-8292275](https://bugs.openjdk.org/browse/JDK-8292275) made the
> parameters of compact constructors o
On Tue, 23 Apr 2024 12:49:15 GMT, Jaikiran Pai wrote:
>> Archie Cobbs has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 additional
>> commits s
On Wed, 24 Apr 2024 15:45:58 GMT, Brian Burkhalter wrote:
>> Prevent blocking due to a carrier thread not being released when
>> `ByteArrayOutputStream.writeTo` is invoked from a virtual thread.
>
> Brian Burkhalter has updated the pull request with a new target base due to a
> merge or a rebas
On Wed, 24 Apr 2024 14:07:43 GMT, Sean Mullan wrote:
>
> Sounds good, can you add an example to the RN using the above system property?
Added. Thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/18831#issuecomment-2075305341
> Prevent blocking due to a carrier thread not being released when
> `ByteArrayOutputStream.writeTo` is invoked from a virtual thread.
Brian Burkhalter has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought i
On Wed, 24 Apr 2024 14:54:34 GMT, Viktor Klang wrote:
>> Currently we have
>>
>> public void writeTo(OutputStream out) throws IOException {
>> if (Thread.currentThread().isVirtual()) {
>> out.write(toByteArray());
>> } else synchronized (this) {
>> out
On Wed, 24 Apr 2024 13:50:56 GMT, Raffaello Giulietti
wrote:
> Move all random generators mandated in package `java.util.random` and
> currently implemented in module `jdk.random` to module `java.base`, and
> remove module `jdk.random`.
In terms of .jmod, the footprint of java.base.jmod is 20
> Move all random generators mandated in package `java.util.random` and
> currently implemented in module `jdk.random` to module `java.base`, and
> remove module `jdk.random`.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
R
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
On Wed, 24 Apr 2024 14:52:45 GMT, Brian Burkhalter wrote:
>> Using a subclass to count the number of invocations of toByteArray seems a
>> bit strange but in general it is more robust to not rely on a method that
>> may be overridden by a subclass. So I think the suggestion is good.
>
> Current
On Wed, 24 Apr 2024 07:08:20 GMT, Alan Bateman wrote:
>> So do we think it better not to invoke `toByteArray` here?
>
> Using a subclass to count the number of invocations of toByteArray seems a
> bit strange but in general it is more robust to not rely on a method that may
> be overridden by a
> Hi folks,
>
> This PR aims to fix
> [JDK-8329581](https://bugs.openjdk.org/browse/JDK-8329581).
>
> I think the regression got introduced in
> [JDK-8315458](https://bugs.openjdk.org/browse/JDK-8315458).
>
> In the issue linked above,
> [LauncherHelper#getMainType](https://github.com/open
On Wed, 24 Apr 2024 13:50:56 GMT, Raffaello Giulietti
wrote:
> Move all random generators mandated in package `java.util.random` and
> currently implemented in module `jdk.random` to module `java.base`, and
> remove module `jdk.random`.
What is the footprint implications for this? I'm trying
On Tue, 23 Apr 2024 19:26:05 GMT, Lance Andersen wrote:
> > Also, how does one try out these property files? Is there a system property
> > that needs to be set? Can you add more details to the RN on that?
>
> java -Djava.xml.config.file=$JAVA_HOME/conf/jaxp-compat.properties
>
> The property
On Tue, 23 Apr 2024 14:31:44 GMT, Matthias Baesken wrote:
>> We have already good JLI tracing capabilities. But GetApplicationHome and
>> GetApplicationHomeFromDll lack some tracing and should be enhanced.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional com
Move all random generators mandated in package `java.util.random` and currently
implemented in module `jdk.random` to module `java.base`, and remove module
`jdk.random`.
-
Commit messages:
- 8330005: RandomGeneratorFactory.getDefault() throws exception when the
runtime image only
On Wed, 24 Apr 2024 12:00:47 GMT, Evemose wrote:
>> **Subject**
>> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
>> `java.util.List`
>>
>> **Motivation**
>> The motivation behind this proposal is to enhance the functionality of the
>> `List` interface by providing a more f
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those ove
On Wed, 24 Apr 2024 13:14:02 GMT, Ludvig Janiuk wrote:
> While not a blocker IMO, I'm curious about the issues for the removed lines.
> Taking the first one as an example, I see it's "unresolved" (JDK-8192647) but
> the file was removed in JDK-8289764. I don't see any other mentions of
> "prob
On Wed, 24 Apr 2024 10:50:44 GMT, Doug Simon wrote:
>> This PR adds a check for the format of ProblemList files and ensures they
>> only have entries referring to existing tests.
>>
>> The cleanups in the second commit of this PR were done based on the output
>> of `CheckProblemLists`:
>>
>>>
On Mon, 25 Mar 2024 14:56:23 GMT, Per Minborg wrote:
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
> `Optional::or
On Mon, 22 Apr 2024 13:46:59 GMT, Maurizio Cimadamore
wrote:
>> Per Minborg has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 12 additional
>> co
> **Subject**
> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
> `java.util.List`
>
> **Motivation**
> The motivation behind this proposal is to enhance the functionality of the
> `List` interface by providing a more flexible way to find the index of an
> element. Currently,
On Tue, 23 Apr 2024 13:54:42 GMT, Evemose wrote:
>> **Subject**
>> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
>> `java.util.List`
>>
>> **Motivation**
>> The motivation behind this proposal is to enhance the functionality of the
>> `List` interface by providing a more f
> While `SymbolLookup` correctly uses an `Optional` return to denote whether a
> symbol has been found by the lookup or not (which enables composition of
> symbol lookups), many clients end up just calling `Optional::get`, or
> `Optional::orElseThrow()` on the result.
>
> This PR proposes to ad
On Wed, 24 Apr 2024 08:29:56 GMT, Evemose wrote:
>> src/java.base/share/classes/java/util/ArrayList.java line 380:
>>
>>> 378: }
>>> 379:
>>> 380: int findLastIndexInRange(Predicate filter, int start,
>>> int end) {
>>
>> Suggestion:
>>
>> private int findLastIndexInRange(Predica
That is a good question. libiconv is used only on macOS and AIX, for a
few libraries, as you say. I just tried removing -liconv from the macOS
dependencies and recompiled, just to see what would happen. There were
three instances for macOS: libsplashscreen, libjdwp and libinstrument.
Out of th
On Tue, 23 Apr 2024 07:51:28 GMT, Matthias Baesken wrote:
> In the hashN usages of readCen from zip_util.c we see a lot of signed integer
> overflows.
> For example in the java/util jtreg tests those are easily reproducable when
> compiling with -ftrapv (clang/gcc toolchains).
> While those ove
On Sun, 21 Apr 2024 22:00:52 GMT, Doug Simon wrote:
> This PR adds a check for the format of ProblemList files and ensures they
> only have entries referring to existing tests.
>
> The cleanups in the second commit of this PR were done based on the output of
> `CheckProblemLists`:
>
>> make t
> This PR adds a check for the format of ProblemList files and ensures they
> only have entries referring to existing tests.
>
> The cleanups in the second commit of this PR were done based on the output of
> `CheckProblemLists`:
>
>> make test TEST=build/problemLists/CheckProblemLists.java
> .
> This patch suggests a workaround to an issue with huge SCF MH expression
> trees taking excessive JIT compilation resources by reviving (part of) the
> simple bytecode-generating strategy that was originally available as an
> all-or-nothing strategy choice.
>
> Instead of reintroducing a bin
On Wed, 24 Apr 2024 10:01:47 GMT, Claes Redestad wrote:
> > I really wish this change was not done with ClassFile API, but with a
> > simple bundled ASM, so it would be easily backportable, if we decide to. It
> > does not look like CFA buys us a lot here readability/complexity wise:
> > [d99b
On Wed, 24 Apr 2024 09:57:42 GMT, Claes Redestad wrote:
>> This patch suggests a workaround to an issue with huge SCF MH expression
>> trees taking excessive JIT compilation resources by reviving (part of) the
>> simple bytecode-generating strategy that was originally available as an
>> all-or
On Sun, 14 Apr 2024 14:33:26 GMT, Claes Redestad wrote:
>> What are the scenarios which had regressions?
>> Given the conservative growth for StringBuilder, it surprises me a bit that
>> any scenario would regress.
>
> I took a second look and it turns out that there were neither regressions no
> This patch suggests a workaround to an issue with huge SCF MH expression
> trees taking excessive JIT compilation resources by reviving (part of) the
> simple bytecode-generating strategy that was originally available as an
> all-or-nothing strategy choice.
>
> Instead of reintroducing a bin
On Tue, 23 Apr 2024 13:56:32 GMT, Julian Waters wrote:
> WIP
>
> This changeset contains hsdis for Windows/gcc Port. It supports both the
> binutils and capstone backends, though the LLVM backend is left out due to
> compatibility issues encountered during the build. Currently, which gcc
> di
On Sat, 20 Apr 2024 22:31:48 GMT, Scott Gibbons wrote:
>> This code makes an intrinsic stub for `Unsafe::setMemory` for x86_64. See
>> [this PR](https://github.com/openjdk/jdk/pull/16760) for discussion around
>> this change.
>>
>> Overall, making this an intrinsic improves overall performanc
> Fix typos within the `DatabaseMetaData.java`.
Jin Kwon has updated the pull request incrementally with one additional commit
since the last revision:
8330686: Fix typos in the DatabaseMetaData javadoc
Reviewed-by: jpai
-
Changes:
- all: https://git.openjdk.org/jdk/pull/1
On Tue, 23 Apr 2024 20:30:22 GMT, ExE Boss wrote:
>> Evemose has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Added Objects import to sun List
>> - Replaced on-demand import in com.sunList
>> - added non-null assertions
>
> src/
On Tue, 23 Apr 2024 18:08:34 GMT, Brian Burkhalter wrote:
>> I was thinking more of a subclass that counted invocations to public methods
>> or metering which would cause subclass to double the counts when calling via
>> virtual thread.
>
> So do we think it better not to invoke `toByteArray` h
73 matches
Mail list logo
