Re: RFR: 8329354: java/text/Format/MessageFormat/CompactSubFormats.java fails

2024-03-30 Thread Justin Lu
On Sat, 30 Mar 2024 02:26:32 GMT, Jie Fu wrote: > Hi all, > > java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing > machines. > I'm not an expert in this area and just guess it can be fixed like this. > Please review it. > > Thanks. > Best regards, > Jie Hi Jie, This i

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v4]

2024-03-30 Thread Liam Miller-Cushon
On Sat, 30 Mar 2024 17:28:11 GMT, Jiangli Zhou wrote: >> I think that's similar idea to one of the alternatives I mentioned earlier, >> won't that allocate for every central directory entry? This callsite has >> already read the data we need into a buffer, if we end up doing something >> like

Re: RFR: 8328995: launcher can't open jar files where the offset of the manifest is >4GB [v4]

2024-03-30 Thread Jiangli Zhou
On Sat, 30 Mar 2024 03:47:10 GMT, Liam Miller-Cushon wrote: > I think that's similar idea to one of the alternatives I mentioned earlier, > won't that allocate for every central directory entry? Ok. Re-reading your earlier comment more closely, I see you mentioned allocating memory option. Th

Re: RFR: 8329138: Convert JFR FileForceEvent to static mirror event

2024-03-30 Thread Alan Bateman
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote: > Currently the JFR event FileForceEvent is generated by instrumenting the > sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer > mirror events with static methods. > > Added the event at jdk.internal.event.FileForc