On Sat, 30 Mar 2024 03:21:39 GMT, Jiangli Zhou wrote:
>> The other loop uses `readAt` to read in additional data and advance through
>> the extra fields, this loop already has access to a buffer that contains all
>> of the data for the extra fields and doesn't need to do that.
>>
>> I consider
On Fri, 29 Mar 2024 18:43:51 GMT, Liam Miller-Cushon wrote:
>> src/java.base/share/native/libjli/parse_manifest.c line 506:
>>
>>> 504: jlong offset = 0;
>>> 505: while (offset < cenext) {
>>> 506: short headerId = ZIPEXT_HDR(base + offset);
>>
>> Thi
On Tue, 26 Mar 2024 23:32:34 GMT, Justin Lu wrote:
>> Please review this PR which updates two MessageFormat sub format related
>> tests to be guaranteed to run under the `en_US` locale.
>>
>> There exists locale that do not provide distinct instances for separate
>> styles. For example, the `e
Hi all,
java/text/Format/MessageFormat/CompactSubFormats.java fails in our testing
machines.
I'm not an expert in this area and just guess it can be fixed like this.
Please review it.
Thanks.
Best regards,
Jie
-
Commit messages:
- 8329354: java/text/Format/MessageFormat/CompactSub
This code makes an intrinsic stub for `Unsafe::setMemory`. See [this
PR](https://github.com/openjdk/jdk/pull/16760) for discussion around this
change.
Overall, making this an intrinsic improves overall performance of
`Unsafe::setMemory` by up to 4x for all buffer sizes.
Tested with tier-1 (an
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> - `Refer
On Fri, 29 Mar 2024 00:52:46 GMT, Tim Prinzing wrote:
> Currently the JFR event FileForceEvent is generated by instrumenting the
> sun.nio.ch.FileChannelImpl class. This needs to be changed to use the newer
> mirror events with static methods.
>
> Added the event at jdk.internal.event.FileForc
> Classes in the `java.lang.ref` package would benefit from an update to bring
> the spec in line with how the VM already behaves. The changes would focus on
> _happens-before_ edges at some key points during reference processing.
>
> A couple key things we want to be able to say are:
> - `Refer
On Fri, 29 Mar 2024 18:41:09 GMT, Liam Miller-Cushon wrote:
>> src/java.base/share/native/libjli/parse_manifest.c line 197:
>>
>>> 195: jlong cenoff = CENOFF(cenhdr);
>>> 196: jlong cenext = CENEXT(cenhdr);
>>> 197: if (cenoff == ZIP64_MAGICVAL && cenext > 0) {
>>
>> Probably also need to
On Fri, 29 Mar 2024 18:24:23 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Maximum Zip64 extra field length is 32
>
> src/java.base/share/native/libjli/parse_manifest.c line 197:
>
>> 195
On Fri, 29 Mar 2024 18:28:37 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Maximum Zip64 extra field length is 32
>
> src/java.base/share/native/libjli/parse_manifest.c line 506:
>
>> 504
On Fri, 29 Mar 2024 17:38:47 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3
On Fri, 29 Mar 2024 17:38:47 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3
On Fri, 29 Mar 2024 18:08:56 GMT, Liam Miller-Cushon wrote:
>> Could you please point to the related spec for the other `extra field`?
>
> it's in APPNOTE.TXT 4.5, the extra field structure is `header1+data1 +
> header2+data2 . . .`, and we have to iterate through to see if there's an
> entry t
On Fri, 29 Mar 2024 18:03:13 GMT, Jiangli Zhou wrote:
>> There can be multiple extra fields, and the zip64 extended information may
>> not be the first one
>
> Could you please point to the related spec for the other `extra field`?
it's in APPNOTE.TXT 4.5, the extra field structure is `header1+
On Fri, 29 Mar 2024 17:50:00 GMT, Liam Miller-Cushon wrote:
>> src/java.base/share/native/libjli/parse_manifest.c line 505:
>>
>>> 503: Byte *base = p + CENHDR + CENNAM(p);
>>> 504: jlong offset = 0;
>>> 505: while (offset < cenext) {
>>
>> Any reason w
On Wed, 27 Mar 2024 19:58:17 GMT, Naoto Sato wrote:
> Clarifying the behavior for non-ASCII digits in Double/Float.valueOf(String)
> method descriptions. A draft CSR has also been created.
This pull request has now been integrated.
Changeset: 8a0ef811
Author:Naoto Sato
URL:
https:/
On Fri, 29 Mar 2024 17:43:36 GMT, Jiangli Zhou wrote:
>> Liam Miller-Cushon has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Make cendsk an unsigned short
>
> src/java.base/share/native/libjli/parse_manifest.c line 505:
>
>> 503:
On Wed, 27 Mar 2024 17:43:41 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3
On Wed, 27 Mar 2024 17:43:41 GMT, Liam Miller-Cushon wrote:
>> This change fixes a zip64 bug in the launcher that is prevent it from
>> reading the manifest of jars where the 'relative offset of local header'
>> field in the central directory entry is >4GB. As described in APPNOTE.TXT
>> 4.5.3
On Fri, 29 Mar 2024 17:32:11 GMT, Jiangli Zhou wrote:
>> Thanks for the catch, I had missed that the disk start number is 4 bytes and
>> not 8. I pushed a commit. I also removed some unused references to the disk
>> number, which is only being used to validate the size of the zip64 extended
>>
> This change fixes a zip64 bug in the launcher that is prevent it from reading
> the manifest of jars where the 'relative offset of local header' field in the
> central directory entry is >4GB. As described in APPNOTE.TXT 4.5.3, the
> offset is too large to be stored in the central directory it
On Wed, 27 Mar 2024 16:03:09 GMT, Liam Miller-Cushon wrote:
>> src/java.base/share/native/libjli/manifest_info.h line 59:
>>
>>> 57: #define ZIP64_EXTID 1 // Extra field Zip64 header ID
>>> 58:
>>> 59: #define ZIP64_EXTMAXLEN 36 // Maximum Zip64 extra field length
>>
>> The fields desc
23 matches
Mail list logo
