Integrated: 8326915: NPE when a validating parser is restricted

2024-03-01 Thread Joe Wang
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote: > Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null ch

RFR: 8327138: Clean up status management in cdsConfig.hpp and CDS.java

2024-03-01 Thread Ioi Lam
A few clean ups: 1. Rename functions like "`s_loading_full_module_graph()` to `is_using_full_module_graph()`. The meaning of "loading" is not clear: it might be interpreted as to cover only the period where the artifact is being loaded, but not the period after the artifact is completely loaded

RFR: JDK-8326908: DecimalFormat::toPattern throws OutOfMemoryError when pattern is empty string

2024-03-01 Thread Justin Lu
Please review this PR and corresponding CSR which prevents an OutOfMemoryError by restricting the initial maximum fraction digits for an empty pattern DecimalFormat. The cause is that the maximum fraction digits is initialized to `Integer.MAX_VALUE` which causes StringBuilder to eventually thro

Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v11]

2024-03-01 Thread Brent Christian
> Classes in the `java.lang.ref` package would benefit from an update to bring > the spec in line with how the VM already behaves. The changes would focus on > _happens-before_ edges at some key points during reference processing. > > A couple key things we want to be able to say are: > - `Refer

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v11]

2024-03-01 Thread Naoto Sato
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed (thus the original NPE will no longer be possible). A

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v11]

2024-03-01 Thread Roger Riggs
On Fri, 1 Mar 2024 21:29:17 GMT, Naoto Sato wrote: >> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 >> where aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored >> the in-house cache with WeakHashMap, and removed the Key class as it is no >> longer nee

Integrated: JDK-8316708: Augment WorstCaseTests with more cases

2024-03-01 Thread Joe Darcy
On Fri, 22 Sep 2023 05:36:02 GMT, Joe Darcy wrote: > A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZimmermann/papers/accuracy.pdf > > det

Re: RFR: 8309622: Re-examine the cache mechanism in BaseLocale [v10]

2024-03-01 Thread Naoto Sato
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where > aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the > in-house cache with WeakHashMap, and removed the Key class as it is no longer > needed (thus the original NPE will no longer be possible). A

Re: RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries [v2]

2024-03-01 Thread Magnus Ihse Bursie
On Fri, 1 Mar 2024 13:58:08 GMT, Erik Joelsson wrote: >> Executables and dynamic libraries on Linux can encode a search path that the >> dynamic linker will use when looking up library dependencies, generally >> referred to as an "rpath". In the JDK we use this with the $ORIGIN feature >> to s

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Lance Andersen
On Fri, 1 Mar 2024 18:02:24 GMT, Joe Wang wrote: >> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve >> property. Also slightly improved the error msg with the catalog name. >> >> Test: new test added >> existing test CatalogSupport5 would fail without the Nul

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v9]

2024-03-01 Thread Raffaello Giulietti
On Fri, 1 Mar 2024 18:01:11 GMT, Joe Darcy wrote: >> A new paper >> >> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and >> Quadruple Precision" >> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann >> https://members.loria.fr/PZimmermann/papers/accuracy.pdf >>

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Joe Wang
> Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null check on > ErrorReporter. It's a separate issue not c

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v9]

2024-03-01 Thread Joe Darcy
> A new paper > > "Accuracy of Mathematical Functions in Single, Double, Double Extended, and > Quadruple Precision" > by Brian Gladman, Vincenzo Innocente and Paul Zimmermann > https://members.loria.fr/PZimmermann/papers/accuracy.pdf > > details the inputs with generate the worst-case observed

Re: RFR: 8326915: NPE when a validating parser is restricted [v2]

2024-03-01 Thread Joe Wang
On Fri, 1 Mar 2024 00:53:17 GMT, Naoto Sato wrote: >> Joe Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> input.substring second argument not needed; proper test method name > > src/java.xml/share/classes/jdk/xml/internal/SecuritySu

Re: RFR: 8326915: NPE when a validating parser is restricted

2024-03-01 Thread Naoto Sato
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote: > Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null ch

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v8]

2024-03-01 Thread Raffaello Giulietti
On Wed, 28 Feb 2024 06:08:18 GMT, Joe Darcy wrote: >> A new paper >> >> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and >> Quadruple Precision" >> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann >> https://members.loria.fr/PZimmermann/papers/accuracy.pdf >>

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-03-01 Thread Magnus Ihse Bursie
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on X8

Re: RFR: 8312425: [vectorapi] AArch64: Optimize vector math operations with SLEEF [v9]

2024-03-01 Thread Hamlin Li
On Thu, 7 Dec 2023 09:30:01 GMT, Xiaohong Gong wrote: >> Currently the vector floating-point math APIs like >> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform, >> which causes large performance gap on AArch64. Note that those APIs are >> optimized by C2 compiler on X8

Re: RFR: JDK-8316708: Augment WorstCaseTests with more cases [v8]

2024-03-01 Thread Raffaello Giulietti
On Wed, 28 Feb 2024 06:08:18 GMT, Joe Darcy wrote: >> A new paper >> >> "Accuracy of Mathematical Functions in Single, Double, Double Extended, and >> Quadruple Precision" >> by Brian Gladman, Vincenzo Innocente and Paul Zimmermann >> https://members.loria.fr/PZimmermann/papers/accuracy.pdf >>

Re: RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries [v2]

2024-03-01 Thread Erik Joelsson
> Executables and dynamic libraries on Linux can encode a search path that the > dynamic linker will use when looking up library dependencies, generally > referred to as an "rpath". In the JDK we use this with the $ORIGIN feature to > set search paths relative to the location of the binary itsel

Re: RFR: 8326891: Prefer RPATH over RUNPATH for $ORIGIN rpaths in internal JDK binaries [v2]

2024-03-01 Thread Erik Joelsson
On Fri, 1 Mar 2024 06:30:14 GMT, David Holmes wrote: >> Erik Joelsson has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use @requires in test > > test/jdk/tools/launcher/RunpathTest.java line 27: > >> 25: * @test >> 26: * @bug 7190813 8

Re: RFR: JDK-8326389: [test] improve assertEquals failure output [v3]

2024-03-01 Thread Matthias Baesken
On Mon, 26 Feb 2024 06:57:49 GMT, Jaikiran Pai wrote: > Hello David, the updated text that I proposed to Matthias, of the form > "expected: ... but was: ..." was borrowed from what junit5 Unfortunately we get now error messages like this java.lang.RuntimeException: VM output should contain ex

Integrated: 8319648: java/lang/SecurityManager tests ignore vm flags

2024-03-01 Thread Matthew Donovan
On Thu, 15 Feb 2024 17:06:25 GMT, Matthew Donovan wrote: > In this PR I updated the tests to use the newer > ProcessTools.createTestJavaProcessBuilder methods to pass VM options to child > processes. This pull request has now been integrated. Changeset: 437cf354 Author:Matthew Donovan UR

Re: RFR: 8326915: NPE when a validating parser is restricted

2024-03-01 Thread Lance Andersen
On Thu, 29 Feb 2024 21:00:09 GMT, Joe Wang wrote: > Fix a NPE when a validating parser is restricted by the JDKCatalog resolve > property. Also slightly improved the error msg with the catalog name. > > Test: new test added > existing test CatalogSupport5 would fail without the Null ch

Re: RFR: 8325579: Inconsistent behavior in com.sun.jndi.ldap.Connection::createSocket [v7]

2024-03-01 Thread Christoph Langer
> During analysing a customer case I figured out that we have an inconsistency > between documentation and actual behavior in class > com.sun.jndi.ldap.Connection. The [method documentation of > com.sun.jndi.ldap.Connection::createSocket](https://github.com/openjdk/jdk/blob/3ebe6c192a5dd5cc46ae2

Re: RFR: 8326591: New test JmodExcludedFiles.java fails on Windows when --with-external-symbols-in-bundles=public is used

2024-03-01 Thread Matthias Baesken
On Fri, 23 Feb 2024 19:18:46 GMT, Christoph Langer wrote: > The new test JmodExcludedFiles.java checks that no debug symbol files are > contained in the jmod files. It does not take into account that with > configure option --with-external-symbols-in-bundles=public we want to have > stripped p

Withdrawn: 8325567: jspawnhelper without args fails with segfault

2024-03-01 Thread Vladimir Petko
On Fri, 1 Mar 2024 01:50:46 GMT, Vladimir Petko wrote: > This MR fixes segsegv in jspawnhelper when it is called without args. > This scenario happens when a long running Java process is not restarted > during upgrade. > > It updates test/jdk/java/lang/ProcessBuilder/JspawnhelperProtocol.java