> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
> it hasn't to be re-opened.
Christian Stein has updated the
On Thu, 14 Dec 2023 12:39:52 GMT, Adam Sotona wrote:
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments an
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
On Thu, 15 Feb 2024 00:13:28 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> improve method name as suggested, remove unusued clutter
>
> test/jdk/java/text/Format/NumberFormat/DFSExponential.java line
> Please review this PR which fixes / finishes the rest of the IntlTest test
> framework removal in java.text and java.util.i18n tests.
>
> For context, the IntlTest class only ran methods prefixed by _test_ or _Test_
> with public visibility and was originally removed due to some tests
> spuri
On Wed, 14 Feb 2024 23:05:25 GMT, Justin Lu wrote:
> Please review this PR which fixes / finishes the rest of the IntlTest test
> framework removal in java.text and java.util.i18n tests.
>
> For context, the IntlTest class only ran methods prefixed by _test_ or _Test_
> with public visibility
On Mon, 12 Feb 2024 22:52:51 GMT, Attila Szegedi wrote:
> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and will
> thus fall back to slower default method of `List.sort()` instead of sorting a
> range of the array in-place in its backing root `ArrayList`.
>
> This doesn
Thank you to Stuart, Michel, and Joe for taking care of closing my
enhancement and adding helpful comments, I appreciate it!
On Sun, Feb 11, 2024, 5:13 AM David Alayachew
wrote:
> Since I am abandoning this idea, could someone close my JBS ticket?
>
> And please link this message in the core-lib
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
> Data- and ObjectInputStream
>
> Testing: tier1-3
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Revert "Refactor to use a shared impl for slow-path mod-
Vote: Yes
On 2/13/2024 12:25 PM, Brian Burkhalter wrote:
I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group.
Raffaello has been working in the Core Library team at Oracle since April,
2022. He has authored more than 50 contributions to OpenJDK in a number of
areas
On Wed, 14 Feb 2024 21:22:14 GMT, Stuart Marks wrote:
> CopyOnWriteArrayList needs to override subList.sort since it potentially
> modifies the array, and COWAL needs to make a copy before making any
> modifications.
I admit, I didn't look into that much; I just skimmed through some overrides
Please review this PR which fixes / finishes the rest of the IntlTest test
framework removal in java.text and java.util.i18n tests.
For context, the IntlTest class only ran methods prefixed by _test_ or _Test_
with public visibility and was originally removed due to some tests spuriously
passin
Please review this PR and [CSR](https://bugs.openjdk.org/browse/JDK-8317756)
which defines the behavior for creating ChoiceFormats with incorrect patterns.
The wording is added to both the ChoiceFormat constructor and
ChoiceFormat::applyPattern method.
While ideally the inconsistent behavior it
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
> Data- and ObjectInputStream
>
> Testing: tier1-3
Claes Redestad has updated the pull request incrementally with one additional
commit since the last revision:
Refactor to use a shared impl for slow-path mod-UTF8 dec
On Mon, 12 Feb 2024 23:37:59 GMT, Jim Laskey wrote:
>> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and
>> will thus fall back to slower default method of `List.sort()` instead of
>> sorting a range of the array in-place in its backing root `ArrayList`.
>>
>> This does
On Mon, 5 Feb 2024 09:06:24 GMT, Richard Reingruber wrote:
>> Set `interrupted` in `Thread::interrupt` before reading `nioBlocker` for
>> correct (Dekker scheme) synchronization with concurrent execution of
>> [`AbstractInterruptibleChannel::begin`](https://github.com/openjdk/jdk/blob/59062402b
> Update the documentation for `@return` tag of `putIfAbsent` to match the main
> description. `putIfAbsent` uses the same wording as `put` for its `@return`
> tag, but that is incorrect. `putIfAbsent` never returns the **previous**
> value, as the whole point of the method is not the replace t
On Tue, 6 Feb 2024 16:17:21 GMT, Claes Redestad wrote:
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
> Data- and ObjectInputStream
>
> Testing: tier1-3
As there are no regression tests added by this request, I assume that existing
tests must sufficiently cover thi
On Wed, 14 Feb 2024 10:41:08 GMT, Raffaello Giulietti
wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> src/java.base/share/classes/java/io/DataInputStream.java line 585:
>
>> 583: DataInputStre
On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx wrote:
>> Update the documentation for `@return` tag of `putIfAbsent` to match the
>> main description. `putIfAbsent` uses the same wording as `put` for its
>> `@return` tag, but that is incorrect. `putIfAbsent` never returns the
>> **previous**
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
> Re-write the IndexOf code without the use of the pcmpestri instruction, only
> using AVX2 instructions. This change accelerates String.IndexOf on average
> 1.3x for AVX2. The benchmark numbers:
>
>
> BenchmarkScore
> Latest
> During analysing a customer case I figured out that we have an inconsistency
> between documentation and actual behavior in class
> com.sun.jndi.ldap.Connection. The [method documentation of
> com.sun.jndi.ldap.Connection::createSocket](https://github.com/openjdk/jdk/blob/3ebe6c192a5dd5cc46ae2
On Wed, 14 Feb 2024 15:49:01 GMT, Christian Stein wrote:
>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 596:
>>
>>> 594: String mainValue;
>>> 595: try {
>>> 596: Manifest manifest = jarFile.getManifest();
>>
>> I think the try-catch around the
On Wed, 14 Feb 2024 11:41:43 GMT, Alan Bateman wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
>>
On Wed, 14 Feb 2024 11:40:16 GMT, Alan Bateman wrote:
>> Please review this PR that makes the launcher helper keep a reference to the
>> executable JAR file active after extracting the name of the main class and
>> returning it as Class instance. Now, when loading classes from the JAR file,
>>
On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx wrote:
>> Update the documentation for `@return` tag of `putIfAbsent` to match the
>> main description. `putIfAbsent` uses the same wording as `put` for its
>> `@return` tag, but that is incorrect. `putIfAbsent` never returns the
>> **previous**
On Tue, 13 Feb 2024 17:11:05 GMT, John Hendrikx wrote:
>> Update the documentation for `@return` tag of `putIfAbsent` to match the
>> main description. `putIfAbsent` uses the same wording as `put` for its
>> `@return` tag, but that is incorrect. `putIfAbsent` never returns the
>> **previous**
On Fri, 9 Feb 2024 21:29:28 GMT, Christoph Langer wrote:
> During analysing a customer case I figured out that we have an inconsistency
> between documentation and actual behavior in class
> com.sun.jndi.ldap.Connection. The [method documentation of
> com.sun.jndi.ldap.Connection::createSocket
On Tue, 13 Feb 2024 03:55:37 GMT, Stuart Marks wrote:
> My guess is that nobody noticed this because sublists aren't used that much,
> and sorting of subarrays, while arguably necessary for completeness, probably
> aren't used all that much either.
FWIW, `CopyOnWriteArrayList.COWSubList` overr
On Wed, 15 Nov 2023 22:46:03 GMT, Jorn Vernee wrote:
> See the JBS issue for an extended problem description.
>
> This patch changes the specification and implementation of
> `MethodHandles::byteArrayViewVarHandle`,
> `MethodHandles::byteBufferViewVarHandle`, `ByteBuffer::alignedSlice`, and
>
On Wed, 14 Feb 2024 00:48:18 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Wed, 14 Feb 2024 11:35:10 GMT, Raffaello Giulietti
wrote:
>> While properly encoded modified UTF-8 strings won't have embedded zeros
>> (`\u` will be encoded as `0xC0, 0x80`) the decoding routines in
>> `DataInputStream` and `ObjectInputStream` allows them and does not throw an
>> exce
On Tue, 30 Jan 2024 09:08:28 GMT, Matthias Baesken wrote:
> On some Windows machines we see sometimes OOM errors because of high resource
> (memory/swap) consumption. This is especially seen when the jtreg runs have
> higher concurrency. A solution is to put the java/lang/StringBuilder tests in
Vote: Yes
On 13/02/2024 20:25, Brian Burkhalter wrote:
I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group.
Raffaello has been working in the Core Library team at Oracle since April,
2022. He has authored more than 50 contributions to OpenJDK in a number of
areas i
Vote: yes
best regards,
-- daniel
On 13/02/2024 20:25, Brian Burkhalter wrote:
I hereby nominate Raffaello Giulietti to Membership in the Core Libraries Group.
On Wed, 14 Feb 2024 11:03:07 GMT, Christian Stein wrote:
> Please review this PR that makes the launcher helper keep a reference to the
> executable JAR file active after extracting the name of the main class and
> returning it as Class instance. Now, when loading classes from the JAR file,
>
On Mon, 12 Feb 2024 22:52:51 GMT, Attila Szegedi wrote:
> Somewhat surprisingly, `ArrayList$Sublist.sort()` is not specialized and will
> thus fall back to slower default method of `List.sort()` instead of sorting a
> range of the array in-place in its backing root `ArrayList`.
>
> This doesn
On Wed, 14 Feb 2024 11:29:43 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/io/DataInputStream.java line 604:
>>
>>> 602: // For ASCII ISO-8859-1 is equivalent to UTF-8, while
>>> avoiding a redundant
>>> 603: // scan
>>> 604: retu
On Wed, 14 Feb 2024 10:41:17 GMT, Raffaello Giulietti
wrote:
>> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
>> Data- and ObjectInputStream
>>
>> Testing: tier1-3
>
> src/java.base/share/classes/java/io/DataInputStream.java line 604:
>
>> 602: // Fo
Please review this PR that makes the launcher helper keep a reference to the
executable JAR file active after extracting the name of the main class and
returning it as Class instance. Now, when loading classes from the JAR file, it
hasn't to be re-opened.
-
Commit messages:
- Fail
On Tue, 6 Feb 2024 16:17:21 GMT, Claes Redestad wrote:
> Adding a fast-path for ASCII-only modified UTF-8 strings deserialied via
> Data- and ObjectInputStream
>
> Testing: tier1-3
src/java.base/share/classes/java/io/DataInputStream.java line 585:
> 583: DataInputStream dis = null;
>
Vote: yes
> On 13 Feb 2024, at 20:25, Brian Burkhalter
> wrote:
>
> I hereby nominate Raffaello Giulietti to Membership in the Core Libraries
> Group.
>
> Raffaello has been working in the Core Library team at Oracle since April,
> 2022. He has authored more than 50 contributions to OpenJDK
On Tue, 13 Feb 2024 18:03:14 GMT, Dan Lutker wrote:
>> Ran the test on AmazonLinux 2 which has multiple binaries from coreutils
>> package and no coreutils executable as well as AmazonLinux 2023 that uses
>> `--enable-single-binary`
>
> Dan Lutker has updated the pull request incrementally with
44 matches
Mail list logo
