Re: Gatherers -- conditionalWindowFixed?

2024-01-27 Thread David Alayachew
Thank you both for your replies! And thanks for the Gatherer example Viktor. It sounds like, from your email, that you want to see just how useful this method would be to add before we can justify adding it to Gatherers. Fair enough. I have spent a couple of days using this custom Gatherer you m

Re: RFR: 8323159: Consider adding some text re. memory zeroing in Arena::allocate [v5]

2024-01-27 Thread ExE Boss
On Fri, 12 Jan 2024 14:35:01 GMT, Per Minborg wrote: >> This PR proposes to add a clarification that an `Arena` always returns >> zeroed-out segments for `Arena::allocate` methods. >> >> Note that other overloaded methods refer to the abstract `Arena::allocate` >> method via implementation not

Re: RFR: 8324573: HashMap::putAll should resize to sum of both map sizes [v3]

2024-01-27 Thread Joshua Cao
On Sat, 27 Jan 2024 09:09:26 GMT, Ismael Juma wrote: >> Joshua Cao has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Use max of both sizes and other maps size in case of overflow > > src/java.base/share/classes/java/util/HashMap.java line

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v4]

2024-01-27 Thread Coleen Phillimore
> This mechanically replaces NULL with nullptr in hpp/cpp native files in test > native code. This didn't attempt to change NULL in comments to say null > because nullptr is generally the right thing for the comment to say. It does > attempt to change NULL to "null" rather than "nullptr" in st

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread Chen Liang
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 17:05:59 GMT, Chen Liang wrote: > Your API is risky as well: it won't get a compile error if you add a new > field but forgot to add that field to equality checks too. And since > initialization happens in ``, your said error is quite easy to detect > if this class is ever

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread Chen Liang
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread Chen Liang
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread Chen Liang
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread David Alayachew
On Sat, 27 Jan 2024 15:36:59 GMT, Chen Liang wrote: >> David Alayachew has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Rather than reiterating the precondition, let's explain why the method >> failed > > I fail to see the point of this

Re: RFR: 8324718: Add a static function to java.util.Objects to simplify object equality checks [v6]

2024-01-27 Thread Chen Liang
On Sat, 27 Jan 2024 07:52:56 GMT, David Alayachew wrote: >> Adding a function to Objects in order to facilitate equality checking and >> enhance readability. You simply specify the 2 objects that you want to check >> for equality, and then provide the functions which will be used to provide >>

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v3]

2024-01-27 Thread Kevin Walls
On Fri, 26 Jan 2024 21:06:00 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>

Re: RFR: 8324681: Replace NULL with nullptr in HotSpot jtreg test native code files [v3]

2024-01-27 Thread Kevin Walls
On Fri, 26 Jan 2024 21:06:00 GMT, Coleen Phillimore wrote: >> This mechanically replaces NULL with nullptr in hpp/cpp native files in test >> native code. This didn't attempt to change NULL in comments to say null >> because nullptr is generally the right thing for the comment to say. It >>

Re: RFR: 8324573: HashMap::putAll should resize to sum of both map sizes [v3]

2024-01-27 Thread Ismael Juma
On Thu, 25 Jan 2024 00:29:40 GMT, Joshua Cao wrote: >> This change mirrors what we did for ConcurrentHashMap in >> https://github.com/openjdk/jdk/pull/17116. When we add all entries from one >> map to anther, we should resize that map to the size of the sum of both maps. >> >> I used the comma