Update the documentation for `@return` tag of `putIfAbsent` to match the main
description. `putIfAbsent` uses the same wording as `put` for its `@return`
tag, but that is incorrect. `putIfAbsent` never returns the **previous**
value, as the whole point of the method is not the replace the value
On Tue, 16 Jan 2024 06:08:28 GMT, Jatin Bhateja wrote:
>> Or would that require too many registers?
>
>> Can the `offset` not be added to `idx_base` before the loop?
>
> Offset needs to be added to each index element, please refer to API
> specification for details.
> https://docs.oracle.com/en
On Tue, 16 Jan 2024 06:08:35 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1634:
>>
>>> 1632: Register offset,
>>> XMMRegister offset_vec, XMMRegister idx_vec,
>>> 1633:
On Tue, 16 Jan 2024 06:08:40 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1627:
>>
>>> 1625: vpsrlvd(dst, dst, xtmp, vlen_enc);
>>> 1626: // Pack double word vector into byte vector.
>>> 1627: vpackI2X(T_BYTE, dst, ones, xtmp, vlen_enc);
>>
>> I wo
On Tue, 16 Jan 2024 06:08:31 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1757:
>>
>>> 1755: for (int i = 0; i < 4; i++) {
>>> 1756: movl(rtmp, Address(idx_base, i * 4));
>>> 1757: pinsrw(dst, Address(base, rtmp, Address::times_2), i);
>>
>> Do
On Tue, 16 Jan 2024 06:17:43 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1900:
>>
>>> 1898: vgather8b(elem_ty, xtmp3, base, idx_base, rtmp, vlen_enc);
>>> 1899: } else {
>>> 1900: LP64_ONLY(vgather8b_masked(elem_ty, xtmp3, base, idx_base,
>>>
On Tue, 16 Jan 2024 06:13:43 GMT, Jatin Bhateja wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 5309:
>>
>>> 5307: assert(bt == T_LONG || bt == T_DOUBLE, "");
>>> 5308: vmovmskpd(rtmp, mask, vec_enc);
>>> 5309: shlq(rtmp, 5); // for 64 bit rows (4 longs)
>>
>> Suggestio
On Wed, 10 Jan 2024 13:39:52 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data de
On Mon, 15 Jan 2024 14:27:43 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Accelerating masked sub-word gathers for AVX2 targets, this gives
>> additional 1.5-4x s
On Thu, 11 Jan 2024 23:06:32 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Mon, 15 Jan 2024 09:10:38 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Using emulated variable blend E-Core optimized instruction.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 53
On Mon, 15 Jan 2024 14:36:38 GMT, Emanuel Peter wrote:
>> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 1776:
>>
>>> 1774: for (int i = 0; i < 4; i++) {
>>> 1775: movl(rtmp, Address(idx_base, i * 4));
>>> 1776: addl(rtmp, offset);
>>
>> Can the `offset` not be added to `idx
On Mon, 15 Jan 2024 13:49:06 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Accelerating masked sub-word gathers for AVX2 targets, this gives
>> additional 1.5-4x s
On Sat, 13 Jan 2024 18:08:03 GMT, Alan Bateman wrote:
> Clean backport of P3 issue JDK-8322818. The test was initially problematic so
> I have to include the test-only fixes JDK-8323002 and JDK-8323296 (doing
> these as follow-on or dependent PRs wouldn't guarantee that would integrate
> at th
On Sat, 13 Jan 2024 18:06:11 GMT, Alan Bateman wrote:
> Clean backport of P3 issue JDK-8322846.
Marked as reviewed by jpai (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/71#pullrequestreview-1822387922
On Tue, 12 Sep 2023 19:59:57 GMT, Andrey Turbanov wrote:
> A few classes in `jdk.internal.util.xml.impl` package have non-final fields
> which could easily be marked `final`.
>
> Also fixed a few typos and incorrect javadoc links.
This pull request has been closed without being integrated.
--
On Fri, 12 Jan 2024 18:45:39 GMT, Glavo wrote:
> I generated runtime images using `jlink --compress 2 --add-modules
> java.se,jdk.unsupported,jdk.management` and then ran the following JMH
> benchmark:
>
>
> @Warmup(iterations = 10, time = 2)
> @Measurement(iterations = 5, time = 3)
> @Fork(v
On Mon, 15 Jan 2024 09:49:53 GMT, Alan Bateman wrote:
>> With my CSR hat on, JDK-8301341 should never have made the changes it did
>> without going through a CSR request. We have been bitten by this kind of
>> problem many times. Unless a public method is specified to utilise another
>> public
On Mon, 15 Jan 2024 22:16:13 GMT, Glavo wrote:
> In the early development stage of JApp, I used 32-bit integers to store
> metadata such as resource size. But after using zstd to compress the
> metadata, I was surprised to find that storing them as 64-bit integers can
> actually reduce the fil
On Mon, 15 Jan 2024 11:05:09 GMT, Aleksey Shipilev wrote:
> Since recent work to improve `tier4` performance, we actually test
> `tier{1,2,3,4}` often, which includes all the tests in current tree. It would
> be more convenient to just have the `all` test group/alias, so that we can do
> `make
On Mon, 15 Jan 2024 16:08:35 GMT, Claes Redestad wrote:
> I'd very much welcome support for zstd, both for resource content and
> metadata. A larger JEP-sized project, that.
>
> I have run a quick experiment with adding a more compact header format
> (16-bit sizes for the four fields) and on a
On Fri, 12 Jan 2024 18:45:39 GMT, Glavo wrote:
> I generated runtime images using `jlink --compress 2 --add-modules
> java.se,jdk.unsupported,jdk.management` and then ran the following JMH
> benchmark:
>
>
> @Warmup(iterations = 10, time = 2)
> @Measurement(iterations = 5, time = 3)
> @Fork(v
On Mon, 15 Jan 2024 17:59:38 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
Hello Magnus,
Thank you for closing my bug! Terribly sorry to ask another favor, but
could you link the following link for traceability in the JBS submission?
https://mail.openjdk.org/pipermail/amber-dev/2024-January/008488.html
Thank you again for the time and help!
David Alayachew
On Mon, Jan
On Mon, 15 Jan 2024 17:59:38 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Thu, 21 Sep 2023 11:46:19 GMT, Adam Sotona wrote:
>> Chen Liang has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 14 commits:
>>
>> - Classfile object update
>> - Merge branch 'master' into invoke-test-classfile
>> - Merge bra
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains seven addi
Clean backport of P3 issue JDK-8322846.
-
Commit messages:
- Backport faa9c6909dda635eb008b9dada6e06fca47c17d6
Changes: https://git.openjdk.org/jdk22/pull/71/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=71&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8322846
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Mon, 15 Jan 2024 12:34:57 GMT, Doug Lea wrote:
> Sorry for needlessly calling overridable versions in these two cases. I
> should have caught that.
No problem, easy to overlook. I assume you are ok with the changes? If so,
could I please ask you to add your review. Otherwise, is there anoth
On Mon, 15 Jan 2024 16:01:32 GMT, Per Minborg wrote:
>> This PR proposes to add an improved Improve
>> `LayoutPath.PathElement::toString` method simplifying debugging.
>>
>> Opinions and suggestions for `static PathElement sequenceElement(long start,
>> long step)` are welcome.
>
> Per Minborg
On Wed, 10 Jan 2024 13:39:52 GMT, Eirik Bjørsnøs wrote:
>> ZipInputStream.readEnd currently assumes a Zip64 data descriptor if the
>> number of compressed or uncompressed bytes read from the inflater is larger
>> than the Zip64 magic value.
>>
>> While the ZIP format mandates that the data de
On Mon, 15 Jan 2024 16:25:41 GMT, Per Minborg wrote:
> This PR proposed to fix a missing comma in the header of TestScope
This pull request has now been integrated.
Changeset: edc0ebb7
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/edc0ebb7803982311e96a8710e73fa920f32199
This PR proposed to fix a missing comma in the header of TestScope
-
Commit messages:
- Add missing comma in copyright header
Changes: https://git.openjdk.org/jdk/pull/17431/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17431&range=00
Issue: https://bugs.openjdk.org/brow
On Mon, 15 Jan 2024 16:25:41 GMT, Per Minborg wrote:
> This PR proposed to fix a missing comma in the header of TestScope
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/17431#pullrequestreview-1821998292
On Mon, 15 Jan 2024 14:17:40 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Removed useless event settings in test.
Marked as rev
On Mon, 15 Jan 2024 16:14:15 GMT, Per Minborg wrote:
> 8323159: Consider adding some text re. memory zeroing in Arena::allocate
test/jdk/java/foreign/TestScope.java line 2:
> 1: /*
> 2: * Copyright (c) 2023, 2024 Oracle and/or its affiliates. All rights
> reserved.
Can you hold off on this u
8323159: Consider adding some text re. memory zeroing in Arena::allocate
-
Commit messages:
- Backport f5b757ced6b672010ea10575d644d3f9d1728923
Changes: https://git.openjdk.org/jdk22/pull/77/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=77&range=00
Issue: https://bugs.
On Fri, 12 Jan 2024 18:45:39 GMT, Glavo wrote:
> I generated runtime images using `jlink --compress 2 --add-modules
> java.se,jdk.unsupported,jdk.management` and then ran the following JMH
> benchmark:
>
>
> @Warmup(iterations = 10, time = 2)
> @Measurement(iterations = 5, time = 3)
> @Fork(v
Since recent work to improve `tier4` performance, we actually test
`tier{1,2,3,4}` often, which includes all the tests in current tree. It would
be more convenient to just have the `all` test group/alias, so that we can do
`make test TEST=all`. This also gives a parallelism / run time benefit, a
On Fri, 12 Jan 2024 18:45:39 GMT, Glavo wrote:
> I generated runtime images using `jlink --compress 2 --add-modules
> java.se,jdk.unsupported,jdk.management` and then ran the following JMH
> benchmark:
>
>
> @Warmup(iterations = 10, time = 2)
> @Measurement(iterations = 5, time = 3)
> @Fork(v
On Mon, 8 Jan 2024 16:16:50 GMT, Per Minborg wrote:
> This PR proposes to add a clarification that an `Arena` always returns
> zeroed-out segments for `Arena::allocate` methods.
>
> Note that other overloaded methods refer to the abstract `Arena::allocate`
> method via implementation notes.
T
On Tue, 2 Jan 2024 22:06:36 GMT, Eirik Bjørsnøs wrote:
> A CSR for this change has been proposed and is ready for review:
> [JDK-8322871](https://bugs.openjdk.org/browse/JDK-8322871)
I've reviewed the CSR so you can finalize. The implementation change looks fine.
-
PR Comment: htt
> This PR proposes to add an improved Improve
> `LayoutPath.PathElement::toString` method simplifying debugging.
>
> Opinions and suggestions for `static PathElement sequenceElement(long start,
> long step)` are welcome.
Per Minborg has updated the pull request incrementally with one additional
On Mon, 15 Jan 2024 14:25:28 GMT, Emanuel Peter wrote:
>> Jatin Bhateja has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 12 commits:
>>
>> - Accelerating masked sub-word gathers for AVX2 targets, this gives
>> additional 1.5-4x s
On Mon, 1 Jan 2024 14:36:06 GMT, Jatin Bhateja wrote:
>> Hi All,
>>
>> This patch optimizes sub-word gather operation for x86 targets with AVX2 and
>> AVX512 features.
>>
>> Following is the summary of changes:-
>>
>> 1) Intrinsify sub-word gather using hybrid algorithm which initially
>> pa
> Adds serialization misdeclaration events to JFR.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Removed useless event settings in test.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17129/files
- new:
On Thu, 11 Jan 2024 23:06:32 GMT, Scott Gibbons wrote:
>> Re-write the IndexOf code without the use of the pcmpestri instruction, only
>> using AVX2 instructions. This change accelerates String.IndexOf on average
>> 1.3x for AVX2. The benchmark numbers:
>>
>>
>> Benchmark
On Sun, 14 Jan 2024 04:07:29 GMT, Chen Liang wrote:
>> make/modules/java.base/Java.gmk line 41:
>>
>>> 39: java/lang/classfile/snippet-files \
>>> 40: java/lang/classfile/components/snippet-files \
>>> 41: jdk/lang/foreign/snippet-files
>>
>> I can't find this directory in the sourc
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes according to reviewer's comments.
>
>> You mean, in the @description annotation?
>
> Yes.
> @egahlin Ar
On Mon, 4 Dec 2023 13:56:55 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelate
On Mon, 15 Jan 2024 12:09:48 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pull request contains five addit
On Mon, 15 Jan 2024 09:49:39 GMT, Chris Hegarty wrote:
>> Update LinkedTransferQueue add and put methods to not call overridable offer.
>
> Chris Hegarty has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update
> src/java.base/share/classes/
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
> Classfile API to generate proxy classes #17121
>
On Sat, 13 Jan 2024 19:46:05 GMT, He-Pin(kerr) wrote:
>> Cool, I just encounter this problem, when I migrate to Virtual threads and
>> set `jdk.virtualThreadScheduler.maxPoolSize` to 2500.
>>
>> Will this change backport to j21u, thanks.
>
>> @He-Pin I tried to backport this patch for you just
On Mon, 15 Jan 2024 07:57:00 GMT, Per Minborg wrote:
>> This PR proposes to add an improved Improve
>> `LayoutPath.PathElement::toString` method simplifying debugging.
>>
>> Opinions and suggestions for `static PathElement sequenceElement(long start,
>> long step)` are welcome.
>
> test/jdk/ja
> Please consider this PR which makes `DeflaterOutputStream.close()` always
> close its wrapped output stream exactly once.
>
> Currently, closing of the wrapped output stream happens outside the finally
> block where `finish()` is called. If `finish()` throws, this means the
> wrapped stream w
On Tue, 19 Dec 2023 17:53:49 GMT, Erik Gahlin wrote:
>> Raffaello Giulietti has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Changes according to reviewer's comments.
>
>> You mean, in the @description annotation?
>
> Yes.
@egahlin Are
On Wed, 10 Jan 2024 18:56:45 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Small space optimization.
Anybody from security wants
On Sat, 13 Jan 2024 19:46:05 GMT, He-Pin(kerr) wrote:
> I think the related issue should be backported too.
That update is a huge update to FJP that includes API and behavior changes, the
CSR has details. Maybe the starting out here is to first see if running with
the JDK 22 EA builds address
On Mon, 15 Jan 2024 01:55:12 GMT, David Holmes wrote:
> With my CSR hat on, JDK-8301341 should never have made the changes it did
> without going through a CSR request. We have been bitten by this kind of
> problem many times. Unless a public method is specified to utilise another
> public met
On Mon, 15 Jan 2024 07:31:13 GMT, Andrey Turbanov wrote:
>> Chris Hegarty has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> timed offer
>
> src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
> line 1162:
>
>> 1160:
> Update LinkedTransferQueue add and put methods to not call overridable offer.
Chris Hegarty has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/java/util/concurrent/LinkedTransferQueue.java
Co-authored-by: An
Clean backport of P3 issue JDK-8322818. The test was initially problematic so I
have to include the test-only fixes JDK-8323002 and JDK-8323296 (doing these as
follow-on or dependent PRs wouldn't guarantee that would integrate at the same
time).
-
Commit messages:
- JDK-8323002 an
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
On Tue, 9 Jan 2024 16:48:56 GMT, Jatin Bhateja wrote:
>> Hi,
>>
>> Patch optimizes non-subword vector compress and expand APIs for x86 AVX2
>> only targets.
>> Upcoming E-core Xeons (Sierra Forest) and Hybrid CPUs only support AVX2
>> instruction set.
>> These are very frequently used APIs in
> Tests using ProcessTools.executeProcess gets the following output written to
> stdout:
> [2023-11-24T09:58:16.797540608Z] Gathering output for process 2517117
> [2023-11-24T09:58:23.070781345Z] Waiting for completion for process 2517117
> [2023-11-24T09:58:23.071045055Z] Waiting for completion f
On Mon, 15 Jan 2024 07:56:13 GMT, Per Minborg wrote:
> This PR proposes to add an improved Improve
> `LayoutPath.PathElement::toString` method simplifying debugging.
>
> Opinions and suggestions for `static PathElement sequenceElement(long start,
> long step)` are welcome.
test/jdk/java/forei
This PR proposes to add an improved Improve `LayoutPath.PathElement::toString`
method simplifying debugging.
Opinions and suggestions for `static PathElement sequenceElement(long start,
long step)` are welcome.
-
Commit messages:
- Add toString to PathElement
Changes: https://git
On Tue, 2 Jan 2024 12:21:21 GMT, Eirik Bjørsnøs wrote:
>> Please consider this PR which makes `DeflaterOutputStream.close()` always
>> close its wrapped output stream exactly once.
>>
>> Currently, closing of the wrapped output stream happens outside the finally
>> block where `finish()` is ca
71 matches
Mail list logo
