Re: RFR: 6356745: (coll) Add PriorityQueue(Collection, Comparator) [v4]

On Mon, 25 Dec 2023 05:52:51 GMT, jmehrens wrote: >> Valeh Hajiyev has updated the pull request incrementally with one additional >> commit since the last revision: >> >> updated the javadoc > > Would adding a fast path to addAll solve this issue? I asked this back in > 2006 in JDK-6356745.

Re: RFR: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. Integrating under trivial rule. - PR

Integrated: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. This pull request has now been integrated. Changes

Withdrawn: 8319386: Migrate Class::getEnclosingMethod/Constructor away from old generic utilities

On Fri, 3 Nov 2023 14:03:02 GMT, Chen Liang wrote: > Please review a patch that migrates `Class::getEnclosingMethod` and > `Class::getEnclosingConstructor`'s descriptor parsing from old generic > utilities to more simple utilities from java.lang.invoke implementation. This > will help migrate

Re: RFR: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. Looks OK - Marked as reviewed by vtew

Re: RFR: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. LGTM. - Marked as reviewed by mdoerr

Re: RFR: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. LGTM - Marked as reviewed by goetz (R

Re: RFR: 8322772: Clean up code after JDK-8322417

On Fri, 29 Dec 2023 13:44:27 GMT, Christoph Langer wrote: > In the review of the PR for JDK-8322417 it was noted that a fully qualified > class name "java.util.Arrays" is unnecessary but it was forgotten to clean it > up prior to integration. Marked as reviewed by mbaesken (Reviewer). ---

RFR: 8322772: Clean up code after JDK-8322417

In the review of the PR for JDK-8322417 it was noted that a fully qualified class name "java.util.Arrays" is unnecessary but it was forgotten to clean it up prior to integration. - Commit messages: - JDK-8322417 Changes: https://git.openjdk.org/jdk/pull/17203/files Webrev: https:

Withdrawn: 8314986: Module readability resolution is slow with large numbers of automatic modules

On Tue, 26 Sep 2023 14:19:55 GMT, Technici4n wrote: > Fixes the issue (hopefully) by resolving automatic modules and automatic > module dependencies after propagation of non-automatic transitive > dependencies. The module tests run. > > I also added a few asserts to validate that the automatic