Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Sat, 23 Dec 2023 15:24:55 GMT, ExE Boss wrote: >> src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java >> line 49: >> >>> 47: dcb, >>> 48: dcb.methodInfo.methodName(), >>> 49: dcb.methodInfo.methodType(), >> >> Can you enl

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Thu, 21 Dec 2023 13:32:12 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions

Integrated: 8068958: Timestamp.from(Instant) should throw when conversion is not possible

2023-12-23 Thread Eamonn McManus
On Thu, 21 Dec 2023 21:51:10 GMT, Eamonn McManus wrote: > Multiplying with `*` never produces `ArithmeticException`, so the catch in > the existing code is never triggered. `Math.multiplyExact` does produce > `ArithmeticException` if the multiplication overflows. So we can use that, > and reth

Re: RFR: 8068958: Timestamp.from(Instant) should throw when conversion is not possible [v3]

2023-12-23 Thread Roger Riggs
On Sat, 23 Dec 2023 15:22:58 GMT, Eamonn McManus wrote: >> Multiplying with `*` never produces `ArithmeticException`, so the catch in >> the existing code is never triggered. `Math.multiplyExact` does produce >> `ArithmeticException` if the multiplication overflows. So we can use that, >> and

Re: RFR: 8068958: Timestamp.from(Instant) should throw when conversion is not possible [v3]

2023-12-23 Thread Raffaello Giulietti
On Sat, 23 Dec 2023 15:22:58 GMT, Eamonn McManus wrote: >> Multiplying with `*` never produces `ArithmeticException`, so the catch in >> the existing code is never triggered. `Math.multiplyExact` does produce >> `ArithmeticException` if the multiplication overflows. So we can use that, >> and

The default java.library.path on Linux does not include the library paths in the mulitarch-spec

2023-12-23 Thread Glavo
Hi, There are already many Linux distributions that are following the multiarch-spec[1] and adding the following paths to the default library path list: - /usr/local/lib/ - /lib/ - /usr/lib/ But OpenJDK doesn't add these paths to the java.library.path by default, so System.loadLibrary(S

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v4]

2023-12-23 Thread ExE Boss
On Thu, 21 Dec 2023 12:49:02 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread ExE Boss
On Sat, 23 Dec 2023 12:40:33 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> minor StackCounter fix > > src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java > line 49: > >> 47:

Re: RFR: 8068958: Timestamp.from(Instant) should throw when conversion is not possible [v2]

2023-12-23 Thread Eamonn McManus
On Fri, 22 Dec 2023 23:25:35 GMT, Raffaello Giulietti wrote: > Don't forget to update the copyright years in both files, please ;-) Done. (I'm a bit surprised there isn't some sort of automated check if this is a requirement.) - PR Comment: https://git.openjdk.org/jdk/pull/17181#

Re: RFR: 8068958: Timestamp.from(Instant) should throw when conversion is not possible [v3]

2023-12-23 Thread Eamonn McManus
> Multiplying with `*` never produces `ArithmeticException`, so the catch in > the existing code is never triggered. `Math.multiplyExact` does produce > `ArithmeticException` if the multiplication overflows. So we can use that, > and rethrow `IllegalArgumentException` as the specification says.

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v5]

2023-12-23 Thread Chen Liang
On Thu, 21 Dec 2023 13:32:12 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes. >> >> This patch converts it to use Classfile API. >> >> It is continuation of https://github.com/openjdk/jdk/pull/10991 >> >> Any comments and suggestions

Re: RFR: 8322322: Support archived full module graph when -Xbootclasspath/a is used [v2]

2023-12-23 Thread Alan Bateman
On Fri, 22 Dec 2023 18:34:30 GMT, Calvin Cheung wrote: > A full bcp would contain the path to the module image as the first path. This > "append" property only contains the path specified in -Xbootclasspath/a. > That's why I had bootAppendUcp as the variable name. I've changed it to > `bootUcp

Re: RFR: 8322322: Support archived full module graph when -Xbootclasspath/a is used [v2]

2023-12-23 Thread Alan Bateman
On Fri, 22 Dec 2023 18:33:59 GMT, Calvin Cheung wrote: >> Please review this change for enabling full module graph even when >> -Xbootclasspath/a is specified. The validation of -Xbootclasspath/a is >> already being done in `FileMapInfo::validate_boot_class_paths()`. The full >> module graph w