On Mon, 4 Dec 2023 14:05:14 GMT, Vladimir Sitnikov
wrote:
>>> > it doesn't solve the second part of the concern which is read-only view
>>> > on the internal buffer.
>>>
>>> I think `ByteBuffer.asReadOnlyBuffer()` should resolve the issues regarding
>>> naked byte access. At least `ByteBuffer
On Fri, 15 Dec 2023 21:13:07 GMT, Archie Cobbs wrote:
>> `GZIPInputStream`, when looking for a concatenated stream, relies on what
>> the underlying `InputStream` says is how many bytes are `available()`. But
>> this is inappropriate because `InputStream.available()` is just an estimate
>> and
On Fri, 15 Dec 2023 22:26:04 GMT, Raffaello Giulietti
wrote:
>> Adds serialization misdeclaration events to JFR.
>
> Raffaello Giulietti has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Restrict accessibility of nested classes.
It seems co
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
This pull request has now been integrated.
Changeset: b061b667
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/b061b6678fde891974d5b58cec963b3481099a8d
Stats: 290 lines in 36 file
On Thu, 14 Dec 2023 22:17:54 GMT, Alisen Chung wrote:
>> Translation drop for JDK22 RDP1
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> removed quotes around Ablehnen
The diffs are more conveniently available here:
https:
On Fri, 15 Dec 2023 19:35:18 GMT, Sergey Tsypanov wrote:
> If we drop the method for now I have to write it later again, I guess
Maybe, but it's archived so it's easy enough.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16879#discussion_r1428601842
Or use extended Grapheme Cluster boundary "\\b{g}" instead of "\\b".
This will correctly search emoji sequences such as 👨👩👧👧, while
"\\b" with Unicode option won't.
HTH,
Naoto
On 12/15/23 11:29 AM, Stefan Norberg wrote:
Thanks Raffaello,
Ah, thanks! Found https://bugs.openjdk.org/browse/JD
On Fri, 15 Dec 2023 22:40:17 GMT, Brian Burkhalter wrote:
> This test does not fail for me when run against my local build of the current
> mainline. Usually, unless randomness is involved, a test should fail before
> the proposed patch is applied but succeed thereafter.
This is weird. How cou
On Fri, 15 Dec 2023 18:34:42 GMT, Markus KARG wrote:
> I quickly drafted an absolute minimal test for this in [2aaac63] [...].
This test does not fail for me when run against my local build of the current
mainline. Usually, unless randomness is involved, a test should fail before the
proposed
> Adds serialization misdeclaration events to JFR.
Raffaello Giulietti has updated the pull request incrementally with one
additional commit since the last revision:
Restrict accessibility of nested classes.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17129/files
- new
On Fri, 15 Dec 2023 20:38:19 GMT, Eirik Bjorsnos wrote:
> The test is shaping up nicely. Since it's a new test it should use JUnit 5.
>
> Also included a couple suggestions, I'll stop now, promise! :)
No prob - they're all reasonable suggestions :)
> test/jdk/java/util/zip/GZIP/GZIPInputStream
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
> allowed (for example) to always return zero.
>
> The fi
> This is a doc change to clarify what the `Default Locale` is, and how it is
> established during the system startup using the system properties. Those
> locale-related system properties have existed since the early days of Java,
> but have never been publicly documented before. It is also the
On Fri, 15 Dec 2023 20:39:47 GMT, Brent Christian wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Reflects review comments
>
> src/java.base/share/classes/java/util/Locale.java line 327:
>
>> 325: * the value of th
On Thu, 14 Dec 2023 21:50:01 GMT, Naoto Sato wrote:
>> This is a doc change to clarify what the `Default Locale` is, and how it is
>> established during the system startup using the system properties. Those
>> locale-related system properties have existed since the early days of Java,
>> but h
On Fri, 15 Dec 2023 16:30:01 GMT, Archie Cobbs wrote:
>> `GZIPInputStream`, when looking for a concatenated stream, relies on what
>> the underlying `InputStream` says is how many bytes are `available()`. But
>> this is inappropriate because `InputStream.available()` is just an estimate
>> and
On Fri, 15 Dec 2023 17:21:52 GMT, Brian Burkhalter wrote:
>> I think this would be doing double job, wouldn't it?
>
>> I think this would be doing double job, wouldn't it?
>
> Sorry, I don't understand.
If we drop the method for now I have to write it later again, I guess
-
PR Rev
Thanks Raffaello,
Ah, thanks! Found https://bugs.openjdk.org/browse/JDK-8264160 in the
release notes for 19 just now.
Have a great weekend!
/Stefan
On Fri, Dec 15, 2023 at 8:24 PM Raffaello Giulietti <
raffaello.giulie...@oracle.com> wrote:
> By default, a word boundary only considers ASCII lett
By default, a word boundary only considers ASCII letters and digits. See
"Predefined character classes" in the documentation.
To add Unicode support, you have a choice between adding a flag as a 2nd
argument to the compile() method
Pattern p = Pattern.compile("(\\b" + word + "\\b)",
Pattern.
The following test works in 17 but fails in 19.0.2, and 21.0.1 on the last
assertion. Bug or feature?
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import java.util.ArrayList;
import java.util.regex.Matcher;
import java.util.regex.Pattern;
/**
* Tests passes in JDK
On Fri, 15 Dec 2023 18:21:14 GMT, Brian Burkhalter wrote:
> > [...] maybe we need to come up with tests that quickly check the handling
> > at this limit.
> @mkarg Do you intend to provide any such test as part of this request?
@bplb I quickly drafted an absolute minimal test for this in
[2aa
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
Markus KARG has updated the pull request incrementally with one additional
commit since the last revision:
New test asserts subsequent input stream is read
On Fri, 15 Dec 2023 09:55:36 GMT, Alan Bateman wrote:
> [...] maybe we need to come up with tests that quickly check the handling at
> this limit.
@mkarg Do you intend to provide any such test as part of this request?
-
PR Comment: https://git.openjdk.org/jdk/pull/17119#issuecomme
On Fri, 15 Dec 2023 17:41:43 GMT, Naoto Sato wrote:
> 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are
> incorrect
This pull request has now been integrated.
Changeset: 57d97b52
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk22/commit/57d97b52c9d3e92318c
On Fri, 15 Dec 2023 17:41:43 GMT, Naoto Sato wrote:
> 8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are
> incorrect
Marked as reviewed by bpb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk22/pull/16#pullrequestreview-1784673248
8321958: @param/@return descriptions of ZoneRules#isDaylightSavings() are
incorrect
-
Commit messages:
- Backport 87ef73329f66e898d85eecea94a4104a13b3a2db
Changes: https://git.openjdk.org/jdk22/pull/16/files
Webrev: https://webrevs.openjdk.org/?repo=jdk22&pr=16&range=00
Issue: h
Adds serialization misdeclaration events to JFR.
-
Commit messages:
- Make use of EventNames.
- Merge branch 'master' into 8275338
- 8275338: Add JFR events for notable serialization situations
Changes: https://git.openjdk.org/jdk/pull/17129/files
Webrev: https://webrevs.openjdk.
On Fri, 15 Dec 2023 17:34:53 GMT, Raffaello Giulietti
wrote:
> Adds serialization misdeclaration events to JFR.
A serialization misdeclaration on one of the following fields or methods means
that they are not declared according to the Java Object Serialization
Specification (JOSS) or in the J
On Wed, 13 Dec 2023 23:10:05 GMT, Naoto Sato wrote:
> Small document correction on a return description.
This pull request has now been integrated.
Changeset: 87ef7332
Author:Naoto Sato
URL:
https://git.openjdk.org/jdk/commit/87ef73329f66e898d85eecea94a4104a13b3a2db
Stats: 3 lin
On Thu, 14 Dec 2023 17:08:02 GMT, Naoto Sato wrote:
>> Small document correction on a return description.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Corrected @param description
Thanks for the reviews!
-
P
On Fri, 15 Dec 2023 09:25:00 GMT, Sergey Tsypanov wrote:
> I think this would be doing double job, wouldn't it?
Sorry, I don't understand.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16879#discussion_r1428236374
On Fri, 15 Dec 2023 14:09:12 GMT, Eirik Bjorsnos wrote:
>> Archie Cobbs has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address review comments.
>
> test/jdk/java/util/zip/GZIP/GZIPInputStreamAvailable.java line 52:
>
>> 50: buf
> `GZIPInputStream`, when looking for a concatenated stream, relies on what the
> underlying `InputStream` says is how many bytes are `available()`. But this
> is inappropriate because `InputStream.available()` is just an estimate and is
> allowed (for example) to always return zero.
>
> The fi
On Wed, 13 Dec 2023 21:38:43 GMT, Roger Riggs wrote:
> The test java/lang/String/CompactString/MaxSizeUTF16String.java fails when
> run with -Xcomp.
>
> Both the java implementation and the intrinsic for StringUTF16.toBytes()
> allocate memory for a copy of the string.
> The java implementatio
java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
This patch converts it to use Classfile API.
It is continuation of https://github.com/openjdk/jdk/pull/10991
Any comments and suggestions are welcome.
Please review.
Thank you,
Adam
-
Commit messages:
On Fri, 15 Dec 2023 03:20:01 GMT, Archie Cobbs wrote:
>> `GZIPInputStream`, when looking for a concatenated stream, relies on what
>> the underlying `InputStream` says is how many bytes are `available()`. But
>> this is inappropriate because `InputStream.available()` is just an estimate
>> and
On Fri, 15 Dec 2023 12:27:16 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> added missing comment
>
> src/java.base/share/classes/java/lang/invoke/InnerClassLambdaMetafactory.java
> line 548:
>
>> 5
On Fri, 15 Dec 2023 12:26:50 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>>
>> Any com
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments and suggestions are welcome.
>
> Please review.
>
> Tha
On Thu, 14 Dec 2023 04:00:58 GMT, Vicente Romero wrote:
>> Reflection is not retrieving generic type information for mandated
>> parameters. This is a known issue which has been explicitly stated in the
>> API of some reflection methods. Fix for
>> [JDK-8292275](https://bugs.openjdk.org/browse
On Thu, 14 Dec 2023 12:39:52 GMT, Adam Sotona wrote:
> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
> method handles.
>
> This patch converts ASM calls to Classfile API.
>
> This PR is continuation of https://github.com/openjdk/jdk/pull/12945
>
> Any comments an
java.base java.lang.invoke package heavily uses ASM to generate lambdas and
method handles.
This patch converts ASM calls to Classfile API.
This PR is continuation of https://github.com/openjdk/jdk/pull/12945
Any comments and suggestions are welcome.
Please review.
Thank you,
Adam
--
On Fri, 15 Dec 2023 09:41:38 GMT, Jaikiran Pai wrote:
>> Markus KARG has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Keep transferring beyond MAX_VALUE bytes
>
> src/java.base/share/classes/java/io/SequenceInputStream.java line 249:
>
>
On 14/12/2023 10:55, Viktor Klang wrote:
I presume that the precondition to have the original collection be
pre-ordered according to the supplied Comparator can be verified by
checking before adding each element in the collection to the PQ that
it compareTo equal-or-greater to the previous one?
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
Markus KARG has updated the pull request incrementally with one additional
commit since the last revision:
Keep transferring beyond MAX_VALUE bytes
--
On Thu, 14 Dec 2023 15:00:15 GMT, Eirik Bjorsnos wrote:
> Seeing that `ReadAfterClose.java` uses a binary test vector `crash.jar`, I
> think it makes sense to include it in this PR, convert it to JUnit and move
> it into `ReadZip.readAfterClose`.
>
> This removes the last remaining binary test
On Fri, 15 Dec 2023 08:57:45 GMT, Alan Bateman wrote:
>> Serguei Spitsyn has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review: moved a couple of comments out of try blocks
>
> src/hotspot/share/prims/jvm.cpp line 4019:
>
>> 4017:
> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
> time frame.
> It is fixing a deadlock issue between `VirtualThread` class critical sections
> with the `interruptLock` (in methods: `unpark()`, `interrupt()`,
> `getAndClearInterrupt()`, `threadState()`, `toString()`)
On Mon, 11 Dec 2023 16:37:38 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a jlink mode to the JDK which doesn't
>> need the packaged modules being present. A.k.a run-time image based jlink.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>>
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
I think Jai is right, maybe we need to come up with tests that quickly check
the handling at this limit
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
src/java.base/share/classes/java/io/SequenceInputStream.java line 249:
> 247: t
On Thu, 14 Dec 2023 22:57:53 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
On Thu, 14 Dec 2023 23:04:25 GMT, Brian Burkhalter wrote:
>> Sergey Tsypanov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8320971: Revert irrelevant changes
>
> src/java.base/share/classes/java/io/BufferedInputStream.java line 646:
>
On Thu, 14 Dec 2023 22:57:53 GMT, Serguei Spitsyn wrote:
>> This fix is for JDK 23 but the intention is to back port it to 22 in RDP-1
>> time frame.
>> It is fixing a deadlock issue between `VirtualThread` class critical
>> sections with the `interruptLock` (in methods: `unpark()`, `interrupt(
On Mon, 11 Dec 2023 02:36:30 GMT, Guoxiong Li wrote:
> Hi all,
>
> This patch fixes the building failure introduced by
> [JDK-8319577](https://bugs.openjdk.org/browse/JDK-8319577) in old GCC version
> (linux & GCC 7.5.0 locally).
>
> Thanks for the review.
>
> Best Regards,
> -- Guoxiong
T
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
@bplb Kindly requesting your sponsoring. :-)
-
PR Comment: https://git.openjdk.org/jdk/pul
On Fri, 15 Dec 2023 05:15:17 GMT, David Holmes wrote:
>> Any non-zero exit value is acceptable. The intent here is to check that the
>> process didn't complete normally.
>
> A non-zero non-crashing value. Just wondering what that actually would be?
For instance, when we exit due to an uncaught
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
Marked as reviewed by alanb (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/1711
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
Marked as reviewed by vsitnikov (no project role).
-
PR Review: https://git.openjdk.org/jd
Fixes JDK-8322141
As suggested by @vlsi and documented by @bplb this PR does not return, but only
sets the maximum result value.
-
Commit messages:
- Fixes JDK-8322141
Changes: https://git.openjdk.org/jdk/pull/17119/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=17119&ran
On Thu, 14 Dec 2023 20:21:10 GMT, Vladimir Sitnikov
wrote:
>>> What do you think?
>>
>> I think that you are looking at an obsolete repository:
>>
>> https://github.com/openjdk/jdk/blob/c328f9589ddc3a981a2c63801bd991f8e593e69f/src/java.base/share/classes/java/io/InputStream.java#L802
>
> I mea
On Fri, 15 Dec 2023 08:23:58 GMT, Markus KARG wrote:
> Fixes JDK-8322141
>
> As suggested by @vlsi and documented by @bplb this PR does not return, but
> only sets the maximum result value.
@bplb Kindly requesting your review.
-
PR Comment: https://git.openjdk.org/jdk/pull/17119#
On Thu, 14 Dec 2023 23:17:41 GMT, Brian Burkhalter wrote:
>> IMHO @vlsi is right. It is incorrect that we stop the transfer in the
>> overflow case. We should fix it as he suggested. I can do that if you like.
>
> Right, the base class. The suggested change was made for `InputStream` in
> 254d6
63 matches
Mail list logo
