On Mon, 13 Nov 2023 04:38:35 GMT, David Holmes wrote:
> As discussed in JBS all platforms (some tweaks to Zero are in progress)
> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
> out the locked-based alternatives to using it and just add a guarantee that
> it is tr
On Thu, 23 Nov 2023 12:09:27 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it i
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
test/jdk/java/awt/print/PrinterJob/PrintAllFon
On Thu, 23 Nov 2023 11:27:08 GMT, Alexey Ivanov wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> test/jdk/java/awt/print/PageFormat/
On Fri, 17 Nov 2023 23:14:18 GMT, Srinivas Vamsi Parasa
wrote:
>> Hello Vamsi (@vamsi-parasa),
>>
>> Thank you very much for benchmarking, I appreciate your efforts!
>>
>> I looked at non-parallel sorting when radix sort is switched off
>> (DualPivotQuicksort_RadixForParallel) and cannot expl
On Thu, 16 Nov 2023 19:00:57 GMT, Mandy Chung wrote:
> It'd be helpful if you write down your proposed behavior for each plugin for
> discussion. Otherwise, we will have to find out from the code.
Here it goes. This was a *very* useful exercise and uncovered some bugs.
Fundamentally, each plug
On Thu, 23 Nov 2023 11:53:08 GMT, Alexey Ivanov wrote:
> Having said the above, this test requires its own bug to fix the test.
I submitted [JDK-8320671](https://bugs.openjdk.org/browse/JDK-8320671):
PageFormat/SmallPaperPrinting.java needs three sets of @test tags
-
PR Review Com
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked ru
On Wed, 22 Nov 2023 19:26:40 GMT, Phil Race wrote:
> Many printing tests do not have the @printer keyword. This adds them to those
> that need it.
> I also found one test that has nothing to do with printing in the print
> folder and moved it out.
Changes requested by aivanov (Reviewer).
test
On Thu, 23 Nov 2023 17:17:34 GMT, Daniel Fuchs wrote:
>>> I see Integer.getInteger handles the obvious Exceptions, so specifying a
>>> strange value does not immediately break us.
>>
>> Oh - right. It's `Integer.getInteger`, not `Integer.parseInt` Ok, then - I
>> withdraw my first comment :-)
On Thu, 23 Nov 2023 17:14:52 GMT, Daniel Fuchs wrote:
>>> IIRC, the default agent uses / may use its own socket factories - are we
>>> still coming here even with those factories?
>>
>> We do get here, yes (not saying you can't customise your way out of getting
>> here). This is a stack from
On Thu, 23 Nov 2023 12:43:33 GMT, Kevin Walls wrote:
>>> An exception here will prevent the class from being initialized...
>>
>> Maybe we can break it, but this new property is following the same pattern I
>> think as the neighbouring file
>> src/java.rmi/share/classes/sun/rmi/transport/tcp/T
Fix uninstallation scripts in Linux installers to take action on desktop files
only if these desktop files are not owned by another package. This prevents
`xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from execution in
case of upgrades.
Borrowed helper shell script function from "
On Thu, 23 Nov 2023 16:36:28 GMT, Alexey Semenyuk wrote:
> Fix uninstallation scripts in Linux installers to take action on desktop
> files only if these desktop files are not owned by another package. This
> prevents `xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from
> execution
On Thu, 23 Nov 2023 16:23:20 GMT, Erik Österlund wrote:
>> The current logic for closing memory in panama today is susceptible to live
>> lock if we have a closing thread that wants to close the memory in a loop
>> that keeps failing, and a bunch of accessing threads that want to perform
>> ac
On Thu, 23 Nov 2023 16:34:23 GMT, Erik Österlund wrote:
>> The current logic for closing memory in panama today is susceptible to live
>> lock if we have a closing thread that wants to close the memory in a loop
>> that keeps failing, and a bunch of accessing threads that want to perform
>> ac
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> accesses as long as the memory is alive. They can both create im
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> accesses as long as the memory is alive. They can both create im
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
> Address changes from JEP 445 to JEP 463.
>
> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>
> - Don't mark class on read.
>
> - Remove reflection and annotation processing related to unnamed classes.
>
> - Simplify main method search.
Jim Laskey has updated the pull re
@bwhuang-us @mahendrachhipa
-
Commit messages:
- 8320665: update jdk_core at test/jdk/TEST.groups
- 8316121: JDK22 ATR tasks job definition updates
Changes: https://git.openjdk.org/jdk/pull/16796/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16796&range=00
Issue: https:
On Thu, 23 Nov 2023 01:41:46 GMT, Xiaohong Gong wrote:
>> As I said above, you should not mix the two together. Keep the library
>> handling for libsleef. Move the march setting to where it belongs. And
>> rename the files, functions and variables after this.
>
> OK, I see. It makes sense that
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 08:57:23 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 08:40:57 GMT, Xiaohong Gong wrote:
>> Thanks for the advice! I will take a consideration for it.
>
>> Thirdly, I do not like at all how you just come crashing in setting -march
>> like that. The -march flag is handled by FLAGS_SETUP_ABI_PROFILE.
>
> `-march=armv8-a+sve` is j
On Thu, 23 Nov 2023 11:35:47 GMT, Mark Sheppard wrote:
> In any case the change looks fine. Do you have a test c.f. bug comment
Thanks @msheppar yes I agree with the comments.
For testing I got as far as a test that often cannot see the timeout as we are
too quick for a 1ms timeout. I was thin
On Thu, 23 Nov 2023 11:14:29 GMT, Erik Österlund wrote:
> The current logic for closing memory in panama today is susceptible to live
> lock if we have a closing thread that wants to close the memory in a loop
> that keeps failing, and a bunch of accessing threads that want to perform
> access
On Thu, 23 Nov 2023 12:40:18 GMT, Kevin Walls wrote:
>> IIRC, the default agent uses / may use its own socket factories - are we
>> still coming here even with those factories?
>
>> An exception here will prevent the class from being initialized...
>
> Maybe we can break it, but this new proper
On Thu, 23 Nov 2023 11:37:12 GMT, Daniel Fuchs wrote:
>> src/java.rmi/share/classes/sun/rmi/transport/tcp/TCPDirectSocketFactory.java
>> line 46:
>>
>>> 44: private static final int connectTimeout =// default 1 minute
>>> 45: AccessController.doPrivileged((PrivilegedAction) () -
> As discussed in JBS all platforms (some tweaks to Zero are in progress)
> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
> out the locked-based alternatives to using it and just add a guarantee that
> it is true at runtime. And all platforms except some ARM variant
ClassFile API StackMapGenerator caused a NPE for a test case with invalid
sequence of instructions.
This fix simply avoids the NPE and adds StackMapsTest::testInvalidAALOADStack
Please review.
Thanks,
Adam
-
Commit messages:
- 8320618: NPE: Cannot invoke "java.lang.constant.ClassD
On Tue, 21 Nov 2023 17:57:32 GMT, Kevin Walls wrote:
> RMI Connections (in general) should use a timeout on the Socket connect call
> by default.
>
> JMX connections use RMI and some connection failures never terminate. The
> hang described in 8316649 is hard to reproduce manually: the descri
On Thu, 23 Nov 2023 11:35:11 GMT, Daniel Fuchs wrote:
>> RMI Connections (in general) should use a timeout on the Socket connect call
>> by default.
>>
>> JMX connections use RMI and some connection failures never terminate. The
>> hang described in 8316649 is hard to reproduce manually: the
On Tue, 21 Nov 2023 17:57:32 GMT, Kevin Walls wrote:
> RMI Connections (in general) should use a timeout on the Socket connect call
> by default.
>
> JMX connections use RMI and some connection failures never terminate. The
> hang described in 8316649 is hard to reproduce manually: the descri
On Wed, 22 Nov 2023 12:25:45 GMT, Alan Bateman wrote:
>> Added mirror event with static methods: jdk.internal.event.SelectionEvent
>> that provides the duration of select calls and the count of how many keys
>> are available.
>>
>> Emit the event from SelectorImpl::lockAndDoSelect
>>
>> Test
The current logic for closing memory in panama today is susceptible to live
lock if we have a closing thread that wants to close the memory in a loop that
keeps failing, and a bunch of accessing threads that want to perform accesses
as long as the memory is alive. They can both create impediment
On Tue, 21 Nov 2023 17:12:39 GMT, Doug Lea wrote:
>> This update cascades timeouts to trim subsequent workers after the first
>> keepAlive inactive period.
>
> Doug Lea has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes the unrelat
On Wed, 22 Nov 2023 15:29:08 GMT, Jim Laskey wrote:
>> Address changes from JEP 445 to JEP 463.
>>
>> - Move from a SYNTHETIC unnamed class to a MANDATED implicit class.
>>
>> - Don't mark class on read.
>>
>> - Remove reflection and annotation processing related to unnamed classes.
>>
>> - S
On Wed, 22 Nov 2023 11:32:53 GMT, Ivan Šipka wrote:
> @mahendrachhipa @bwhuang-us
This pull request has now been integrated.
Changeset: 99b9cb0a
Author:Ivan Šipka
Committer: Mark Sheppard
URL:
https://git.openjdk.org/jdk/commit/99b9cb0a2eae1196f2127cd48e4085f19a90c4b4
Stats: 10
RMI Connections (in general) should use a timeout on the Socket connect call by
default.
JMX connections use RMI and some connection failures never terminate. The hang
described in 8316649 is hard to reproduce manually: the description says it can
be caused by a firewall that never returns a r
On Wed, 22 Nov 2023 15:59:38 GMT, Christoph Langer wrote:
> java/lang/invoke/lambda/LambdaFileEncodingSerialization.java is already
> problem listed on linux-x64. However, the issue is not processor specific. We
> see the failure on linux on other architectures as well.
Makes sense to do it on
> Currently the vector floating-point math APIs like
> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
> which causes large performance gap on AArch64. Note that those APIs are
> optimized by C2 compiler on X86 platforms by calling Intel's SVML code [1].
> To close th
On Wed, 15 Nov 2023 01:32:00 GMT, Xiaohong Gong wrote:
>> Currently the vector floating-point math APIs like
>> `VectorOperators.SIN/COS/TAN...` are not intrinsified on AArch64 platform,
>> which causes large performance gap on AArch64. Note that those APIs are
>> optimized by C2 compiler on X
On Thu, 23 Nov 2023 01:28:40 GMT, Xiaohong Gong wrote:
>> Ah, now I se what you are trying to do here. First of all, in the detection
>> part, only set `SVE_FEATURE_SUPPORT`. Then you can handle the `SVE_CFLAGS`
>> addition elsewhere/later.
>>
>> Secondly, you should not mix these `SVE_CFLAGS
On Thu, 23 Nov 2023 03:14:27 GMT, David Holmes wrote:
>> As discussed in JBS all platforms (some tweaks to Zero are in progress)
>> actually do support `cx8` i.e. 64-bit compare-and-exchange, so we can strip
>> out the locked-based alternatives to using it and just add a guarantee that
>> it i
On Thu, 23 Nov 2023 08:09:44 GMT, Viktor Klang wrote:
>>> Wow! This PR is much larger than I expected.
>>>
>>> Thumbs up!
>>
>> Thanks for the Review Dan! Yes lots of code deletion engineering in this one
>> - and even better I got to delete template code with meta-programming stuff!
>> :D
>
On Thu, 23 Nov 2023 03:11:15 GMT, David Holmes wrote:
>> Wow! This PR is much larger than I expected.
>>
>> Thumbs up!
>
>> Wow! This PR is much larger than I expected.
>>
>> Thumbs up!
>
> Thanks for the Review Dan! Yes lots of code deletion engineering in this one
> - and even better I got
49 matches
Mail list logo
