Withdrawn: 8317870: Add @sealedGraph to Thread.Builder

2023-10-22 Thread Per Minborg
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote: > This PR proposes to Add @sealedGraph to `Thread.Builder`. This pull request has been closed without being integrated. - PR: https://git.openjdk.org/jdk/pull/16138

Re: RFR: 8317870: Add @sealedGraph to Thread.Builder

2023-10-22 Thread Per Minborg
On Wed, 11 Oct 2023 07:52:54 GMT, Per Minborg wrote: > This PR proposes to Add @sealedGraph to `Thread.Builder`. I will close this PR as the taglet was not deemed to be helpful here. - PR Comment: https://git.openjdk.org/jdk/pull/16138#issuecomment-1774522674

Re: RFR: 8317846: Typo in API documentation of classes IdentityHashMap [v2]

2023-10-22 Thread Jaikiran Pai
On Wed, 11 Oct 2023 05:29:22 GMT, ANUPAM DEV wrote: >> Hello, >> >> I have fixed the typo in the comment for the constructor >> IdentityHashMap(Map m) >> >> before: Constructs a new identity hash map containing the keys-value >> mappings in the specified map. >> after: Constructs a new identi

Integrated: 8317868: Add @sealedGraph to MethodHandleDesc and descendants

2023-10-22 Thread Per Minborg
On Wed, 11 Oct 2023 07:45:17 GMT, Per Minborg wrote: > This PR proposes to add @sealedGraph to MethodHandleDesc and descendants. This pull request has now been integrated. Changeset: ffadd635 Author:Per Minborg URL: https://git.openjdk.org/jdk/commit/ffadd635759d0898cd108f5fe5fe3a4

Re: RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal [v3]

2023-10-22 Thread Joe Darcy
> Add informative notes to BigInteger and BigDecimal about possible running > times, etc. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Fix typo. - Changes: - all: https://git.openjdk.org/jdk/pull/16298/files - new:

Re: RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal [v2]

2023-10-22 Thread Joe Darcy
> Add informative notes to BigInteger and BigDecimal about possible running > times, etc. Joe Darcy has updated the pull request incrementally with one additional commit since the last revision: Respond to review feedback. - Changes: - all: https://git.openjdk.org/jdk/pull/162

Re: RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal

2023-10-22 Thread Joe Darcy
On Sun, 22 Oct 2023 11:22:27 GMT, Raffaello Giulietti wrote: >> Add informative notes to BigInteger and BigDecimal about possible running >> times, etc. > > src/java.base/share/classes/java/math/BigInteger.java line 152: > >> 150: * time of operations can screen out {@code BigInteger} values

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v11]

2023-10-22 Thread Laurent Bourgès
> * improved mixed insertion sort (makes whole sorting faster) > * introduced Radix which sort shows several times boost of performance and > has linear complexity instead of n*ln(n) > * improved merging sort for almost sorted data > * optimized parallel sorting > * improved step for pivot candid

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v9]

2023-10-22 Thread iaroslavski
On Wed, 20 Sep 2023 16:33:56 GMT, Paul Sandoz wrote: > > Hi Paul (@PaulSandoz), Alan (@AlanBateman), Any update? Do you agree with > > Radix sort in parallel case only? > > I think its definitely a better fit, but another aspect of my previous > comment was wondering if we need a radix sort if

Re: RFR: JDK-8266431: Dual-Pivot Quicksort improvements (Radix sort) [v10]

2023-10-22 Thread Laurent Bourgès
> * improved mixed insertion sort (makes whole sorting faster) > * introduced Radix which sort shows several times boost of performance and > has linear complexity instead of n*ln(n) > * improved merging sort for almost sorted data > * optimized parallel sorting > * improved step for pivot candid

Re: RFR: 8318569: Add getter methods for Locale and Patterns in ListFormat

2023-10-22 Thread Hamlin Li
On Fri, 20 Oct 2023 17:57:46 GMT, Naoto Sato wrote: > Proposing adding getter methods for `locale` and `patterns` fields in the > `ListFormat` instances. Those fields are used for `equals()`, but without the > public getter methods, users cannot tell the reasoning of the equality of two > inst

Re: RFR: JDK-8318476: Add resource consumption note to BigInteger and BigDecimal

2023-10-22 Thread Raffaello Giulietti
On Sat, 21 Oct 2023 00:56:21 GMT, Joe Darcy wrote: > Add informative notes to BigInteger and BigDecimal about possible running > times, etc. src/java.base/share/classes/java/math/BigDecimal.java line 310: > 308: * time of operations can screen out {@code BigDecimal} values with > 309: * unsc

Re: RFR: 8318027: Support alternative name to jdk.internal.vm.compiler [v4]

2023-10-22 Thread Hamlin Li
On Sat, 21 Oct 2023 10:56:01 GMT, Doug Simon wrote: >> The Graal code base has >> [renamed](https://github.com/oracle/graal/commit/1e41203d10db321f86723eac90f6cd0573b08b33) >> its module to `jdk.compiler.graal` as part of preparations for Project >> Galahad. Due to the way Java modules work, t

Re: RFR: 8317868: Add @sealedGraph to MethodHandleDesc and descendants [v2]

2023-10-22 Thread Hamlin Li
On Wed, 11 Oct 2023 11:18:41 GMT, Per Minborg wrote: >> This PR proposes to add @sealedGraph to MethodHandleDesc and descendants. > > Per Minborg has updated the pull request incrementally with two additional > commits since the last revision: > > - Update copyright year > - Revoke change in

Re: RFR: 8317846: Typo in API documentation of classes IdentityHashMap [v2]

2023-10-22 Thread Hamlin Li
On Wed, 11 Oct 2023 05:29:22 GMT, ANUPAM DEV wrote: >> Hello, >> >> I have fixed the typo in the comment for the constructor >> IdentityHashMap(Map m) >> >> before: Constructs a new identity hash map containing the keys-value >> mappings in the specified map. >> after: Constructs a new identi