Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Andrey Turbanov
On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of an enhancement that replaces the use of ASM with >> the new Class-File API. This change only deals with bytecode that writes >> event data into buffers. Bytecode transformations carried out by classes in

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Erik Gahlin
On Mon, 16 Oct 2023 05:56:00 GMT, Chen Liang wrote: >> I could not get it to work with findAttribute. No annotations were found. > > The existing code will silently finish the loop no-op and return `null` if no > RVAA is present. So if `findAttribute` returns `Optional.empty()`, you should > ju

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Erik Gahlin
On Mon, 16 Oct 2023 06:01:01 GMT, Chen Liang wrote: >> Erik Gahlin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updates > > src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 256: > >> 254:

Re: RFR: 8318126: Refresh manpages

2023-10-15 Thread Alan Bateman
On Mon, 16 Oct 2023 01:18:52 GMT, David Holmes wrote: > The open nroff manpage files are out of sync with their closed markdown > sources and need to be refreshed. > > The changes to apply are coming from: > > - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor > to ea

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Chen Liang
On Mon, 16 Oct 2023 05:07:42 GMT, Erik Gahlin wrote: >> Hi, >> >> Could I have a review of an enhancement that replaces the use of ASM with >> the new Class-File API. This change only deals with bytecode that writes >> event data into buffers. Bytecode transformations carried out by classes in

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Chen Liang
On Mon, 16 Oct 2023 05:02:01 GMT, Erik Gahlin wrote: >> src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line >> 204: >> >>> 202: String typeDescriptor = classDesc.descriptorString(); >>> 203: for (ClassElement ce : classModel.elements()) { >>> 204:

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Erik Gahlin
> Hi, > > Could I have a review of an enhancement that replaces the use of ASM with the > new Class-File API. This change only deals with bytecode that writes event > data into buffers. Bytecode transformations carried out by classes in > jdk.jfr.internal.intrument package are kept as is. Plan

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API [v2]

2023-10-15 Thread Erik Gahlin
On Sun, 15 Oct 2023 23:45:05 GMT, Chen Liang wrote: >> Erik Gahlin has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Updates > > src/jdk.jfr/share/classes/jdk/jfr/internal/EventInstrumentation.java line 204: > >> 202: String typeD

Re: RFR: 8318058: Notify the jvm when the direct memory is oom

2023-10-15 Thread xpbob
On Fri, 13 Oct 2023 05:26:37 GMT, Thomas Stuefe wrote: >> Big data processes often experience situations where the direct memory oom >> process is alive but not serving properly. If the direct memory is oom, code >> can notify the jvm. Can bring the following benefits: >> 1. Analysis of direct

Withdrawn: 8318058: Notify the jvm when the direct memory is oom

2023-10-15 Thread xpbob
On Fri, 13 Oct 2023 03:23:04 GMT, xpbob wrote: > Big data processes often experience situations where the direct memory oom > process is alive but not serving properly. If the direct memory is oom, code > can notify the jvm. Can bring the following benefits: > 1. Analysis of direct memory Java.

RFR: 8318126: Refresh manpages

2023-10-15 Thread David Holmes
The open nroff manpage files are out of sync with their closed markdown sources and need to be refreshed. The changes to apply are coming from: - [JDK-8288158](https://bugs.openjdk.org/browse/JDK-8288158): Add an anchor to each subcommand option on jfr html page - [JDK-8273131](https://bugs.ope

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API

2023-10-15 Thread Erik Gahlin
On Sun, 15 Oct 2023 23:34:01 GMT, Chen Liang wrote: >> Hi, >> >> Could I have a review of an enhancement that replaces the use of ASM with >> the new Class-File API. This change only deals with bytecode that writes >> event data into buffers. Bytecode transformations carried out by classes in

Re: RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API

2023-10-15 Thread Chen Liang
On Sun, 15 Oct 2023 20:20:48 GMT, Erik Gahlin wrote: > Hi, > > Could I have a review of an enhancement that replaces the use of ASM with the > new Class-File API. This change only deals with bytecode that writes event > data into buffers. Bytecode transformations carried out by classes in > j

RFR: 8318124: JFR: Rewrite instrumentation to use Class-File API

2023-10-15 Thread Erik Gahlin
Hi, Could I have a review of an enhancement that replaces the use of ASM with the new Class-File API. This change only deals with bytecode that writes event data into buffers. Bytecode transformations carried out by classes in jdk.jfr.internal.intrument package are kept as is. Plan is to try to

Re: RFR: 8315585: Optimization for decimal to string [v6]

2023-10-15 Thread Shaojin Wen
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i also

Re: RFR: 8315585: Optimization for decimal to string [v6]

2023-10-15 Thread Claes Redestad
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote: >> I submitted PR #1 before, and there were too many changes. I split it >> into multiple PRs with small changes. This one is one of them. >> >> this PR removed the duplicate code for getChars in >> BigDecimal#StringBuilderHelper, i also

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v11]

2023-10-15 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with one additional commit since the last revision: Corrected use of whitespace in text block. - Changes: - all: https://git.openjdk.org/jdk/pull/13537

Re: RFR: JDK-8077371: Binary files in JAXP test should be removed [v10]

2023-10-15 Thread Mahendra Chhipa
> Test is updated to create the binary files during test execution. Mahendra Chhipa has updated the pull request incrementally with two additional commits since the last revision: - Removed commented code. - Use of HexFormatter clas instead of Formatter. Addition of copyright section in aut

Re: RFR: 8309130: x86_64 AVX512 intrinsics for Arrays.sort methods (int, long, float and double arrays) [v42]

2023-10-15 Thread himichael
On Sat, 14 Oct 2023 03:21:52 GMT, himichael wrote: >>> my question is that this feature should improve performance several times, >>> but it doesn't look like there's much difference between open jdk 22.19 and >>> jdk 8. is there a problem with my configuration ? >> >> Hello @himichael, >> >>