On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i also
On Sat, 14 Oct 2023 03:21:52 GMT, himichael wrote:
>>> my question is that this feature should improve performance several times,
>>> but it doesn't look like there's much difference between open jdk 22.19 and
>>> jdk 8. is there a problem with my configuration ?
>>
>> Hello @himichael,
>>
>>
On Fri, 13 Oct 2023 23:59:55 GMT, Srinivas Vamsi Parasa
wrote:
> > my question is that this feature should improve performance several times,
> > but it doesn't look like there's much difference between open jdk 22.19 and
> > jdk 8. is there a problem with my configuration ?
>
> Hello @himich
On Fri, 13 Oct 2023 10:31:14 GMT, himichael wrote:
> my question is that this feature should improve performance several times,
> but it doesn't look like there's much difference between open jdk 22.19 and
> jdk 8. is there a problem with my configuration ?
Hello @himichael,
Using your code s
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i also
On Fri, 13 Oct 2023 10:31:14 GMT, himichael wrote:
>> @himichael Please refer to [this
>> question](https://stackoverflow.com/questions/504103/how-do-i-write-a-correct-micro-benchmark-in-java)
>> for how to correctly benchmark Java code.
>
>> @himichael Please refer to [this
>> question](https
On Fri, 13 Oct 2023 15:37:00 GMT, Maurizio Cimadamore
wrote:
> This PR makes sure that `MemorySegment` is initialized *before* any of its
> subclasses.
> This is done by centralizing all the memory segment factories in a single
> implementation class (`SegmentFactories`).
> Doing so addresses
On Tue, 3 Oct 2023 22:23:11 GMT, Justin Lu wrote:
> Please review this PR which refactors a number of tests under
> `test/text/NumberFormat` to use JUnit.
>
> During the switch to JUnit, the tests had the following updates (to improve
> readability)
> - separate the test data generation from t
On Fri, 13 Oct 2023 17:01:11 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i also
On Tue, 10 Oct 2023 17:58:12 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/901
>
> Original PR body:
>
>> This PR adds more javadoc to explain how base offsets in var handles
>> obtained from layouts can be used.
>>
>> First, a number of examples in the mai
On Tue, 10 Oct 2023 21:41:01 GMT, Jorn Vernee wrote:
> Port of miscellaneous leftover implementation-only changes from the
> panama-foreign repo:
>
> These four related to improving the performance of the internal `strlen`
> implementation:
>
> - https://github.com/openjdk/panama-foreign/pu
On Fri, 13 Oct 2023 08:00:07 GMT, Jorn Vernee wrote:
> Implement missing by-reference argument acquire/release functionality in
> DowncallLinker::invokeInterpBindings.
>
> I've also simplified the related code a bit:
> - `retIndexMap` was not used. I've removed it
> - `BindingInterpreter.StoreF
On Fri, 13 Oct 2023 17:31:15 GMT, Maurizio Cimadamore
wrote:
>> This PR makes sure that `MemorySegment` is initialized *before* any of its
>> subclasses.
>> This is done by centralizing all the memory segment factories in a single
>> implementation class (`SegmentFactories`).
>> Doing so addre
> This PR makes sure that `MemorySegment` is initialized *before* any of its
> subclasses.
> This is done by centralizing all the memory segment factories in a single
> implementation class (`SegmentFactories`).
> Doing so addresses a possible deadlock condition when using multiple threads.
Maur
On Fri, 13 Oct 2023 17:25:03 GMT, Maurizio Cimadamore
wrote:
>> This PR makes sure that `MemorySegment` is initialized *before* any of its
>> subclasses.
>> This is done by centralizing all the memory segment factories in a single
>> implementation class (`SegmentFactories`).
>> Doing so addre
On Fri, 13 Oct 2023 17:16:09 GMT, Maurizio Cimadamore
wrote:
>> This PR is based on a port of: openjdk/panama-foreign#898
>>
>> Some additional changes are contained in this PR:
>>
>> * instead of using a different "always alive" scope for zero-length memory
>> segments, we now use the global
On Fri, 13 Oct 2023 17:10:48 GMT, Maurizio Cimadamore
wrote:
>> This PR is based on a port of: openjdk/panama-foreign#898
>>
>> Some additional changes are contained in this PR:
>>
>> * instead of using a different "always alive" scope for zero-length memory
>> segments, we now use the global
> This PR is based on a port of: openjdk/panama-foreign#898
>
> Some additional changes are contained in this PR:
>
> * instead of using a different "always alive" scope for zero-length memory
> segments, we now use the global scope
> * the javadoc for `MemorySegment::ofArray`, `MemorySegment::o
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote:
>> Port of miscellaneous leftover implementation-only changes from the
>> panama-foreign repo:
>>
>> These four related to improving the performance of the internal `strlen`
>> implementation:
>>
>> - https://github.com/openjdk/panama-for
On Fri, 13 Oct 2023 15:37:00 GMT, Maurizio Cimadamore
wrote:
> This PR makes sure that `MemorySegment` is initialized *before* any of its
> subclasses.
> This is done by centralizing all the memory segment factories in a single
> implementation class (`SegmentFactories`).
> Doing so addresses
> I submitted PR #1 before, and there were too many changes. I split it
> into multiple PRs with small changes. This one is one of them.
>
> this PR removed the duplicate code for getChars in
> BigDecimal#StringBuilderHelper, i also make performance faster.
> Please review and don't hesitate
On Fri, 13 Oct 2023 15:39:06 GMT, Maurizio Cimadamore
wrote:
>> This PR is based on a port of: openjdk/panama-foreign#898
>>
>> Some additional changes are contained in this PR:
>>
>> * instead of using a different "always alive" scope for zero-length memory
>> segments, we now use the global
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote:
>> Port of miscellaneous leftover implementation-only changes from the
>> panama-foreign repo:
>>
>> These four related to improving the performance of the internal `strlen`
>> implementation:
>>
>> - https://github.com/openjdk/panama-for
On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Tests with base64 input are removed.
test/jdk
On Fri, 13 Oct 2023 12:18:41 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
This PR makes sure that `MemorySegment` is initialized *before* any of its
subclasses.
This is done by centralizing all the memory segment factories in a single
implementation class (`SegmentFactories`).
Doing so addresses a possible deadlock condition when using multiple threads.
-
Hi all, please review this changes into risc-v floating point copysign and
signum intrinsics.
CopySign - returns first argument with the sign of second. On risc-v we have
`fsgnj.x` instruction, which can implement this intrinsic.
Signum - returns input value if it is +/- 0.0 or NaN, otherwise 1.0
On Fri, 13 Oct 2023 12:21:28 GMT, Mahendra Chhipa wrote:
>> Test is updated to create the binary files during test execution.
>
> Mahendra Chhipa has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Tests with base64 input are removed.
test/jdk
> This PR is based on a port of: openjdk/panama-foreign#898
>
> Some additional changes are contained in this PR:
>
> * instead of using a different "always alive" scope for zero-length memory
> segments, we now use the global scope
> * the javadoc for `MemorySegment::ofArray`, `MemorySegment::o
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote:
>> Port of miscellaneous leftover implementation-only changes from the
>> panama-foreign repo:
>>
>> These four related to improving the performance of the internal `strlen`
>> implementation:
>>
>> - https://github.com/openjdk/panama-for
On Fri, 13 Oct 2023 12:18:59 GMT, Jorn Vernee wrote:
>> Port of miscellaneous leftover implementation-only changes from the
>> panama-foreign repo:
>>
>> These four related to improving the performance of the internal `strlen`
>> implementation:
>>
>> - https://github.com/openjdk/panama-for
On Fri, 13 Oct 2023 14:28:58 GMT, Jorn Vernee wrote:
>>> Just to clarify, is the ABI equal to what is described in this table:
>>> https://www.ibm.com/docs/en/xl-c-and-cpp-aix/16.1?topic=data-using-alignment-modes
>>> ?
>>>
>>> This shows `double` having 8-byte alignment, but being 4-byte alig
This PR is based on a port of: openjdk/panama-foreign#898
Some additional changes are contained in this PR:
* instead of using a different "always alive" scope for zero-length memory
segments, we now use the global scope
* the javadoc for `MemorySegment::ofArray`, `MemorySegment::ofBuffer` and
On Fri, 13 Oct 2023 13:39:11 GMT, Martin Doerr wrote:
>> Just to clarify, is the ABI equal to what is described in this table:
>> https://www.ibm.com/docs/en/xl-c-and-cpp-aix/16.1?topic=data-using-alignment-modes
>> ?
>>
>> This shows `double` having 8-byte alignment, but being 4-byte aligned
On Fri, 13 Oct 2023 14:03:34 GMT, Martin Doerr wrote:
>>> Okay, so it sounds like Java double on AIX is still 8-byte aligned, but the
>>> native double is 4-byte aligned?
>>
>> Correct within structures. I believe they are always 8-byte aligned except
>> in structures which are packed more den
Hello all, I'm new to the mailing list.
This week I've run into an issue that was already reported here:
https://bugs.openjdk.org/browse/JDK-8176407
JDK-8176407 is actually a clone of JDK-8072582, which was fixed but
then partially reverted because according to Xueming Shen, it
"triggered the reg
On Tue, 10 Oct 2023 17:17:00 GMT, Jorn Vernee wrote:
> Port of: https://github.com/openjdk/panama-foreign/pull/898
>
> Original PR body:
>
>>
>> This patch addresses some issues with `MemorySegment.Scope::equals`. More
>> specifically, when two segments are created from the same array/buffer,
On Fri, 13 Oct 2023 13:37:10 GMT, Jorn Vernee wrote:
>>> I guess changing it would probably be better?
>>
>> Yeah, I think so.
>>
>>> Note that we will need something which maps to the 8-Byte aligned double.
>>> Otherwise we get an Exception when passing a JAVA_DOUBLE as normal argument.
>>
>
On Fri, 13 Oct 2023 13:02:24 GMT, Jorn Vernee wrote:
>> Not sure how `jdouble` would be used. JNI doesn't support C structures and
>> the double alignment is only an issue in structures. Do we support embedding
>> `jdouble` in structures? I guess changing it would probably be better?
>> Note th
On Fri, 13 Oct 2023 12:34:53 GMT, Martin Doerr wrote:
> I guess changing it would probably be better?
Yeah, I think so.
> Note that we will need something which maps to the 8-Byte aligned double.
> Otherwise we get an Exception when passing a JAVA_DOUBLE as normal argument.
Okay, so it sounds
On Thu, 12 Oct 2023 21:49:00 GMT, Shaojin Wen wrote:
>> I submitted PR #1 before, and there were too many changes. I split it
>> into multiple PRs with small changes. This one is one of them.
>>
>> this PR removed the duplicate code for getChars in
>> BigDecimal#StringBuilderHelper, i also
On Fri, 13 Oct 2023 10:24:58 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve micro benchmarks and a comment.
>
> src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/aix/AixPPC64Linke
On Fri, 13 Oct 2023 10:21:06 GMT, Jorn Vernee wrote:
>> Martin Doerr has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improve micro benchmarks and a comment.
>
> test/micro/org/openjdk/bench/java/lang/foreign/CLayouts.java line 68:
>
>>
On Fri, 13 Oct 2023 11:32:09 GMT, Jorn Vernee wrote:
>> Port of miscellaneous leftover implementation-only changes from the
>> panama-foreign repo:
>>
>> These four related to improving the performance of the internal `strlen`
>> implementation:
>>
>> - https://github.com/openjdk/panama-for
> Please review this PR as a fix of
> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
> bug with after @ignore annotation.
Agnibho Hom Chowdhury has updated the pull request incrementally with one
additional commit since the last revision:
reverted copyright year
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
> Test is updated to create the binary files during test execution.
Mahendra Chhipa has updated the pull request incrementally with one additional
commit since the last revision:
Tests with base64 input are removed.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/13537/files
On Thu, 12 Oct 2023 14:18:16 GMT, Agnibho Hom Chowdhury
wrote:
>> Please review this PR as a fix of
>> [JDK-8249832](https://bugs.openjdk.org/browse/JDK-8249832). I have added the
>> bug with after @ignore annotation.
>
> Agnibho Hom Chowdhury has updated the pull request incrementally with on
On Tue, 10 Oct 2023 21:41:01 GMT, Jorn Vernee wrote:
> Port of miscellaneous leftover implementation-only changes from the
> panama-foreign repo:
>
> These four related to improving the performance of the internal `strlen`
> implementation:
>
> - https://github.com/openjdk/panama-foreign/pu
> Port of miscellaneous leftover implementation-only changes from the
> panama-foreign repo:
>
> These four related to improving the performance of the internal `strlen`
> implementation:
>
> - https://github.com/openjdk/panama-foreign/pull/862
> - https://github.com/openjdk/panama-foreign/
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment. This PR is based on JDK22 version
> of the FFI.
Martin Doerr has updated the pull request incrementally with one additional
commit since the last revision:
Improve micro
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
minor test edits and comment updates
-
Change
> VarHandle implementations have many static fields and methods that can be
> pulled to the common superclass to avoid repeated initialization and code
> duplication.
>
> In addition, the Unsafe-based Buffer field access are replaced by usage of
> public methods or JavaNioAccess.
Chen Liang ha
On Fri, 13 Oct 2023 08:00:07 GMT, Jorn Vernee wrote:
> Implement missing by-reference argument acquire/release functionality in
> DowncallLinker::invokeInterpBindings.
>
> I've also simplified the related code a bit:
> - `retIndexMap` was not used. I've removed it
> - `BindingInterpreter.StoreF
On Fri, 13 Oct 2023 08:17:58 GMT, Quan Anh Mai wrote:
> @himichael Please refer to [this
> question](https://stackoverflow.com/questions/504103/how-do-i-write-a-correct-micro-benchmark-in-java)
> for how to correctly benchmark Java code.
thanks for your reply, but I think this has nothing t
The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
double values have only 4 Byte alignment.
-
Commit messages:
- Change double alignment to 4 in tests.
- 8317545: AIX PPC64: Implementation of Foreign Function & Memory API
Changes: https://git.openjdk.org
On Fri, 13 Oct 2023 10:12:24 GMT, Martin Doerr wrote:
> The AIX linker has a few minor diffs to the linux ABIv1 linker. In addition,
> double values have only 4 Byte alignment. This PR is based on JDK22 version
> of the FFI.
src/java.base/share/classes/jdk/internal/foreign/abi/ppc64/aix/AixPPC
On Wed, 11 Oct 2023 15:43:19 GMT, Aggelos Biboudis
wrote:
>> This is the first draft of a patch for Primitive types in patterns,
>> instanceof, and switch (Preview).
>>
>> Draft spec here:
>> https://cr.openjdk.org/~abimpoudis/instanceof/jep443-20231010/specs/instanceof-jls.html
>
> Aggelos B
Implement missing by-reference argument acquire/release functionality in
DowncallLinker::invokeInterpBindings.
I've also simplified the related code a bit:
- `retIndexMap` was not used. I've removed it
- `BindingInterpreter.StoreFunc::store`'s type argument was not used. Removed
- UpcallLinker wa
On Fri, 13 Oct 2023 08:45:07 GMT, Sean Coffey wrote:
>> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
>> objects aren't created for the same zip file.
>
> Sean Coffey has updated the pull request incrementally with one additional
> commit since the last revision:
> Fix up java.util.zip.ZipFile$Source hashCode() impl so that duplicate Source
> objects aren't created for the same zip file.
Sean Coffey has updated the pull request incrementally with one additional
commit since the last revision:
insert back lastmodified check. enhance testcase. more revi
On Thu, 5 Oct 2023 10:02:05 GMT, Joachim Kern wrote:
> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
> in TreeTest.test5.
> The reason is: Previously the implementation based on the /proc file system
> lead to double pids in the child list; at least intermittent.
On Fri, 13 Oct 2023 07:02:18 GMT, himichael wrote:
>> Srinivas Vamsi Parasa has updated the pull request with a new target base
>> due to a merge or a rebase. The pull request now contains 45 commits:
>>
>> - fix code style and formatting
>> - Merge branch 'master' of https://git.openjdk.java
On Thu, 5 Oct 2023 23:36:48 GMT, Srinivas Vamsi Parasa wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Thu, 20 Jul 2023 01:11:43 GMT, Glavo wrote:
> The changes to `Arrays.hashCode(Object[])` in JDK-8312164 caused its
> performance is reduced by about 80%.
>
> This PR reverts this change.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org
On Thu, 12 Oct 2023 09:30:09 GMT, Joachim Kern wrote:
>> We see rather often failures in java/lang/ProcessHandle/TreeTest.java on AIX
>> in TreeTest.test5.
>> The reason is: Previously the implementation based on the /proc file system
>> lead to double pids in the child list; at least intermitt
66 matches
Mail list logo
