Re: RFR: 8308753: Class-File API transition to Preview [v12]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread Adam Sotona
On Tue, 3 Oct 2023 18:55:36 GMT, ExE Boss wrote: >> Adam Sotona has updated the pull request incrementally with three additional >> commits since the last revision: >> >> - fixed case in the test text >> - fixing javadoc >> - Unified implementations of InvokeInstruction::count, fixed javadoc

Re: RFR: 8314544: Matrix multiple benchmark using Vector API

2023-10-03 Thread Sandhya Viswanathan
On Mon, 21 Aug 2023 03:50:32 GMT, Martin Stypinski wrote: >> Added a bunch of different implementations for Vector API Matrix >> Multiplications: >> >> - Baseline >> - Blocked (Cache Local) >> - FMA >> - Vector API Simple Implementation >> - Vector API Blocked Implementation >> >> Commit was d

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread ExE Boss
On Tue, 3 Oct 2023 14:11:08 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8180892: Correct handling of annotations on parameters [v2]

2023-10-03 Thread Chen Liang
On Thu, 27 Apr 2023 23:42:54 GMT, Joe Darcy wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix assuming match without MethodParameters for type annotations, move >> implementation related to getAnnotatedParameterTy

Integrated: 8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.

2023-10-03 Thread Naoto Sato
On Mon, 2 Oct 2023 16:59:00 GMT, Naoto Sato wrote: > A simple clarification of the conditions for throwing an IAE. This pull request has now been integrated. Changeset: 1809b8cd Author:Naoto Sato URL: https://git.openjdk.org/jdk/commit/1809b8cdd6f27fd2f19072a874f5020ca717ad11 Stats:

Re: RFR: 8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.

2023-10-03 Thread Joe Wang
On Mon, 2 Oct 2023 16:59:00 GMT, Naoto Sato wrote: > A simple clarification of the conditions for throwing an IAE. Marked as reviewed by joehw (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16013#pullrequestreview-1655850720

Integrated: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest

2023-10-03 Thread Justin Lu
On Thu, 28 Sep 2023 01:02:46 GMT, Justin Lu wrote: > Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `

Re: RFR: JDK-8316696: Remove the testing base classes: IntlTest and CollatorTest [v6]

2023-10-03 Thread Justin Lu
> Please review this PR which removes the i18n related testing base classes > `IntlTest` and `CollatorTest` and converts all the tests that use them, > > IntlTest and CollatorTest are testing classes which are extended by tests in > `text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. T

Integrated: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-10-03 Thread Swati Sharma
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of the benchmarks scalabili

Integrated: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi

2023-10-03 Thread Jiangli Zhou
On Tue, 3 Oct 2023 02:19:00 GMT, Jiangli Zhou wrote: > Please help review this trivial change that adds missing > DEF_STATIC_JNI_OnLoad for librmi. > > Thanks This pull request has now been integrated. Changeset: ae796a4e Author:Jiangli Zhou URL: https://git.openjdk.org/jdk/commit

Re: RFR: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi [v2]

2023-10-03 Thread Jiangli Zhou
On Tue, 3 Oct 2023 06:08:20 GMT, Alan Bateman wrote: > Surprised this one didn't have DEF_STATIC_JNI_OnLoad already. Change looks > okay, can you update the copyright date before integrating. Thanks for the review! Updated copyright year as you suggested. - PR Comment: https://git

Re: RFR: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi [v2]

2023-10-03 Thread Jiangli Zhou
> Please help review this trivial change that adds missing > DEF_STATIC_JNI_OnLoad for librmi. > > Thanks Jiangli Zhou has updated the pull request incrementally with one additional commit since the last revision: Update copyright year as suggested by @AlanBateman. - Changes:

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Tue, 3 Oct 2023 13:19:18 GMT, Aggelos Biboudis wrote: >> src/jdk.compiler/share/classes/com/sun/tools/javac/code/Types.java line 5052: >> >>> 5050: >>> 5051: return (source.isPrimitive() && target.isPrimitive()) && >>> 5052: ((source.hasTag(BYTE) && !target.hasTag(CH

Re: RFR: 8314085: Fixing scope from benchmark to thread for JMH tests having shared state

2023-10-03 Thread Eric Caspole
On Thu, 10 Aug 2023 15:30:19 GMT, Swati Sharma wrote: > In addition to the issue > [JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing > the scope from benchmark to thread for below benchmark files having shared > state, also which fixes few of the benchmarks scalabili

Re: RFR: 8308753: Class-File API transition to Preview [v11]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/classfiles/attributes/SourceFile/NoSourceFileAttribute.java >

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 389: > >> 387: *

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:54:22 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 259: > >> 257: *

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v4]

2023-10-03 Thread Aggelos Biboudis
> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request incrementally with one addit

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Aggelos Biboudis
On Tue, 3 Oct 2023 09:58:11 GMT, Maurizio Cimadamore wrote: >> Aggelos Biboudis has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/package-info.java line 273: > >> 271: *

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:50:56 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java >> line 67: >> >>> 65: >>> 66: /** >>> 67: * {@return for an {@code invokeinterface}, the {@code count} >>> value, as defined in {@jvms 6

Re: RFR: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi

2023-10-03 Thread Alan Bateman
On Tue, 3 Oct 2023 02:19:00 GMT, Jiangli Zhou wrote: > Please help review this trivial change that adds missing > DEF_STATIC_JNI_OnLoad for librmi. > > Thanks Marked as reviewed by alanb (Reviewer). - PR Review: https://git.openjdk.org/jdk/pull/16020#pullrequestreview-1654871269

Re: RFR: 8316971: Add Lint warning for restricted method calls [v4]

2023-10-03 Thread Maurizio Cimadamore
> This patch adds a new lint warning category, namely `-Xlint:restricted` to > enable warnings on restricted method calls. > > The patch is relatively straightforward: javac marks methods that are marked > with the `@Restricted` annotation with a corresponding internal flag. This is > done both

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Tue, 3 Oct 2023 08:58:55 GMT, Maurizio Cimadamore wrote: >> Aggelos Biboudis has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8308753: Class-File API transition to Preview [v10]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

2023-10-03 Thread Maurizio Cimadamore
On Mon, 2 Oct 2023 17:42:39 GMT, Maurizio Cimadamore wrote: >> Aggelos Biboudis has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains four additional

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:46:53 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/instruction/CharacterRange.java > line 77

Re: RFR: 8308753: Class-File API transition to Preview [v9]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

2023-10-03 Thread Adam Sotona
On Mon, 2 Oct 2023 13:38:18 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/attribute/package-info.java > line 27: >

RFR: 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch

2023-10-03 Thread Gergö Barany
This test requires certain methods to be compiled, but without `-Xbatch` the compiler races against the test code, which can lead to intermittent failures. - Commit messages: - 8315680: java/lang/ref/ReachabilityFenceTest.java should run with -Xbatch Changes: https://git.openjdk.or

Re: RFR: 8308753: Class-File API transition to Preview [v8]

2023-10-03 Thread Adam Sotona
> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: New method on java.util.function.Function -- ternary method

2023-10-03 Thread David Alayachew
Whoops, bad import. Please replace the following line with the one after it. > import java.util.function.Function; > import java.util.function.*; On Tue, Oct 3, 2023 at 3:09 AM David Alayachew wrote: > Hello all, > > I have an idea that I want to run by you all -- a new method on > java.util.

New method on java.util.function.Function -- ternary method

2023-10-03 Thread David Alayachew
Hello all, I have an idea that I want to run by you all -- a new method on java.util.function.Function to capture ternary operations. Here is a mockup of what I wanted to do. > > import java.util.function.Function; > > @FunctionalInterface > public interface Function2 extends Function > { > >