Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v6]

On Mon, 2 Oct 2023 23:12:24 GMT, Brian Burkhalter wrote: > remove stripLongOrUNCPrefix() except in normalize() I haven't had time to look at the test changes yet but the I think the code changes look okay so I think go ahead and create the CSR as this behavior change will need to be tracked.

Re: RFR: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi

On Tue, 3 Oct 2023 02:19:00 GMT, Jiangli Zhou wrote: > Please help review this trivial change that adds missing > DEF_STATIC_JNI_OnLoad for librmi. > > Thanks Surprised this one didn't have DEF_STATIC_JNI_OnLoad already. Change looks okay, can you update the copyright date before integrating.

Re: An error will be reported when compiling the master on OrangeP5 Plus

Moving to hotspot-runtime-dev as this is a VM crash with compressed Oops. David On 1/10/2023 10:49 am, 温绍锦(高铁) wrote: An error will be reported when compiling the master on OrangeP5 Plus (http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/details/Orange-Pi-5-plus.html

RFR: 8316923: Add DEF_STATIC_JNI_OnLoad for librmi

Please help review this trivial change that adds missing DEF_STATIC_JNI_OnLoad for librmi. Thanks - Commit messages: - 8316923: Add DEF_STATIC_JNI_OnLoad for librmi Changes: https://git.openjdk.org/jdk/pull/16020/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16020&range=

Re: RFR: 8287843: File::getCanonicalFile doesn't work for \?\C:\ style paths DOS device paths [v6]

> In the Windows implementation of java.io.File.getCanonicalPath, strip any > long path or UNC prefix before canonicalizing the remainder of the pathname. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 8287843: remove stripLongO

Integrated: 8317034: Remove redundant type cast in the java.util.stream package

On Wed, 27 Sep 2023 08:50:20 GMT, Mourad Abbay wrote: > Remove redundant type cast in the java.util.stream package. This pull request has now been integrated. Changeset: ad81abd2 Author:Mourad Abbay Committer: Paul Sandoz URL: https://git.openjdk.org/jdk/commit/ad81abd2dbddc47d57ec

Re: Adding appendHex method to StringBuilder

2023/10/2 10:01:10 -0400, shaojin.we...@alibaba-inc.com: > StringTemplate is great and I wish I can submit PR to improve it. But > I still think StringBuilder.appendHex is a basic API, not a formatted > API. Just like Integer.toHexString and Long.toHexString, they are very > commonly used and shoul

Re: RFR: JDK-8315064: j.text.ChoiceFormat provides no specification on quoting behavior

On Fri, 29 Sep 2023 20:46:44 GMT, Justin Lu wrote: > Please review this PR and which adjusts the pattern section of > java.text.ChoiceFormat to specify the single quote behavior within a String > pattern. > > The other Format classes that take a String pattern such as DecimalFormat, > Compact

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v46]

> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Bug Report [jpackage Packaging Issue]

luke.k...@hotmail.com 邮箱：luke.k...@hotmail.com 转发的邮件 发件人 Andrew H. Gross 日期 2023年09月30日 08:40 收件人 许轲 抄送至 vuln-rep...@openjdk.org 主题 Re: Bug Report [jpackage Packaging Issue] Hello, I read your problem description.  As I understand it, this does not appear to be a vulnerability. If you

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

On Mon, 2 Oct 2023 14:47:59 GMT, Aggelos Biboudis wrote: >> This is the first draft of a patch for Primitive types in patterns, >> instanceof, and switch (Preview). >> >> Draft spec here: >> https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html > > Aggelo

RFR: 8317265: ListFormat::format specification could be made clearer regarding handling IllegalArgumentException.

A simple clarification of the conditions for throwing an IAE. - Commit messages: - initial commit Changes: https://git.openjdk.org/jdk/pull/16013/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=16013&range=00 Issue: https://bugs.openjdk.org/browse/JDK-8317265 Stats: 2 li

Re: RFR: 8312522: Implementation of Foreign Function & Memory API [v33]

> This patch contains the implementation of the foreign linker & memory API JEP > for Java 22. The initial patch is composed of commits brought over directly > from the [panama-foreign repo](https://github.com/openjdk/panama-foreign). > The main changes found in this patch come from the followin

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 14:45:52 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line >> 107: >> >>> 105: } >>> 106: >>> 107: // this version of the code can be used when ClassFile API in not in a >>> preview >> >> Do you want to kee

Re: RFR: 8308753: Class-File API transition to Preview [v2]

On Mon, 2 Oct 2023 07:18:19 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/classfile/AnnotationElement.java line >> 34: >> >>> 32: import jdk.internal.javac.PreviewFeature; >>> 33: >>> 34: /** >> >> shouldn't we have the preview header applied to all these compilation units?

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 14:56:11 GMT, Maurizio Cimadamore wrote: >> test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java >> line 45: >> >>> 43: * @see #compileAndTest >>> 44: */ >>> 45: public class SourceFileTestBase_legacy extends TestBase { >> >> Why is t

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v45]

On Mon, 2 Oct 2023 14:51:01 GMT, Doug Lea wrote: >> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java >> failed with "InterruptedException: sleep interrupted" and related issues. >> >> This is a major ForkJoin update (and hard to review -- sorry) that finally >> addre

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 14:52:58 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/classfiles/attributes/SourceFile/SourceFileTestBase_legacy.java

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v45]

> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 14:40:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > test/langtools/tools/javac/7166455/CheckACC_STRICTFlagOnclinitTest.java line > 107: > >>

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v2]

On Fri, 29 Sep 2023 16:17:06 GMT, Raffaello Giulietti wrote: >> Aggelos Biboudis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Apply suggestions from code review >> >> Co-authored-by: Raffaello Giulietti > > I just had a reading

Re: RFR: 8303374: Compiler Implementation for Primitive types in patterns, instanceof, and switch (Preview) [v3]

> This is the first draft of a patch for Primitive types in patterns, > instanceof, and switch (Preview). > > Draft spec here: > https://cr.openjdk.org/~abimpoudis/instanceof/instanceof-20230913/specs/instanceof-jls.html Aggelos Biboudis has updated the pull request with a new target base due t

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:40:40 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/components/CodeRelabeler.java > line 71:

Re: RFR: 8308753: Class-File API transition to Preview [v7]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v6]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v5]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:26:38 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/CodeTransform.java line 101: > >> 99: >>

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:29:59 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/FieldTransform.java line 116: >> >>> 114: >>> 115: /** >>> 116: * @implSpec The default implementation returns a resolved >>> transform with all >> >> Perhaps lose the `all

Re: RFR: 8308753: Class-File API transition to Preview [v4]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe

回复：Adding appendHex method to StringBuilder

StringTemplate is great and I wish I can submit PR to improve it. But I still think StringBuilder.appendHex is a basic API, not a formatted API. Just like Integer.toHexString and Long.toHexString, they are very commonly used and should be built-in. ---

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:23:00 GMT, Maurizio Cimadamore wrote: >> src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164: >> >>> 162: >>> 163: /** >>> 164: * @implSpec >> >> Should these overridden method have `@inheritDoc` ? If not, their javadoc >> won't show mu

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:50:17 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java > line

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:24:49 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/CodeBuilder.java line 596: > >> 594:

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: Adding appendHex method to StringBuilder

It’s possible to build up and combine unprocessed RAW template snippets, then combine and process them together: static int[] val = new int[] { 2048, 31337, 0xbeefcace, 9000, 4711, 1337, 2100, 2600 }; @Benchmark public String toStringFMTCombineHex8() { var templates = new ArrayList(); f

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 13:19:48 GMT, Maurizio Cimadamore wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed javadoc typo > > src/java.base/share/classes/java/lang/classfile/ClassTransform.java line 164: > >> 162:

Re: RFR: 8308753: Class-File API transition to Preview [v3]

On Mon, 2 Oct 2023 08:34:19 GMT, Adam Sotona wrote: >> Classfile API is an internal library under package `jdk.internal.classfile`  >> in JDK 21. >> This pull request turns the Classfile API into a preview feature and moves >> it into `java.lang.classfile`. >> It repackages all uses across JDK a

回复：Adding appendHex method to StringBuilder

Using String Template FMT has better performance and better code readability. But String Template does not yet support for/while/if/switch. Is there any plan to enhance String Template to support for/while/if/switch? The following scenarios cannot be implemented using String.format or String Tem

Re: Adding appendHex method to StringBuilder

2023/10/2 7:22:55 -0400, claes.redes...@oracle.com: > I think this goes against the grain: StringBuilder is a simple builder > for non-localized unformatted output. For formatted output there’s > Formatter, String.format and, with JEP 430[1], FMT."..." to help output > string data in more advanced,

Re: Adding appendHex method to StringBuilder

I think this goes against the grain: StringBuilder is a simple builder for non-localized unformatted output. For formatted output there’s Formatter, String.format and, with JEP 430[1], FMT.”…” to help output string data in more advanced, formatted and localized ways. The latter has traditionally

Re: RFR: 8308753: Class-File API transition to Preview [v2]

On Fri, 29 Sep 2023 23:00:44 GMT, Vicente Romero wrote: >> Adam Sotona has updated the pull request incrementally with one additional >> commit since the last revision: >> >> PreviewFeature annotated with JEP 457 > > make/jdk/src/classes/build/tools/module/GenModuleInfoSource.java line 476: >

Re: RFR: 8308753: Class-File API transition to Preview [v3]

> Classfile API is an internal library under package `jdk.internal.classfile`  > in JDK 21. > This pull request turns the Classfile API into a preview feature and moves it > into `java.lang.classfile`. > It repackages all uses across JDK and tests and adds lots of missing Javadoc. > > This PR goe