On Wed, 27 Sep 2023 07:11:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8316946?
>
> Failure handler actions can specify a "successArtifacts" property value,
> which are file name(s) for which hyp
On Wed, 27 Sep 2023 07:11:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8316946?
>
> Failure handler actions can specify a "successArtifacts" property value,
> which are file name(s) for which hyp
On Fri, 9 Jun 2023 22:17:39 GMT, Naoto Sato wrote:
> This is stemming from the PR: https://github.com/openjdk/jdk/pull/14211 where
> aggressive GC can cause NPE in `BaseLocale$Key` class. I refactored the
> in-house cache with WeakHashMap, and removed the Key class as it is no longer
> needed
On Fri, 22 Jul 2022 20:51:59 GMT, Brent Christian wrote:
>> Please review this change to replace the finalizer in
>> `AbstractLdapNamingEnumeration` with a Cleaner.
>>
>> The pieces of state required for cleanup (`LdapCtx homeCtx`, `LdapResult
>> res`, and `LdapClient enumClnt`) are moved to a
Please review this PR which removes the i18n related testing base classes
`IntlTest` and `CollatorTest` and converts all the tests that use them,
IntlTest and CollatorTest are testing classes which are extended by tests in
`text/`, `util/Locale`, `util/TimeZone`, and `util/Calendar`. The abstrac
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote:
>> Remove unused imports in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by iris (Reviewer).
On Wed, 27 Sep 2023 22:44:52 GMT, Mourad Abbay wrote:
>> Remove unused imports in the java.util.stream package.
>
> Mourad Abbay has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update copyright year.
Marked as reviewed by naoto (Reviewer).
> Remove redundant type cast in the java.util.stream package.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15942/files
- new: https://git.o
> Remove unused imports in the java.util.stream package.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15949/files
- new: https://git.openjd
> Remove cases of redundant type arguments in the java.util.stream package.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Update copyright year.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15936/files
- new:
> Remove cases of redundant type arguments in the java.util.stream package.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Remove redundant type arguments.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15936/file
On Wed, 27 Sep 2023 07:11:59 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which addresses the issue noted in
> https://bugs.openjdk.org/browse/JDK-8316946?
>
> Failure handler actions can specify a "successArtifacts" property value,
> which are file name(s) for which hyp
> Remove redundant type cast in the java.util.stream package.
Mourad Abbay has updated the pull request incrementally with one additional
commit since the last revision:
Apply Paul's review.
-
Changes:
- all: https://git.openjdk.org/jdk/pull/15942/files
- new: https://git.ope
On Wed, 27 Sep 2023 17:45:58 GMT, Mourad Abbay wrote:
> Remove unused imports in the java.util.stream package.
Please modify the copyright year accordingly. Otherwise LGTM
-
PR Review: https://git.openjdk.org/jdk/pull/15949#pullrequestreview-1647590729
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on Mac
On Wed, 27 Sep 2023 08:50:20 GMT, Mourad Abbay wrote:
> Remove redundant type cast in the java.util.stream package.
src/java.base/share/classes/java/util/stream/DoublePipeline.java line 391:
> 389: if (maxSize < 0)
> 390: throw new IllegalArgumentException(Long.toString(maxS
On Wed, 27 Sep 2023 00:58:01 GMT, Mourad Abbay wrote:
> Remove cases of redundant type arguments in the java.util.stream package.
Looks like there are a few others in the package. In `Collectors`, see see
construction of `CollectorImpl`. See also `DistinctOp`, `DoublePipeline`,
`IntPipeline`,
On Wed, 27 Sep 2023 19:13:02 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
>
On Wed, 27 Sep 2023 19:06:26 GMT, Naoto Sato wrote:
>> Some CLDR locales have partial list patterns, such as only the "end"
>> pattern, and expect "start" and "middle" patterns to be inherited from
>> parent locales. Made the code capable of the inheritance.
>
> Naoto Sato has updated the pull
On Wed, 27 Sep 2023 19:06:26 GMT, Naoto Sato wrote:
>> Some CLDR locales have partial list patterns, such as only the "end"
>> pattern, and expect "start" and "middle" patterns to be inherited from
>> parent locales. Made the code capable of the inheritance.
>
> Naoto Sato has updated the pull
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on Mac
> Some CLDR locales have partial list patterns, such as only the "end" pattern,
> and expect "start" and "middle" patterns to be inherited from parent locales.
> Made the code capable of the inheritance.
Naoto Sato has updated the pull request incrementally with one additional
commit since the
On Wed, 27 Sep 2023 17:29:29 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new internal annotation that is used to mark all
>> restricted me
>> thods in the FFM API. The new annotation is similar to the one we used for
>> preview API methods.
>>
>> We plan to use the new annotation for
On Wed, 27 Sep 2023 14:13:05 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
Remove unused imports in the java.util.stream package.
-
Commit messages:
- Remove unused imports.
Changes: https://git.openjdk.org/jdk/pull/15949/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15949&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8317119
Stats: 9 l
On Wed, 27 Sep 2023 09:35:47 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
>
On Wed, 27 Sep 2023 17:29:29 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new internal annotation that is used to mark all
>> restricted me
>> thods in the FFM API. The new annotation is similar to the one we used for
>> preview API methods.
>>
>> We plan to use the new annotation for
On Wed, 27 Sep 2023 17:23:48 GMT, Maurizio Cimadamore
wrote:
>> This patch adds a new internal annotation that is used to mark all
>> restricted me
>> thods in the FFM API. The new annotation is similar to the one we used for
>> preview API methods.
>>
>> We plan to use the new annotation for
> This patch adds a new internal annotation that is used to mark all restricted
> me
> thods in the FFM API. The new annotation is similar to the one we used for
> preview API methods.
>
> We plan to use the new annotation for adding new javac warnings when calling
> restricted methods, as well
On Wed, 27 Sep 2023 16:57:08 GMT, Alan Bateman wrote:
> I'll add myself as Reviewer to the CSR when you create it.
CSR created. Thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15673#issuecomment-1737786818
On Wed, 27 Sep 2023 16:19:04 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
On Wed, 27 Sep 2023 14:52:52 GMT, Jorn Vernee wrote:
>> test/hotspot/jtreg/compiler/rangechecks/TestRangeCheckHoistingScaledIV.java
>> line 32:
>>
>>> 30: * @modules jdk.incubator.vector
>>> 31: * @compile -source ${jdk.version} TestRangeCheckHoistingScaledIV.java
>>> 32: * @run main/othervm
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Wed, 27 Sep 2023 16:12:46 GMT, Jorn Vernee wrote:
> Side note: I don't believe I have to add all the different error message
> translations right? Only the English version?
That's right, the translations will be updated towards the end of the release.
-
PR Review Comment: https
On Wed, 27 Sep 2023 08:03:38 GMT, Alan Bateman wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8316000: Modify spec and return verbiage
>
> src/java.base/share/classes/java/io/File.java line 1630:
>
>> 1628:
> On Windows, do not return `true` from the `java.io.File` methods
> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
> file does not exist.
Brian Burkhalter has updated the pull request incrementally with one additional
commit since the last revision:
8316000: Ad
This patch adds a new internal annotation that is used to mark all restricted me
thods in the FFM API. The new annotation is similar to the one we used for
preview API methods.
We plan to use the new annotation for adding new javac warnings when calling
restricted methods, as well as to add bett
On Wed, 27 Sep 2023 15:04:12 GMT, Alan Bateman wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix visibility issues
>>
>>Reviewed-by: mcimadamore
>> - Review comments
>
> src/java.base/share/classes/java
On Wed, 27 Sep 2023 00:53:25 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Wed, 27 Sep 2023 14:50:32 GMT, Alan Bateman wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix visibility issues
>>
>>Reviewed-by: mcimadamore
>> - Review comments
>
> test/hotspot/jtreg/compiler/rang
On Wed, 27 Sep 2023 00:53:25 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Tue, 26 Sep 2023 22:27:55 GMT, Naoto Sato wrote:
>> Some CLDR locales have partial list patterns, such as only the "end"
>> pattern, and expect "start" and "middle" patterns to be inherited from
>> parent locales. Made the code capable of the inheritance.
>
> Naoto Sato has updated the pull
On Wed, 27 Sep 2023 14:13:05 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
> negative length this condition will never be satisfied.
>
> Tes
On Wed, 27 Sep 2023 13:27:10 GMT, Roger Riggs wrote:
>> Aleksei Voitylov has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review comments
>
> test/jdk/java/lang/String/RegionMatches.java line 41:
>
>> 39:
>> 40: private final
On Wed, 27 Sep 2023 09:07:44 GMT, 温绍锦 wrote:
>> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
>> were discussed.
>>
>> But if the input is byte[], using lookup table can improve performance.
>>
>> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify performance is
On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote:
> The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp.
> The problem appears with the Graal compiler but may also occur on other
> platforms.
This pull request has now been integrated.
Changeset: 1be35573
Author:R
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Wed, 27 Sep 2023 07:47:19 GMT, Alan Bateman wrote:
> A test only change to a stress test for virtual thread parking/unparking to
> limit execution time on a larger systems. Right run, the test bashes
> parking/unparking for 1, 2, 3, ... up to the number of half the hardware
> threads. It is
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java
> failed with "InterruptedException: sleep interrupted" and related issues.
>
> This is a major ForkJoin update (and hard to review -- sorry) that finally
> addresses incompatibilities between ExecutorService and ForkJ
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Mon, 25 Sep 2023 12:20:36 GMT, 温绍锦 wrote:
>>> The reason why I split it into multiple small methods is to avoid a single
>>> method codeSize > 325. After merging small methods, the performance will
>>> decrease.
>>
>> Yes, I can refactor to keep the same structure and verify performance is
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
On Tue, 26 Sep 2023 17:03:00 GMT, Roger Riggs wrote:
> The timing of the test can be disturbed by -Xcomp so do not run with -Xcomp.
> The problem appears with the Graal compiler but may also occur on other
> platforms.
The change looks good to me, given the description in the JBS.
On Wed, 27 Sep 2023 07:47:19 GMT, Alan Bateman wrote:
> A test only change to a stress test for virtual thread parking/unparking to
> limit execution time on a larger systems. Right run, the test bashes
> parking/unparking for 1, 2, 3, ... up to the number of half the hardware
> threads. It is
On Wed, 27 Sep 2023 09:58:58 GMT, Aleksei Voitylov
wrote:
>> test java.lang.String.RegionMatches1Tests fails on all platforms with
>> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
>> default. The fix is to return true immediately if len is negative, since for
>>
> test java.lang.String.RegionMatches1Tests fails on all platforms with
> -XX:-CompactStrings option and on ARM32 where Compact Strings is disabled by
> default. The fix is to return true immediately if len is negative, since for
> negative length this condition will never be satisfied.
>
> Tes
On Wed, 27 Sep 2023 07:47:19 GMT, Alan Bateman wrote:
> A test only change to a stress test for virtual thread parking/unparking to
> limit execution time on a larger systems. Right run, the test bashes
> parking/unparking for 1, 2, 3, ... up to the number of half the hardware
> threads. It is
On Wed, 27 Sep 2023 09:35:47 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
>
> @cl4es made performance optimizations for the simple specifiers of
> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
> same idea, I continued to make improvements. I made patterns like %2d %02d
> also be optimized.
>
> The following are the test results based on Mac
On Thu, 14 Sep 2023 21:30:39 GMT, Lance Andersen wrote:
>Joe is on holiday so please wait for his input as there are some additional
>constants that may also be removed.
BTW, Who is Joe?
🙂
-
PR Comment: https://git.openjdk.org/jdk/pull/15692#issuecomment-1737031055
> In the improvement of @cl4es PR #15591, the advantages of non-lookup-table
> were discussed.
>
> But if the input is byte[], using lookup table can improve performance.
>
> For HexFormat#formatHex(Appendable, byte[]) and HexFormat#formatHex(byte[]),
> If the length of byte[] is larger, the pe
On Wed, 27 Sep 2023 04:16:11 GMT, Roger Riggs wrote:
> ok, but perhaps you can shrink it further, if it does not hurt performance,
> by subtracting 0x20 before indexing and cut the table to 64 bytes.
If you use DIGITS of size 54, performance will be 10% slower, The code is
written like this:
On Mon, 25 Sep 2023 14:28:56 GMT, 温绍锦 wrote:
>> @cl4es made performance optimizations for the simple specifiers of
>> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the
>> same idea, I continued to make improvements. I made patterns like %2d %02d
>> also be optimized.
>
Remove redundant type cast in the java.util.stream package.
-
Commit messages:
- Remove redundant type cast.
Changes: https://git.openjdk.org/jdk/pull/15942/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15942&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8317034
On Tue, 26 Sep 2023 18:03:54 GMT, Brian Burkhalter wrote:
>> On Windows, do not return `true` from the `java.io.File` methods
>> `setReadable(boolean, boolean)` and `setExecutable(boolean, boolean)` if the
>> file does not exist.
>
> Brian Burkhalter has updated the pull request incrementally w
A test only change to a stress test for virtual thread parking/unparking to
limit execution time on a larger systems. Right run, the test bashes
parking/unparking for 1, 2, 3, ... up to the number of half the hardware
threads. It is changed to limit it to 4 iterations. It is also dialed down for
On Tue, 26 Sep 2023 14:54:37 GMT, Chen Liang wrote:
>> Fixes the issue (hopefully) by resolving automatic modules and automatic
>> module dependencies after propagation of non-automatic transitive
>> dependencies. The module tests run.
>>
>> I also added a few asserts to validate that the auto
Can I please get a review of this change which addresses the issue noted in
https://bugs.openjdk.org/browse/JDK-8316946?
Failure handler actions can specify a "successArtifacts" property value, which
are file name(s) for which hypherlinks will be created in the "processes.html"
file. This prope
72 matches
Mail list logo
