Re: RFR: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing [v2]

2023-09-24 Thread Alan Bateman
On Tue, 19 Sep 2023 20:03:51 GMT, Naoto Sato wrote: >> Fixed the failing (well, false-positive) test case. Made the following >> changes to the test: >> >> - Corrected the path to the mapping files directory >> - Made sure to fail if the directory path is incorrect >> - Took care of `GB18030` a

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v7]

2023-09-24 Thread 温绍锦
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on Mac

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v6]

2023-09-24 Thread Claes Redestad
On Sun, 24 Sep 2023 13:08:58 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized. >

Re: RFR: 8315999: Improve Date toString performance [v13]

2023-09-24 Thread 温绍锦
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote: >> improve date toString performance, includes: >> >> java.util.Date.toString >> java.util.Date.toGMTString >> java.time.Instant.toString >> java.time.LocalDate.toString >> java.time.LocalDateTime.toString >> java.time.LocalTime.toString > > 温绍锦 has u

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v6]

2023-09-24 Thread Chen Liang
> VarHandle implementations have many static fields and methods that can be > pulled to the common superclass to avoid repeated initialization and code > duplication. > > In addition, the Unsafe-based Buffer field access are replaced by usage of > public methods or JavaNioAccess. Chen Liang ha

Re: RFR: 8316641: VarHandle template classes can share code in the base class [v5]

2023-09-24 Thread Chen Liang
On Sun, 24 Sep 2023 02:11:50 GMT, Chen Liang wrote: >> VarHandle implementations have many static fields and methods that can be >> pulled to the common superclass to avoid repeated initialization and code >> duplication. >> >> In addition, the Unsafe-based Buffer field access are replaced by

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v5]

2023-09-24 Thread 温绍锦
On Sun, 24 Sep 2023 11:59:51 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized. >

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v6]

2023-09-24 Thread 温绍锦
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on Mac

Re: RFR: 8315999: Improve Date toString performance [v13]

2023-09-24 Thread Chen Liang
On Wed, 13 Sep 2023 14:22:35 GMT, 温绍锦 wrote: >> improve date toString performance, includes: >> >> java.util.Date.toString >> java.util.Date.toGMTString >> java.time.Instant.toString >> java.time.LocalDate.toString >> java.time.LocalDateTime.toString >> java.time.LocalTime.toString > > 温绍锦 has u

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v5]

2023-09-24 Thread Claes Redestad
On Sun, 24 Sep 2023 11:59:51 GMT, 温绍锦 wrote: >> @cl4es made performance optimizations for the simple specifiers of >> String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the >> same idea, I continued to make improvements. I made patterns like %2d %02d >> also be optimized. >

Re: RFR: 8316704: Regex-free parsing of Formatter and FormatProcessor specifiers [v5]

2023-09-24 Thread 温绍锦
> @cl4es made performance optimizations for the simple specifiers of > String.format in PR https://github.com/openjdk/jdk/pull/2830. Based on the > same idea, I continued to make improvements. I made patterns like %2d %02d > also be optimized. > > The following are the test results based on Mac

Re: RFR: 8315999: Improve Date toString performance [v13]

2023-09-24 Thread 温绍锦
On Tue, 19 Sep 2023 16:27:50 GMT, Roger Riggs wrote: > Lots of adhoc changes bulk up the source and make it less maintainable. Given > the common element of time and date formatting strings as a domain specific > language, there would be more benefit to leveraging one of several existing > mec