On Fri, 15 Sep 2023 00:36:10 GMT, David Holmes wrote:
> What is TIMED PINNING?
LockSupport.parkNanos when the carrier can't be released due to monitor or
native frame.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/14978#discussion_r1326860516
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
Per Minborg has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request
On Wed, 13 Sep 2023 09:50:35 GMT, Alan Bateman wrote:
> Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for
> removal since JDK 15. It's time to remove them.
> Lookup.ensureInitialized(Class) was added in Java 15 as a standard API to
> ensure that an accessible class is init
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote:
> This PR proposes to improve the MemorySegment::toString to reduce cluttering
> and add missing comas.
This pull request has now been integrated.
Changeset: 8dc2d928
Author:Per Minborg
URL:
https://git.openjdk.org/jdk/commit/8dc
On Thu, 14 Sep 2023 13:29:48 GMT, Alan Bateman wrote:
>> Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a
>> stand-alone bit because you can be in various states and suspended at the
>> same time. But TIMED isn't like that.
>
>> Yes but TIMED and SUSPENDED are not alike. I ass
On Thu, 14 Sep 2023 22:08:02 GMT, Lance Andersen wrote:
> Given this is a small test, perhaps it would be worthwhile to convert to
> Junit as part of your cleanup
It was not completely obvious at first how to do this, but after some
investigation, I think it is feasible.
-
PR Com
On Wed, 13 Sep 2023 23:02:21 GMT, Srinivas Vamsi Parasa
wrote:
> Could you please have a look at the changes in `DualPivotQuicksort.java` and
> provide your feedback?
I agree that is much cleaner, glad that worked out. That neatly covers multiple
element types and Java-based insertion sort al
On Tue, 12 Sep 2023 21:57:31 GMT, Justin Lu wrote:
> JDK .properties files still use ISO-8859-1 encoding with escape sequences. It
> would improve readability to see the native characters instead of escape
> sequences (especially for the L10n process). The majority of files changed
> are local
On Thu, 14 Sep 2023 21:53:30 GMT, Brian Burkhalter wrote:
> Add a `finally` block to delete the created files.
Given this is a small test, perhaps it would be worthwhile to convert to Junit
as part of your cleanup
-
PR Review: https://git.openjdk.org/jdk/pull/15757#pullrequestrevi
Add a `finally` block to delete the created files.
-
Commit messages:
- 8315960: test/jdk/java/io/File/TempDirDoesNotExist.java leaves test files
behind
Changes: https://git.openjdk.org/jdk/pull/15757/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15757&range=00
Issue: h
On Tue, 12 Sep 2023 20:04:54 GMT, Andrey Turbanov wrote:
> A field `short _Depth` in the
> `jdk.internal.util.xml.impl.XMLStreamWriterImpl.Element` class is unused and
> can be removed.
This makes sense to remove.
Joe is on holiday so please wait for his input as there are some additional
co
On Thu, 14 Sep 2023 21:15:48 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/StackStreamFactory.java line 544:
>>
>>> 542: return walker.estimateDepth() == 0
>>> 543: ? SMALL_BATCH
>>> 544: : Math.min(walker.estimat
On Thu, 14 Sep 2023 17:06:53 GMT, Mandy Chung wrote:
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack depth
On Thu, 14 Sep 2023 20:42:57 GMT, Brent Christian wrote:
>> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
>> intends to change the initial batch size only for a stack walker with an
>> estimated stack depth. For stack walkers without user-supplied estimated
>> sta
On Thu, 14 Sep 2023 17:06:53 GMT, Mandy Chung wrote:
> A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
> intends to change the initial batch size only for a stack walker with an
> estimated stack depth. For stack walkers without user-supplied estimated
> stack depth
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 233
On Thu, 14 Sep 2023 16:38:36 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes from review
>
> src/java.base/share/classes/jdk/internal/classfile/ClassReader.java line 184:
>
On Thu, 7 Sep 2023 13:55:18 GMT, Soumadipta Roy wrote:
> This test is running in tier1, and takes about 400 seconds to complete. Thus,
> it drags the execution time of tier1 on large machines. The commit includes
> changing the sequential run of test cases in
> java/util/concurrent/tck/JSR166T
On Tue, 1 Aug 2023 08:36:01 GMT, Adam Sotona wrote:
> This PR improved Classfile API attributes handling safety by introduction of
> attribute stability indicator
> and by extension of UnknownAttributesOption to more general
> AttributesProcessingOption.
This pull request has now been integrat
> This PR improved Classfile API attributes handling safety by introduction of
> attribute stability indicator
> and by extension of UnknownAttributesOption to more general
> AttributesProcessingOption.
Adam Sotona has updated the pull request incrementally with one additional
commit since the
On Thu, 14 Sep 2023 16:30:21 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> magic moved to Util::isAttributeAllowed and fixed possible NPE
>
> src/java.base/share/classes/jdk/internal/classfile/Att
On Thu, 31 Aug 2023 11:09:05 GMT, Adam Sotona wrote:
> Classfile API suppose to throw IllegalArgumentException in situations where
> bytecode offset is out of allowed range. Such situation includes invalid
> offset parsed from a TypeAnnotation as well as from other CodeAttribute
> attributes.
On Tue, 5 Sep 2023 14:18:08 GMT, Adam Sotona wrote:
> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex`
> methods are confusing and unsafe to use without knowledge of constant pool
> specification.
> This patch renames `ConstantPool::entryCount` to `ConstantPool::size` a
On Thu, 14 Sep 2023 16:17:35 GMT, Brian Goetz wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>> commits s
On Tue, 5 Sep 2023 10:59:09 GMT, Adam Sotona wrote:
> This patch performs null checks in to refuse null labels in
> TypeAnnotation.TargetInfo implementations.
>
> Please review.
>
> Thanks,
> Adam
This pull request has now been integrated.
Changeset: c7d306c6
Author:Adam Sotona
URL:
On Wed, 13 Sep 2023 09:50:35 GMT, Alan Bateman wrote:
> Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for
> removal since JDK 15. It's time to remove them.
> Lookup.ensureInitialized(Class) was added in Java 15 as a standard API to
> ensure that an accessible class is init
On Wed, 13 Sep 2023 09:50:35 GMT, Alan Bateman wrote:
> Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for
> removal since JDK 15. It's time to remove them.
> Lookup.ensureInitialized(Class) was added in Java 15 as a standard API to
> ensure that an accessible class is init
On Tue, 12 Sep 2023 06:27:42 GMT, Alan Bateman wrote:
>> src/java.base/windows/native/libjava/WinNTFileSystem_md.c line 479:
>>
>>> 477: if (access == java_io_FileSystem_ACCESS_READ ||
>>> 478: access == java_io_FileSystem_ACCESS_EXECUTE) {
>>> 479: return _waccess(pathbuf, 0
A trivial fix. [JDK-8285447](https://bugs.openjdk.org/browse/JDK-8285447)
intends to change the initial batch size only for a stack walker with an
estimated stack depth. For stack walkers without user-supplied estimated stack
depth, the initial batch size is changed to 3 which is a bug. This
On Fri, 8 Sep 2023 10:15:26 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with o
On Tue, 5 Sep 2023 10:59:09 GMT, Adam Sotona wrote:
> This patch performs null checks in to refuse null labels in
> TypeAnnotation.TargetInfo implementations.
>
> Please review.
>
> Thanks,
> Adam
Marked as reviewed by briangoetz (Reviewer).
-
PR Review: https://git.openjdk.org
On Wed, 6 Sep 2023 15:03:24 GMT, Adam Sotona wrote:
>> This PR improved Classfile API attributes handling safety by introduction of
>> attribute stability indicator
>> and by extension of UnknownAttributesOption to more general
>> AttributesProcessingOption.
>
> Adam Sotona has updated the pull
On Thu, 31 Aug 2023 11:09:05 GMT, Adam Sotona wrote:
> Classfile API suppose to throw IllegalArgumentException in situations where
> bytecode offset is out of allowed range. Such situation includes invalid
> offset parsed from a TypeAnnotation as well as from other CodeAttribute
> attributes.
On Fri, 8 Sep 2023 10:27:28 GMT, Adam Sotona wrote:
>> Classfile API `ConstantPool::entryCount` and `ConstantPool::entryByIndex`
>> methods are confusing and unsafe to use without knowledge of constant pool
>> specification.
>> This patch renames `ConstantPool::entryCount` to `ConstantPool::siz
On Wed, 6 Sep 2023 18:34:29 GMT, Mandy Chung wrote:
> This reimplements
> `sun.reflect.ReflectionFactory::newConstructorForSerialization` with method
> handles.
>
> This API currently generates the bytecode which fails the verification
> because `new C; invokespecial A()` where the given clas
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We have a valid size for the Zip64 extra header but we are
On Tue, 29 Aug 2023 20:00:49 GMT, Nikita Sakharin wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new ArrayList<>(s
On Mon, 11 Sep 2023 23:42:37 GMT, Sergey Bylokhov wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added additional tests, along with additional cleanup and refactoring
>
> test/jdk/java/util/zip/ZipFile/MissingZI
On Tue, 12 Sep 2023 08:47:03 GMT, Andrey Turbanov wrote:
>> Lance Andersen has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Added additional tests, along with additional cleanup and refactoring
>
> test/jdk/java/util/zip/ZipFile/MissingZI
> Please review this PR which improves the Zip64 extra header validation:
>
> - Throw a ZipException If the extra len field is 0 and :
> -- size, csize, or loc offset are set to 0x
> -- disk starting number is set to 0x
>
> - We have a valid size for the Zip64 extra header but we are
On Thu, 14 Sep 2023 14:05:36 GMT, Martin Buchholz wrote:
>> Soumadipta Roy has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Changing test id name from security-manager-allow to security-manager
>> - Creating a separate parallelized tes
Please review this fix for a regression in the LDAP CertStore implementation
where a null CRL issuerName in an X509CRLSelector should be treated as a
CertStoreException instead of a NullPointerException.
A new test has been added but requires internal infrastructure so will only be
in the close
On Thu, 14 Sep 2023 13:44:59 GMT, Roger Riggs wrote:
>> src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
>>
>>> 275: }
>>> 276:
>>> 277: public static String toHexString(long value) {
>>
>> We intend to use this utility method in coming PRs.
>
> The String concat c
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote:
> This PR proposes to improve the MemorySegment::toString to reduce cluttering
> and add missing comas.
Marked as reviewed by rriggs (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/15740#pullrequestreview-1626999067
On Thu, 14 Sep 2023 08:08:18 GMT, Soumadipta Roy wrote:
>> This test is running in tier1, and takes about 400 seconds to complete.
>> Thus, it drags the execution time of tier1 on large machines. The commit
>> includes changing the sequential run of test cases in
>> java/util/concurrent/tck/JS
On Thu, 14 Sep 2023 08:08:18 GMT, Soumadipta Roy wrote:
>> This test is running in tier1, and takes about 400 seconds to complete.
>> Thus, it drags the execution time of tier1 on large machines. The commit
>> includes changing the sequential run of test cases in
>> java/util/concurrent/tck/JS
On Thu, 14 Sep 2023 13:45:30 GMT, Per Minborg wrote:
> This PR proposes to use hexadecimal formatting for raw addresses in
> `VarHandleSegmentViewBase`.
src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
> 275: }
> 276:
> 277: public static String toHexString(long v
This PR proposes to use hexadecimal formatting for raw addresses in
`VarHandleSegmentViewBase`.
-
Commit messages:
- VarHandleSegmentViewBase::newIllegalArg... to use hexadecimal form
Changes: https://git.openjdk.org/jdk/pull/15742/files
Webrev: https://webrevs.openjdk.org/?repo=j
On Thu, 14 Sep 2023 12:02:53 GMT, Per Minborg wrote:
>> This PR proposes to improve the MemorySegment::toString to reduce cluttering
>> and add missing comas.
>
> src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
>
>> 275: }
>> 276:
>> 277: public static String toHe
On Thu, 27 Jul 2023 01:54:58 GMT, Serguei Spitsyn wrote:
> Looks good.
> Thanks,
> Serguei
Thanks Serguei. I had to pause this to work on other things. When I sync'ed up
the branch I found I had to update recently introduced test
jvmti/vthread/VThreadEventTest/VThreadEventTest.java as it was c
On Wed, 26 Jul 2023 12:18:02 GMT, David Holmes wrote:
> Yes but TIMED and SUSPENDED are not alike. I assume SUSPENDED is a
> stand-alone bit because you can be in various states and suspended at the
> same time. But TIMED isn't like that.
The SUSPENDED bit can only be set when the virtual thre
> Thread::getState is an API for monitoring and management purposes to report
> the thread state. If a virtual thread is parked with LockSupport.parkNanos,
> its state is reported as WAITING when it should be TIMED_WAITING. JVM TI
> GetThreadState has the same issue in that it returns
> JVMTI_
On Thu, 14 Sep 2023 12:01:29 GMT, Per Minborg wrote:
> This PR proposes to improve the MemorySegment::toString to reduce cluttering
> and add missing comas.
src/java.base/share/classes/jdk/internal/foreign/Utils.java line 277:
> 275: }
> 276:
> 277: public static String toHexString(lo
This PR proposes to improve the MemorySegment::toString to reduce cluttering
and add missing comas.
-
Commit messages:
- Improve MemorySegment::toString
Changes: https://git.openjdk.org/jdk/pull/15740/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15740&range=00
Issue: h
> BigDecimal is a commonly used class in business development, It is often
> necessary to perform toString or toPlainString operations on BigDecimal.
>
> The current version uses StringBuilder resulting in multiple memory
> allocations, I made a modification to improve performance.
>
> Because
Unsafe.{shouldBeInitialized,ensureClassInitialized} are deprecated for removal
since JDK 15. It's time to remove them. Lookup.ensureInitialized(Class) was
added in Java 15 as a standard API to ensure that an accessible class is
initialized.
A search of 175973022 classes in 484751 artifacts fou
On Mon, 21 Aug 2023 15:07:45 GMT, Andrey Turbanov wrote:
> These messages were used before
> [JDK-8248862](https://bugs.openjdk.org/browse/JDK-8248862)
This pull request has now been integrated.
Changeset: 14408bc8
Author:Andrey Turbanov
URL:
https://git.openjdk.org/jdk/commit/1440
On Thu, 14 Sep 2023 04:29:17 GMT, Martin Buchholz wrote:
>> Soumadipta Roy has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Adding summary for each parallelized section.
>
> Marked as reviewed by martin (Reviewer).
Hi @Martin-Buchholz I
> This test is running in tier1, and takes about 400 seconds to complete. Thus,
> it drags the execution time of tier1 on large machines. The commit includes
> changing the sequential run of test cases in
> java/util/concurrent/tck/JSR166TestCase.java to the best possible combination
> of paral
59 matches
Mail list logo
