Re: RFR: 8315454: Add a way to create an immutable snapshot of a BitSet [v4]

2023-09-03 Thread Per Minborg
> This PR proposes adding a new method to BitSet that provides an immutable > snapshot of the set in the form of an `IntPredicate`. > > The predicate is eligible for constant folding. > > Here are some classes in the JDK that would benefit directly from > constant-folding of BitSets: > > PoolR

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v7]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8315585: Optimization for decimal to string

2023-09-03 Thread 温绍锦
On Mon, 4 Sep 2023 04:58:08 GMT, 温绍锦 wrote: > BigDecimal is a commonly used class in business development, It is often > necessary to perform toString or toPlainString operations on BigDecimal. > > The current version uses StringBuilder resulting in multiple memory > allocations, I made a modi

RFR: 8315585: Optimization for decimal to string

2023-09-03 Thread 温绍锦
BigDecimal is a commonly used class in business development, It is often necessary to perform toString or toPlainString operations on BigDecimal. The current version uses StringBuilder resulting in multiple memory allocations, I made a modification to improve performance. Because BigDecimal use

Re: RFR: 8310929: Optimization for Integer.toString [v12]

2023-09-03 Thread Quan Anh Mai
On Thu, 20 Jul 2023 09:20:00 GMT, 温绍锦 wrote: >> src/java.base/share/classes/java/lang/Long.java line 527: >> >>> 525: /** >>> 526: * Places characters representing the long i into the >>> 527: * character array buf. The characters are placed into >> >> Add the array bound check fo

Re: RFR: 8310929: Optimization for Integer.toString [v13]

2023-09-03 Thread 温绍锦
On Fri, 1 Sep 2023 12:01:58 GMT, 温绍锦 wrote: >> @cl4es can you help me to review this PR? > >> @wenshao How about of approach used in [James Anhalt's >> algorithm](https://jk-jeon.github.io/posts/2022/02/jeaiii-algorithm/)? >> >> It reduces number of multiplications ([and store operations in cas

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 17:54:02 GMT, Claes Redestad wrote: > The preferred route is to merge in then push changes from master to your PR > branch. Merge will cause a lot of file changes > `hasNotUpperCaseEx` sounds wrong. `hasUpperCaseMapping`? i have renamed hasNotUpperCaseEx to hasUpperCaseMapp

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v6]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread Claes Redestad
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread Claes Redestad
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 17:36:03 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v4]

2023-09-03 Thread 温绍锦
On Sun, 3 Sep 2023 12:33:18 GMT, Claes Redestad wrote: > The two odd codepoints I was curious about are `0xaa` and `0xba`, both of > which are lower-case according to `Character.isLowerCase(..)` but does not > actually have an uppercase. The Unicode data categorize these two as `Lo`, > Letter,

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v5]

2023-09-03 Thread 温绍锦
> # Benchmark Result > > > sh make/devkit/createJMHBundle.sh > bash configure --with-jmh=build/jmh/jars > make test TEST="micro:java.lang.StringUpperLower.*" > > > > ## 1. > [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detail/25378.html#c8i) > * cpu : intel xeon sapphire rapids (x

Re: RFR: 8311220: Optimization for StringLatin UpperLower [v4]

2023-09-03 Thread Claes Redestad
On Fri, 1 Sep 2023 18:44:13 GMT, 温绍锦 wrote: >> # Benchmark Result >> >> >> sh make/devkit/createJMHBundle.sh >> bash configure --with-jmh=build/jmh/jars >> make test TEST="micro:java.lang.StringUpperLower.*" >> >> >> >> ## 1. >> [aliyun_ecs_c8i.xlarge](https://help.aliyun.com/document_detai

Re: RFR: 8288899: java/util/concurrent/ExecutorService/CloseTest.java failed with "InterruptedException: sleep interrupted" [v22]

2023-09-03 Thread Doug Lea
> Addresses Jdk 8288899 : java/util/concurrent/ExecutorService/CloseTest.java > failed with "InterruptedException: sleep interrupted" and related issues. > > This is a major ForkJoin update (and hard to review -- sorry) that finally > addresses incompatibilities between ExecutorService and ForkJ