On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderI
On Fri, 25 Aug 2023 13:20:54 GMT, Nikita Sakharin wrote:
>> `Collections.rotate` method contains a bug. This method throws
>> IndexOutOfBoundsException on arrays larger than $2^{30}$ elements. The way
>> to reproduce:
>>
>> final int size = (1 << 30) + 1;
>> final List list = new ArrayList<>(s
> 8268829: Provide an optimized way to walk the stack with Class object only
>
> `StackWalker::walk` creates one `StackFrame` per frame and the current
> implementation
> allocates one `StackFrameInfo` and one `MemberName` objects per frame. Some
> frameworks
> like logging may only interest in
Windows 11 does not reserve as many names as prior versions of Windows so do
not expect exceptions for COM7 and LPT1.
-
Commit messages:
- 8274122: java/io/File/createTempFile/SpecialTempFile.java fails in Windows 11
Changes: https://git.openjdk.org/jdk/pull/15460/files
Webrev: ht
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
On Mon, 28 Aug 2023 22:42:50 GMT, Srinivas Vamsi Parasa
wrote:
>> make/modules/java.base/Lib.gmk line 239:
>>
>>> 237:
>>>
>>> 238:
>>> 239: ifeq ($(call isTargetOs, linux)+$(call isTargetCpu,
>>> x86_64)+$(INCL
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
On Mon, 28 Aug 2023 21:27:25 GMT, Srinivas Vamsi Parasa
wrote:
>> The goal is to develop faster sort routines for x86_64 CPUs by taking
>> advantage of AVX512 instructions. This enhancement provides an order of
>> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>>
Vote: Yes
On 8/25/23 8:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Vote: Yes
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated the pull request inc
On Fri, 25 Aug 2023 13:20:09 GMT, Erik Joelsson wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary import in Arrays.java
>
> make/modules/java.base/Lib.gmk line 239:
>
>> 237:
>>
On Mon, 28 Aug 2023 21:36:34 GMT, Justin Lu wrote:
>> Please review this PR which updates some exceptions in j.util.Currency to
>> have an explicit error message (as opposed to nothing).
>>
>> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
>> in an invalid form, or
> Please review this PR which updates some exceptions in j.util.Currency to
> have an explicit error message (as opposed to nothing).
>
> The exceptions are thrown when the ISO 4217/3166 currency/country codes are
> in an invalid form, or do not exist.
Justin Lu has updated the pull request inc
Please review this PR which refines the spec of `equals()` and `hashCode()` in
`java.text.Format` related classes.
The current spec for most of these methods is either "_Overrides
_" or are incomplete/wrong (i.e. see `ChoiceFormat`).
This fix adjusts the spec to provide a consistent definition
On Fri, 25 Aug 2023 01:52:32 GMT, Sandhya Viswanathan
wrote:
>> pivotIndices array is being passed as a parameter to the partition intrinsic
>> as it is updated in-place with the new pivot indices after partitioning. The
>> Unsafe.ARRAY_INT_BASE_OFFSET is being used in libary_call.cpp to get t
On Fri, 25 Aug 2023 22:04:45 GMT, Vladimir Kozlov wrote:
>> Srinivas Vamsi Parasa has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove unnecessary import in Arrays.java
>
> src/hotspot/cpu/x86/stubGenerator_x86_64.cpp line 4143:
>
>>
> The goal is to develop faster sort routines for x86_64 CPUs by taking
> advantage of AVX512 instructions. This enhancement provides an order of
> magnitude speedup for Arrays.sort() using int, long, float and double arrays.
>
> This PR shows upto ~7x improvement for 32-bit datatypes (int, floa
Please review this PR which updates some exceptions in j.util.Currency to have
an explicit error message (as opposed to nothing).
The exceptions occur in the two static `getInstance()` methods. They are thrown
generally when the ISO 4217/3166 currency/country codes are in an invalid form,
or do
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
On Mon, 28 Aug 2023 20:05:41 GMT, Naoto Sato wrote:
>> Introducing a new formatting class for locale-dependent list patterns. The
>> class is to provide the functionality from the Unicode Consortium's LDML
>> specification for [list
>> patterns](https://www.unicode.org/reports/tr35/tr35-genera
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
On Wed, 23 Aug 2023 23:50:29 GMT, Qing Xiao wrote:
> Migrate jdk.jlink StringSharingPlugin to use new classfile library
It looks good, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/15408#issuecomment-1695382042
Migrate jdk.jlink StringSharingPlugin to use new classfile library
-
Commit messages:
- Migrate jdk.jlink StringSharingPlugin to use new classfile library
Changes: https://git.openjdk.org/jdk/pull/15408/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15408&range=00
Issue:
On Mon, 28 Aug 2023 18:49:40 GMT, Daniel Fuchs wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix up test cases
>
> test/jdk/java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java
> line
On Mon, 28 Aug 2023 15:54:08 GMT, Leo Korinth wrote:
> Rename createJavaProcessBuilder so that it is not used by mistake instead of
> createTestJvm.
>
> I have used the following sed script: `find -name "*.java" | xargs -n 1 sed
> -i -e
> "s/createJavaProcessBuilder(/createJavaProcessBuilderI
On Fri, 25 Aug 2023 18:59:47 GMT, Srinivas Vamsi Parasa
wrote:
>>> Improvements are nice but it would not pay off if you have big regressions.
>>> I can accept 0.9x but 0.4x - 0.8x regressions should be investigated and
>>> implementation adjusted to avoid them.
>>
>> Hello Vladimir (@vnkozlo
On Mon, 28 Aug 2023 18:45:03 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
On Mon, 28 Aug 2023 17:29:16 GMT, Sean Coffey wrote:
>> Recursive initialization calls possible during loading of LoggerFinder
>> service.
>>
>> This fix detects the recursive call and returns a temporary LoggerFinder
>> that is backed by a lazy logger. Automated test case developed to simul
On Mon, 28 Aug 2023 17:42:34 GMT, Daniel Fuchs wrote:
>> Sean Coffey has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Tidy up SignedLoggerFinderTest.java
>> - Code contribution from Daniel included. New tests. Fix up extra service
>>
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate loading
> of an external LoggerFinder service while als
On Mon, 28 Aug 2023 17:15:36 GMT, Lance Andersen wrote:
> It was a clean copy(which I have been able to do as of zlib 1.2.13). Sorry I
> should have mentioned this in the PR request
That's okay, I just wanted to check to be sure that the ChangeLog_java (renamed
adler32.c -> zadler32.c, crc32c
On Fri, 25 Aug 2023 22:22:43 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Mon, 28 Aug 2023 14:47:20 GMT, Volker Simonis wrote:
> thanks for doing this experiment. I've looked at your proposal, but I can't
> see how it can help to fix
> [JDK-8311500](https://bugs.openjdk.org/browse/JDK-8311500).
I think you may be confused. This PR can be viewed as follows:
Vote: yes
Naoto
On 8/25/23 8:24 AM, Roger Riggs wrote:
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
Michael has been contributing to the OpenJDK Core Libraries since 2008,
originally at Sun Microsystems, now Oracle. He has deep networking
experience and has mad
Vote: yes
Naoto
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Daniel has been contributing to the OpenJDK Core Libraries at Oracle
since 2012. He is leading the networking team and has made nearly 400
contributions to OpenJDK
Vote: yes
Naoto
On 8/25/23 8:23 AM, Roger Riggs wrote:
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Lance has been contributing to the OpenJDK at Oracle since 2007. He has
been the JDBC spec lead since 2005 and an OpenJDK committer since day 1.
He has extensive
> Recursive initialization calls possible during loading of LoggerFinder
> service.
>
> This fix detects the recursive call and returns a temporary LoggerFinder that
> is backed by a lazy logger. Automated test case developed to simulate loading
> of an external LoggerFinder service while als
On Mon, 28 Aug 2023 17:10:04 GMT, Alan Bateman wrote:
> Are there any changes from the upstream zlib 1.3 code that should be called
> out or is zlib 1.3 copied in without any changes?
It was a clean copy(which I have been able to do as of zlib 1.2.13). Sorry I
should have mentioned this in th
On Mon, 28 Aug 2023 16:31:06 GMT, Lance Andersen wrote:
> Hi all,
>
> Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK
>
> The [Zlib Data Compression Library](https://github.com/madler/zlib ) has
> released Zlib 1.3 on August 18, 2023.
>
> There are a [small number of
>
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
On Mon, 28 Aug 2023 15:29:32 GMT, Alan Bateman wrote:
> > @AlanBateman Is there anything else you need me to do? If so, please let me
> > know. Thanks!
>
> I don't think the JDK is the right place to workaround this issue. Also, we
> really need to get back re-implementing FileInputStream and
Hi all,
Please review this PR which updates zlib from 1.2.13 to 1.3 in openJDK
The [Zlib Data Compression Library](https://github.com/madler/zlib ) has
released Zlib 1.3 on August 18, 2023.
There are a [small number of
updates](https://github.com/madler/zlib/compare/v1.2.13...master ) between
Rename createJavaProcessBuilder so that it is not used by mistake instead of
createTestJvm.
I have used the following sed script: `find -name "*.java" | xargs -n 1 sed -i
-e "s/createJavaProcessBuilder(/createJavaProcessBuilderIgnoreTestJavaOpts(/g"`
Then I have manually modified ProcessTools.j
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
On Fri, 25 Aug 2023 22:22:43 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Thu, 24 Aug 2023 13:16:16 GMT, Severin Gehwolf wrote:
> Please review this rather trivial fix to not use `nio` in `CgroupUtil`, part
> of the
> JDK's Metrics API. The primary motivating factor is that it allows one to use
> the
> JDK's version of `Metrics` in GraalVM. See the bug for details
On Fri, 25 Aug 2023 22:22:43 GMT, Mandy Chung wrote:
>> 8268829: Provide an optimized way to walk the stack with Class object only
>>
>> `StackWalker::walk` creates one `StackFrame` per frame and the current
>> implementation
>> allocates one `StackFrameInfo` and one `MemberName` objects per fr
On Fri, 25 Aug 2023 10:04:28 GMT, Alan Bateman wrote:
>>> Something fishy here, is this working around a bug in GraaVM native image
>>> or why does this change need to be in JDK?
>>
>> I've now realized that the bug had an incorrect statement in the
>> description. The cycle happens due to the
Yes, it's 2 subclasses hierarchy.
https://github.com/iselo/jdk-optional/tree/master/lib/src
I'm open to learning about my pitfalls.
# JMH version: 1.36
# VM version: JDK 20.0.2, Java HotSpot(TM) 64-Bit Server VM, 20.0.2+9-78
# VM invoker:
/Library/Java/JavaVirtualMachines/jdk-20.jdk/Contents/Hom
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote:
>> Please review this trivial PR.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into 8314753
> - Initial commit
Mark
Can you share the benchmark code? Maybe C2 profiled class hierarchy,
determined your optional only has 2 subclasses and can thus generate
optimized machine code. Or maybe your benchmark is wrong that the result is
not consumed by blackhole so the whole benchmark is moot. We need the code
to make a
Now it is clear. Sorry for the inconvenience. Thank you for your time. I
appreciate.
On Mon, 28 Aug 2023 at 2:03 PM Quân Anh Mai wrote:
> Tbh I have a hard time understand what you are trying to convey. Please
> write grammatically correct sentences with clear structure.
>
> I notice you attach
Tbh I have a hard time understand what you are trying to convey. Please
write grammatically correct sentences with clear structure.
I notice you attach benchmark results but I don't see what was benchmarked
to produce those results.
Another point is that Value classes has not been delivered yet,
Thank you Quân.
All you saying guys make sense.
Yes there is a difference calling methods by pointer and involving vtable.
But one thing didn't came out of my head:
If virtual dispatch dispatch is 10-time more expensive and polymorphism is
a performance killer so how combinations of "return optio
Thank you for your interest,
I'll also include loom-dev with this mail.
Yours,
Daniel
Am 28.08.2023 um 11:12 schrieb Alan Bateman:
This looks fun! It's probably best to bring this to loom-dev. In its
archives you'll find several discussions about generators as several
people have been inter
On Fri, 25 Aug 2023 07:04:50 GMT, Vladimir Petko wrote:
>> 8314491: Linux: jexec launched via PATH fails to find java
>
> Vladimir Petko has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> brought in by the me
This looks fun! It's probably best to bring this to loom-dev. In its
archives you'll find several discussions about generators as several
people have been interested in that topic. Even when thread confined,
the main concern has been that exotic control flow yields leads to
surprising behavio
Hi,
After seeing the JVM Language Summit talk on Continuations
(https://www.youtube.com/watch?v=6nRS6UiN7X0), I thought about it being
possible to implement something like "yield return" in languages like C#
(or "yield" in Python) based on Continuations.
Kotlin has implemented a similar featur
On Thu, 20 Jul 2023 09:11:20 GMT, Adam Sotona wrote:
>> javap uses proprietary com.sun.tools.classfile library to parse class files.
>>
>> This patch converts javap to use Classfile API.
>>
>> Please review.
>>
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request with a new target b
Hi,
Polymorphism is a performance killer. Normally this does not matter much,
but for thin wrappers such as Optional, this is one of the most important
factor.
Behaviour polymorphism requires virtual dispatch and prevents inlining.
This is really detrimental, as simple operations such as a getter
On Tue, 22 Aug 2023 07:48:46 GMT, Matthias Baesken wrote:
> For the tests, I'm surprised the TEST.properties in this directory doesn't
> have exclusiveAccess.dirs=. as there has been historical issues with
> interference between tests in this area.
Hi Alan , when adding the test group sun/to
On Mon, 28 Aug 2023 02:26:30 GMT, David Holmes wrote:
> Sorry but looking at the hotspot part of this I do not like the code in
> jvm.cpp at all - it is far too messy. I expected to see a simple interface to
> os::dlopen which then handles all the platform specific issues.
>
> I'm also somewha
Vote: yes
-Per
From: core-libs-dev on behalf of Roger Riggs
Sent: Friday, August 25, 2023 5:24 PM
To: core-libs-dev
Subject: CFV: New Core Libraries Group Member: Michael McMahon
I hereby nominate Michael McMahon to Membership in the Core Libraries Group
Mich
Vote: yes
* Per
From: core-libs-dev on behalf of Roger Riggs
Sent: Friday, August 25, 2023 5:23 PM
To: core-libs-dev
Subject: CFV: New Core Libraries Group Member: Daniel Fuchs
I hereby nominate Daniel Fuchs to Membership in the Core Libraries Group
Dan
Vote: yes
-Per
From: core-libs-dev on behalf of Roger Riggs
Sent: Friday, August 25, 2023 5:23 PM
To: core-libs-dev
Subject: CFV: New Core Libraries Group Member: Lance Andersen
I hereby nominate Lance Andersen to Membership in the Core Libraries Group
Lance
68 matches
Mail list logo
