>>
>> I assume done with jpackage by indicating something like —mac-sign only? If
>> wrong feel free to correct.
>
> No, it is always done if —mac-sign is NOT specified and we doing ad-hoc
> signing on app bundle only. PKG will not be ad-hoc signed.
> If —mac-sign is provided we will use certi
On Wed, 19 Apr 2023 15:51:01 GMT, Mahendra Chhipa wrote:
> Test is updated to create the binary files during test execution.
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/13537
Hi Michael,
On Aug 10, 2023, at 6:11 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Aug 10, 2023, at 6:35 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Aug 10, 2023, at 6:21 PM, Alexander Matveev
mailto:almat...@openjdk.org>> wrote:
- Fixed tests by checking that all app
> On Aug 10, 2023, at 6:35 PM, Michael Hall wrote:
>
>
>
>> On Aug 10, 2023, at 6:21 PM, Alexander Matveev wrote:
>>
>> - Fixed tests by checking that all app bundles are signed and by checking
>> how they signed ad-hoc vs actual certificate.
>
> How is ad-hoc signing done?
>
>
If it’s
On Thu, 10 Aug 2023 20:43:28 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Thu, 13 Jul 2023 08:57:05 GMT, Andrey Turbanov wrote:
> Made a few fields `final` in java.util.Scanner.
> Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
Marked as reviewed by liach (Author).
-
PR Review: https://git.openjdk.org/jdk/pull/14863#pullrequestrevie
> On Aug 10, 2023, at 6:21 PM, Alexander Matveev wrote:
>
> - Fixed tests by checking that all app bundles are signed and by checking how
> they signed ad-hoc vs actual certificate.
How is ad-hoc signing done?
- This is regression from
[JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488).
- Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` will
report that app bundle is signed and thus our tests failed.
- Fixed tests by checking that all app bundles are signed and by checkin
On Thu, 10 Aug 2023 21:42:41 GMT, Christoph wrote:
> Add new test case with sample modules that contains some
> requires/exports/uses/provides.
>
> We are just unsure if and how we should add some last step of verificaiton
> with the extracted and decompiled class.
>
> Follow up task from htt
> Add new test case with sample modules that contains some
> requires/exports/uses/provides.
>
> We are just unsure if and how we should add some last step of verificaiton
> with the extracted and decompiled class.
>
> Follow up task from https://github.com/openjdk/jdk/pull/14408
Christoph has
On Thu, 10 Aug 2023 16:59:14 GMT, Naoto Sato wrote:
>> src/java.base/share/classes/java/text/ListFormat.java line 58:
>>
>>> 56: * .format(List.of("Foo", "Bar", "Baz"))
>>> 57: * }
>>> 58: * This will produce the concatenated list string, "Foo, Bar, and Baz"
>>> as seen in
>>
>> With th
On Fri, 14 Jul 2023 16:08:12 GMT, Mandy Chung wrote:
>>> It's looking pretty good.
>>
>> Thank you!
>>
>>> About the test, I don't see `ArrayList::add` in the generated bytecode of
>>> `sub2-13`. The dedup string set is used for the targets of qualified
>>> exports and opens and uses. The mod
Add new test case with sample modules that contains some
requires/exports/uses/provides.
We are just unsure if and how we should add some last step of verificaiton with
the extracted and decompiled class.
Follow up task from https://github.com/openjdk/jdk/pull/14408
-
Commit messa
On Thu, 10 Aug 2023 20:43:28 GMT, Jorn Vernee wrote:
>> This patch contains the implementation of the foreign linker & memory API
>> JEP for Java 22. The initial patch is composed of commits brought over
>> directly from the [panama-foreign
>> repo](https://github.com/openjdk/panama-foreign).
On Thu, 13 Jul 2023 08:57:05 GMT, Andrey Turbanov wrote:
> Made a few fields `final` in java.util.Scanner.
> Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
Marked as reviewed by stsypanov (Author).
-
PR Review: https://git.openjdk.org/jdk/pull/14863#pullrequestr
Made a few fields `final` in java.util.Scanner.
Also made `digits`, `non0Digit`, `SIMPLE_GROUP_INDEX` as `static.`
-
Commit messages:
- [PATHC] Make fields final in java.util.Scanner
Changes: https://git.openjdk.org/jdk/pull/14863/files
Webrev: https://webrevs.openjdk.org/?repo=jdk
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
On Thu, 10 Aug 2023 13:56:37 GMT, Doug Simon wrote:
>> In a test that stresses metaspace (such as
>> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
>> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
>> `TranslatedException.` due to exhausted metaspac
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote:
> In a test that stresses metaspace (such as
> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
> `TranslatedException.` due to exhausted metaspace:
>
On Thu, 10 Aug 2023 16:54:35 GMT, Maurizio Cimadamore
wrote:
> 8298095: Refine implSpec for SegmentAllocator
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk21/pull/172
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The main changes found in this patch come from the followin
> Introducing a new formatting class for locale-dependent list patterns. The
> class is to provide the functionality from the Unicode Consortium's LDML
> specification for [list
> patterns](https://www.unicode.org/reports/tr35/tr35-general.html#ListPatterns).
> For example, given a list of Stri
On Wed, 9 Aug 2023 23:39:24 GMT, Joe Wang wrote:
>> Naoto Sato has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Small cleanup
>
> src/java.base/share/classes/java/text/ListFormat.java line 58:
>
>> 56: * .format(List.of("Foo", "Bar"
On Tue, 8 Aug 2023 16:34:09 GMT, Severin Gehwolf wrote:
>> Please review this patch which adds a "jmodless" jlink mode to the JDK.
>> Fundamentally this patch adds an option to use `jlink` even though your JDK
>> install might not come with the packaged modules (directory `jmods`). This
>> is
8298095: Refine implSpec for SegmentAllocator
-
Commit messages:
- Backport 35b60f925a4e7e2e3f1ec7c5c1eee60206e7508a
Changes: https://git.openjdk.org/jdk21/pull/172/files
Webrev: https://webrevs.openjdk.org/?repo=jdk21&pr=172&range=00
Issue: https://bugs.openjdk.org/browse/JDK-82
> Please review this patch which adds a "jmodless" jlink mode to the JDK.
> Fundamentally this patch adds an option to use `jlink` even though your JDK
> install might not come with the packaged modules (directory `jmods`). This is
> particularly useful to further reduce the size of a jlinked ru
When backporting [JDK-8312127](https://bugs.openjdk.org/browse/JDK-8312127), I
realized there are no targeted tests for FileDescriptor.sync that can be used
to qualify the changes in that area.
Additionally, we use FD.sync for durability in Java databases, and we want to
make sure at least som
In addition to the issue
[JDK-8311178](https://bugs.openjdk.org/browse/JDK-8311178), logically fixing
the scope from benchmark to thread for below benchmark files having shared
state, also which fixes few of the benchmarks scalability problems.
org/openjdk/bench/java/io/DataInputStreamTest.java
On Sun, 6 Aug 2023 12:23:54 GMT, Wouter Born wrote:
>> Doug Lea has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains 13 additional commits
>> since t
On Tue, 1 Aug 2023 10:29:06 GMT, Jorn Vernee wrote:
> This patch contains the implementation of the foreign linker & memory API JEP
> for Java 22. The initial patch is composed of commits brought over directly
> from the [panama-foreign repo](https://github.com/openjdk/panama-foreign).
> The m
> In a test that stresses metaspace (such as
> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
> `TranslatedException.` due to exhausted metaspace:
>
> java.lang.OutOfMemoryError: Metaspace
> at
On Thu, 10 Aug 2023 13:41:05 GMT, Doug Simon wrote:
>> In a test that stresses metaspace (such as
>> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
>> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
>> `TranslatedException.` due to exhausted metaspac
On Wed, 9 Aug 2023 10:45:56 GMT, Christian Stein wrote:
> Please review this change to remove Unit-based tests in `java/lang/invoke`
> from `jdk`'s problem list. The underlying race condition in jtreg was fixed
> in release 7.3; which is now the default version used in JDK mainline
> developme
On Wed, 9 Aug 2023 10:45:56 GMT, Christian Stein wrote:
> Please review this change to remove Unit-based tests in `java/lang/invoke`
> from `jdk`'s problem list. The underlying race condition in jtreg was fixed
> in release 7.3; which is now the default version used in JDK mainline
> developme
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote:
> In a test that stresses metaspace (such as
> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
> `TranslatedException.` due to exhausted metaspace:
>
On Tue, 8 Aug 2023 20:52:29 GMT, Doug Simon wrote:
> In a test that stresses metaspace (such as
> `vmTestbase/vm/mlvm/hiddenloader/stress/oome/metaspace/Test.java`) that also
> uses `-Xcomp -XX:-TieredCompilation`, we've seen a failure in
> `TranslatedException.` due to exhausted metaspace:
>
On Fri, 28 Jul 2023 08:40:30 GMT, Aleksey Shipilev wrote:
>> Cristian Vat has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce allocations also for Matcher.usePattern
>
> Shouldn't the similar change be in `CIBackRef.match` too? The fa
On Fri, 28 Jul 2023 08:40:30 GMT, Aleksey Shipilev wrote:
>> Cristian Vat has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reduce allocations also for Matcher.usePattern
>
> Shouldn't the similar change be in `CIBackRef.match` too? The fa
On Thu, 10 Aug 2023 11:40:52 GMT, Pavel Rappo wrote:
>> My bad. Forget my note
>
>> Some have a preference for providing a seed for `Random` instances in
>> micros. Either hard-coded or through a `@Param` (I find this a bit
>> excessive). Doing so might reduce run-to-run noise.
>
> I hear you,
On Thu, 10 Aug 2023 11:28:39 GMT, Raffaello Giulietti
wrote:
>>> AFAIK, if you need reproducible randoms in tests, you should add the tags:
>>>
>>> ```
>>> * @key randomness
>>> * @library /test/lib
>>> ```
>>>
>>> and initialize your random generator with
>>>
>>> ```
>>> import jdk.test.li
On Wed, 9 Aug 2023 22:54:28 GMT, Pavel Rappo wrote:
>> Please review this PR to use modern APIs and language features to simplify
>> equals, hashCode, and compareTo for BigInteger. If you have any performance
>> concerns, please raise them.
>>
>> This PR is cherry-picked from a bigger, not-yet
On Wed, 9 Aug 2023 22:36:47 GMT, Claes Redestad wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 13 additional
>> commits s
On Thu, 10 Aug 2023 11:23:02 GMT, Pavel Rappo wrote:
>> AFAIK, if you need reproducible randoms in tests, you should add the tags:
>>
>> * @key randomness
>> * @library /test/lib
>>
>> and initialize your random generator with
>>
>> import jdk.test.lib.RandomFactory;
>> ...
>> Random rnd = R
On Thu, 10 Aug 2023 11:13:12 GMT, Raffaello Giulietti
wrote:
> AFAIK, if you need reproducible randoms in tests, you should add the tags:
>
> ```
> * @key randomness
> * @library /test/lib
> ```
>
> and initialize your random generator with
>
> ```
> import jdk.test.lib.RandomFactory;
> ...
On Wed, 9 Aug 2023 10:45:56 GMT, Christian Stein wrote:
> Please review this change to remove Unit-based tests in `java/lang/invoke`
> from `jdk`'s problem list. The underlying race condition in jtreg was fixed
> in release 7.3; which is now the default version used in JDK mainline
> developme
Please review this change to remove Unit-based tests in `java/lang/invoke` from
`jdk`'s problem list. The underlying race condition in jtreg was fixed in
release 7.3; which is now the default version used in JDK mainline development.
-
Commit messages:
- Update ProblemList.txt
Cha
On Windows, the test java/lang/ProcessHandle/InfoTest.java can fail when run as
user that is member of the Administrators group. In that case new files are not
owned by the user but instead by BUILTIN\ADMINISTRATORS. This breaks the
assumptions of the test's whoami check. My suggestion is to cat
On Mon, 24 Jul 2023 12:32:59 GMT, Per Minborg wrote:
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
> methods as well as clarifying the docs a bit more. Also, a local variable is
> renamed.
This pull request has now been integrated.
Changeset: 35b60f92
Author:
> This PR suggests refining the `@implSpec` for the SegmentAllocator::allocate
> methods as well as clarifying the docs a bit more. Also, a local variable is
> renamed.
Per Minborg has updated the pull request incrementally with one additional
commit since the last revision:
Simplify java sn
On Thu, 10 Aug 2023 07:44:58 GMT, Matthias Baesken wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
> Matthias
On Fri, 4 Aug 2023 09:59:41 GMT, Matthias Baesken wrote:
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
This pull reques
On Wed, 9 Aug 2023 11:06:04 GMT, Matthias Baesken wrote:
>> There is coding e.g. in
>> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
>> that deals with shared lib naming on different OS.
>> This code should be simplified.
>
> Matthias
> There is coding e.g. in
> https://github.com/openjdk/jdk/blob/master/test/jdk/jdk/jfr/event/runtime/TestNativeLibrariesEvent.java#L72
> that deals with shared lib naming on different OS.
> This code should be simplified.
Matthias Baesken has updated the pull request incrementally with one additi
54 matches
Mail list logo
