Re: RFR: 8313023: Return value corrupted when using CCS + isTrivial (mainline)

On Tue, 25 Jul 2023 19:17:38 GMT, Jorn Vernee wrote: > Port of: https://github.com/openjdk/panama-foreign/pull/848 from the > panama-foreign repo. > > Copying the PR body here for convenience: > > Due to a bug in the downcall linker stub generation, we don't save the return > value when captu

RFR: 8306632: Add a JDK Property for specifying DTD support

Add a JDK Impl specific property 'jdk.xml.dtd.support' for applications to specify how DTDs are handled. This property is uniformly supported across the JDK XML libraries. It complements, rather than replaces, the existing properties that are supportDTD for StAX and disallow-doctype-decl for DOM

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v2]

On Wed, 26 Jul 2023 09:29:18 GMT, Alan Bateman wrote: > I think this is close to what you want Modified as suggested in 9264975. The limit is increased to 1.5 Mb where it was in native malloc clamping. This appears to prevent any throughput degradation. - PR Comment: https://git.o

Re: RFR: 6478546: FileInputStream.read() throws OutOfMemoryError when there is plenty available [v3]

> Limit native memory allocation and move write loop from the native layer into > Java. This change should make the OOME reported in the issue much less likely. Brian Burkhalter has updated the pull request incrementally with one additional commit since the last revision: 6478546: Move buffer

Re: CFV: New Core Libraries Group Member: Joe Wang

Vote: Yes. On 27/07/2023 19:36, Roger Riggs wrote: I hereby nominate Joe Wang to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including DOM, SAX, StAX, Transform, V

Re: CFV: New Core Libraries Group Member: Brent Christian

Vote: Yes. On 27/07/2023 19:36, Roger Riggs wrote: I hereby nominate Brent Christian to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class loader, NIO J

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

Vote: Yes. On 27/07/2023 19:35, Roger Riggs wrote: I hereby nominate Brian Burkhalter to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channe

Re: CFV: New Core Libraries Group Member: Joe Wang

Vote: Yes. -Chris On 27/07/2023 19:36, Roger Riggs wrote: |I hereby nominate Joe Wang||to Membership in the Core Libraries Group Joe has been working in the core library team since 2012. He has been maintaining and improving the XML library APIs and implementations including ||DOM, SAX, StAX,

Re: CFV: New Core Libraries Group Member: Brent Christian

Vote: Yes. -Chris On 27/07/2023 19:36, Roger Riggs wrote: |I hereby nominate |Brent Christian|to Membership in the Core Libraries Group Brent has been working in the Core Library team at Oracle since 2012. He has made contributions to many areas of OpenJDK including java.lang strings, class lo

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

Vote: Yes. -Chris On 27/07/2023 19:35, Roger Riggs wrote: |I hereby nominate |Brian Burkhalter|to Membership in the Core Libraries Group Brian has been working in the Core Library team since 2012. Brian's many contributions to the OpenJDK libraries include java.io subsystems, NIO channels, fil

Re: CFV: New Core Libraries Group Member: Joe Wang

Vote: yes

Re: CFV: New Core Libraries Group Member: Brian Burkhalter

Vote: yes

Re: CFV: New Core Libraries Group Member: Brent Christian

Vote: yes

Re: RFR: 8310643: Misformatted copyright messages in FFM

On Wed, 26 Jul 2023 15:43:12 GMT, Per Minborg wrote: > This PR suggests updating some of the ill-formed copyright headers in the FFM > API and the implementation and test thereof. > > Some of the test files will have now the "classpath" exception. Is this > correct? Hi @minborg, Would you a

Re: RFR: 8313312: Add missing classpath exception copyright header [v2]

> Adds `classpath exception` in multiple files, affects copyright header only. Amit Kumar has updated the pull request incrementally with one additional commit since the last revision: revert java.lang.foreign changes - Changes: - all: https://git.openjdk.org/jdk/pull/15070/fil

Integrated: 8312411: MessageFormat.formatToCharacterIterator() can be improved

On Wed, 26 Jul 2023 07:39:09 GMT, Justin Lu wrote: > Please review this change which makes > `MessageFormat.formatToCharacterIterator` fail fast(er). The return statement > is also modified to call toArray() as `toArray(new T[0])` over `toArray(new > T[size])`. This pull request has now been

Re: RFR: 8312491: Update Classfile API snippets and examples [v6]

On Thu, 27 Jul 2023 15:16:33 GMT, Adam Sotona wrote: >> src/java.base/share/classes/jdk/internal/classfile/CodeBuilder.java line >> 1239: >> >>> 1237: return ldc(BytecodeHelpers.constantEntry(constantPool(), >>> value)); >>> 1238: } >>> 1239: >> >> Method needs specification > >

Re: RFR: 8312491: Update Classfile API snippets and examples [v6]

> This pull request updates Classfile API snippets and examples and adds > missing javadoc. > > Please review. > > Thanks, > Adam Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - fixing javadoc - fixing javadoc - Cha

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales [v2]

On Fri, 28 Jul 2023 17:13:54 GMT, Aleksey Shipilev wrote: >> Fails like this: >> >> >> $ CONF=macosx-aarch64-server-fastdebug make images test >> TEST=java/util/Formatter/Padding.java >> >> ... >> STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' >> org.opentest4j.AssertionFailedErr

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales [v2]

> Fails like this: > > > $ CONF=macosx-aarch64-server-fastdebug make images test > TEST=java/util/Formatter/Padding.java > > ... > STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' > org.opentest4j.AssertionFailedError: expected: <-001.2> but was: > <-001,2> > > > Looks lik

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales [v2]

On Fri, 28 Jul 2023 16:53:51 GMT, Naoto Sato wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Change to Locale.US > > test/jdk/java/util/Formatter/Padding.java line 312: > >> 310: @MethodSource >> 311:

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales

On Fri, 28 Jul 2023 08:49:20 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ CONF=macosx-aarch64-server-fastdebug make images test > TEST=java/util/Formatter/Padding.java > > ... > STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' > org.opentest4j.AssertionFailedError: expec

Re: RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales

On Fri, 28 Jul 2023 08:49:20 GMT, Aleksey Shipilev wrote: > Fails like this: > > > $ CONF=macosx-aarch64-server-fastdebug make images test > TEST=java/util/Formatter/Padding.java > > ... > STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' > org.opentest4j.AssertionFailedError: expec

Integrated: 8312416: Tests in Locale should have more descriptive names

On Wed, 26 Jul 2023 07:11:16 GMT, Justin Lu wrote: > Please review this change which renames tests for Locale from > `bugNNN.java` to something more descriptive. > > In addition to the name changes, accompanying copyright year, name usage > within the test, and other minor changes were inc

[jdk21] Integrated: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

On Thu, 27 Jul 2023 18:21:45 GMT, Sergey Bylokhov wrote: > This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the > problem list for linux-x86 where it intermittently fails on a GA, ex: > https://github.com/openjdk/jdk21/pull/148 > > This is only for JDK 21, test passes on

Re: RFR: 8313312: Add missing classpath exception copyright header

On Fri, 28 Jul 2023 13:02:20 GMT, Amit Kumar wrote: > Adds `classpath exception` in multiple files, affects copyright header only. Please leave the java.lang.foreign changes out of this. We already have another PR for those: https://github.com/openjdk/jdk/pull/15042 - PR Comment:

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Fri, 28 Jul 2023 10:05:01 GMT, Claes Redestad wrote: > I think we could consider dropping `vectorized` from `vectorizedHashCode`: > there's nothing in the library-side implementation for this that is > explicitly setting up for vectorization of each case (unlike the > `mismatch/vectorizedMi

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote: > This PR adds an internal method to calculate hash code from the provided > integer array, offset and length into that array, and the initial hash code > value. > > Current options for calculating a hash code for int[] are inflexible. It's

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote: > This PR adds an internal method to calculate hash code from the provided > integer array, offset and length into that array, and the initial hash code > value. > > Current options for calculating a hash code for int[] are inflexible. It's

RFR: 8313312: Add missing classpath exception copyright header

Adds `classpath exception` in multiple files, affects copyright header only. - Commit messages: - adds classpath exception Changes: https://git.openjdk.org/jdk/pull/15070/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15070&range=00 Issue: https://bugs.openjdk.org/browse/

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Fri, 28 Jul 2023 12:37:13 GMT, Claes Redestad wrote: > > Perhaps surprisingly, we don't need int[]; what JDK seems to use is these: > > > > * byte[] > > * unsigned byte[] > > * Object[] > > All `vectorizedHashCode` variants are exposed (and testable) via the public > `java.util.Arrays.hashC

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Fri, 28 Jul 2023 10:49:34 GMT, Pavel Rappo wrote: > Perhaps surprisingly, we don't need int[]; what JDK seems to use is these: > > * byte[] > * unsigned byte[] > * Object[] All `vectorizedHashCode` variants are exposed (and testable) via the public `java.util.Arrays.hashCode(byte/char/short

Re: RFR: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview) [v6]

On Fri, 28 Jul 2023 03:59:26 GMT, sid8606 wrote: >> Implementation of "Foreign Function & Memory API" for s390x (Big Endian). > > sid8606 has updated the pull request incrementally with one additional commit > since the last revision: > > Preserve and restore register Z_R6 > > Though Z_R

Re: [jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

On Fri, 28 Jul 2023 09:10:20 GMT, Alan Bateman wrote: > JDK-8308609 I added a comment on https://bugs.openjdk.org/browse/JDK-8303498, cc @offamitkumar - PR Comment: https://git.openjdk.org/jdk21/pull/149#issuecomment-1655513822

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote: > This PR adds an internal method to calculate hash code from the provided > integer array, offset and length into that array, and the initial hash code > value. > > Current options for calculating a hash code for int[] are inflexible. It's

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

On Fri, 28 Jul 2023 12:15:21 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8312491: Update Classfile API snippets and examples [v5]

> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with two additional commits since the last revision: - fixing javadoc - fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://gi

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

On Fri, 28 Jul 2023 08:25:55 GMT, Aleksey Shipilev wrote: >> Cristian Vat has updated the pull request incrementally with one additional >> commit since the last revision: >> >> reduce allocations also for Matcher.usePattern > > src/java.base/share/classes/java/util/regex/Pattern.java line 51

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v4]

> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with Matche

Re: RFR: 8311864: Add ArraysSupport.hashCode(int[] a, fromIndex, length, initialValue)

On Tue, 11 Jul 2023 16:35:51 GMT, Pavel Rappo wrote: > This PR adds an internal method to calculate hash code from the provided > integer array, offset and length into that array, and the initial hash code > value. > > Current options for calculating a hash code for int[] are inflexible. It's

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v3]

On Fri, 28 Jul 2023 09:29:48 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v3]

> Reduces excessive allocation of Matcher.groups array when the original > Pattern has no groups or less than 9 groups. > > Original clamping to 10 possibly due to documented behavior from javadoc: > "In this class, \1 through \9 are always interpreted as back references, " > > Only with Matche

Re: [jdk21] RFR: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86

On Thu, 27 Jul 2023 18:21:45 GMT, Sergey Bylokhov wrote: > This patch adds the java/lang/ScopedValue/StressStackOverflow.java to the > problem list for linux-x86 where it intermittently fails on a GA, ex: > https://github.com/openjdk/jdk21/pull/148 > > This is only for JDK 21, test passes on

RFR: 8313307: java/util/Formatter/Padding.java fails on some Locales

Fails like this: $ CONF=macosx-aarch64-server-fastdebug make images test TEST=java/util/Formatter/Padding.java ... STARTED Padding::padding '[216] -001.2, % 010.1f, -1.2' org.opentest4j.AssertionFailedError: expected: <-001.2> but was: <-001,2> Looks like a locale problem in test

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a

Re: RFR: 8312491: Update Classfile API snippets and examples [v4]

> 8312491: Update Classfile API snippets and examples Adam Sotona has updated the pull request incrementally with one additional commit since the last revision: fixing javadoc - Changes: - all: https://git.openjdk.org/jdk/pull/14968/files - new: https://git.openjdk.org/jdk/pu

Re: RFR: 8311939: Excessive allocation of Matcher.groups array [v2]

On Sat, 22 Jul 2023 12:13:10 GMT, Cristian Vat wrote: >> Reduces excessive allocation of Matcher.groups array when the original >> Pattern has no groups or less than 9 groups. >> >> Original clamping to 10 possibly due to documented behavior from javadoc: >> "In this class, \1 through \9 are a