Re: RFR: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files [v2]

2023-07-16 Thread yaqsun
On Fri, 14 Jul 2023 21:58:33 GMT, Alexey Semenyuk wrote: > The fix with `%{_builddir}` looks better. Did it resolve the issue? Yes, it solved. The root of intermediate files changed to /tmp/jdk.jpackage16701381473798822/BUILD/commonlicensetest.filesystem.files. - PR Comment: https

Re: List extending Collection/SequencedCollection

2023-07-16 Thread Ryan Ernst
Hi Joe and Stuart, Given the inconsistencies mentioned, I see how this change may not be worth the hassle, so I’ll drop it. I appreciate the thoughtful responses to explain your reasoning. Thanks! Ryan > On Jul 7, 2023, at 4:21 PM, Stuart Marks wrote: > > Hi Ryan, > > Thanks for trying

Re: RFR: 8312089: Simplify and modernize equals, hashCode, and compareTo in java.nio and implementation code [v3]

2023-07-16 Thread Vyom Tewari
On Fri, 14 Jul 2023 18:54:35 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for in java.nio and implementation code. >> >> Please note, test results are pending. >> >> Additional notes: >> >> * This PR s

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v23]

2023-07-16 Thread Jaikiran Pai
On Sun, 16 Jul 2023 06:24:59 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated imag

Integrated: 8304006: jlink should create the jimage file in the native endian for the target platform

2023-07-16 Thread Jaikiran Pai
On Wed, 11 Jan 2023 13:19:32 GMT, Jaikiran Pai wrote: > Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Be