Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v23]

On Sun, 16 Jul 2023 06:24:59 GMT, Jaikiran Pai wrote: >> Can I please get a review for this change which proposes to fix the issue >> reported in https://bugs.openjdk.org/browse/JDK-8206890? >> >> The `jlink` command allows a `--endian` option to specify the byte order in >> the generated imag

Re: Illegal field name when trying to compile with a javax.swing.Action

H, this one might actually be IDE specific. Please ignore.

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v21]

On Sat, 15 Jul 2023 06:16:45 GMT, Alan Bateman wrote: >> Done. The PR has been updated with these changes. > > Apologies, I somehow had Files.mismatch in my head, which does compare > contents. If the files exists, Files.isSameFile is semantically equivalent to > checking if the real path to bo

Re: RFR: 8304006: jlink should create the jimage file in the native endian for the target platform [v23]

> Can I please get a review for this change which proposes to fix the issue > reported in https://bugs.openjdk.org/browse/JDK-8206890? > > The `jlink` command allows a `--endian` option to specify the byte order in > the generated image. Before this change, when such a image was being > launche

Illegal field name when trying to compile with a javax.swing.Action

Hello Core Libs Dev Team, I tried to compile the attached project, and got the following error. Exception in thread "main" java.lang.ClassFormatError: Illegal field name "" in class ToDoList$2 at java.base/java.lang.ClassLoader.defineClass1(Native Method) at java.base/java.lang.ClassLoader.define

Re: Questions about using `assert` in Java

Hi Daohan, assert keyword is safely usable within production code. I don't think it has a significant performance impact if it is not enabled. Thus, you should not enable it in production unless you are debugging. A package that uses assert extensively is java.lang.invoke package. For me, these a

Questions about using `assert` in Java

Dear developers, I'm a graduate student doing software engineering research. Recently, I came across some interesting facts about Java assert​ statements and have a few questions to ask. Although the assert​ keyword has been around for a long time and is handy for invariant checks, it does not se

Re: RFR: 8240567: MethodTooLargeException thrown while creating a jlink image [v19]

On Wed, 5 Jul 2023 23:30:03 GMT, Oliver Kopp wrote: >> It's looking pretty good. >> >> About the test, I don't see `ArrayList::add` in the generated bytecode of >> `sub2-13`. The dedup string set is used for the targets of qualified >> exports and opens and uses. The modifiers set of `req

Re: RFR: 8312089: Simplify and modernize equals, hashCode, and compareTo in java.nio and implementation code [v3]

On Fri, 14 Jul 2023 18:54:35 GMT, Pavel Rappo wrote: >> Please review this PR to use modern APIs and language features to simplify >> equals, hashCode, and compareTo for in java.nio and implementation code. >> >> Please note, test results are pending. >> >> Additional notes: >> >> * This PR s